78d435a5fa
rpc: don't display invalid json errors on default log level
...
It's not something the user needs to know, and will display
attacker controlled data
2020-05-23 12:26:49 +00:00
2314dae8c8
workflows: fix windows build
2020-05-23 02:30:09 +02:00
a6803231e6
daemon: complain if data dir resides on FAT32 volume (Windows)
2020-05-21 15:23:44 +00:00
4d3c2d0b7b
rpc: add a sanity limit to a few RPC in restricted mode
2020-05-20 19:17:49 +00:00
15538f7e3f
ByteSlice: Fix persisting ptr to std::moved SSO buffer
...
The Bug:
1. Construct `byte_slice.portion_` with `epee::span(buffer)` which copies a pointer to the SSO buffer to `byte_slice.portion_`
2. It constructs `byte_slice.storage_` with `std::move(buffer)` (normally this swap pointers, but SSO means a memcpy and clear on the original SSO buffer)
3. `slice.data()` returns a pointer from `slice.portion_` that points to the original SSO cleared buffer, `slice.storage_` has the actual string.
2020-05-20 10:13:58 +10:00
1d31e6c000
net_node: remove dead seed nodes
2020-05-20 01:06:03 +02:00
7ebb351c2d
rpc: lock access to the rpc payment object
2020-05-19 18:26:28 +00:00
f0371210e9
cryptonote_core: remove "We are most likely forked" message
...
It's time based and we don't have forks every 6 months anymore
2020-05-19 16:27:24 +00:00
567402c508
protocol: move the "peer claims higher version" warning to debug
...
Because there's a neverending supply of cunts claiming a wrong
version just to say "look at me" I guess
2020-05-19 16:14:53 +00:00
72cdfa4a20
fix a few typos in error messages
...
Reported by adrelanos
2020-05-19 15:59:26 +00:00
c17fe815a2
wallet2: fix multisig data clearing stomping on a vector
2020-05-19 10:45:40 +00:00
f1d0457523
cryptonote_protocol: stricter limit to number of objects requested
...
Reported by xnbya
2020-05-19 10:33:03 +00:00
bb5c5dff15
cryptonote_protocol: reject requests/notifications before handshake
...
Reported by xnbya
2020-05-19 10:33:02 +00:00
ca60d60fea
easylogging++: sanitize log payload
...
Some of it might be coming from untrusted sources
Reported by itsunixiknowthis
2020-05-19 10:31:28 +00:00
bd69e3b37a
testdb: add override in a couple places where it's missing
2020-05-18 14:17:48 +00:00
5ed37ba83c
serialization: fix bad rapidjson api usage
2020-05-18 14:17:23 +00:00
5741b4d74d
blockchain: detect and log bad difficulty calculations
2020-05-17 12:44:45 +00:00
eda1675858
wallet_rpc_server: use unlock_time in suggested confirmations calc
2020-05-17 01:03:32 +00:00
35665df206
protocol: don't drop a connection if we can't get a compatible chain
...
This can now happen if:
- we have a pruned db
- we have not connected to the monero network for a while
- we connect to a node
- that node asks us for history
- we only have a pruned version of the most recent common block
In that case, it's better to not reply but keep the connection alive,
so we can sync off it.
2020-05-16 19:55:31 +00:00
85164a8daf
epee: use memwipe rather than memset for md5 secrets
...
That's used by HTTP auth now
2020-05-16 18:12:55 +00:00
7178bb5c84
keccak: remove aligned check
...
Some tools report the alignment check as UB, which seems a bit
dubious, but since the performance difference between the two
versions is minimal, I'll go with the safe version
2020-05-16 12:28:27 +00:00
a11ec4ac1d
Support for supercop ASM in wallet, and benchmark for supercop
2020-05-16 10:25:17 +00:00
5e0ea6e95c
simplewallet: add missing calls to on_command
...
It resets the inactivity time
2020-05-16 00:48:44 +00:00
bd96536637
db_lmdb: test for mmap support at init time
...
It'll make it clearer when a DB init failure is due to being
on a filesystem which does not support mmap
2020-05-16 00:20:22 +00:00
cb4edc1f45
cmake: ASAN and PIE don't mix
...
Binaries built with both crash on startup with maybe 25% probability
2020-05-15 17:18:50 +00:00
81773f55a4
fuzz_tests: refactor and add OSS-Fuzz compatibility
2020-05-15 17:18:27 +00:00
67ade80055
Add randomized delay when forwarding txes from i2p/tor -> ipv4/6
2020-05-15 07:57:35 +00:00
f35ced6d7f
build: fix boost 1.73 compatibility
2020-05-14 22:57:53 +02:00
86cf811a39
simplewallet: don't complain about incoming payment ids on change
2020-05-13 23:28:31 +00:00
153977aed4
libzmq should be libzmq4.
2020-05-13 14:21:18 -07:00
b73f4e78d0
[master]: Update gitian yml files
2020-05-13 22:08:00 +02:00
4baee200a7
build: prepare v0.16.0.0 release
2020-05-13 16:15:03 +02:00
5d882f4f14
blockchain: fix theoretical race getting bulk timestamps
2020-05-13 13:42:41 +00:00
ab4429346d
trezor: add new firmware version support
2020-05-12 16:31:36 +02:00
29e563bb1e
Fixed bugs for take_slice and byte_stream->byte_slice
2020-05-12 01:26:37 -04:00
8656a8c9ff
remove double includes
2020-05-11 13:53:17 +00:00
77a008f714
Merge pull request #6510
...
70609d7
2020-05-07 10:44:34 -05:00
4c2f78aeeb
Merge pull request #6506
...
42e1484
2020-05-07 10:43:05 -05:00
5ef0607da6
Update copyright year to 2020
...
Update copyright year to 2020
2020-05-06 22:36:54 -04:00
70609d7681
cryptonote_core: take out the time based upgrade warning
...
It doesn't really work anymore since we don't have a fork soon
2020-05-06 18:27:23 +00:00
dbba6004f5
Merge pull request #6503
...
f80ab3e
2020-05-06 12:22:28 -05:00
71693f06a1
systemd: Make sure required folders exist
...
The default monero.conf file depends on the existence of the folders `/var/log/monero/` and `/var/lib/monero/`.
This change makes sure systemd will create them, together with the proper permissions, if they don't exist.
`StateDirectory` can be considered an extra safety in case the user `monero` happens to have been created with specifying `/var/lib/monero/` as a home folder but without actually creating it.
2020-05-06 14:57:47 +02:00
f80ab3edde
cryptonote_protocol: do not request pruned borromean sig txes
...
We don't have a function to calculate their weight from a pruned
version (yet).
2020-05-06 12:44:00 +00:00
f2c78f6a5b
Merge pull request #6486
...
feee455
2020-05-06 00:34:30 -05:00
3de804f1e9
Merge pull request #6485
...
7a8c1ee
2020-05-06 00:31:51 -05:00
98e3802b26
Merge pull request #6484
...
e7d0105
2020-05-06 00:30:39 -05:00
de025281dc
Merge pull request #6481
...
119f706
2020-05-06 00:29:49 -05:00
9e3f72c375
Merge pull request #6480
...
4f489fa
2020-05-06 00:28:18 -05:00
0f233c6ad8
Merge pull request #6478
...
ee58362
2020-05-06 00:27:13 -05:00
9f3e8e3ff0
Merge pull request #6477
...
afe5a55babf25d5715460
2020-05-06 00:26:16 -05:00
moneromooo-monero