5ee6f03742
blockchain: fix wrong hf version when popping multiple blocks
...
Since we keep track of the hf version in the db, we pick it up
from there instead of doing the full reorg call, which is quite
expensive
2019-01-01 18:28:01 +00:00
634d359a84
blockchain: use the version passed as parameter, not a new one
2019-01-01 18:28:01 +00:00
94a375d559
hardfork: remove batch transactions setup
...
This is now default, so it spares us the warnings
2019-01-01 18:28:01 +00:00
5dc590cbdb
wallet2: speedup output tracking
...
It can get heavy for large wallets
2018-12-31 23:57:54 +00:00
db3f2a91fa
wallet: optionally keep track of owned outputs uses
2018-12-31 23:57:51 +00:00
e344d93ce7
Merge pull request #4960
...
b56b5b5
2018-12-31 16:32:12 -06:00
53760ee044
Merge pull request #4957
...
0e2f5cb
2018-12-31 16:30:47 -06:00
1aaa82cb1a
Merge pull request #4955
...
25e5a85
2018-12-31 16:28:49 -06:00
61c0083105
Merge pull request #4953
...
dbbb3ce
2018-12-31 16:26:22 -06:00
a872a2a41a
Merge pull request #4948
...
1d892ec
2018-12-31 16:10:30 -06:00
69e8567c0e
Merge pull request #4946
...
6644b9bce594f583326985511563d1efe3d9cc68a2
2018-12-31 16:06:50 -06:00
9c2d671397
Merge pull request #4945
...
e37154a
2018-12-31 15:53:59 -06:00
6e4e228461
Merge pull request #4944
...
1505dd3db57374
2018-12-31 15:52:17 -06:00
c7af379d29
Merge pull request #4940
...
9e64a71
2018-12-31 15:44:49 -06:00
3adac4ee2b
Merge pull request #4929
...
5a76933
2018-12-31 15:31:01 -06:00
6d3caaff70
Merge pull request #4928
...
affff94
2018-12-31 15:28:25 -06:00
a7ff63ec77
Merge pull request #4898
...
e6f026e
2018-12-31 15:15:46 -06:00
c93c638199
Merge pull request #4864
...
707c2f8
2018-12-31 15:13:59 -06:00
d1b3990d40
p2p: don't stop the idle thread when no gray peers are found
2018-12-30 19:32:38 +00:00
9092fc4bfd
wallet: do not display daemon controlled text if untrusted
2018-12-30 01:32:57 +00:00
8bd716777e
simplewallet: remove ability to transfer with detached short payment ids
...
It seemed like a good idea at the time
2018-12-27 00:45:04 +00:00
65ce387c93
daemon: add a +hex option to print_block
2018-12-26 17:55:28 +00:00
d24c325c7d
daemon: print human friendly timestamp too
2018-12-26 14:01:18 +00:00
434a147b57
blocks: fix checkpoint code generation on OpenBSD
...
Its od outputs small decimals with leading 0, which means octal in C
2018-12-25 19:11:39 +00:00
6f2081f867
cryptonote_core: revert extra_tx_map
...
While the lookups are faster, the zeroCommit calls have to be
done again when storing the new outputs in the db, which ends
up making the whole thing slower after all, and the ways this
can be cached aren't very nice code wise, so let's forget it
since the gains aren't very large anyway.
2018-12-25 15:19:41 +00:00
d7354c7864
wallet_rpc_server: add all field to export_key_images
...
To use if you want all key images, not just the ones for
recently imported outputs
2018-12-24 13:00:29 +00:00
e6f026e530
Simplewallet: Unify usage messages.
...
Help messages describe the commands usage. When users run the command
with wrong arguments, it usually helpfully offers the usage, too.
Unfortunately, these two usage messages were duplicated in the code and
started to get out of sync.
Fixing with constant strings.
2018-12-23 20:12:50 +00:00
85665003a7
epee: better network buffer data structure
...
avoids pointless allocs and memcpy
2018-12-23 16:46:07 +00:00
5e10dee3ea
simplewallet: fix show_transfers colouring, and add red for failed
...
Also add the type back, as it was somehow weirdly split into
two different fields, one being a union...
2018-12-23 15:15:55 +00:00
a5ffc2d5ad
Remove boost::lexical_cast for uuid and unused uuid function
2018-12-23 11:11:30 +00:00
68f095f059
message_store: fix error message adding const char * with offset
2018-12-22 15:52:10 +00:00
7c58421c79
blockchain_blackball: make log file name consistent with executable
2018-12-22 14:46:35 +09:00
de9dcdd179
wallet2: finalize_multisig now rejects non N-1/N multisig wallets
2018-12-21 23:41:16 +00:00
99765b218e
Remove unused hash in export_key_images
2018-12-19 14:45:13 +11:00
c5e0539cb5
device/trezor: store tx_prefix_hash in tx key aux
...
- tx_prefix_hash is required in the key derivation for decryption of the tx keys
2018-12-18 22:20:18 +01:00
b8342dd52c
blockchain: fix block rate check for empty blockchains
2018-12-18 18:47:54 +00:00
e37154a879
build: protobuf dependency fixes, libusb build
...
- docker protobuf dependencies, cross-compilation
- device/trezor protobuf build fixes, try_compile
- libusb built under all platforms, used by trezor for direct connect
2018-12-18 16:50:19 +01:00
008647d7eb
blockchain_db: speedup tx output gathering
...
We know all the data we'll want for getblocks.bin is contiguous
2018-12-18 11:55:21 +00:00
808a1f1e8a
wallet2: cut down on the number of useless derivation threads
2018-12-16 18:31:10 +00:00
841a6acda2
wallet2: fix accessing unwound stack on exception
2018-12-16 18:30:02 +00:00
60b35c91b9
Add --restore-date param
...
Estimate restore height from given date
Check date format early, error out early if invalid
2018-12-14 19:11:35 +00:00
219548f299
Sync hashchain bug fixed
2018-12-14 17:42:11 +03:00
611db08a00
Wallet: Initialize members without default ctor.
...
Found by Coverity (188336 in Anonimal's Coverity account).
2018-12-14 13:45:41 +00:00
1ebcd7b9b0
MMS (Multisig Messaging System): Initial version
2018-12-12 21:49:20 +01:00
aaafa8a946
ringct: avoid repeated point conversion
2018-12-12 12:48:10 +00:00
6bc0c7e685
Merge pull request #4927
...
6456cb41
2018-12-12 12:01:31 +02:00
5e9225e637
Merge pull request #4925
...
ab783b179b69a0ae4d71d463
2018-12-12 12:01:18 +02:00
51874e5a40
Merge pull request #4924
...
0c5dd316
2018-12-12 12:00:50 +02:00
fe3c8c9682
Merge pull request #4923
...
aba9a9c2
2018-12-12 12:00:37 +02:00
e9aa886d9e
Merge pull request #4921
...
ac665418
2018-12-12 11:59:56 +02:00
e19a205ff4
Merge pull request #4920
...
e98ae34e
2018-12-12 11:59:43 +02:00
83684ea515
Merge pull request #4909
...
756684bb
2018-12-12 11:59:25 +02:00
4556f0e2b8
Merge pull request #4908
...
5ca4994c
2018-12-12 11:59:04 +02:00
0fccc78e39
Merge pull request #4903
...
dc1c1252
2018-12-12 11:58:37 +02:00
d855f9bb92
Merge pull request #4901
...
a48f2dab17b45725
2018-12-12 11:57:31 +02:00
85262ca8cd
Merge pull request #4899
...
2be31b4c
2018-12-12 11:56:21 +02:00
c73ac91af8
Merge pull request #4897
...
9b5efad2
2018-12-12 11:55:13 +02:00
0b31baf6e4
Merge pull request #4839
...
d71f89e265b9bca79cf636afd21dad70318cc784
2018-12-12 11:53:42 +02:00
dde1e69723
Merge pull request #4787
...
3dba7f25
2018-12-12 11:53:10 +02:00
b56b5b52eb
ignore child process when exec
2018-12-08 20:52:54 -05:00
0e2f5cb5fc
perf_timer: make all logs Info level
...
and make them not default at log level 1
2018-12-08 10:53:09 +00:00
2d7b0236eb
wallet2: clear all payments on soft rescan_bc
...
They'll get duplicated otherwise
2018-12-08 10:39:54 +00:00
3a3858dc90
epee: avoid string allocation when parsing a pod from string
2018-12-08 02:00:34 +00:00
25e5a8539c
singleton: fix missing *this return value in operator=
...
while there, disable both operator= and copy ctor, since they
are not supposed to be around for a singleton
2018-12-07 16:56:59 +00:00
93c59b29a8
perf_timer: check allowed categories before logging
2018-12-07 14:23:47 +00:00
6a507dab6f
perf_timer: add a way to get and reset the current time
2018-12-07 14:23:47 +00:00
c1581a5bb8
perf_timer: only log to file
2018-12-07 14:23:47 +00:00
dbbb3ce9d8
cryptonote: don't serialize for blob size if already known
2018-12-07 14:07:26 +00:00
570dd3690e
p2p: use vector instead of list for peer lists
2018-12-07 13:20:34 +00:00
5464725a29
protocol: change standby mode to not wait sleeping
2018-12-07 12:53:11 +00:00
1d892ec881
simplewallet: donate command validate amount
2018-12-07 13:43:21 +01:00
db5737413e
util: use fcntl instead of flock, for compatibility
...
in particular with NFS
2018-12-06 12:59:29 +00:00
9cc68a2f74
tx_pool: add a few std::move where it can make a difference
2018-12-05 21:13:37 +00:00
d1efe3d91c
cryptonote: set tx hash on newly parsed txes when known
2018-12-05 21:13:29 +00:00
5511563e92
db_lmdb: avoid pointless division
2018-12-05 21:13:24 +00:00
833269834d
db_lmdb: inline check_open, it's trivial and called everywhere
2018-12-05 21:13:21 +00:00
ce594f5af7
blockchain_db: allocate known size vector only once
2018-12-05 21:13:18 +00:00
6644b9b7b7
blockchain_db: remove a couple unused functions
2018-12-05 21:13:13 +00:00
1505dd38c9
util: set MONERO_DEFAULT_LOG_CATEGORY
...
Otherwise it'd end up with whatever was included last
2018-12-05 14:53:30 +00:00
9e64a71e7d
blockchain: call deinit in dtor
...
This ensures the io service that runs in another thread cannot
access data after it's deleted
2018-12-05 00:13:28 +00:00
d71f89e2a2
device/trezor: device/trezor: correct device initialization, status check
...
- checks if the device is in the correct usable state
- implements check for the v2.0.9 firmware which does not support payment IDs
- simple transacttion check, payment id fmt consistency
- minor fixes, refactoring, webusb session counting fix
2018-12-04 20:12:03 +01:00
65b9bca70e
device/trezor: python2 compatibility - bundle dependencies
2018-12-04 18:38:18 +01:00
9cf636af69
device/trezor: ask for KI sync on first refresh
...
When doing a first refresh on HW-token based wallet KI sync is required if money were received. Received money may indicate wallet was already used before the restore I.e., some transaction could have been already sent from the wallet. The spent UTXO would not be detected as spent which could lead to double spending errors on submitting a new transaction.
Thus if the wallet is HW-token based with the cold signing protocol and the first refresh detected received money the user is asked to perform the key image sync.
2018-12-04 18:38:17 +01:00
d21dad70dd
device: enable to use multiple independent device wallets
...
- adds a new option `--hw-device-deriv-path` to the simple wallet. Enables to specify wallet derivation path / wallet code (path avoided so it can be misinterpreted as a file path).
- devices can use different derivation mechanisms. Trezor uses standard SLIP-10 mechanism with fixed SLIP-44 prefix for Monero
- Trezor: when empty, the default derivation mechanism is used with 44'/128'/0'. When entered the derivation path is 44'/128'/PATH.
- Trezor: the path is always taken as elements are hardened (1<<31 bit turned on)
2018-12-04 18:38:16 +01:00
7e957c162a
Merge pull request #4879
...
243f010e
2018-12-04 17:34:57 +02:00
5ed45acaec
Merge pull request #4906
...
506472e0
2018-12-04 17:33:53 +02:00
81418cb281
Merge pull request #4894
...
aee7a4e31a0733e50dac3c645d9915abd4f50cb16116397130023074
2018-12-04 17:33:19 +02:00
6d1c2a9304
Merge pull request #4892
...
c28e3d2d
2018-12-04 17:32:42 +02:00
243f010edc
rpc: mask values that are nobody else's business in restricted RPC
2018-12-04 15:32:21 +00:00
0e0777e4d1
Merge pull request #4888
...
b0d9d605
2018-12-04 17:31:43 +02:00
6e74aa9a6c
Merge pull request #4885
...
b5573fc2
2018-12-04 17:31:27 +02:00
1bebe99496
Merge pull request #4884
...
56e616e8
2018-12-04 17:31:15 +02:00
302fd80826
Merge pull request #4882
...
6bfcc573
2018-12-04 17:30:30 +02:00
e799fc87ae
Merge pull request #4866
...
9c923badec1a62b5
2018-12-04 17:30:11 +02:00
d4a0fb2b89
Merge pull request #4880
...
96e6b439
2018-12-04 17:29:46 +02:00
e282e9fa40
Merge pull request #4878
...
517f25ef
2018-12-04 17:28:24 +02:00
868630c1db
Merge pull request #4877
...
c25260f5
2018-12-04 17:16:52 +02:00
ec1a62b50d
move int-util.h to epee
2018-12-04 15:14:29 +00:00
a605c0da08
Merge pull request #4872
...
fc99f177
2018-12-04 17:13:21 +02:00
e7d30780de
Merge pull request #4869
...
60f36386
2018-12-04 17:12:47 +02:00
eba668c6ad
Merge pull request #4862
...
3998a9373900fb77
2018-12-04 17:09:40 +02:00
11d86f6008
Merge pull request #4859
...
6f2497bc
2018-12-04 17:09:21 +02:00
c00ac446fd
Merge pull request #4854
...
bd98e99c
2018-12-04 17:08:42 +02:00
398f7076bb
Merge pull request #4853
...
2b3595d0
2018-12-04 17:07:51 +02:00
94288d7d1d
Merge pull request #4845
...
6732fc7f
2018-12-04 17:06:04 +02:00
5a76933903
Add glibc back compat code
...
To ensure that the binaries compiled by gitian run across many linux
distributions, enforce 2.17 as the minimum libc version supported.
2018-12-04 02:21:06 +01:00
affff949f9
blockchain: fix race between two external mining threads
2018-12-02 13:08:41 +00:00
6456cb415a
Bulletproof: Initialize members in default construtor.
...
Fixing a build warning on g++ 7.3.0
2018-12-01 13:03:32 +00:00
9b69a0ae01
daemon: print monero version at startup when calling a detached daemon
...
So people who want a timstamp get a timestamp
2018-11-30 17:55:16 +00:00
0c5dd3161b
cryptonote: add a set_null for transaction_prefix
...
Since it's all inline, I suspect the compiler will merge the
duplicate stores anyway.
2018-11-30 15:11:43 +00:00
aba9a9c277
daemon: stop miner before we bring the whole thing down
...
This avoids the miner erroring out trying to submit blocks
to a core that's already shut down (and avoids pegging
the CPU while we're busy shutting down).
2018-11-30 15:10:25 +00:00
ac665418f0
ringct: fix dummy bulletproofs on ledger in fake mode
...
Ledger does some basic checks on them
2018-11-30 13:33:29 +00:00
318cc78457
device/trezor: passphrase entry on host
...
- simple device callback object added. Device can request passphrase/PIN entry via the callback or notify user some action is required
- callback is routed to wallet2, which routes the callback to i_wallet_callback so CLI or GUI wallets can support passphrase entry for HW tokens
- wallet: device open needs wallet callback first - passphrase protected device needs wallet callback so user can enter passphrase
2018-11-29 04:33:41 +01:00
dc1c12528d
add command pop_blocks
...
add new public method to Blockchain and update according to code review
update after review: better lock/unlock, try catch and coding style
2018-11-28 12:20:28 +01:00
a48f2dab00
blockchain_prune_known_spent_data: blackball file is now optional
...
If not present, the tool will scan the blockchain, since scanning
for this is fairly fast.
2018-11-27 15:45:47 +00:00
17b45725af
Outputs where all amounts are known spent can now be pruned
...
Only for pre rct for obvious reasons.
Note: DO NOT use a known spent list which includes outputs
which are not known spent. If the list includes any output
that's just strongly thought to be spent, but not provably
so, you risk finding yourself unable to sync past the point
where that output is spent.
I estimate only 200 MB saved on current mainnet though,
unless the new blackballing rule unearths a good amount of
large-amount-set extra spent outs.
2018-11-27 15:45:42 +00:00
756684bb28
blockchain: avoid unnecessary DB lookups when syncing
...
Some of the inputs for block in a span will be from other earlier
blocks in that span. Keep track of those outputs so we don't have
to look them up again after those early blocks are added to the
blockchain.
2018-11-27 14:03:06 +00:00
5ca4994c9c
rpc: speed up the common get_output_distribution case while syncing
2018-11-27 14:01:40 +00:00
e98ae34e4b
core: fix adding new pre-hoh block when a tx is already in the pool
2018-11-26 23:45:01 +00:00
0e2a5d75de
simplewallet: use is_transfer_unlocked instead of is_tx_spendtime_unlocked for show_transfers
...
Followup on #4728
2018-11-27 07:50:16 +09:00
58ce16d4d9
Merge pull request #4821
...
fc98f7a0
2018-11-26 21:51:27 +02:00
fc98f7a0a1
rpc: speedup get_outs.bin
2018-11-26 18:56:23 +00:00
3e2abc9eaa
Merge pull request #4834
...
2c7195d8
2018-11-26 20:30:15 +02:00
4a64303d71
Merge pull request #4831
...
c5ee14ae
2018-11-26 20:29:06 +02:00
c4fd8ce97e
Merge pull request #4830
...
dffec258
2018-11-26 20:28:49 +02:00
eccb9b08c4
Merge pull request #4825
...
b9b307d1
2018-11-26 20:28:02 +02:00
b37ce24cdd
Merge pull request #4824
...
2ffe53d9
2018-11-26 20:27:29 +02:00
cc1ea0b651
Merge pull request #4816
...
1a4d1603
2018-11-26 20:25:39 +02:00
506472e0c6
protocol: fix use after free when dropping a connection
2018-11-26 17:19:25 +00:00
2ffe53d9e6
device/trezor: webusb transport added, cmake fixes
...
- webusb transport based on libusb added. Provides direct access to Trezor via USB, no need for Trezor bridge.
- trezor protocol message handler improved, no recursion used. Ready for upcoming integration tests.
- libusb (for docker) bumped from v1.0.9 to v1.0.22, newer version required for webusb transport, for device enumeration.
- cmake improvements and fixes. Cmake Trezor checks are moved to a dedicated CheckTrezor.cmake file. In case of a problem Trezor is excluded from build.
- ifdefs made consistent to Ledger.
- UDP Transport enumeration disabled by default in release mode
2018-11-25 11:57:19 +01:00
2be31b4c9c
blockchain_blackball: spot when all outputs of an amount are spent
2018-11-24 11:07:15 +00:00
9b5efad294
simplewallet: enable donation on testnet/stagenet for easier testing
2018-11-24 08:25:38 +09:00
aee7a4e364
wallet_rpc_server: do not use RPC data if the call failed
...
Found by codacy.com
2018-11-23 15:38:00 +00:00
1a0733e534
windows_service: fix memory leak
...
Found by codacy.com
2018-11-23 15:38:00 +00:00
5d9915ab9e
cryptonote: fix get_unit for non default settings
...
Found by codacy.com
2018-11-23 15:37:39 +00:00
d4f50cb109
remove some unused code
...
Found by codacy.com
2018-11-23 15:37:36 +00:00
611639710d
a few minor (but easy) performance tweaks
...
Found by codacy.com
2018-11-23 15:36:48 +00:00
3002307418
tests: slow_memmem now returns size_t
...
Makes more sense than uint64_t for an offset, and agrees with
the %zu used to print results.
Found by codacy.com
2018-11-23 15:36:48 +00:00
c28e3d2dae
rctOps: add braces to suppress warnings
2018-11-23 12:28:04 +09:00
b0d9d6051f
cn_deserialize: allow parsing partially valid tx extra
2018-11-22 11:15:57 +00:00
b5573fc231
wallet2: resume processing when tx extra is partially broken
...
Motivated by https://monero.stackexchange.com/questions/10483
Some exchanges appear to have customized the wallet software
in an inappropriate way, making the tx extra field partially
unreadable. PR #3716 changed the wallet behavior disallowing
such partially valid tx extra.
An example tx reported by the user is
e87c675a85f34ecac58a8846613d25062f1813e1023c552b705afad32b972c38
where the normal tx pubkey appears again with the aditional
tx pubkeys tag `04` which is inappropriate.
2018-11-22 14:51:35 +09:00
56e616e855
wallet2: add n_vouts to capture list
2018-11-22 01:45:45 +00:00
517f25efd1
rpc: add version to get_info
2018-11-21 12:56:34 -05:00
6bfcc57395
scoped_message_writer: protect all std::cout usage from readline
2018-11-21 12:48:43 +00:00
96e6b43970
blockchain_stats: don't use gmtime_r on Windows
...
In some cases, it doesn't like it (I don't know the details).
Factor into a new epee function
2018-11-21 00:50:53 +00:00
c25260f51c
protocol: fix incorrect tx hash in log
2018-11-20 18:35:58 +00:00
6732fc7fde
Fix issue 4793 - M/N multisig transaction signature
2018-11-20 16:50:41 +03:00
b9b307d11a
rpc: speedup get_output_distribution
...
and decrease the amount of data carried around
2018-11-20 10:11:25 +00:00
84dd674cd0
Merge pull request #4781
...
2a48c2a2b39fdf8e
2018-11-20 12:34:41 +09:00
fc99f177f3
lmdb: fix gcc 7.3.0 'implicit-fallthrough' warning
2018-11-19 22:36:10 +00:00
moneromooo-monero