d93746b6d3
rct: rework the verification preparation process
...
The whole rct data apart from the MLSAGs is now included in
the signed message, to avoid malleability issues.
Instead of passing the data that's not serialized as extra
parameters to the verification API, the transaction is modified
to fill all that information. This means the transaction can
not be const anymore, but it cleaner in other ways.
2016-08-28 21:30:16 +01:00
3ab2ab3e76
rct: change the simple flag to a type
...
for future expansion
2016-08-28 21:30:14 +01:00
c5be4b0bea
rct: avoid the need for the last II element
...
This element is used in the generation of the MLSAG, but isn't
needed in verification.
Also misc changes in the cryptonote code to match, by mooo.
2016-08-28 21:30:12 +01:00
a47ceee83b
wallet: do not store signatures in the wallet cache
...
Saves some substantial space.
Also avoid calculating tx hashes we don't need.
2016-08-28 21:30:10 +01:00
b337aea6cc
rct: do not serialize senderPk - it is not used anymore
2016-08-28 21:30:01 +01:00
e5a9a4755b
core_tests: fix a couple pre-rct tests using rct
2016-08-28 21:29:58 +01:00
37bdf6ebe3
change fork settings to allow pre-rct txes for one more fork cycle
2016-08-28 21:29:50 +01:00
9b70856ccb
rct: make the amount key derivable by a third party with the tx key
...
Scheme design from luigi1114.
2016-08-28 21:29:46 +01:00
cf33e1a52a
rct: do not serialize public keys in outPk
...
They can be reconstructed from vout
2016-08-28 21:29:43 +01:00
ce5de8b430
tests: add tests for wallet output selection
2016-08-28 21:29:34 +01:00
e81a2b2cfa
port get_tx_key/check_tx_key to rct
2016-08-28 21:29:24 +01:00
e06faefde4
tests: add basic tests for simple rct api
2016-08-28 21:29:22 +01:00
a4d4d6194b
integrate simple rct api
2016-08-28 21:29:20 +01:00
59a66e209a
move the rct commitments to the output_amounts database
...
Since these are needed at the same time as the output pubkeys,
this is a whole lot faster, and takes less space. Only outputs
of 0 amount store the commitment. When reading other outputs,
a fake commitment is regenerated on the fly. This avoids having
to rewrite the database to add space for fake commitments for
existing outputs.
This code relies on two things:
- LMDB must support fixed size records per key, rather than
per database (ie, all records on key 0 are the same size, all
records for non 0 keys are same size, but records from key 0
and non 0 keys do have different sizes).
- the commitment must be directly after the rest of the data
in outkey and output_data_t.
2016-08-28 21:29:02 +01:00
6d0e47148b
rct: add the tx prefix hash into the MLSAG
...
to protect the non-signatures parts of the tx from tampering.
2016-08-28 21:28:58 +01:00
20e50ec7f7
ringct: do not serialize what can be reconstructed
...
The mixRing (output keys and commitments) and II fields (key images)
can be reconstructed from vin data.
This saves some modest amount of space in the tx.
2016-08-28 21:28:55 +01:00
106e3dc3d4
Add rct core tests
2016-08-28 21:28:53 +01:00
161551e13b
tests: test for ringct rctSig data sizes
...
ie, more data or less data than expected in various fields
2016-08-28 21:28:42 +01:00
dc4aad7eb5
add rct to the protocol
...
It is not yet constrained to a fork, so don't use on the real network
or you'll be orphaned or rejected.
2016-08-28 21:28:37 +01:00
cc7f449d57
make rct tx serialization work
...
It may be suboptimal, but it's a pain to have to rebuild everything
when some of this changes.
Also, no clue why there seems to be two different code paths for
serializing a tx...
2016-08-28 21:28:31 +01:00
54f7429cf6
ringct: allow no outputs, and add tests for this and fees
2016-08-28 21:28:27 +01:00
f8c04ad94f
ringct: txn fee stuff
2016-08-28 21:28:23 +01:00
eb56d0f994
blockchain_db: add functions for adding/removing/getting rct commitments
2016-08-28 21:28:11 +01:00
53cdf4df5e
tests: new ringct test for checking H2 values
...
Ported from Shen's RingCT repo
2016-08-28 21:28:01 +01:00
720ac85553
tests: zero inputs/outputs are in fact supposed to be accepted
2016-08-28 21:27:52 +01:00
84948eabae
ringct: add a test for prooveRange being non deterministic
2016-08-28 21:27:50 +01:00
700248f59e
tests: more ringct range proof tests
2016-08-28 21:27:43 +01:00
9e82b694da
remove original Cryptonote blockchain_storage blockchain format
2016-08-28 21:27:32 +01:00
57779abe27
tests: add some more ringct building block tests
2016-08-28 21:27:26 +01:00
2d6303fb2c
tests: add Shen Noether's basic ringct tests
2016-08-28 21:27:19 +01:00
f017fecde9
Build the core_tests under Travis
2016-08-27 06:22:57 -06:00
65041fbbf8
Disabled libwallet_api_test until Issue #895 resolved
...
Signed-off-by: Jacob Torrey <discipleofranok@gmail.com>
2016-08-26 14:03:27 -06:00
a4501384bf
Disable core_tests on Travis-CI
...
Signed-off-by: Jacob Torrey <discipleofranok@gmail.com>
2016-08-26 14:03:27 -06:00
99dd57258f
libwallet_api: tests: checking for result while opening wallet
2016-08-23 14:13:30 +03:00
bcf7b67cd6
libwallet_api: Wallet::amountFromString fixed
2016-08-23 13:47:21 +03:00
cbe534db1a
libwallet_api: tests: removed logged passwords
2016-08-22 23:14:58 +03:00
b1a5a937ff
libwallet_api: do not store wallet on close if status is not ok
2016-08-22 22:47:59 +03:00
11dc091464
Fake outs set is now decided by the wallet
...
This plugs a privacy leak from the wallet to the daemon,
as the daemon could previously see what input is included
as a transaction input, which the daemon hadn't previously
supplied. Now, the wallet requests a particular set of
outputs, including the real one.
This can result in transactions that can't be accepted if
the wallet happens to select too many outputs with non standard
unlock times. The daemon could know this and select another
output, but the wallet is blind to it. It's currently very
unlikely since I don't think anything uses non default
unlock times. The wallet requests more outputs than necessary
so it can use spares if any of the returns outputs are still
locked. If there are not enough spares to reach the desired
mixin, the transaction will fail.
2016-08-11 14:35:27 +01:00
46188734f6
tests: fix a bitflag test typo
2016-07-26 22:40:46 +01:00
89e68d778d
unit_tests: check adding checkpoints succeeded
2016-07-26 22:40:38 +01:00
b582764bd6
Merge pull request #915
...
d7597c56d32a3d193d25110c06dd9d2cb4fd27b883083380c00ed12b
2016-07-23 09:17:21 +02:00
61ed40a618
Tests: fix signed/unsigned comparison in hash-target
...
* References #886
2016-07-22 22:05:35 +00:00
6d32a3d16b
wallet_api: async init, Wallet::connected status, log level
2016-07-18 23:03:09 +03:00
9d2cb4f36c
WalletListener functionality
2016-07-18 23:02:47 +03:00
083380cb8f
Transaction fee multiplier aka priority integraged
2016-07-18 23:02:18 +03:00
d7b681cd65
remove hf_starting_height db
...
It's not really needed, it used to be an optimization for when
that code was not using the db and needed to recalculate things
fast on startup.
2016-07-13 21:38:34 +01:00
ab61ba0c9b
Merge branch 'master' of https://github.com/mbg033/bitmonero
2016-06-23 16:23:09 +03:00
ca61153003
Wallet: payment id and integrated address
2016-06-23 16:01:41 +03:00
2efec04f74
Wallet::createTransaction: added mixin_count param
2016-06-23 16:01:41 +03:00
85a632244e
double/string to monero integer convertion methods
2016-06-23 16:01:41 +03:00
e7d8f2a085
wallet::default_mixin exposed to public interface as
...
Wallet::setDefaultMixin, Wallet::defaultMixin;
wallet::create_transaction_2 used in Wallet::createTransaction
2016-06-23 16:01:41 +03:00
a5374897f8
Wallet::filename, Wallet::keysFilename, tests for move wallet
2016-06-23 16:01:41 +03:00
8390bfa770
Wallet API : WalletManager::findWallets() added
2016-06-23 16:01:41 +03:00
44cc0ef147
scripts for faster test wallets generation
2016-06-23 16:01:41 +03:00
2060bfe5ad
regenerated test wallets, basic functions got broken
2016-06-23 16:01:41 +03:00
91eeeb8989
WalletListener::moneyReceived test
2016-06-23 16:01:33 +03:00
64348a2d11
WalletListener::moneySpent test
2016-06-23 16:01:33 +03:00
e6fdd5dd10
TransactionHistory continued
2016-06-23 16:01:26 +03:00
d500272fa8
Wallet API : transaction history in progress
2016-06-23 15:50:33 +03:00
951f3b5d83
Wallet::createTransaction API introduced
...
Transaction API continued
TODOs for Transaction/Transfer interface
2016-06-23 15:49:54 +03:00
7c51227f88
Wallet::transfer in progress
2016-06-23 15:49:36 +03:00
e04c67ac4c
Wallet::refresh + tests
2016-06-23 15:49:36 +03:00
caf0e02787
testnet option, Wallet::balance(), Wallet::unlockedBalance()
2016-06-23 15:49:22 +03:00
8df820b301
- testnet option added to api;
2016-06-23 15:49:07 +03:00
94eaeb50b2
wallet2::store() implemented within wallet2::store_to
2016-06-23 15:40:48 +03:00
f1c4a376af
Wallet::createTransaction: added mixin_count param
2016-06-20 22:56:30 +03:00
3318addafa
double/string to monero integer convertion methods
2016-06-16 16:42:33 +03:00
3ac20a46b3
wallet::default_mixin exposed to public interface as
...
Wallet::setDefaultMixin, Wallet::defaultMixin;
wallet::create_transaction_2 used in Wallet::createTransaction
2016-06-10 13:52:10 +03:00
c554055ce4
Wallet::filename, Wallet::keysFilename, tests for move wallet
2016-06-10 12:51:09 +03:00
2facbe77e4
Wallet API : WalletManager::findWallets() added
2016-06-03 14:52:58 +03:00
ec949c383c
scripts for faster test wallets generation
2016-06-01 17:06:10 +03:00
7f3d28fe1b
regenerated test wallets, basic functions got broken
2016-05-27 13:35:00 +03:00
bc4584c1ff
Merge remote-tracking branch 'upstream/master'
2016-05-27 11:33:08 +03:00
de030d99a5
fix: error: -Werror=misleading-indentation
...
Compilation of bitmonero on Arch with gcc 6.1 results in the following
error:
/home/mwo/bitmonero/tests/unit_tests/hardfork.cpp: In member function ‘virtual void TestDB::set_hard_fork_version(uint64_t, uint8_t)’:
/home/mwo/bitmonero/tests/unit_tests/hardfork.cpp:132:5: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
if (versions.size() <= height) versions.resize(height+1); versions[height] = version;
This can be fixed by simply unfolding this line into three lines.
2016-05-18 10:54:41 -04:00
e54e4d96a4
Merge pull request #831
...
9ef8c7ba6e717e3eff37f7a66387d6bce4b
2016-05-17 19:07:28 +02:00
9ae4e871a3
WalletListener::moneyReceived test
2016-05-17 12:16:11 +03:00
40087a745f
WalletListener::moneySpent test
2016-05-16 13:11:44 +03:00
2d799097ca
Merge remote-tracking branch 'upstream/master'
2016-05-12 15:14:30 +03:00
9ef8c7b694
tests: fix tests broken by the removal of the block reward accumulation loop
...
The tests for rejection of unmixable outputs in v2 are commented out,
as there are no unmixable outputs created anymore. This should be
restored at some point.
2016-05-01 20:59:41 +01:00
3eff37f931
unit_tests: add a write_varint/read_varint test
2016-05-01 11:42:31 +01:00
7a663873ce
unit_tests: fix UNBOUND_LIBRARIES/UNBOUND_LIBRARY typo
2016-05-01 11:35:14 +01:00
30dce45643
Merge branch 'performance' of https://github.com/LMDB/bitmonero
2016-04-29 21:41:43 +02:00
93119344ec
TransactionHistory continued
2016-04-29 16:26:14 +03:00
dce5374660
Merge remote-tracking branch 'upstream/master' into develop
2016-04-26 11:08:40 +03:00
53a97bdcd3
Wallet API: transaction history in progress
2016-04-22 13:33:09 +03:00
02c9df5de2
Wallet API : transaction history in progress
2016-04-22 13:21:08 +03:00
672162d9e2
tests: fix compile failure on wallet2::transfer
2016-04-17 11:21:01 +01:00
b52148201b
Merge pull request #786
...
5092e45
2016-04-14 16:26:29 +09:00
6bfb8799c3
Merge pull request #783
...
48d0747
2016-04-14 16:25:38 +09:00
1774d9574b
TODOs for Transaction/Transfer interface
2016-04-12 22:30:20 +03:00
d97e9ef8a5
Transaction API continued
2016-04-06 13:56:57 +03:00
d7ea7d9a23
Merge branch 'performance' into master
2016-04-05 21:13:16 +01:00
372acee723
Cleanup
...
drop obsolete remove_output()
fix get_output_key(global), fix crash in blockchain_dump
2016-04-05 21:05:24 +01:00
079fbd3d42
Wallet::createTransaction API introduced
2016-04-05 15:24:44 +03:00
ee5bb17f26
Wallet::transfer() continued
2016-04-04 14:56:17 +03:00
17cac41968
tests: fix build with older GCC
2016-04-02 22:05:56 +01:00
5092e45e3f
tests: unbound API is only accessible in static builds
2016-04-02 16:02:18 +01:00
48d0747d00
wallet: better output selection for transfer/transfer_new
...
This now requests the set of outputs that can be mixed first,
to avoid trying non dust but unmixable outputs, which we know
will fail.
2016-04-02 14:17:02 +01:00
830c19c934
Wallet::refresh + tests
2016-03-31 16:38:57 +03:00
2157a9ac48
testnet option, Wallet::balance(), Wallet::unlockedBalance()
2016-03-31 12:48:41 +03:00
moneromooo-monero