Commit Graph

6908 Commits

Author SHA1 Message Date
Riccardo Spagni acc9b32749
Merge pull request #4409
7a056f44 WalletAPI: multisigSignData bug fixed (naughtyfox)
2018-09-29 22:11:13 +02:00
Riccardo Spagni 9d0b177720
Merge pull request #4407
43a06350 ringdb: use cursors to be a bit faster (moneromooo-monero)
2018-09-29 22:10:48 +02:00
Riccardo Spagni 0d062bacfb
Merge pull request #4406
7964d4f8 wallet2: handle corner case in picking fake outputs (moneromooo-monero)
2018-09-29 21:51:51 +02:00
moneromooo-monero 7340300460
add --block-notify to monerod and --tx-notify to monero-wallet-{cli,rpc}
Those take a command line of the form "A [B]", with A being the
name (and optional path, if not in the caller's CWD, but fully
qualified path is recommended, avoids possible security issues)
to a program, and optional arguments. Any occurence of the two
character string "%s" will be replaced by the hash of the block
or transaction which triggered the notification.

Tokenization is barebones. If you want things like pipes, calls
to paths with spaces, etc, then use a script (though exec time
will suffer).

block-notify is called when a new block is added onto the chain.

tx-notify is called when a new transaction happens with the
wallet as source and/or destination.

It is the notification program's responsibility to determine what
to do in those cases.

Note that this is asynchronous, so it is very possible that:
- the notification programs will be run out of order
- several events happen before the notification for the first one

A Windows port would be nice if someone wants to make one.
2018-09-29 08:44:18 +00:00
moneromooo-monero 83debef99e
wallet_rpc_server: remove verbose field in incoming_transfers query
The key image (which was only supplied if verbose was true) is
readily available, not a secret key, and it was only modelled
after the CLI command because it's a bit spammy for the CLI.
2018-09-28 17:06:56 +00:00
moneromooo-monero 7dd11711b0
wallet2: fix transfers between subaddresses hitting the sanity check
Transfers between subaddresses are accounted for differently
2018-09-28 10:41:17 +00:00
moneromooo-monero bcf3f6afdd
fuzz_tests: catch unhandled exceptions
Coverity 175293, 175312, 175266
2018-09-27 18:23:24 +00:00
moneromooo-monero 3ebd05d4e5
miner: restore stream flags after changing them
Coverity 136462
2018-09-27 18:17:32 +00:00
moneromooo-monero a093092ef7
levin_protocol_handler_async: do not propagate exception through dtor
Coverity 161856
2018-09-27 18:02:42 +00:00
moneromooo-monero 1eebb82bcc
net_helper: do not propagate exceptions through dtor
Coverity 161864
2018-09-27 17:43:49 +00:00
moneromooo-monero fb6a363050
miner: do not propagate exceptions through dtor
Coverity 161862
2018-09-27 17:42:39 +00:00
moneromooo-monero 2e2139ffb7
epee: do not propagate exception through dtor
Coverity 161867
2018-09-27 17:40:56 +00:00
moneromooo-monero 0749a8bd3c
db_lmdb: do not propagate exceptions in dtor
Not much we can do here

Coverity 161875
2018-09-27 17:29:15 +00:00
moneromooo-monero 1b0afeeb1c
wallet_rpc_server: exit cleanly on unhandled exceptions
Coverity 161868
2018-09-27 17:29:12 +00:00
moneromooo-monero 418a993618
unit_tests: catch unhandled exceptions
Coverity 182560
2018-09-27 17:29:09 +00:00
moneromooo-monero ea7f954381
threadpool: do not propagate exceptions through the dtor
This would call terminate.
We ignore exceptions in pthread_join instead, as this is not
a fatal problem here.

Coverity 182568
2018-09-27 17:29:02 +00:00
moneromooo-monero 6e8554221f
gen_multisig: nice exit on unhandled exception
Coverity 182569
2018-09-27 17:28:59 +00:00
moneromooo-monero 53df2deb36
db_lmdb: catch error in mdb_stat calls during migration
Coverity 188305
2018-09-27 17:28:53 +00:00
moneromooo-monero e67016ddb4
blockchain_blackball: catch failure to commit db transaction
Coverity 188349
2018-09-27 17:28:50 +00:00
moneromooo-monero 661439f4e0
mlog: don't remove old logs if we failed to rename the current file
Coverity 188348
2018-09-27 17:28:47 +00:00
moneromooo-monero 5fdcda50ee
easylogging++: test for NULL before dereference 2018-09-27 17:28:42 +00:00
m2049r 921b0fb11b
use default create_address_file argument 2018-09-27 17:59:46 +02:00
moneromooo-monero 7ece1550e1
performance_test: fix bad last argument calling add_arg
Coverity 182572
2018-09-27 12:53:12 +00:00
xiphon 85318e7800 build: set ARCH_FLAG before compiler/linker flag checks 2018-09-27 12:05:36 +00:00
moneromooo-monero a085da3247
unit_tests: add check for page size > 0 before dividing
Coverity 188426
2018-09-27 11:59:52 +00:00
moneromooo-monero d8b1ec8b8b
unit_tests: use std::shared_ptr to shut coverity up about leaks
Coverity 188436, 188433, 188428, 188415, 188416, 188410, 188400,
188298, 188299, 188321, 188342, 188343, 188355, 188357, 188361,
188366, 188374
2018-09-27 11:59:49 +00:00
moneromooo-monero 02563bf4b9
simplewallet: top level exception catcher to print nicer messages
Coverity 188408
2018-09-27 10:56:54 +00:00
moneromooo-monero c57a65b246
blockchain_blackball: fix shift range for 32 bit archs
Coverity 188406
2018-09-27 10:54:35 +00:00
Dusan Klinec 06d05c21eb
device: set device name correctly if key_on_device is set 2018-09-27 00:58:47 +02:00
Dusan Klinec b2972927ea
osx compilation fix: missing boost libs added 2018-09-26 21:23:01 +02:00
m2049r 17142ec9bb
malloc scratchpad for all supported android archs 2018-09-26 00:59:12 +02:00
TheCharlatan 6a78140863 Make depends use self built clang for darwin
The configure script in hidapi and libsodium tried to find clang in /usr/bin,
even though the correct prefix was passed in. This sets the correct CC flag.
This was previously undetected, because clang and the sdk where
installed in the global environment.

This also fixes a subsequent error, where IOKIT and CoreFoundation are
not found, again for the reason stated above.
2018-09-25 23:05:16 +02:00
Dusan Klinec 69da14e105 fixes make debug compilation on OSX 2018-09-25 22:44:00 +02:00
Howard Chu fe1256471a
Fixup RENAME_DB() macro
Make sure target DB's record is on a writable page
2018-09-25 21:01:03 +01:00
Riccardo Spagni 558da3684c
Merge pull request #4441
6f5360b3 bump version to 0.13.0.1 (Riccardo Spagni)
2018-09-25 15:54:01 +02:00
Riccardo Spagni 6f5360b3c6
bump version to 0.13.0.1 2018-09-25 15:48:56 +02:00
Riccardo Spagni 3882b30076
Merge pull request #4440
cf470bf3 switch from master to rc (Riccardo Spagni)
2018-09-25 15:26:24 +02:00
Riccardo Spagni cf470bf3d6
switch from master to rc 2018-09-25 15:07:28 +02:00
moneromooo-monero 174f31bf7d
simplewallet: don't complain about payment id on pool mined blocks
Those use the extra nonce without a payment id
2018-09-25 12:34:42 +00:00
Riccardo Spagni 8bf5a00564
Merge pull request #4423
357441a2 add checkpoints for testnet and mainnet (Riccardo Spagni)
d9f666d7 update checkpoints.dat (Riccardo Spagni)
6b1b4e83 update version to 13.0 (Riccardo Spagni)
6f153533 update readme with v13.0 (Riccardo Spagni)
2018-09-25 13:33:52 +02:00
Riccardo Spagni f2eee1eb8c
Merge pull request #4438
e350cc5a wallet2: fix duplicate output making it to the RPC (moneromooo-monero)
bf9a0f4c epee: fix stack overflow on crafted input (moneromooo-monero)
45683ee0 epee: fix invalid memory write reading an array entry (moneromooo-monero)
2018-09-25 13:33:37 +02:00
moneromooo-monero e350cc5ad5
wallet2: fix duplicate output making it to the RPC 2018-09-25 11:28:39 +00:00
moneromooo-monero bf9a0f4c65
epee: fix stack overflow on crafted input 2018-09-25 11:27:50 +00:00
moneromooo-monero 45683ee02c
epee: fix invalid memory write reading an array entry
Reported by Lilith Wyatt at Talos.

Since this is not needed in normal operation, I just let this
error out.
2018-09-25 11:27:48 +00:00
Riccardo Spagni 689758d691
Merge pull request #4435
c39ad0cd tx_pool: fix tx removal at startup keeping references (moneromooo-monero)
2018-09-25 13:11:05 +02:00
Riccardo Spagni 13d9bdb849
Merge pull request #4431
5c234cbd Add hidapi to depends (TheCharlatan)
2018-09-25 13:09:54 +02:00
TheCharlatan 5c234cbdcb Add hidapi to depends
Clang needs to get its cctools path passed directly for the hid build to
succeed.
Make gperf a permanent external dependency.
Remove pcsc from depends.
2018-09-25 12:13:54 +02:00
Riccardo Spagni 295bae10ba
Merge pull request #4412
4d0a8db0 device: fix warnings about overridden functions (moneromooo-monero)
2018-09-25 12:13:51 +02:00
Riccardo Spagni e67789d075
Merge pull request #4422
6e270fbd wallet2_api: fix for latest code changes (moneromooo-monero)
2018-09-25 12:13:34 +02:00
Riccardo Spagni 0d206dccda
Merge pull request #4430
50981c40 blockchain: add stagenet v8 and v9, two weeks before mainnet (moneromooo-monero)
2018-09-25 12:12:29 +02:00