Mirrors
/
wownero
mirror of https://git.wownero.com/wownero/wownero.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,136 Commits 21 Branches 51 Tags 162 MiB
Commit Graph

6967 Commits

Author SHA1 Message Date
Alexander Blair b04da25e4d
Merge pull request #6760 
844fb4e94 enforce claiming maximum coinbase amount (moneromooo-monero)
 2020-08-27 03:01:28 -07:00
Alexander Blair 4fe2858b4d
Merge pull request #6746 
20f603c6b Fix broken multisig pubkey sorting (Jason Rhinelander)
 2020-08-27 02:58:53 -07:00
Alexander Blair dd7fd2ef80
Merge pull request #6753 
4ff2074c7 cryptonote_protocol: don't synced pruned blocks before v11 (cohcho)
 2020-08-27 02:58:45 -07:00
Alexander Blair a06c83db73
Merge pull request #6752 
85899230d simplewallet: allow setting tx keys when sending to a subaddress (moneromooo-monero)
e916201f1 wallet2: fix setting tx keys when another is already set (moneromooo-monero)
 2020-08-27 02:58:23 -07:00
Alexander Blair 42519b48a7
Merge pull request #6731 
db5d6e460 wallet2: fix wrong name when checking RPC cost (moneromooo-monero)
 2020-08-27 02:55:48 -07:00
Alexander Blair bad5d8d6f0
Merge pull request #6690 
7175dcb10 replace most boost serialization with existing monero serialization (moneromooo-monero)
 2020-08-27 02:54:30 -07:00
Alexander Blair 38914fe6fa
Merge pull request #6613 
55363c594 Avoid some temporary strings when reading off the database (moneromooo-monero)
 2020-08-27 02:52:59 -07:00
Alexander Blair a6f1fa0194
Merge pull request #6607 
eb1b321fe miner: increase min/max intervals to full extents (moneromooo-monero)
 2020-08-26 12:53:09 -07:00
moneromooo-monero 844fb4e940
enforce claiming maximum coinbase amount 
Claiming a slightly lesser amount does not yield the size gains
that were seen pre rct, so this closes a fingerprinting vector
 2020-08-21 12:36:53 +00:00
Lee Clagett bdc6b10d62 Fix ZMQ pruned bulletproof transactions 2020-08-19 00:36:06 -04:00
luigi1111 765db1ae7a
Revert "Use domain-separated ChaCha20 for in-memory key encryption" 
This reverts commit 921dd8dde5.
 2020-08-17 14:08:59 -05:00
moneromooo-monero 7175dcb107
replace most boost serialization with existing monero serialization 
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.

For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.

Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.

Some tests and tools also do, this will stay as is for now.
 2020-08-17 16:23:58 +00:00
moneromooo-monero 55363c5941
Avoid some temporary strings when reading off the database 2020-08-17 14:02:27 +00:00
Alexander Blair 43f5369bec
Merge pull request #6733 
4f01cf4b4 Tweak format, add option for difficulty (Howard Chu)
429d49512 Add options to print daily coin emission and fees (Howard Chu)
d745d2433 Don't forget size of prunable txn part (Howard Chu)
 2020-08-16 12:56:03 -07:00
Alexander Blair d73b1b6560
Merge pull request #6727 
13eee1d6a rpc: reject wrong sized txid (moneromooo-monero)
92e6b7df2 easylogging++: fix crash with reentrant logging (moneromooo-monero)
6dd95d530 epee: guard against exceptions in RPC handlers (moneromooo-monero)
90016ad74 blockchain: guard against exceptions in add_new_block/children (moneromooo-monero)
 2020-08-16 12:55:25 -07:00
Alexander Blair 569d07d60b
Merge pull request #6722 
c1b03fb1a rpc: return empty txid get_outs rather than 00..00 when not requested (moneromooo-monero)
 2020-08-16 12:54:42 -07:00
Alexander Blair 01b512f3a9
Merge pull request #6716 
76c16822d wallet2_api: implement runtime proxy configuration (xiphon)
 2020-08-16 12:52:21 -07:00
Alexander Blair f40b9e34e0
Merge pull request #6715 
3d6bc0a68 wallet2: throw a error on wallet initialization failure (xiphon)
 2020-08-16 12:51:57 -07:00
Alexander Blair 43f91ee12e
Merge pull request #6703 
8baa7bb23 daemon: don't print "(pruned)" for coinbase txes (moneromooo-monero)
 2020-08-16 12:50:43 -07:00
Alexander Blair 0b0da2aa81
Merge pull request #6689 
afd002c31 daemon: print sampling time in print_net_stats (moneromooo-monero)
ec7bba079 util: fix kilo prefix typo (K instead of k) (moneromooo-monero)
 2020-08-16 12:47:36 -07:00
Alexander Blair 236256f114
Merge pull request #6679 
2f1ad3b3d updates: mac gui .tar.bz2 -> .dmg (selsta)
 2020-08-16 12:46:51 -07:00
Alexander Blair eba2189925
Merge pull request #6677 
f9e3fcdf3 add trezor support to sweep_single (Dusan Klinec)
 2020-08-16 12:46:27 -07:00
Alexander Blair bc48494731
Merge pull request #6661 
267ce5b71 avoid a couple needless copies (moneromooo-monero)
 2020-08-16 12:45:37 -07:00
Alexander Blair 8f02e7a7fc
Merge pull request #6632 
ef694d028 fix warning by removing std::move() on temporary http_client object (woodser)
 2020-08-16 12:44:59 -07:00
Alexander Blair c6c4ead44e
Merge pull request #6614 
fb31167b1 Wallet, daemon: From 'help_advanced' back to 'help', and new 'apropos' command (rbrunner7)
 2020-08-16 12:44:03 -07:00
Alexander Blair a08df6eb1b
Merge pull request #6603 
4e2377995 Change ZMQ-JSON txextra to hex and remove unnecessary base fields (Lee Clagett)
 2020-08-16 12:43:38 -07:00
Alexander Blair 009ca6fcd3
Merge pull request #6601 
98c151ecb Optimize ZMQ-JSON vector reading; GetBlocksFast reads 24%+ faster (Lee Clagett)
60627c9f2 Switch to insitu parsing for ZMQ-JSON; GetBlocksFast reads 13%+ faster (Lee Clagett)
fe96e66eb Fix pruned tx for ZMQ's GetBlocksFast (Lee Clagett)
 2020-08-16 12:43:11 -07:00
Alexander Blair 0f5eb0e70c
Merge pull request #6546 
eda167585 wallet_rpc_server: use unlock_time in suggested confirmations calc (moneromooo-monero)
 2020-08-16 12:40:51 -07:00
Alexander Blair 461651fce5
Merge pull request #6542 
35665df20 protocol: don't drop a connection if we can't get a compatible chain (moneromooo-monero)
 2020-08-16 12:40:37 -07:00
Alexander Blair 6d29ee6c52
Merge pull request #6493 
921dd8dde Use domain-separated ChaCha20 for in-memory key encryption (Sarang Noether)
 2020-08-16 12:39:59 -07:00
Alexander Blair e2e09d00c2
Merge pull request #6337 
a11ec4ac1 Support for supercop ASM in wallet, and benchmark for supercop (Lee Clagett)
 2020-08-16 12:38:44 -07:00
Alexander Blair 13549d590e
Merge pull request #6329 
6bfcd3101 Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests. (Sarang Noether)
 2020-08-16 12:37:43 -07:00
xiphon 728ba38b11 rpc: always send raw txes through P2P (don't use bootstrap daemon) 
It turns out that some remote (bootstrap) nodes silently drop /
don't broadcast client's transactions.
 2020-08-16 17:34:28 +00:00
moneromooo-monero 07442a6059
Fix build with Boost 1.74 
Thanks iDunk for testing
 2020-08-16 16:23:26 +00:00
Lee Clagett 4e2377995d Change ZMQ-JSON txextra to hex and remove unnecessary base fields 2020-08-14 23:01:00 +00:00
Lee Clagett 98c151ecb8 Optimize ZMQ-JSON vector reading; GetBlocksFast reads 24%+ faster 2020-08-14 19:47:19 +00:00
Lee Clagett 60627c9f24 Switch to insitu parsing for ZMQ-JSON; GetBlocksFast reads 13%+ faster 2020-08-14 19:46:59 +00:00
Lee Clagett fe96e66ebe Fix pruned tx for ZMQ's GetBlocksFast 2020-08-14 19:46:33 +00:00
moneromooo-monero 85899230d1
simplewallet: allow setting tx keys when sending to a subaddress 
The tx key derivation is different then
 2020-08-10 21:25:51 +00:00
cohcho 4ff2074c74
cryptonote_protocol: don't synced pruned blocks before v11 
There are a few Borromean proofs txes in the v8 era, and these
aren't supported by get_pruned_transaction_weight. Moreover, only
only the most recent variant of bulletproofs is currently supported.
 2020-08-10 16:17:39 +00:00
Sarang Noether 921dd8dde5 Use domain-separated ChaCha20 for in-memory key encryption 2020-08-09 19:11:54 -04:00
Sarang Noether 6bfcd31015 Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests. 2020-08-09 18:42:15 -04:00
Alexander Blair c108c5e2f0
Merge pull request #6354 
67ade8005 Add randomized delay when forwarding txes from i2p/tor -> ipv4/6 (Lee Clagett)
 2020-08-09 06:42:49 -07:00
moneromooo-monero e916201f12
wallet2: fix setting tx keys when another is already set 
insert doesn't actually insert if another element with the
same key is already in the map
 2020-08-08 14:40:03 +00:00
Jason Rhinelander 20f603c6be Fix broken multisig pubkey sorting 
The sort predicate is a boolean ordered-before value, but these are
returning the memcmp value directly, and thus returns true whenever the
pubkeys aren't equal.  This means:

- it isn't actually sorting.

- it can (and does) segfault for some inputs.
 2020-08-05 12:42:27 -03:00
Alexander Blair 9414194b1e
Merge pull request #6571 
1d31e6c00 net_node: remove dead seed nodes (selsta)
 2020-08-05 07:57:54 -07:00
Howard Chu 4f01cf4b46
Tweak format, add option for difficulty 
Set input, output, ringsize averages to 2 decimal places precision
Add option to show min/max/av per-block difficulty
 2020-08-03 13:13:14 +01:00
Howard Chu 429d495121
Add options to print daily coin emission and fees 
Closes #6735
 2020-08-01 20:48:42 +01:00
Howard Chu d745d24333
Don't forget size of prunable txn part 
Fixes #6732
 2020-08-01 13:41:38 +01:00
moneromooo-monero db5d6e4602
wallet2: fix wrong name when checking RPC cost 2020-07-31 14:17:23 +00:00
moneromooo-monero 13eee1d6ab
rpc: reject wrong sized txid 
Reporter requested credit to be given to Decred
 2020-07-30 22:52:14 +00:00
moneromooo-monero 90016ad744
blockchain: guard against exceptions in add_new_block/children 
Reporter requested credit to be given to Decred
 2020-07-30 22:52:11 +00:00
moneromooo-monero c1b03fb1a6
rpc: return empty txid get_outs rather than 00..00 when not requested 
It's more obvious there's no txid, and it saves space
 2020-07-25 17:01:21 +00:00
moneromooo-monero 8baa7bb238
daemon: don't print "(pruned)" for coinbase txes 
Pruned coinbase txes are the same as unpruned ones, so the
prunable data is empty
 2020-07-24 13:42:20 +00:00
rbrunner7 fb31167b12 Wallet, daemon: From 'help_advanced' back to 'help', and new 'apropos' command 2020-07-24 07:12:11 +02:00
xiphon 76c16822d0 wallet2_api: implement runtime proxy configuration 2020-07-20 13:45:12 +00:00
xiphon 3d6bc0a680 wallet2: throw a error on wallet initialization failure 2020-07-20 04:40:34 +00:00
Alexander Blair 2a82258dff
Merge pull request #6580 
ed901798d version: update name (selsta)
 2020-07-19 03:42:43 -07:00
Alexander Blair 3434cc24a2
Merge pull request #6578 
a6803231e daemon: complain if data dir resides on FAT32 volume (Windows) (xiphon)
 2020-07-19 03:41:55 -07:00
Alexander Blair 9871fefbf9
Merge pull request #6565 
72cdfa4a2 fix a few typos in error messages (moneromooo-monero)
 2020-07-19 03:40:19 -07:00
Alexander Blair c0a6e1aab9
Merge pull request #6557 
bd69e3b37 testdb: add override in a couple places where it's missing (moneromooo-monero)
 2020-07-19 03:39:53 -07:00
Alexander Blair bb0241da6e
Merge pull request #6538 
7178bb5c8 keccak: remove aligned check (moneromooo-monero)
 2020-07-19 03:38:53 -07:00
Alexander Blair 61e5208181
Merge pull request #6537 
5e0ea6e95 simplewallet: add missing calls to on_command (moneromooo-monero)
 2020-07-19 03:38:07 -07:00
Alexander Blair 6d6c691a0f
Merge pull request #6536 
bd9653663 db_lmdb: test for mmap support at init time (moneromooo-monero)
 2020-07-19 03:37:15 -07:00
Alexander Blair 36d50d93f2
Merge pull request #6534 
7bd66b01b daemon: guard against rare 'difficulty drift' bug with checkpoints and recalculation (stoffu)
 2020-07-19 03:36:39 -07:00
Alexander Blair 814e617117
Merge pull request #6526 
5d882f4f1 blockchain: fix theoretical race getting bulk timestamps (moneromooo-monero)
 2020-07-19 03:34:52 -07:00
Alexander Blair 3ba6c7fd30
Merge pull request #6516 
8656a8c9f remove double includes (sumogr)
 2020-07-19 03:34:28 -07:00
Alexander Blair a0d179e528
Merge pull request #6512 
5ef0607da Update copyright year to 2020 (SomaticFanatic)
 2020-07-19 03:32:59 -07:00
Alexander Blair 5041de8a3b
Merge pull request #6488 
99684e3e simplewallet: add show_qr_code command (selsta)
 2020-07-16 06:14:30 -07:00
moneromooo-monero 332d60719a
tx_pool: mine stem txes in fake chain mode 
This fixes the functional tests, since txes would not be mined
after being sent to the daemon (they'd be waiting for the
dandelion timeout first)
 2020-07-09 14:52:13 +00:00
moneromooo-monero 0fd6ccef21
blockchain: fix timestamp/difficulty cache getting out of sync 
The cache is discarded when a block is popped, but then gets
rebuilt when the difficulty for next block is requested.
While this is all properly locked, it does not take into account
the delay caused by a database transaction being only committed
(and thus its effects made visible to other threads) later on,
which means another thread could request difficulty between
the pop and the commit, which would end up using stale database
view to build the cache, but that cache would not be invalidated
again when the transaction gets committed, which would cause the
cache to not match the new database data.

To fix this, we now keep track of when the cache is invalidated
so we can invalidate it again upon database transaction commit
to ensure it gets calculated again with fresh data next time it
is nedeed.
 2020-07-08 22:31:51 +00:00
luigi1111 99b14ccd6a
Merge pull request #6647 
4d8d121 Fix D++ block template check (vtnerd)
 2020-07-08 17:25:01 -05:00
luigi1111 18bb011afe
Merge pull request #6629 
795e186 blockchain: fix total_height in getblocks.bin response (moneromooo-monero)
 2020-07-08 17:23:28 -05:00
luigi1111 e8d87fccc2
Merge pull request #6627 
4df8f9c rpc: fix loading rpc payment data from file (moneromooo-monero)
 2020-07-08 17:22:33 -05:00
luigi1111 0376195015
Merge pull request #6611 
dc1a053 rpc: fix comparison of seconds vs microseconds (moneromooo-monero)
 2020-07-08 17:21:31 -05:00
luigi1111 3057f52f89
Merge pull request #6599 
6e4a55b rpc: fix relay_tx error return mixup (moneromooo-monero)
9b86e14 functional_tests: add simple relay_tx test (moneromooo-monero)
 2020-07-08 17:20:29 -05:00
luigi1111 228101a72e
Merge pull request #6597 
ec46069 Fix incorrect lenght of command INS_PREFIX_HASH (grydz)
 2020-07-08 17:18:10 -05:00
luigi1111 81c2586358
Merge pull request #6588 
bcef52d daemon: remove time based 'update needed' status string (moneromooo-monero)
 2020-07-08 17:15:19 -05:00
luigi1111 340e1943ac
Merge pull request #6587 
94befec fix typo in pick_preferred_rct_inputs (Parean)
 2020-07-08 17:14:09 -05:00
luigi1111 be170c485c
Merge pull request #6584 
78d435a rpc: don't display invalid json errors on default log level (moneromooo-monero)
 2020-07-08 17:12:43 -05:00
luigi1111 8b3fa2d373
Merge pull request #6574 
7ebb351 rpc: lock access to the rpc payment object (moneromooo-monero)
 2020-07-08 17:11:32 -05:00
luigi1111 634262f3f5
Merge pull request #6568 
f037121 cryptonote_core: remove 'We are most likely forked' message (moneromooo-monero)
 2020-07-08 17:10:39 -05:00
luigi1111 f1334ebf64
Merge pull request #6566 
567402c protocol: move the 'peer claims higher version' warning to debug (moneromooo-monero)
 2020-07-08 17:08:58 -05:00
luigi1111 ed903578d7
Merge pull request #6544 
5741b4d blockchain: detect and log bad difficulty calculations (moneromooo-monero)
 2020-07-08 17:04:41 -05:00
selsta ed901798d9
version: update name 2020-07-06 23:22:25 +02:00
moneromooo-monero afd002c31f
daemon: print sampling time in print_net_stats 2020-06-25 13:03:59 +00:00
moneromooo-monero ec7bba0793
util: fix kilo prefix typo (K instead of k) 2020-06-25 13:03:24 +00:00
selsta 2f1ad3b3d2
updates: mac gui .tar.bz2 -> .dmg 2020-06-22 02:55:22 +02:00
Dusan Klinec f9e3fcdf3e
add trezor support to sweep_single 2020-06-21 23:17:58 +02:00
selsta 99684e3ec3
simplewallet: add show_qr_code command 
Thanks to iDunk for helping with Windows.
 2020-06-21 20:15:10 +02:00
moneromooo-monero 267ce5b718
avoid a couple needless copies 2020-06-14 18:05:35 +00:00
Lee Clagett 4d8d121462 Fix D++ block template check 2020-06-12 22:05:52 -04:00
selsta 58e1c8b031
repo: update donation fund address 2020-06-09 12:19:39 +02:00
stoffu 7bd66b01bf
daemon: guard against rare 'difficulty drift' bug with checkpoints and recalculation 
On startup, it checks against the difficulty checkpoints, and if any mismatch is found, recalculates all the blocks with wrong difficulties. Additionally, once a week it recalculates difficulties of blocks after the last difficulty checkpoint.
 2020-06-09 10:40:51 +09:00
luigi1111 ff4d470629
Merge pull request #6576 
4d3c2d0 rpc: add a sanity limit to a few RPC in restricted mode (moneromooo-monero)
 2020-06-08 14:27:05 -05:00
luigi1111 c4f4091dd4
Merge pull request #6561 
c17fe81 wallet2: fix multisig data clearing stomping on a vector (moneromooo-monero)
 2020-06-08 14:21:33 -05:00
luigi1111 445f74c71a
Merge pull request #6556 
5ed37ba serialization: fix bad rapidjson api usage (moneromooo-monero)
 2020-06-08 14:18:09 -05:00
luigi1111 28745b1b63
Merge pull request #6553 
bb5c5df cryptonote_protocol: reject requests/notifications before handshake (moneromooo-monero)
f1d0457 cryptonote_protocol: stricter limit to number of objects requested (moneromooo-monero)
 2020-06-08 14:16:42 -05:00
luigi1111 e17c864ba2
Merge pull request #6549 
82d21f5 easylogging++: sanitize log payload (moneromooo-monero)
7d0b7e8 [master] MMS: New 'config_checksum' subcommand (rbrunner7)
 2020-06-08 14:12:08 -05:00
luigi1111 3a577f1ce7
Merge pull request #6525 
86cf811 simplewallet: don't complain about incoming payment ids on change (moneromooo-monero)
 2020-06-08 14:07:45 -05:00
luigi1111 09667700e8
Merge pull request #6519 
ab44293 trezor: add new firmware version support (ph4r05)
 2020-06-08 14:03:57 -05:00
luigi1111 37c359e765
Merge pull request #6514 
4baee20 build: prepare v0.16.0.0 release (selsta)
 2020-06-08 14:02:00 -05:00
woodser ef694d028f fix warning by removing std::move() on temporary http_client object 2020-06-06 11:38:32 -04:00
moneromooo-monero 795e18632c
blockchain: fix total_height in getblocks.bin response 2020-06-05 15:27:07 +00:00
moneromooo-monero 4df8f9c414
rpc: fix loading rpc payment data from file 
Got broken after making one of those micro optimizations requested on review..
 2020-06-05 11:21:24 +00:00
Lee Clagett 7aeb503547 Fix boost <1.60 compilation and fix boost 1.73+ warnings 2020-05-31 21:18:11 -04:00
moneromooo-monero dc1a053081
rpc: fix comparison of seconds vs microseconds 2020-05-31 22:28:23 +00:00
moneromooo-monero eb1b321fe2
miner: increase min/max intervals to full extents 
This prevents setting target to, eg, 65 being ignored

and remove an unused constant
 2020-05-31 12:36:47 +00:00
moneromooo-monero 6e4a55ba7e
rpc: fix relay_tx error return mixup 2020-05-28 11:33:27 +00:00
François Colas ec46069248 Fix incorrect lenght of command INS_PREFIX_HASH 
buffer_send[4] (LC) is an unsigned char, len should not
exceed 254 (255 - 1 for the option).
 2020-05-27 18:06:19 +02:00
moneromooo-monero bcef52d430
daemon: remove time based "update needed" status string 2020-05-24 21:44:03 +00:00
Denis Smirnov 94befecb05 fix typo in pick_preferred_rct_inputs 2020-05-25 03:39:54 +07:00
rbrunner7 7d0b7e83ef [master] MMS: New 'config_checksum' subcommand 2020-05-24 10:23:55 +02:00
moneromooo-monero 82d21f5b3c easylogging++: sanitize log payload 
Some of it might be coming from untrusted sources

Reported by itsunixiknowthis
 2020-05-24 08:38:59 +02:00
moneromooo-monero 78d435a5fa
rpc: don't display invalid json errors on default log level 
It's not something the user needs to know, and will display
attacker controlled data
 2020-05-23 12:26:49 +00:00
xiphon a6803231e6 daemon: complain if data dir resides on FAT32 volume (Windows) 2020-05-21 15:23:44 +00:00
moneromooo-monero 4d3c2d0b7b
rpc: add a sanity limit to a few RPC in restricted mode 2020-05-20 19:17:49 +00:00
selsta 1d31e6c000
net_node: remove dead seed nodes 2020-05-20 01:06:03 +02:00
moneromooo-monero 7ebb351c2d
rpc: lock access to the rpc payment object 2020-05-19 18:26:28 +00:00
moneromooo-monero f0371210e9
cryptonote_core: remove "We are most likely forked" message 
It's time based and we don't have forks every 6 months anymore
 2020-05-19 16:27:24 +00:00
moneromooo-monero 567402c508
protocol: move the "peer claims higher version" warning to debug 
Because there's a neverending supply of cunts claiming a wrong
version just to say "look at me" I guess
 2020-05-19 16:14:53 +00:00
moneromooo-monero 72cdfa4a20
fix a few typos in error messages 
Reported by adrelanos
 2020-05-19 15:59:26 +00:00
moneromooo-monero c17fe815a2
wallet2: fix multisig data clearing stomping on a vector 2020-05-19 10:45:40 +00:00
moneromooo-monero f1d0457523
cryptonote_protocol: stricter limit to number of objects requested 
Reported by xnbya
 2020-05-19 10:33:03 +00:00
moneromooo-monero bb5c5dff15
cryptonote_protocol: reject requests/notifications before handshake 
Reported by xnbya
 2020-05-19 10:33:02 +00:00
moneromooo-monero bd69e3b37a
testdb: add override in a couple places where it's missing 2020-05-18 14:17:48 +00:00
moneromooo-monero 5ed37ba83c
serialization: fix bad rapidjson api usage 2020-05-18 14:17:23 +00:00
moneromooo-monero 5741b4d74d
blockchain: detect and log bad difficulty calculations 2020-05-17 12:44:45 +00:00
moneromooo-monero eda1675858
wallet_rpc_server: use unlock_time in suggested confirmations calc 2020-05-17 01:03:32 +00:00
moneromooo-monero 35665df206
protocol: don't drop a connection if we can't get a compatible chain 
This can now happen if:
- we have a pruned db
- we have not connected to the monero network for a while
- we connect to a node
- that node asks us for history
- we only have a pruned version of the most recent common block

In that case, it's better to not reply but keep the connection alive,
so we can sync off it.
 2020-05-16 19:55:31 +00:00
moneromooo-monero 7178bb5c84
keccak: remove aligned check 
Some tools report the alignment check as UB, which seems a bit
dubious, but since the performance difference between the two
versions is minimal, I'll go with the safe version
 2020-05-16 12:28:27 +00:00
Lee Clagett a11ec4ac1d Support for supercop ASM in wallet, and benchmark for supercop 2020-05-16 10:25:17 +00:00
moneromooo-monero 5e0ea6e95c
simplewallet: add missing calls to on_command 
It resets the inactivity time
 2020-05-16 00:48:44 +00:00
moneromooo-monero bd96536637
db_lmdb: test for mmap support at init time 
It'll make it clearer when a DB init failure is due to being
on a filesystem which does not support mmap
 2020-05-16 00:20:22 +00:00
Lee Clagett 67ade80055 Add randomized delay when forwarding txes from i2p/tor -> ipv4/6 2020-05-15 07:57:35 +00:00
selsta f35ced6d7f
build: fix boost 1.73 compatibility 2020-05-14 22:57:53 +02:00
moneromooo-monero 86cf811a39
simplewallet: don't complain about incoming payment ids on change 2020-05-13 23:28:31 +00:00
selsta 4baee200a7
build: prepare v0.16.0.0 release 2020-05-13 16:15:03 +02:00
moneromooo-monero 5d882f4f14
blockchain: fix theoretical race getting bulk timestamps 2020-05-13 13:42:41 +00:00
Dusan Klinec ab4429346d
trezor: add new firmware version support 2020-05-12 16:31:36 +02:00
sumogr 8656a8c9ff remove double includes 2020-05-11 13:53:17 +00:00
luigi1111 77a008f714
Merge pull request #6510 
70609d7 cryptonote_core: take out the time based upgrade warning (moneromooo-monero)
 2020-05-07 10:44:34 -05:00
luigi1111 4c2f78aeeb
Merge pull request #6506 
42e1484 wallet2: fix keys file deserialization exception handling (xiphon)
 2020-05-07 10:43:05 -05:00
SomaticFanatic 5ef0607da6 Update copyright year to 2020 
Update copyright year to 2020
 2020-05-06 22:36:54 -04:00
moneromooo-monero 70609d7681
cryptonote_core: take out the time based upgrade warning 
It doesn't really work anymore since we don't have a fork soon
 2020-05-06 18:27:23 +00:00
luigi1111 dbba6004f5
Merge pull request #6503 
f80ab3e cryptonote_protocol: do not request pruned borromean sig txes (moneromooo-monero)
 2020-05-06 12:22:28 -05:00
moneromooo-monero f80ab3edde
cryptonote_protocol: do not request pruned borromean sig txes 
We don't have a function to calculate their weight from a pruned
version (yet).
 2020-05-06 12:44:00 +00:00
luigi1111 f2c78f6a5b
Merge pull request #6486 
feee455 Fixes for ZMQ JSON-RPC endpoint names for raw tx (vtnerd)
 2020-05-06 00:34:30 -05:00
luigi1111 3de804f1e9
Merge pull request #6485 
7a8c1ee wallet2: fix subaddress expansion when receiving monero (moneromooo-monero)
 2020-05-06 00:31:51 -05:00
luigi1111 98e3802b26
Merge pull request #6484 
e7d0105 message_store: don't print an error when there is no mms file (moneromooo-monero)
 2020-05-06 00:30:39 -05:00
luigi1111 de025281dc
Merge pull request #6481 
119f706 rpc: fix 'use_bootstrap_daemon_if_necessary' return value (xiphon)
 2020-05-06 00:29:49 -05:00
luigi1111 9e3f72c375
Merge pull request #6480 
4f489fa wallet2: check_connection return false on get_version status != OK (xiphon)
 2020-05-06 00:28:18 -05:00
luigi1111 0f233c6ad8
Merge pull request #6478 
ee58362 Used legacy category to match insert_key_images behavior (vtnerd)
 2020-05-06 00:27:13 -05:00
luigi1111 483e5cab5c
Merge pull request #6472 
2efbd5f cryptonote: fix reuse of non default tx data when relaying (moneromooo-monero)
 2020-05-06 00:25:18 -05:00
luigi1111 8d0f1696df
Merge pull request #6471 
c6a1294 add another seed node (Gingeropolous/selsta)
9faf3d1 Add erciccione's seed node (erciccione/selsta)
 2020-05-06 00:23:59 -05:00
luigi1111 1f505a5eac
Merge pull request #6468 
a813c46 cryptonote_core: skip dns checkpoints on startup if not enforced (xiphon)
 2020-05-06 00:22:20 -05:00
luigi1111 6d1f3c9acd
Merge pull request #6467 
8b655de simplewallet: report timestamp based expected unlock time on balance (moneromooo-monero)
 2020-05-05 23:40:44 -05:00
luigi1111 b4023dcfc5
Merge pull request #6441 
613071f use memwipe on secret k/alpha values (moneromooo-monero)
 2020-05-05 23:39:32 -05:00
xiphon 42e14840fb wallet2: fix keys file deserialization exception handling 2020-05-05 16:34:50 +00:00
Lee Clagett e5214a2ca2 Adding ZMQ/Pub support for txpool_add and chain_main events 2020-05-04 02:06:35 +00:00
luigi1111 8185054db7
Merge pull request #6451 
4ed60b6 Bulletproofs: verification speedup (SarangNoether)
 2020-05-02 15:14:41 -05:00
luigi1111 ec90f9a54b
Merge pull request #6453 
d2d3a81 bootstrap_daemon: fix missing virtual destructor and lambda capture (clang warning) (xiphon)
 2020-05-01 15:47:47 -05:00
luigi1111 ac9f7c9bec
Merge pull request #6449 
27d551d simplewallet: add sweep_account command (moneromooo-monero)
 2020-05-01 15:36:19 -05:00
luigi1111 c9b800a787
Merge pull request #6446 
e509ede trezor: adapt to new passphrase mechanism (ph4r05)
 2020-05-01 15:32:52 -05:00
luigi1111 f020b24b02
Merge pull request #6444 
b367630 simplewallet : missing function block separator (sumogr)
 2020-05-01 15:24:33 -05:00
luigi1111 6e7b883212
Merge pull request #6443 
145be6d p2p: startup speedup, init seed nodes on first 'connect_to_seed()' (xiphon)
 2020-05-01 15:23:05 -05:00
luigi1111 6b7e88e16c
Merge pull request #6440 
7c4a400 simplewallet: fix strings (show_transfers & export_transfers) (sumogr)
 2020-05-01 15:21:57 -05:00
luigi1111 443f5c6bda
Merge pull request #6436 
688a3e8 Add timelock verification on device (cslashm)
 2020-05-01 15:20:05 -05:00
luigi1111 3e21e591b8
Merge pull request #6350 
da99157 Use byte_slice for sending zmq messages - removes data copy within zmq (vtnerd)
 2020-05-01 15:13:58 -05:00
Sumo Gr dd807b8410 txpool.cpp: rename var to fix for old g++ version (xenial default) 2020-04-29 10:03:51 +00:00
Lee Clagett feee455c9f Fixes for ZMQ JSON-RPC endpoint names for raw tx 2020-04-29 01:07:27 -04:00
moneromooo-monero 7a8c1eece9
wallet2: fix subaddress expansion when receiving monero 2020-04-27 16:48:19 +00:00
Dusan Klinec e509ede2aa
trezor: adapt to new passphrase mechanism 
- choice where to enter passphrase is now made on the host
- use wipeable string in the comm stack
- wipe passphrase memory
- protocol optimizations, prepare for new firmware version
- minor fixes and improvements
- tests fixes, HF12 support
 2020-04-27 18:17:56 +02:00
moneromooo-monero e7d01056f4
message_store: don't print an error when there is no mms file 
It confuses people
 2020-04-27 15:44:29 +00:00
xiphon 119f706921 rpc: fix 'use_bootstrap_daemon_if_necessary' return value 2020-04-27 10:32:33 +00:00
xiphon 4f489fa6a2 wallet2: check_connection return false on get_version status != OK 2020-04-26 13:08:17 +00:00
Lee Clagett ee58362b1f Used legacy category to match insert_key_images behavior 2020-04-24 20:19:37 -04:00
moneromooo-monero 2efbd5f0cc
cryptonote: fix reuse of non default tx data when relaying 
An automatic tx variable is initialized properly on the first
run through the loop, but not the second. Moving the variable
inside the loop ensures the ctor is called again to init it.
 2020-04-22 16:50:20 +00:00
Gingeropolous c6a1294b5e
add another seed node 
node is funded by random people and managed by me. currently functioning as public node at uwillrunanodesoon.moneroworld.com
 2020-04-22 15:43:22 +02:00
moneromooo-monero 8b655de8ed
simplewallet: report timestamp based expected unlock time on balance 2020-04-22 13:34:58 +00:00
erciccione 9faf3d1a72
Add erciccione's seed node 2020-04-22 10:24:40 +02:00
xiphon 145be6dbdb p2p: startup speedup, init seed nodes on first 'connect_to_seed()' 2020-04-21 23:40:04 +00:00
luigi1111 378cdeaeae
Merge pull request #6470 
79a1653 p2p: add seed node. (guywillett)
 2020-04-21 09:14:38 -05:00
luigi1111 c846c8650e
Merge pull request #6445 
5715460 Always reject duplicate key-images from second txid (vtnerd)
babf25d Allow unrestricted rpc calls to get full txpool info (vtnerd)
 2020-04-21 09:03:37 -05:00
luigi1111 cc91c0221d
Merge pull request #6415 
09abca7 wallet_api: checkUpdate - optional version and buildtag params (xiphon)
 2020-04-21 08:52:57 -05:00
luigi1111 cb8f4280bb
Merge pull request #6408 
5ef7138 daemon: fix print_net_stats RPC calls (moneromooo-monero)
 2020-04-21 08:46:39 -05:00
guy 79a1653a07 p2p: add seed node. 2020-04-21 15:35:30 +02:00
luigi1111 2d729fbdf7
Merge pull request #6332 
87d7558 Allow wallet2.h to run in WebAssembly (woodser)
 2020-04-21 08:26:54 -05:00
luigi1111 9c660e159e
Merge pull request #6278 
387fd66 Daemon: Print estimates for time until fully synced (rbrunner7)
 2020-04-21 08:19:02 -05:00
xiphon a813c46a1b cryptonote_core: skip dns checkpoints on startup if not enforced 2020-04-20 18:56:22 +00:00
xiphon d2d3a81d0e bootstrap_daemon: fix missing virtual destructor and lambda capture (clang warning) 2020-04-15 21:22:55 +00:00
woodser 87d75584e8 Allow wallet2.h to run in WebAssembly 
- Add abstract_http_client.h which http_client.h extends.
- Replace simple_http_client with abstract_http_client in wallet2,
message_store, message_transporter, and node_rpc_proxy.
- Import and export wallet data in wallet2.
- Use #if defined __EMSCRIPTEN__ directives to skip incompatible code.
 2020-04-15 13:22:46 -04:00
moneromooo-monero 613071f4fa
use memwipe on secret k/alpha values 
Reported by UkoeHB_ and sarang
 2020-04-15 01:16:31 +00:00
Sarang Noether 4ed60b626a Bulletproofs: verification speedup 2020-04-14 20:31:30 -04:00
moneromooo-monero 27d551d12f
simplewallet: add sweep_account command 
Expects an account number, then the usual sweep_all options

Useful to move monero that was accidentally sent to a subaddress
with a very large account index.
 2020-04-14 15:06:46 +00:00
Lee Clagett c26c93019a Add byte_stream for zero-copy serialization, and add support in ZMQ-JSON. 2020-04-11 04:12:11 +00:00
luigi1111 7c74e1919e
Merge pull request #6405 
8d23047 p2p: add another seed node (moneromooo-monero)
 2020-04-10 16:13:04 -05:00
luigi1111 228af683a7
Merge pull request #6403 
5de2295 Correct key image check in tx_pool (vtnerd)
 2020-04-10 16:10:33 -05:00
luigi1111 bce050ee78
Merge pull request #6394 
69b5992 simplewallet: new 'address one-off <major> <minor>' command (moneromooo-monero)
 2020-04-10 16:06:10 -05:00
luigi1111 7954f8cb18
Merge pull request #6358 
8958b4e blockchain_db: faster fetching of consecutive txes (moneromooo-monero)
 2020-04-10 16:01:37 -05:00
luigi1111 53800b3b63
Merge pull request #6341 
927fd47 simplewallet: fix smart mining not starting after first setup (moneromooo-monero)
 2020-04-10 15:59:14 -05:00
Sumo Gr b367630ee8
simplewallet : missing function block separator 2020-04-10 21:27:41 +03:00
sumogr 7c4a4003a3 simplewallet: fix strings (show_transfers & export_transfers) 2020-04-08 19:17:58 +03:00
cslashm 688a3e87e7 Add timelock verification on device 2020-04-08 11:12:32 +02:00
moneromooo-monero 69b5992296
simplewallet: new "address one-off <major> <minor>" command 2020-04-07 16:25:01 +00:00
luigi1111 bbceb31044
Merge pull request #6395 
ad13a4b Fixing static_asserts in ZMQ JSON (vtnerd)
 2020-04-04 13:17:54 -05:00
luigi1111 d102a72027
Merge pull request #6384 
ec01077 db_lmdb: fix race crash using a stale cursor (moneromooo-monero)
 2020-04-04 13:14:19 -05:00
luigi1111 d1f3d3376d
Merge pull request #6381 
e719760 Fix receive order leakage with tx fluffing (vtnerd)
 2020-04-04 13:12:31 -05:00
luigi1111 975825a1fd
Merge pull request #6375 
ebf3c10 Added logging for dropped local txes with no i2p/tor connections (vtnerd)
 2020-04-04 13:11:30 -05:00
luigi1111 97af9649c9
Merge pull request #6372 
7b9017f p2p: plug tor to clearnet association vector (Aaron Hook)
 2020-04-04 13:09:55 -05:00
luigi1111 59ab769210
Merge pull request #6364 
6e1cb5a device: Ledger - fix wide char hidapi error string conversion (xiphon)
 2020-04-04 13:02:18 -05:00
luigi1111 5757d99208
Merge pull request #6361 
68a6507 Fixed bug in ZMQ JSON-RPC method field (vtnerd)
 2020-04-04 13:01:15 -05:00
luigi1111 0150a480fd
Merge pull request #6357 
42a7a4d daemon: auto public nodes - cache and prioritize most stable nodes (xiphon)
 2020-04-04 12:59:23 -05:00
luigi1111 6a6eedd842
Merge pull request #6353 
6810150 daemon: if no banned IPs print something (sumogr)
 2020-04-04 12:56:36 -05:00
luigi1111 cfc0f4a7fa
Merge pull request #6351 
81c5943 Remove temporary std::string creation in some hex->bin calls (vtnerd)
5fcc23a Move hex->bin conversion to monero copyright files and with less includes (vtnerd)
3387f0e Reduce template bloat in hex->bin for ZMQ json (vtnerd)
 2020-04-04 12:55:02 -05:00
luigi1111 44547006bf
Merge pull request #6347 
fcb06f7 cryptonote_core: skip block notify on blockchain switching rollback (xiphon)
 2020-04-04 12:52:46 -05:00
luigi1111 ad5200e440
Merge pull request #6342 
82da832 rpc: Add check for too old timestamps in payment signatures. (glv2)
 2020-04-04 12:49:02 -05:00
luigi1111 c4f75fe898
Merge pull request #6339 
c61abf8 remove empty statements (shopglobal)
 2020-04-04 12:47:31 -05:00
luigi1111 081d49c59f
Merge pull request #6338 
80d5320 Hash domain separation (SarangNoether)
 2020-04-04 12:44:45 -05:00
luigi1111 6011064693
Merge pull request #6334 
cc18926 wallet2_api: wallet recovery - seed offset passphrase support (xiphon)
 2020-04-04 12:41:32 -05:00
luigi1111 0bb7191fd6
Merge pull request #6328 
9bde70e core: mention time being off in hash rate changes message (moneromooo-monero)
 2020-04-04 12:40:18 -05:00
luigi1111 85efaeb7bf
Merge pull request #6322 
29b7cd1 device_ledger: include status code name in error message (xiphon)
 2020-04-04 12:39:21 -05:00
luigi1111 ab802b4b80
Merge pull request #6321 
1a6e7bd wallet2: mention --daemon-ssl-allow-any-cert in --proxy error msg (xiphon)
 2020-04-04 12:37:26 -05:00
luigi1111 4398facb2e
Merge pull request #6286 
6d6af70 cryptonote_basic: drop unused verification_context::m_not_rct field (xiphon)
 2020-04-04 12:33:32 -05:00
Lee Clagett da99157462 Use byte_slice for sending zmq messages - removes data copy within zmq 2020-04-03 01:56:17 +00:00
xiphon 09abca76ae wallet_api: checkUpdate - optional version and buildtag params 2020-04-02 00:31:43 +00:00
Sarang Noether 80d5320fff Hash domain separation 2020-04-01 08:31:00 -04:00
xiphon 6d6af701ec cryptonote_basic: drop unused verification_context::m_not_rct field 2020-03-31 21:58:25 +00:00
moneromooo-monero 21fe6a289b
p2p: fix frequent weak_ptr exception on connection 
When a handshake fails, it can fail due to timeout or destroyed
connection, in which case the connection will be, or already is,
closed, and we don't want to do it twice.
Additionally, when closing a connection directly from the top
level code, ensure the connection is gone from the m_connects
list so it won't be used again.

AFAICT this is now clean in netstat, /proc/PID/fd and print_cn.

This fixes a noisy (but harmless) exception.
 2020-03-31 20:29:41 +00:00
luigi1111 6c7d928f19
Merge pull request #6336 
760ecf2 console_handler: do not let exception past the dor (moneromooo-monero)
09c8111 threadpool: lock mutex in create (moneromooo-monero)
e377977 tx_pool: catch theoretical error in get_block_reward (moneromooo-monero)
 2020-03-31 15:14:12 -05:00
luigi1111 94f44d4ee3
Merge pull request #6325 
3627e53 rpc: fix print_pool_sh not finding local txes (moneromooo-monero)
 2020-03-31 15:13:51 -05:00
luigi1111 f9de65b546
Merge pull request #6304 
2e9d1e6 wallet2: fix store-tx-info loading (moneromooo-monero)
 2020-03-31 15:13:19 -05:00
luigi1111 d0065f3063
Merge pull request #6302 
dab604e wallet2_api: implement estimateTransactionFee (xiphon)
 2020-03-31 15:12:48 -05:00
luigi1111 8a829e2cc4
Merge pull request #6301 
9989cb0 simplewallet: warn about correlations if print-ring-members is not set (moneromooo-monero)
 2020-03-31 13:37:19 -05:00
luigi1111 0253f86fde
Merge pull request #6298 
fe92fa1 [randomx] Add missing randomx_vm_set_cache() (cohcho)
 2020-03-31 13:36:21 -05:00
luigi1111 ccc3726d86
Merge pull request #6260 
320bc84 rpc: add --rpc-payment-allow-free-loopback (moneromooo-monero)
 2020-03-31 13:35:16 -05:00
luigi1111 096e2135dd
Merge pull request #6214 
054b4c7 protocol: request txpool contents when synced (moneromooo-monero)
 2020-03-31 13:32:55 -05:00
Lee Clagett 571546067f Always reject duplicate key-images from second txid 2020-03-30 17:52:42 +00:00
Lee Clagett babf25d2ec Allow unrestricted rpc calls to get full txpool info 2020-03-30 17:52:42 +00:00
moneromooo-monero 5ef7138d86
daemon: fix print_net_stats RPC calls 2020-03-29 13:45:58 +00:00
moneromooo-monero 9989cb087e
simplewallet: warn about correlations if print-ring-members is not set 
The warning about spending more than one output with similar creation
time was skipped if print-ring-members was not set, and it defaults to
false, which means most people probably aren't getting this warning if
they spend correlated outputs.

Reported by SeventhAlpaca.
 2020-03-28 11:46:06 +00:00
moneromooo-monero 8d230473ef
p2p: add another seed node 
Node from syksy, administered by mooo
 2020-03-27 22:51:44 +00:00
Alexander Blair 72262b348a
Merge pull request #6299 
9c1f970b wallet2: remember daemon address overrides when loading a new wallet (moneromooo-monero)
 2020-03-27 12:33:15 -07:00
Alexander Blair 5780594202
Merge pull request #6296 
50e59cfa wallet2: reject zero keys in json input (moneromooo-monero)
 2020-03-27 12:31:59 -07:00
Alexander Blair 3ed5e7ce9f
Merge pull request #6295 
bcae95a2 p2p: do not add recently failed addresses to the peerlist (moneromooo-monero)
 2020-03-27 12:30:06 -07:00
Alexander Blair 8cb005b39c
Merge pull request #6289 
ffe7165e wallet: reroll fake outs selection on local tx_sanity_check failure (xiphon)
 2020-03-27 12:28:29 -07:00
Alexander Blair 5ba6eef272
Merge pull request #6288 
0349347e ringdb: use a different iv for key and data in rings table (moneromooo-monero)
7b882087 simplewallet: reword mixin in user message in terms of ring size (moneromooo-monero)
f507a43a wallet2: do not remove known rings when a tx fails (moneromooo-monero)
 2020-03-27 12:23:59 -07:00
Alexander Blair 7d4a93fab3
Merge pull request #6285 
d0641b42 net: fix incorrect less operator for top/i2p addresses (Aaron Hook)
 2020-03-27 12:23:00 -07:00
Alexander Blair aa982a51da
Merge pull request #6284 
02224e71 Fix check_fee() discrepancy. (UkoeHB)
 2020-03-27 12:21:26 -07:00
Alexander Blair e160e0b517
Merge pull request #6283 
a84131ce p2p: fix off by one adding fallback peers (moneromooo-monero)
 2020-03-27 12:19:55 -07:00
Alexander Blair a762084b15
Merge pull request #6282 
66472074 Daemon: Guard against reporting "synchronized" too early (rbrunner7)
 2020-03-27 12:19:07 -07:00
Alexander Blair c038cc8b79
Merge pull request #6280 
b818522d p2p: fix spurious warning when we're connected to at last one seed (moneromooo-monero)
 2020-03-27 12:17:54 -07:00
Alexander Blair 3baa68bbab
Merge pull request #6279 
36bdf402 p2p: fix adding wrong indices to the filtered peer list (moneromooo-monero)
 2020-03-27 12:17:07 -07:00
Alexander Blair a22cf5de1b
Merge pull request #6275 
aa93e388 p2p: remove old debug commands (Aaron Hook)
 2020-03-27 12:16:30 -07:00
Alexander Blair 338824add3
Merge pull request #6227 
f8d76f39 core: move the LockedTXN class out of txpool so it may be reused (moneromooo-monero)
 2020-03-27 12:15:37 -07:00
Lee Clagett 02d887c2e5 Adding Dandelion++ support to public networks: 
- New flag in NOTIFY_NEW_TRANSACTION to indicate stem mode
  - Stem loops detected in tx_pool.cpp
  - Embargo timeout for a blackhole attack during stem phase
 2020-03-26 15:01:30 +00:00
moneromooo-monero 054b4c7f41
protocol: request txpool contents when synced 
A newly synced Alice sends a (typically quite small) list of
txids in the local tpxool to a random peer Bob, who then uses
the existing tx relay system to send Alice any tx in his txpool
which is not in the list Alice sent
 2020-03-22 16:03:31 +00:00
rbrunner7 387fd668d1 Daemon: Print estimates for time until fully synced 2020-03-21 07:32:55 +01:00
Aaron Hook aa93e38862 p2p: remove old debug commands 2020-03-20 22:09:44 -07:00
moneromooo-monero bcae95a22e
p2p: do not add recently failed addresses to the peerlist 2020-03-20 15:45:26 +00:00
Lee Clagett ad13a4b2ac Fixing static_asserts in ZMQ JSON 2020-03-19 19:49:51 -04:00
Lee Clagett 5de2295f3c Correct key image check in tx_pool 2020-03-14 19:17:15 +00:00
xiphon c075aa7a6c workaround for GetObject windows.h macro and rapidjson conflict 2020-03-14 00:46:47 +00:00
moneromooo-monero f8d76f395b
core: move the LockedTXN class out of txpool so it may be reused 
for example, in the RPC server
 2020-03-12 11:30:05 +00:00
moneromooo-monero 320bc845b3
rpc: add --rpc-payment-allow-free-loopback 
This allows RPC coming from the loopback interface to not have
to pay for service. This makes it possible to run an externally
accessible RPC server for payment while also having a local RPC
server that can be run unrestricted and payment free.
 2020-03-12 11:27:34 +00:00
Alexander Blair 820ab9fdea
Merge pull request #6273 
0f78b06e Various improvements to the ZMQ JSON-RPC handling: (Lee Clagett)
 2020-03-12 01:13:49 -07:00
Alexander Blair d500bbe68f
Merge pull request #6268 
a6c24412 wallet: fix exceptions getting the hash of a pruned tx (moneromooo-monero)
 2020-03-12 01:02:31 -07:00
Alexander Blair 092a57df99
Merge pull request #6243 
4771a7ae p2p: remove obsolete local time in handshake (moneromooo-monero)
2fbbc4a2 p2p: avoid sending the same peer list over and over (moneromooo-monero)
3004835b epee: remove backward compatible endian specific address serialization (moneromooo-monero)
39a343d7 p2p: remove backward compatible peer list (moneromooo-monero)
60631802 p2p: simplify last_seen serialization now we have optional stores (moneromooo-monero)
9467b2e4 cryptonote_protocol: omit top 64 bits of difficulty when 0 (moneromooo-monero)
b595583f serialization: do not write optional fields with default value (moneromooo-monero)
5f98b46d p2p: remove obsolete local time from TIMED_SYNC (moneromooo-monero)
 2020-03-12 00:32:46 -07:00
moneromooo-monero ec01077720
db_lmdb: fix race crash using a stale cursor 
If a db resize happened, the txpool meta cursor might be stale,
and was not being renewed when necessary.
It would cause this SEGSEGV:

in mdb_cursor_set ()
in mdb_cursor_get ()
in cryptonote::BlockchainLMDB::get_txpool_tx_blob(crypto::hash const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, cryptonote::relay_category) const ()
in cryptonote::tx_memory_pool::get_transaction(crypto::hash const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, cryptonote::relay_category) const ()
in cryptonote::t_cryptonote_protocol_handler<cryptonote::core>::handle_notify_new_fluffy_block(int, epee::misc_utils::struct_init<cryptonote::NOTIFY_NEW_FLUFFY_BLOCK::request_t>&, cryptonote::cryptonote_connection_context&) ()
 2020-03-12 00:57:32 +00:00
Lee Clagett e719760253 Fix receive order leakage with tx fluffing 2020-03-10 22:30:07 -04:00
Lee Clagett 3387f0e327 Reduce template bloat in hex->bin for ZMQ json 2020-03-09 17:55:55 +00:00
Lee Clagett 5fcc23ae0a Move hex->bin conversion to monero copyright files and with less includes 2020-03-09 05:23:59 +00:00
Aaron Hook 7b9017f671
p2p: plug tor to clearnet association vector 
During the handshake for an incoming connection, the peer id is checked against the local node's peer id only for the specific zone of the incoming peer, in order to avoid linking public addresses to tor addresses:
5d7ae2d279/src/p2p/net_node.inl (L2343)

However, on handshakes for outgoing connections, all zones are checked:
5d7ae2d279/src/p2p/net_node.inl (L1064)

If an attacker wanted to link a specific tor node to a public node, they could potentially connect to as many public nodes as possible, get themselves added to the peer whitelist, maybe stuff some more attacker-owned addresses into the greylist, then disconnect, and for any future incoming connections, respond with the tor node's id in an attempt to link the public/tor addresses.
 2020-03-07 18:12:59 +00:00
moneromooo-monero 9c1f970b82
wallet2: remember daemon address overrides when loading a new wallet 2020-03-07 18:09:31 +00:00
Lee Clagett ebf3c10fcb Added logging for dropped local txes with no i2p/tor connections 2020-03-07 00:03:17 +00:00
Lee Clagett 0f78b06e8c Various improvements to the ZMQ JSON-RPC handling: 
- Finding handling function in ZMQ JSON-RPC now uses binary search
  - Temporary `std::vector`s in JSON output now use `epee::span` to
    prevent allocations.
  - Binary -> hex in JSON output no longer allocates temporary buffer
  - C++ structs -> JSON skips intermediate DOM creation, and instead
    write directly to an output stream.
 2020-03-05 14:20:56 +00:00
xiphon 6e1cb5a4d0 device: Ledger - fix wide char hidapi error string conversion 2020-03-01 11:42:48 +00:00
Alexander Blair 4764d18eeb
Merge pull request #6248 
21c3d42e p2p: drop the peerlist dump to TRACE (moneromooo-monero)
 2020-02-28 20:21:27 -08:00
Alexander Blair da617ac1b0
Merge pull request #6238 
f717d593 wallet2: guard against race with multiple decrypt_keys users (moneromooo-monero)
 2020-02-28 20:21:06 -08:00
Alexander Blair ea6396ea66
Merge pull request #6222 
a6a2ad6c simplewallet: set manual refresh mode in rescan_bc (moneromooo-monero)
 2020-02-28 19:59:43 -08:00
Alexander Blair 8c2939a7cb
Merge pull request #6058 
88b82bef simplewallet: point to "set help" in the lock screen message (moneromooo-monero)
f19c9f23 util: allow newlines in string to be split (moneromooo-monero)
 2020-02-28 19:54:37 -08:00
Alexander Blair f3fddd935f
Merge pull request #6259 
69336931 rpc: fill miner_tx_hash again (moneromooo-monero)
 2020-02-28 19:51:15 -08:00
Alexander Blair 9ea7df3b31
Merge pull request #6242 
716012ca rpc: drop the obsolete and wrong "unpruned size" log (moneromooo-monero)
 2020-02-28 19:50:02 -08:00
Alexander Blair 5bd496e8ef
Merge pull request #6241 
ae84ec90 wallet-cli/rpc: allow sweep_all to use outputs in all subaddresses within an account (stoffu)
 2020-02-28 19:49:41 -08:00
Alexander Blair 19ce033299
Merge pull request #6236 
bc6d8aa3 Corrected message typo (palomato)
 2020-02-28 19:49:07 -08:00
Alexander Blair a6cf4b09e7
Merge pull request #6235 
5cbb17b9 wallet2: fix hang in wallet refresh (moneromooo-monero)
 2020-02-28 19:48:41 -08:00
Alexander Blair 4371ac4265
Merge pull request #6225 
987c3139 print_coinbase_tx_sum now supports 128 bits sums (moneromooo-monero)
 2020-02-28 19:48:11 -08:00
Alexander Blair 2deb02f81d
Merge pull request #6224 
d93e1dff simplewallet: warn on refresh if refresh-from-block-height seems off (moneromooo-monero)
 2020-02-28 19:46:33 -08:00
Alexander Blair 6742c4acb7
Merge pull request #6223 
c3613031 Silence miner debugmsg spam (Howard Chu)
 2020-02-28 19:45:55 -08:00
Alexander Blair afff9e7041
Merge pull request #6219 
72ca7e3b Fix time comparison math (Jason Rhinelander)
 2020-02-28 19:43:44 -08:00
Alexander Blair e22655a187
Merge pull request #6215 
a2578892 --disable-ban-rpc option to prevent RPC users from banning (naughtyfox)
 2020-02-28 19:43:06 -08:00
Alexander Blair 5e492c4cbc
Merge pull request #6213 
94266eeb simplewallet: fix output age display with duplicate heights (moneromooo-monero)
f1d379d2 simplewallet: fix "outputs in same tx" detector (moneromooo-monero)
 2020-02-28 19:36:41 -08:00
Alexander Blair 4da37daf67
Merge pull request #6211 
5985c5af rpc: add bad-blocks to flush_cache RPC (moneromooo-monero)
 2020-02-28 19:36:16 -08:00
Alexander Blair 8606b1a14a
Merge pull request #6203 
ef95a76d remove unused variable 'ptx' from on_describe_transfer() (woodser)
 2020-02-28 19:34:41 -08:00
xiphon 42a7a4dd32 daemon: auto public nodes - cache and prioritize most stable nodes 2020-02-28 08:06:43 +00:00
moneromooo-monero 8958b4e7aa
blockchain_db: faster fetching of consecutive txes 
Useful for wallet refresh or node sync
 2020-02-27 15:05:34 +00:00
sumogr 6810150d46 daemon: if no banned IPs print something 2020-02-24 20:52:55 +00:00
luigi1111 39e1890276
Merge pull request #6198 
5f2a32c daemon: run with -rpc-payment-address and --rpc-restricted-bind-port (moneromooo-monero)
 2020-02-19 22:25:44 -05:00
luigi1111 04187e5968
Merge pull request #6197 
f812783 simplewallet: fix encrypted payment id note triggering on dummy ones (moneromooo-monero)
 2020-02-19 22:24:44 -05:00
luigi1111 2de1137e60
Merge pull request #6194 
316ab7b wallet2: better error when restoring a wallet with the wrong keys (moneromooo-monero)
 2020-02-19 22:23:46 -05:00