From 99681e1bbbf6849bafb2f199b7eaf258664fc7fd Mon Sep 17 00:00:00 2001
From: m2049r <m2049r@monerujo.io>
Date: Sun, 18 Apr 2021 16:55:14 +0200
Subject: [PATCH] fix permissions Q needs to read our old wallet files (#744)

---
 app/src/main/AndroidManifest.xml                            | 3 ++-
 .../java/com/m2049r/xmrwallet/util/LegacyStorageHelper.java | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index d587a81..e17df51 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -3,6 +3,7 @@
     package="com.m2049r.xmrwallet">
 
     <uses-permission android:name="android.permission.INTERNET" />
+    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
     <uses-permission android:name="android.permission.WAKE_LOCK" />
     <uses-permission android:name="android.permission.CAMERA" />
     <uses-permission android:name="android.permission.USE_BIOMETRIC" />
@@ -10,7 +11,7 @@
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
 
     <application
-        android:requestLegacyExternalStorage="true"
+        android:preserveLegacyExternalStorage="true"
         android:name=".XmrWalletApplication"
         android:allowBackup="false"
         android:icon="@mipmap/ic_launcher"
diff --git a/app/src/main/java/com/m2049r/xmrwallet/util/LegacyStorageHelper.java b/app/src/main/java/com/m2049r/xmrwallet/util/LegacyStorageHelper.java
index 60bbf4e..9ccdf5c 100644
--- a/app/src/main/java/com/m2049r/xmrwallet/util/LegacyStorageHelper.java
+++ b/app/src/main/java/com/m2049r/xmrwallet/util/LegacyStorageHelper.java
@@ -30,7 +30,7 @@ public class LegacyStorageHelper {
     static public void migrateWallets(Context context) {
         try {
             if (isStorageMigrated(context)) return;
-            if (!hasWritePermission(context)) {
+            if (!hasReadPermission(context)) {
                 // nothing to migrate, so don't try again
                 setStorageMigrated(context);
                 return;
@@ -121,9 +121,9 @@ public class LegacyStorageHelper {
         return dir;
     }
 
-    private static boolean hasWritePermission(Context context) {
+    private static boolean hasReadPermission(Context context) {
         if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M) {
-            return context.checkSelfPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_DENIED;
+            return context.checkSelfPermission(Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_DENIED;
         } else {
             return true;
         }