Mirrors
/
youtube-dl
mirror of https://github.com/ytdl-org/youtube-dl.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't be too clever

This commit is contained in:
Philipp Hagemeister 2012-12-12 15:00:03 +01:00
parent fd5ff02042
commit a276e06080
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/test_download.py
View File

@ -49,14 +49,13 @@ class TestDownload(unittest.TestCase):
self.tearDown() self.tearDown()
def tearDown(self): def tearDown(self):
for fn in [ test.get('file', False) for test in self.defs ]: for test in self.defs:
fn = test['file']
if fn and os.path.exists(fn): if fn and os.path.exists(fn):
os.remove(fn) os.remove(fn)
### Dinamically generate tests def make_test_method(test_case):
def generator(test_case):
def test_template(self): def test_template(self):
ie = getattr(youtube_dl.InfoExtractors, test_case['name'] + 'IE') ie = getattr(youtube_dl.InfoExtractors, test_case['name'] + 'IE')
if not ie._WORKING: if not ie._WORKING:
@ -81,14 +80,13 @@ def generator(test_case):
md5_for_file = _file_md5(test_case['file']) md5_for_file = _file_md5(test_case['file'])
self.assertEqual(md5_for_file, test_case['md5']) self.assertEqual(md5_for_file, test_case['md5'])
# TODO proper skipping annotations
return test_template return test_template
### And add them to TestDownload
for test_case in defs: for test_case in defs:
test_method = generator(test_case) test_method = make_test_method(test_case)
test_method.__name__ = "test_{0}".format(test_case["name"]) test_method.__name__ = "test_{0}".format(test_case["name"])
setattr(TestDownload, test_method.__name__, test_method) setattr(TestDownload, test_method.__name__, test_method)
del test_method
if __name__ == '__main__': if __name__ == '__main__':