Mirrors
/
yt-dlp
mirror of https://github.com/yt-dlp/yt-dlp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[EmbedSubtitle, SubtitlesConvertor] Fix error when subtitle file is missing 

Closes #1152, #1134
Bug from 8e25d624df
This commit is contained in:
pukkandan 2021-10-02 22:36:31 +05:30
parent e919569e67
commit a1c3967307
No known key found for this signature in database
GPG Key ID: 0F00D95A001F4698
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
yt_dlp/postprocessor/ffmpeg.py
View File

@ -555,7 +555,7 @@ class FFmpegEmbedSubtitlePP(FFmpegPostProcessor):
mp4_ass_warn = False mp4_ass_warn = False
for lang, sub_info in subtitles.items(): for lang, sub_info in subtitles.items():
if not os.path.exists(information.get('filepath', '')): if not os.path.exists(sub_info.get('filepath', '')):
self.report_warning(f'Skipping embedding {lang} subtitle because the file is missing') self.report_warning(f'Skipping embedding {lang} subtitle because the file is missing')
continue continue
sub_ext = sub_info['ext'] sub_ext = sub_info['ext']
@ -845,6 +845,9 @@ class FFmpegSubtitlesConvertorPP(FFmpegPostProcessor):
self.to_screen('Converting subtitles') self.to_screen('Converting subtitles')
sub_filenames = [] sub_filenames = []
for lang, sub in subs.items(): for lang, sub in subs.items():
if not os.path.exists(sub.get('filepath', '')):
self.report_warning(f'Skipping embedding {lang} subtitle because the file is missing')
continue
ext = sub['ext'] ext = sub['ext']
if ext == new_ext: if ext == new_ext:
self.to_screen('Subtitle file for %s is already in the requested format' % new_ext) self.to_screen('Subtitle file for %s is already in the requested format' % new_ext)