603fca1e27
Fix null errors on conversation holder ( #32258 ) ( #32266 )
...
fix #32258
Errors in the issue was due to unhandled null check. so i fixed it.
### Detailed description for Issue & Fix
To reproduce that issue, the comment must be deleted on Conversation
tab.
#### Before Delete
<img width="1032" alt="image"
src="https://github.com/user-attachments/assets/72df61ba-7db6-44c9-bebc-ca1178dd27f1 ">
#### After Delete (AS-IS)
<img width="1010" alt="image"
src="https://github.com/user-attachments/assets/36fa537e-4f8e-4535-8d02-e538c50f0dd8 ">
gitea already have remove logic for `timeline-item-group`, but because
of null ref exception the later logic that removes `timeline-item-group`
could be not be called correctly.
2024-10-16 20:39:47 +08:00
d50ed0abf7
Support requested_reviewers data in comment webhook events ( #26178 )
...
close #25833
Currently, the information for "requested_reviewers" is only included in
the webhook event for reviews. I would like to suggest adding this
information to the webhook event for "PullRequest comment" as well, as
they both pertain to the "PullRequest" event.
Also, The reviewer information for the Pull Request is not displayed
when it is approved or rejected.
2024-10-16 09:10:05 +00:00
5242e520c4
Make `owner/repo/pulls` handlers use "PR reader" permission ( #32254 )
...
Fix #32253 (partially)
2024-10-15 06:47:07 +00:00
c4b2808b89
make `show stats` work when only one file changed ( #32244 )
...
fix https://github.com/go-gitea/gitea/issues/32226
in https://github.com/go-gitea/gitea/pull/27775 , it do some changes to
only show diff file tree when more than one file changed. But looks it
also break the `diff-file-list` logic, which looks not expected change.
so try fix it.
/cc @silverwind
example view:
Signed-off-by: a1012112796 <1012112796@qq.com>
2024-10-14 21:23:20 +00:00
81aec6d621
Update scheduled tasks even if changes are pushed by "ActionsUser" ( #32246 )
...
Fix #32219
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-10-13 20:28:32 +00:00
74664b08a0
Support migrating GitHub/GitLab PR draft status ( #32242 )
...
Resolve #32196
2024-10-13 22:58:13 +03:00
9df5ddaf44
Only rename a user when they should receive a different name ( #32247 )
...
Fix #31996
2024-10-13 03:13:55 +00:00
6fced33581
Fix dropdown content overflow ( #31610 )
...
close #31602
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-10-13 02:43:43 +00:00
afa8dd45af
Make git push options accept short name ( #32245 )
...
Just like what most CLI parsers do: `--opt` means `opt=true`
Then users could use `-o force-push` as `-o force-push=true`
2024-10-12 05:42:10 +00:00
900ac62251
Allow code search by filename ( #32210 )
...
This is a large and complex PR, so let me explain in detail its changes.
First, I had to create new index mappings for Bleve and ElasticSerach as
the current ones do not support search by filename. This requires Gitea
to recreate the code search indexes (I do not know if this is a breaking
change, but I feel it deserves a heads-up).
I've used [this
approach](https://www.elastic.co/guide/en/elasticsearch/reference/7.17/analysis-pathhierarchy-tokenizer.html )
to model the filename index. It allows us to efficiently search for both
the full path and the name of a file. Bleve, however, does not support
this out-of-box, so I had to code a brand new [token
filter](https://blevesearch.com/docs/Token-Filters/ ) to generate the
search terms.
I also did an overhaul in the `indexer_test.go` file. It now asserts the
order of the expected results (this is important since matches based on
the name of a file are more relevant than those based on its content).
I've added new test scenarios that deal with searching by filename. They
use a new repo included in the Gitea fixture.
The screenshot below depicts how Gitea shows the search results. It
shows results based on content in the same way as the current version
does. In matches based on the filename, the first seven lines of the
file contents are shown (BTW, this is how GitHub does it).
Resolves #32096
---------
Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>
2024-10-11 23:35:04 +00:00
0fe5e2b08c
Allow maintainers to view and edit files of private repos when "Allow maintainers to edit" is enabled ( #32215 )
...
Fix #31539
2024-10-11 19:08:19 +00:00
aebb741c08
Use per package global lock for container uploads instead of memory lock ( #31860 )
...
This PR uses a per-package lock instead of a global lock for container
uploads. So that different packages can be uploaded simultaneously.
2024-10-11 07:37:49 +00:00
cb739f5333
Fix checkbox bug on private/archive filter ( #32236 )
...
fix #32235
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-10-11 01:12:27 +08:00
6029d78ab5
Improve the maintainblity of the reserved username list ( #32229 )
2024-10-10 09:04:42 +00:00
c2217670dd
Move admin routers from /admin to /-/admin ( #32189 )
...
Resolve #32181
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-10-10 04:56:49 +00:00
dd83cfcacc
Refactor CSRF token ( #32216 )
2024-10-10 03:48:21 +00:00
368b0881f5
[skip ci] Updated translations via Crowdin
2024-10-10 00:30:33 +00:00
4eacc61f64
Fix incorrect "Target branch does not exist" in PR title ( #32222 )
2024-10-10 08:25:46 +08:00
8bee7fcf7e
update git book link to v2 ( #32221 )
...
Fix the dead link `https://git-scm.com/book/en/Git-Basics-Getting-a-Git-Repository ` for
empty repositories to help how to clone the repository
to `https://git-scm.com/book/en/v2/Git-Basics-Getting-a-Git-Repository `
which is v2 of the git book. This also updates download git links
2024-10-09 13:04:34 +08:00
f9a9b08896
[skip ci] Updated translations via Crowdin
2024-10-09 00:31:01 +00:00
2e12343fc4
Add null check for responseData.invalidTopics ( #32212 )
...
<img width="553" alt="Screenshot 2024-10-08 at 10 49 10 AM"
src="https://github.com/user-attachments/assets/faeef64d-684a-4aba-b7fc-c7c6a0301abe ">
`responseData.invalidTopics` can be null but it wasn't handled.
2024-10-09 01:27:05 +08:00
d6d3c96e65
Fix bug when a token is given public only ( #32204 )
2024-10-08 12:51:09 +03:00
d3ada91ea4
[skip ci] Updated translations via Crowdin
2024-10-08 00:30:42 +00:00
bdd655f2bd
Allow filtering PRs by poster in the ListPullRequests API ( #32209 )
...
as title
---
*Sponsored by Kithara Software GmbH*
2024-10-07 23:21:07 +02:00
fa35ace9fb
Fix bug when there are multiple triggers with workflow dispatch ( #32200 )
2024-10-07 03:50:38 +00:00
6551847aa8
[skip ci] Updated licenses and gitignores
2024-10-07 00:32:39 +00:00
e530568666
[skip ci] Updated translations via Crowdin
2024-10-06 00:34:29 +00:00
479c31bb4d
Upgrade htmx to 2.0.3 ( #32192 )
...
Release notes:
https://github.com/bigskysoftware/htmx/releases/tag/v2.0.3
Tested `Star`, `Watch`, and the admin dashboard page. All functionality
remains unchanged.
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2024-10-06 04:52:30 +08:00
66923e02d2
Enhance USER_DISABLED_FEATURES to allow disabling change username or full name ( #31959 )
...
Fix #31958
Enhanced `USER_DISABLED_FEATURES`(also `EXTERNAL_USER_DISABLE_FEATURES`)
option in `[admin]` section.
Added following values:
- `change_username`: Disable change username
- `change_full_name`: Disable change full name
---
Progress:
- [x] Update code
- [x] Update translations
2024-10-05 20:41:38 +00:00
6a4eb126bd
[skip ci] Updated translations via Crowdin
2024-10-05 00:30:40 +00:00
5d6d025c9b
Add support for searching users by email ( #30908 )
...
Fix #30898
we have an option `SearchByEmail`, so enable it, then we can search user
by email.
Also added a test for it.
2024-10-04 17:45:06 +00:00
7e68bc8823
Fix PR creation on forked repositories ( #31863 )
...
Resolves #20475
2024-10-04 13:12:48 -04:00
0bd75390f5
[skip ci] Updated translations via Crowdin
2024-10-04 00:30:54 +00:00
d266d190bd
Fixed race condition when deleting documents by repoId in ElasticSearch ( #32185 )
...
Resolves #32184
---------
Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>
2024-10-03 16:03:36 +00:00
0b1b4030e6
add {{TEST_MINIO_ENDPOINT}} for local testing "with/without" docker + fix pgsql testing doc ( #32105 )
...
while testing i found out that testing locally as documented in the
changed README.md for pgsql isn't working because of the minio
dependency. reworked this to by default be still docker, but allow for
for local with only minio in docker and testing on bare metal.
also depending on this: fixed docs for running pgsql test
Closes : #32168 (by changing documentation for pgsql tests)
Closes : #32169 (by changing documentation, Makefile & pgsql.ini.tmpl:
adding {{TEST_MINIO_ENDPOINT}})
sry for the combined pr, but when testing I ran into this issue and
first thought they were related and now finally address the same
problem: not beeing able to run pgsql integration tests as described in
the according README.md
2024-10-03 01:00:56 +00:00
4416a4199b
[skip ci] Updated translations via Crowdin
2024-10-03 00:30:51 +00:00
a989404e23
Fix javascript error when an anonymous user visiting migration page ( #32144 )
...
This PR fixes javascript errors when an anonymous user visits the
migration page.
It also makes task view checking more restrictive.
The router moved from `/user/task/{id}/status` to
`/username/reponame/-/migrate/status` because it's a migrate status.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-10-02 04:37:16 +00:00
3a4a1bffbe
Make oauth2 code clear. Move oauth2 provider code to their own packages/files ( #32148 )
...
Fix #30266
Replace #31533
2024-10-02 08:03:19 +08:00
70b7df0e5e
Support repo license ( #24872 )
...
Close #278
Close #24076
## Solutions:
- Use
[google/licenseclassifier](https://github.com/google/licenseclassifier/ )
Test result between
[google/licensecheck](https://github.com/google/licensecheck ) and
[go-license-detector](https://github.com/go-enry/go-license-detector ):
https://github.com/go-gitea/gitea/pull/24872#issuecomment-1560361167
Test result between
[google/licensecheck](https://github.com/google/licensecheck ) and
[google/licenseclassifier](https://github.com/google/licenseclassifier/ ):
https://github.com/go-gitea/gitea/pull/24872#issuecomment-1576092178
- Generate License Convert Name List to avoid import license templates
with same contents
Gitea automatically get latest license data from[
spdx/license-list-data](https://github.com/spdx/license-list-data ).
But unfortunately, some license templates have same contents. #20915
[click here to see the
list](https://github.com/go-gitea/gitea/pull/24872#issuecomment-1584141684 )
So we will generate a list of these license templates with same contents
and create a new file to save the result when using `make
generate-license`. (Need to decide the save path)
- Save License info into a new table `repo_license`
Can easily support searching repo by license in the future.
## Screen shot
Single License:
Multiple Licenses:
Triggers:
- [x] Push commit to default branch
- [x] Create repo
- [x] Mirror repo
- [x] When Default Branch is changed, licenses should be updated
Todo:
- [x] Save Licenses info in to DB when there's a change to license file
in the commit
- [x] DB Migration
- [x] A nominal test?
- [x] Select which library to
use(https://github.com/go-gitea/gitea/pull/24872#issuecomment-1560361167 )
- [x] API Support
- [x] Add repo license table
- ~Select license in settings if there are several licenses(Not
recommended)~
- License board(later, not in this PR)
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: 6543 <m.huber@kithara.com>
Co-authored-by: a1012112796 <1012112796@qq.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
2024-10-01 15:25:08 -04:00
f4b8f6fc40
Fix the logic of finding the latest pull review commit ID ( #32139 )
...
Fix #31423
2024-10-01 01:58:55 +00:00
13283873e9
Ensure `GetCSRF` doesn't return an empty token ( #32130 )
...
Since page templates keep changing, some pages that contained forms with
CSRF token no longer have them.
It leads to some calls of `GetCSRF` returning an empty string, which
fails the tests. Like
3269b04d61/tests/integration/attachment_test.go (L62-L63)
2024-09-30 02:28:09 +00:00
5015de4d9a
Bump minio-go to latest version ( #32156 )
...
Current minio-go version has issues with S3 compatible storages like
Backblaze or Wasabi. This was fixed in
https://github.com/minio/minio-go/pull/1980 .
2024-09-30 09:57:48 +08:00
99d0510cb6
Change the code search to sort results by relevance ( #32134 )
...
Resolves #32129
Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>
2024-09-28 20:13:55 +00:00
ad749fbf25
[skip ci] Updated translations via Crowdin
2024-09-28 00:30:56 +00:00
8a9fd7f771
Add pure SSH LFS support ( #31516 )
...
Fixes #17554
/claim #17554
Docs PR https://gitea.com/gitea/docs/pulls/49
To test, run pushes like: `GIT_TRACE=1` git push. The trace output
should mention "pure SSH connection".
2024-09-27 10:27:37 -04:00
fdb1df9eca
[skip ci] Updated translations via Crowdin
2024-09-27 00:31:00 +00:00
3f9e360142
Don't join repository when loading action table data ( #32127 )
2024-09-26 04:50:30 +00:00
3269b04d61
Notify the user when the file path contains leading or trailing spaces and fix the error message for invalid file names. ( #31507 )
...
close #31478
2024-09-24 19:06:52 +00:00
6fa962f409
Fix wrong status of `Set up Job` when first step is skipped ( #32120 )
...
Fix #32089
2024-09-24 18:34:08 +00:00
5a8568459d
Fix bug when deleting a migrated branch ( #32075 )
...
After migrating a repository with pull request, the branch is missed and
after the pull request merged, the branch cannot be deleted.
2024-09-24 07:42:08 +00:00
cloudchamb3r