Mirrors
/
gparted
mirror of https://gitlab.gnome.org/GNOME/gparted.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix uninitialised read in OperationDetail::set_status() 

Setting the status and controlling the timing of operation details
initialised with OperationDetail(desc, status, font) uses a conditional
branch depending on the uninitialised variable this->status.

valgrind:
==28957== Conditional jump or move depends on uninitialised value(s)
==28957==    at 0x80E4287:
GParted::OperationDetail::set_status(GParted::OperationDetailStatus)
(OperationDetail.cc:77)

OperationalDetail.cc:
   75  void OperationDetail::set_status( OperationDetailStatus status )
   76  {
>> 77          if ( this ->status != STATUS_ERROR )
   78          {
   79                  switch ( status )
   80                  {
This commit is contained in:
Mike Fleetwood 2011-12-18 12:25:52 +00:00 committed by Curtis Gedak
parent 7477ba3c1d
commit 377d26f0cc
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/OperationDetail.cc
View File

@ -32,6 +32,7 @@ OperationDetail::OperationDetail()
OperationDetail::OperationDetail( const Glib::ustring & description, OperationDetailStatus status, Font font ) OperationDetail::OperationDetail( const Glib::ustring & description, OperationDetailStatus status, Font font )
{ {
this ->status = STATUS_NONE; // prevent uninitialized member access
set_description( description, font ) ; set_description( description, font ) ;
set_status( status ) ; set_status( status ) ;