Commit Graph

3294 Commits

Author SHA1 Message Date
Curtis Gedak ccaeb8dc51 Make the partition information dialog resizable (#690542)
Make the dialog resizable, add a vertical scrollbar to the information
and messages section, and set the initial height to ensure the dialog
fits entirely on an 800x600 screen.

A default height is required because some window managers, such as
fluxbox used in GParted Live, only permit resizing the height by using
the bottom corners of the dialog.  If the dialog is too large for the
screen then the user would not be able to resize it.

Note that two default initial heights are used in an effort to minimize
the amount of extra whitespace.

Bug 690542 - Partition Information Dialog Warning not readable
2014-04-28 08:42:40 +01:00
Curtis Gedak b271e367ea Place partition information percentages in their own column (#690542)
On some desktop environments, such as Unity on Ubuntu 13.04, the
partition information dialog can display the used/unused/unallocated
field values overlapping with the "(##%)" percentage value.  The problem
is pronounced for values with 4 digits to the left of the decimal (for
example a 1024 MiB partition ).  To address this problem, these
percentages are placed in their own column.

Bug 690542 - Partition Information Dialog Warning not readable
2014-04-28 08:42:40 +01:00
Curtis Gedak 898bc35198 Organize partition information into two field & value columns (#690542)
Organize the partition information field & value areas into two columns
to minimize the amount of vertical space required.

This is part of a series of changes to enable viewing all partition
information details on a minimum 800x600 display.

Part of Bug 690542 - Partition Information Dialog Warning not readable
2014-04-28 08:42:40 +01:00
Curtis Gedak 92c771bc7c Add partition information section titles and indent fields (#690542)
This is part of a series of changes to enable viewing all partition
information details on a minimum 800x600 display.

Part of Bug 690542 - Partition Information Dialog Warning not readable
2014-04-28 08:42:40 +01:00
Curtis Gedak 7fc8aa49fe Organize partition information fields into logical sections (#690542)
This is part of a series of changes to enable viewing all partition
information details on a minimum 800x600 display.

Part of Bug 690542 - Partition Information Dialog Warning not readable
2014-04-28 08:42:40 +01:00
Mike Fleetwood 5f6656f267 Initialise file system objects only once
The code used to unnecessarily destroy and re-create the file system
objects on every scan for file system support tools.

Instead only create the file system objects once and just call each
object's get_filesystem_support() method on each rescan.
2014-04-23 10:25:56 -06:00
Mike Fleetwood 131098a797 Remove set_proper_filesystem() method
Prior to commit:

    1f3b11748e
    Remove GParted_Core::p_filesystem (#683149)

set_proper_filesystems() used to set GParted_Core::p_filesystem member
variable to one of the FileSystem objects, but that was just treating it
like a local variable.  After the commit local variables named
p_filesystem were used where required and set_proper_filesystem() became
a function which did nothing other than call get_filesystem_object().

Now remove set_proper_filesystem() altogether and use
get_filesystem_object() in its place.
2014-04-23 10:25:27 -06:00
Mike Fleetwood 67115eeff2 Remove unused member variable GParted_Core::buf 2014-04-23 09:54:20 -06:00
Mike Fleetwood 438685577b Remove outdated comment about ped_partition_is_busy() for DMRaid devices
Comment is outdated after GParted stopped using ped_partition_is_busy()
for busy partition detection of normal and logical partitions since
commit:

    4202992063
    Fix false busy detection of unusual case with Linux Software RAID (#712533)
2014-04-23 09:54:20 -06:00
Jan Simon 2c04654889 Updated German translation 2014-04-18 20:36:44 +02:00
Daniel Mustieles d47b789900 Updated Spanish translation 2014-04-15 14:26:02 +02:00
Daniel Mustieles be482f929a Updated Spanish translation 2014-04-15 14:25:51 +02:00
Rafael Ferreira 9d5155b49c Updated Brazilian Portuguese translation 2014-04-08 16:45:32 +00:00
Piotr Drąg 6a060c6ea8 doap: update URLs 2014-04-04 20:27:48 +02:00
Andika Triwidada 4961ec7138 Updated Indonesian translation 2014-03-30 01:40:37 +00:00
Joe Hansen 5dc11d6b12 Updated Danish translation 2014-03-14 22:43:21 +01:00
Curtis Gedak 7b1011237c Avoid using String::ucompose to build command lines
The String::ucompose method is for easy, i18n-friendly composition of
strings with Gtkmm.  From past experience, String::ucompose should not
be used to build command lines due to differences in how locales handle
number translation.  More specifically, not all locales use number
separators (spaces, commas or periods) and the decimal separator
(period or comma) in the same way.

The problem with using String::ucompose for command lines was
originally encountered and corrected in the following commit:

Fix attempt data rescue fail to open read-only view (#673246)
e494eca1f7
2014-03-05 22:12:10 +00:00
Phillip Susi 86111fe12a Use e2image to move/copy ext[234] file systems (#721516)
Use e2image features added in e2fsprogs 1.42.9 to move/copy
an ext[234] file system more efficiently by skipping unused blocks.
Fall back to the internal copy algorithm if e2image is not found
or does not support move/copy.

Bug #721516 - Use e2image to move/copy ext[234] filesystems
2014-03-05 22:12:10 +00:00
GunChleoc eae15d8887 Updated Scottish Gaelic translation 2014-03-03 11:02:56 +00:00
Rūdolfs Mazurs 805e4e5173 Updated Latvian translation 2014-02-19 22:12:53 +02:00
Curtis Gedak a8bd849d8b Append -git to version for continuing development 2014-02-19 11:13:38 -07:00
Curtis Gedak d55ab1f06d Update NEWS file with missed 0.18.0 release items
Improve release news announcement and add missing BitLocker encrypted
disk detection.
2014-02-19 11:01:16 -07:00
Curtis Gedak d5d80d0942 ========== gparted-0.18.0 ========== 2014-02-19 09:59:45 -07:00
Aurimas Černius 812154449c Updated Lithuanian translation 2014-02-15 19:08:20 +02:00
GunChleoc 704705d1a2 Updated Scottish Gaelic translation 2014-02-14 18:35:05 +00:00
Marek Černocký 07ba9b5e6c Updated Czech translation 2014-02-14 11:02:39 +01:00
Claude Paroz 2644ecc4ea Updated French manual translation 2014-02-13 10:13:53 +01:00
Daniel Korostil 8051f6ee3a Updated Ukrainian translation 2014-02-12 22:56:28 +02:00
Daniel Mustieles 654dc4c25d Updated Spanish translation 2014-02-10 14:30:00 +01:00
GunChleoc d8b29192f3 Updated Scottish Gaelic translation 2014-02-08 15:12:32 +00:00
Curtis Gedak 203a345cfb Update copyright year 2014-02-08 12:23:55 +00:00
Curtis Gedak 93f7cb3f47 Add gnome-common to fedora dependencies in README
The gnome-common package is needed when building from the git
repository.  This package was missed in the list of dependencies for
the Fedora GNU/Linux distribution.
2014-02-08 12:23:55 +00:00
Curtis Gedak 4a85e3cd66 Update help manual to match file system support dialog (#342682)
The help manual was updated to reflect that the legend is now always
displayed on the File System Support dialog.

Bug #342682 - too much information in 'features' dialog
2014-02-08 12:23:55 +00:00
Curtis Gedak 1cffac0dd8 Add empty Scottish Gaelic translation files for GParted help manual
GunChleoc has brought to my attention an inability to create the
Scottish Gaelic (gd) translation files for the GParted help
manual using Damned Lies.  In an effort to work around this challenge
I am adding "gd" to LINGUAS in help/Makefile.am, and also adding a
template help/gd/gd.po file for translation.
2014-02-07 13:49:07 -07:00
Phillip Susi 5f9a55fdcb Remove incorrect rounding in file system resize (#723543)
Work on bug 701075 inadvertently introduced a problem where ext2/3/4,
resierfs, and ntfs file systems were rounding the file system size up
to the nearest kiB.

The problem was discovered when a user resized a partition by moving
only the start boundary to the right thereby shrinking the partition.
In the situation where the resulting partition size was not an integer
kiB value (such as might occur on a 512 byte per sector device) the
file system size was rounded up to the nearest kiB.  This resulted in
a file system size being set one sector larger than the partition
size.

This problem was introduced with the following commit:

Shrink file systems to exact size (#701075)
3461413d28

The fix chosen for this problem involved removing the rounding logic.

Bug 723543 - Shrink ext2/3/4 results in attempt to set partition
             smaller than file system
2014-02-06 10:20:05 -07:00
GunChleoc 510e9eafc4 Updated Scottish Gaelic translation 2014-02-05 12:36:32 +00:00
Gabor Kelemen 6d77722360 Updated Hungarian translation 2014-02-03 15:44:41 +01:00
Mike Fleetwood 9728479771 Recognise BitLocker encrypted partitions (#723232)
Only recognises partitions containing BitLocker Disk Encryption content.
No other actions are supported.

Bug #723232 - BitLocker Disk Encryption not recognised
2014-01-31 09:55:05 -07:00
Daniel Mustieles 2e77431914 Revert "Fixed FSF's address. Fixes #721565"
This reverts commit 9f5d683644.
2014-01-31 14:39:20 +01:00
Daniel Mustieles 9f5d683644 Fixed FSF's address. Fixes #721565 2014-01-31 14:01:11 +01:00
Мирослав Николић c5f77b33bb Updated Serbian translation 2014-01-28 18:36:51 +01:00
Mike Fleetwood a70bfd32fe Restore compilation order of source files
Restore the order of the source files so that they are once again
compiled in order A-Z, a-z.  Order is obtained with:

    fgrep .cc src/Makefile.am | LANG=C sort
    fgrep .h include/Makefile.am | LANG=C sort
2014-01-27 10:54:48 -07:00
Mike Fleetwood 6f9b99f138 Make the File System Support dialog resizable (#342682)
Make the dialog resizable, add a vertical scrollbar and set the minimum
(and therefore initial) height to 500 pixels.  This is so that the
dialog entirely fits on an 800x600 screen, thus allowing the rescan
button to be pressed.

100 pixel difference is to account for the size of the top and bottom
GNOME 2 panels and two sets of title bars.  Two sets of title bars
because the window manager tries to place the top of dialog title bars
in line with the bottom of the main window title bar.

Bug #342682 - too much information in 'features' dialog
2014-01-27 10:54:48 -07:00
Mike Fleetwood cb8ce9caea Indent File System Support legend narrative (#342682)
Use padding to indent the legend narrative to better show hierarchy and
association with the "Legend" category as recommended in the:

    GNOME HIG 2.2.3 / Visual Design / Window Layout
    https://developer.gnome.org/hig-book/stable/design-window.html.en

Padding the legend narrative widget also deliberately increases the
spacing to the legend icons too.

Bug #342682 - too much information in 'features' dialog
2014-01-27 10:54:48 -07:00
Mike Fleetwood 59f684d8cd Always show the File System Support dialog legend (#342682)
Make the legend always shown, ready for when the dialog is resizable.

Change the widget containing the legend from an expander to a frame
widget.  Set the frame to be borderless using a bold label as
recommended in the GNOME Human Interface Guidelines 2.2.1 / Controls /
Frames and Separators.

    https://developer.gnome.org/hig-book/2.32/controls-frames.html.en

Bug #342682 - too much information in 'features' dialog
2014-01-27 10:54:48 -07:00
Mike Fleetwood dd9e2161d4 Enhance readability of the DialogFeatures constructor
The DialogFeatures::DialogFeatures() constructor used four levels of
nested code blocks and reused the same variable names at multiple
levels.  The variable hbox was used at three of the four levels.  This
was done by commit:

    91b971691d
    Bug #634090: Change some attributes to local variables

In my opinion this made the code hard to understand.  Give every local
variable a unique and meaningful name and remove the nested code blocks.
2014-01-27 10:54:48 -07:00
Daniel Mustieles 3861b9257b Replace obsolete FSF postal address in copyright notices (#721565)
This is part of parent bug:
    Bug #721455 - Obsolete info in license text on multiple modules

and GNOME Goal:
    https://wiki.gnome.org/Initiatives/GnomeGoals/Proposals

    * verify all source files to make sure they have a license and a
      copyright, and that both are up-to-date

Bug #721565 -  License text contains obsolete FSF postal address
2014-01-26 10:53:23 +00:00
GunChleoc f51866dcd8 Added Scottish Gaelic translation 2014-01-22 21:35:24 +01:00
Mike Fleetwood 0e253fa234 Prevent crash when creating new partition on loop label (#721988)
Write a loop partition table to a disk and then try to create a new
partition on that disk crashes GParted.

Analysis:

1) Loop partition table, actually just the signature / label
   "GNU Parted Loopback 0", is written to the disk.
2) create_partition() calls ped_disk_app_partition() to create the
   partition which, arguably erroneously, clears the loop signature.
3) In erase_filesystem_signatures(), get_device_and_disk() fails because
   there's no longer a loop signature for libparted to recognise.  This
   leaves lp_device, lp_disk and lp_partition = NULL, but incorrectly
   overall_success = true.
4) Overall_success = true allows the signature erasure loop to run and
   evaluate lp_device->sector_size, dereferencing a NULL pointer and
   crashing GParted.

Fix erase_filesystem_signatures() to correctly handle failure from
get_device_and_disk(), broken by this commit:

    246e05559d
    Clear btrfs file system super block mirror copies too (#705426)

Bug #721988 - Crash when creating new partition on disk with loop label
2014-01-13 08:06:09 +00:00
Marek Černocký f439a31a48 Updated Czech translation 2014-01-11 23:58:46 +01:00