- removed guards on the ove set temp/set op (supported modes seems sufficient)

This commit is contained in:
Jack Simbach 2020-12-29 22:49:12 -05:00
parent e5044846c5
commit 7bbeeb679a
1 changed files with 25 additions and 27 deletions

View File

@ -133,40 +133,38 @@ class GeOven(GeWaterHeater):
async def async_set_operation_mode(self, operation_mode: str): async def async_set_operation_mode(self, operation_mode: str):
"""Set the operation mode.""" """Set the operation mode."""
if self.remote_enabled: erd_cook_mode = COOK_MODE_OP_MAP.inverse[operation_mode]
erd_cook_mode = COOK_MODE_OP_MAP.inverse[operation_mode] # Pick a temperature to set. If there's not one already set, default to
# Pick a temperature to set. If there's not one already set, default to # good old 350F.
# good old 350F. if operation_mode == OP_MODE_OFF:
if operation_mode == OP_MODE_OFF: target_temp = 0
target_temp = 0 elif self.target_temperature:
elif self.target_temperature: target_temp = self.target_temperature
target_temp = self.target_temperature elif self.temperature_unit == TEMP_FAHRENHEIT:
elif self.temperature_unit == TEMP_FAHRENHEIT: target_temp = 350
target_temp = 350 else:
else: target_temp = 177
target_temp = 177
new_cook_mode = OvenCookSetting(OVEN_COOK_MODE_MAP[erd_cook_mode], target_temp) new_cook_mode = OvenCookSetting(OVEN_COOK_MODE_MAP[erd_cook_mode], target_temp)
erd_code = self.get_erd_code("COOK_MODE") erd_code = self.get_erd_code("COOK_MODE")
await self.appliance.async_set_erd_value(erd_code, new_cook_mode) await self.appliance.async_set_erd_value(erd_code, new_cook_mode)
async def async_set_temperature(self, **kwargs): async def async_set_temperature(self, **kwargs):
"""Set the cook temperature""" """Set the cook temperature"""
if self.remote_enabled: target_temp = kwargs.get(ATTR_TEMPERATURE)
target_temp = kwargs.get(ATTR_TEMPERATURE) if target_temp is None:
if target_temp is None: return
return
current_op = self.current_operation current_op = self.current_operation
if current_op != OP_MODE_OFF: if current_op != OP_MODE_OFF:
erd_cook_mode = COOK_MODE_OP_MAP.inverse[current_op] erd_cook_mode = COOK_MODE_OP_MAP.inverse[current_op]
else: else:
erd_cook_mode = ErdOvenCookMode.BAKE_NOOPTION erd_cook_mode = ErdOvenCookMode.BAKE_NOOPTION
new_cook_mode = OvenCookSetting(OVEN_COOK_MODE_MAP[erd_cook_mode], target_temp) new_cook_mode = OvenCookSetting(OVEN_COOK_MODE_MAP[erd_cook_mode], target_temp)
erd_code = self.get_erd_code("COOK_MODE") erd_code = self.get_erd_code("COOK_MODE")
await self.appliance.async_set_erd_value(erd_code, new_cook_mode) await self.appliance.async_set_erd_value(erd_code, new_cook_mode)
def get_erd_value(self, suffix: str) -> Any: def get_erd_value(self, suffix: str) -> Any:
erd_code = self.get_erd_code(suffix) erd_code = self.get_erd_code(suffix)