Mirrors
/
matrix-public-archive
mirror of https://github.com/matrix-org/matrix-public-archive.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add comment reference to issue about adding hour chunk time slices (#126)

This commit is contained in:
Eric Eastwood 2022-11-08 22:35:28 -06:00 committed by GitHub
parent 026a08a77a
commit b3c553a863
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
server/routes/room-routes.js
View File

@ -214,11 +214,13 @@ router.get(
// any messages in the gap.
//
// XXX: This date boundary logic may need to change once we introduce hour
// chunks or time slices. For example if we reached into the next day but it has
// too many messages to show for a given page, we would want to back track until
// a suitable time slice boundary. Maybe we need to add a new URL parameter here
// `?time-slice=true` to indicate that it's okay to break it up by time slice
// based on previously having to view by time slice. We wouldn't want to give
// chunks or time slices
// (https://github.com/matrix-org/matrix-public-archive/issues/7). For example
// if we reached into the next day but it has too many messages to show for a
// given page, we would want to back track until a suitable time slice boundary.
// Maybe we need to add a new URL parameter here `?time-slice=true` to indicate
// that it's okay to break it up by time slice based on previously having to
// view by time slice. We wouldn't want to give
const utcMidnightOfDayBefore = Date.UTC(
dateOfLastMessage.getUTCFullYear(),
dateOfLastMessage.getUTCMonth(),