20fc9fcc33
Clarify the semantics of the `enable_authenticated_media` configuration option. ( #17913 )
...
Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
2024-11-11 10:44:47 +00:00
cacd4fd7bd
Fix MSC4222 returning full state ( #17915 )
...
There was a bug that meant we would return the full state of the room on
incremental syncs when using lazy loaded members and there were no
entries in the timeline.
This was due to trying to use `state_filter or state_filter.all()` as a
short hand for handling `None` case, however `state_filter` implements
`__bool__` so if the state filter was empty it would be set to full.
c.f. MSC4222 and #17888
2024-11-08 16:41:24 +00:00
c7a1d0aa1a
Fix Twisted tests with latest release ( #17911 )
...
c.f. #17906 and #17907
2024-11-07 16:22:09 +00:00
c92639df21
Switch portdb CI to python 3.13, pg 17 ( #17909 )
2024-11-07 16:09:45 +00:00
d0fc1e904a
Fix cancellation tests with new Twisted. ( #17906 )
...
The latest Twisted release changed how they implemented `__await__` on
deferreds, which broke the machinery we used to test cancellation.
This PR changes things a bit to instead patch the `__await__` method,
which is a stable API. This mostly doesn't change the core logic, except
for fixing two bugs:
- We previously did not intercept all await points
- After cancellation we now need to not only unblock currently blocked
await points, but also make sure we don't block any future await points.
c.f. https://github.com/twisted/twisted/pull/12226
---------
Co-authored-by: Devon Hudson <devon.dmytro@gmail.com>
2024-11-07 15:26:14 +00:00
77eafd47df
Fix other unit tests with latest twisted ( #17907 )
...
There's also https://github.com/element-hq/synapse/pull/17906
2024-11-07 10:11:13 +00:00
2a321bac35
Issue one time keys in upload order ( #17903 )
...
Currently, one-time-keys are issued in a somewhat random order. (In
practice, they are issued according to the lexicographical order of
their key IDs.) That can lead to a situation where a client gives up
hope of a given OTK ever being used, whilst it is still on the server.
Related: https://github.com/element-hq/element-meta/issues/2356
2024-11-06 22:21:06 +00:00
eda735e4bb
Remove support for python 3.8 ( #17908 )
...
### Pull Request Checklist
<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->
* [X] Pull request is based on the develop branch
* [X] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog ).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [X] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html ) is
correct
(run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters ))
---------
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
2024-11-06 19:36:01 +00:00
e1f5da65e1
Update version constraint to allow the latest `poetry-core` `1.9.1` ( #17902 )
...
Update version constraint to allow the latest `poetry-core` `1.9.1`
Context:
> I am working on updating poetry-core in Fedora and synapse is one of
affected packages. Please run a CI to see if it works properly. Thank
you.
Mergeable version of https://github.com/element-hq/synapse/pull/17848
2024-11-06 10:51:19 -06:00
61aadb158f
Use unique name for each os.arch variant when uploading Wheels ( #17905 )
...
### Pull Request Checklist
<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->
* [X] Pull request is based on the develop branch
* [X] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog ).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [X] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html ) is
correct
(run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters ))
2024-11-06 15:21:45 +00:00
75698a3e53
Improve nix flake to use nixpkgs-unstable in lieu of master ( #17852 )
2024-11-06 14:03:46 +00:00
46bd7e136d
Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows ( #17657 )
...
Bumps
[actions/download-artifact](https://github.com/actions/download-artifact )
from 3 to 4.1.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/download-artifact/releases ">actions/download-artifact's
releases</a>.</em></p>
<blockquote>
<h2>v4.1.7</h2>
<h2>What's Changed</h2>
<ul>
<li>Update <code>@actions/artifact</code> dependency by <a
href="https://github.com/bethanyj28 "><code>@bethanyj28</code></a> in <a
href="https://redirect.github.com/actions/download-artifact/pull/325 ">actions/download-artifact#325</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/download-artifact/compare/v4.1.6...v4.1.7 ">https://github.com/actions/download-artifact/compare/v4.1.6...v4.1.7 </a></p>
<h2>v4.1.6</h2>
<h2>What's Changed</h2>
<ul>
<li>updating <code>@actions/artifact</code> dependency to v2.1.6 by <a
href="https://github.com/eggyhead "><code>@eggyhead</code></a> in <a
href="https://redirect.github.com/actions/download-artifact/pull/324 ">actions/download-artifact#324</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/download-artifact/compare/v4.1.5...v4.1.6 ">https://github.com/actions/download-artifact/compare/v4.1.5...v4.1.6 </a></p>
<h2>v4.1.5</h2>
<h2>What's Changed</h2>
<ul>
<li>Update readme with v3/v2/v1 deprecation notice by <a
href="https://github.com/robherley "><code>@robherley</code></a> in <a
href="https://redirect.github.com/actions/download-artifact/pull/322 ">actions/download-artifact#322</a></li>
<li>Update dependencies <code>@actions/core</code> to v1.10.1 and
<code>@actions/artifact</code> to v2.1.5</li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/download-artifact/compare/v4.1.4...v4.1.5 ">https://github.com/actions/download-artifact/compare/v4.1.4...v4.1.5 </a></p>
<h2>v4.1.4</h2>
<h2>What's Changed</h2>
<ul>
<li>Update <code>@actions/artifact</code> by <a
href="https://github.com/bethanyj28 "><code>@bethanyj28</code></a> in <a
href="https://redirect.github.com/actions/download-artifact/pull/307 ">actions/download-artifact#307</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/download-artifact/compare/v4...v4.1.4 ">https://github.com/actions/download-artifact/compare/v4...v4.1.4 </a></p>
<h2>v4.1.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Update release-new-action-version.yml by <a
href="https://github.com/konradpabjan "><code>@konradpabjan</code></a>
in <a
href="https://redirect.github.com/actions/download-artifact/pull/292 ">actions/download-artifact#292</a></li>
<li>Update toolkit dependency with updated unzip logic by <a
href="https://github.com/bethanyj28 "><code>@bethanyj28</code></a> in <a
href="https://redirect.github.com/actions/download-artifact/pull/299 ">actions/download-artifact#299</a></li>
<li>Update <code>@actions/artifact</code> by <a
href="https://github.com/bethanyj28 "><code>@bethanyj28</code></a> in <a
href="https://redirect.github.com/actions/download-artifact/pull/303 ">actions/download-artifact#303</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/bethanyj28 "><code>@bethanyj28</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/download-artifact/pull/299 ">actions/download-artifact#299</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/download-artifact/compare/v4...v4.1.3 ">https://github.com/actions/download-artifact/compare/v4...v4.1.3 </a></p>
<h2>v4.1.2</h2>
<ul>
<li>Bump <code>@actions/artifacts</code> to latest version to include
<a href="https://redirect.github.com/actions/toolkit/pull/1648 ">updated
GHES host check</a></li>
</ul>
<h2>v4.1.1</h2>
<ul>
<li>Fix transient request timeouts <a
href="https://redirect.github.com/actions/download-artifact/issues/249 ">actions/download-artifact#249</a></li>
<li>Bump <code>@actions/artifacts</code> to latest version</li>
</ul>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Some cleanup by <a
href="https://github.com/robherley "><code>@robherley</code></a> in <a
href="https://redirect.github.com/actions/download-artifact/pull/247 ">actions/download-artifact#247</a></li>
<li>Fix default for run-id by <a
href="https://github.com/stchr "><code>@stchr</code></a> in <a
href="https://redirect.github.com/actions/download-artifact/pull/252 ">actions/download-artifact#252</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="65a9edc588https://redirect.github.com/actions/download-artifact/issues/325 ">#325</a>
from bethanyj28/main</li>
<li><a
href="fdd1595981c13dba102f0daa75ebeahttps://redirect.github.com/actions/download-artifact/issues/324 ">#324</a>
from actions/eggyhead/use-artifact-v2.1.6</li>
<li><a
href="9c19ed7fe53d3ea8741e89af5db821b4aefff88ehttps://redirect.github.com/actions/download-artifact/issues/323 ">#323</a>
from actions/eggyhead/update-artifact-v215</li>
<li><a
href="8caf195ad4d7a2ec411dhttps://github.com/actions/download-artifact/compare/v3...v4.1.7 ">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/element-hq/synapse/network/alerts ).
</details>
> **Note**
> Automatic rebases have been disabled on this pull request as it has
been open for over 30 days.
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Devon Hudson <devonhudson@librem.one>
2024-11-06 00:24:40 +00:00
eac170b21b
Use more correct changelog entries for refactoring `Generator` usage ( #17890 )
...
Use more correct changelog entries for refactoring `Generator` usage
- https://github.com/element-hq/synapse/pull/17813
- https://github.com/element-hq/synapse/pull/17814
- https://github.com/element-hq/synapse/pull/17815
- https://github.com/element-hq/synapse/pull/17816
- https://github.com/element-hq/synapse/pull/17817
### Pull Request Checklist
<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->
* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog ).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
- Use markdown where necessary, mostly for `code blocks`.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html ) is
correct
(run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters ))
2024-11-05 22:54:18 +00:00
211c31dbd7
Fix WheelTimer implementation that can expired timeout early ( #17850 )
...
When entries insert in the end of timer queue, then unnecessary entry
inserted (with duplicated key).
This can lead to some timeouts expired early and consume memory.
2024-11-05 12:08:17 -06:00
361bdafb87
Add experimental support for MSC4222 ( #17888 )
...
Basically, if the client sets a special query param on `/sync` v2
instead of responding with `state` at the *start* of the timeline, we
instead respond with `state_after` at the *end* of the timeline.
We do this by using the `current_state_delta_stream` table, which is
actually reliable, rather than messing around with "state at" points on
the timeline.
c.f. MSC4222
2024-11-05 14:45:57 +00:00
1c2b18a704
Bump Synapse Dockerfile default to Python 3.12 ( #17887 )
2024-11-05 13:15:10 +00:00
2c9ed5e510
Remove usage of internal header encoding API ( #17894 )
...
```py
from twisted.web.http_headers import Headers
Headers()._canonicalNameCaps
Headers()._encodeName
```
Introduced in https://github.com/matrix-org/synapse/pull/15913 <-
https://github.com/matrix-org/synapse/pull/15773
2024-11-04 12:20:07 -06:00
9c0a3963bc
Bump phonenumbers from 8.13.48 to 8.13.49 ( #17899 )
2024-11-04 17:21:05 +00:00
0932c77539
Sliding Sync: Lazy-loading room members on incremental sync (remember memberships) ( #17809 )
...
Lazy-loading room members on incremental sync and remember which
memberships we've sent down the connection before (up-to 100)
Fix https://github.com/element-hq/synapse/issues/17804
2024-11-04 10:17:58 -06:00
5580a820ae
Bump ruff from 0.7.1 to 0.7.2 ( #17897 )
2024-11-04 16:14:46 +00:00
541a009564
Bump anyhow from 1.0.91 to 1.0.92 ( #17901 )
2024-11-04 16:14:10 +00:00
b5493899c5
Bump serde from 1.0.213 to 1.0.214 ( #17900 )
2024-11-04 16:14:01 +00:00
da7d71e2a2
Bump mypy-zope from 1.0.7 to 1.0.8 ( #17898 )
2024-11-04 16:13:16 +00:00
c705beebf7
Support & use stable endpoints for MSC4151 ( #17374 )
...
https://github.com/matrix-org/matrix-spec-proposals/pull/4151 has
finished FCP.
See https://github.com/element-hq/synapse/issues/17373 for unstable
endpoint removal
---------
Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
2024-10-31 09:55:30 +00:00
47fe6df013
Remove `Generator` in `_prune_old_outbound_device_pokes` ( #17814 )
...
Context: https://github.com/matrix-org/synapse/issues/15439
(https://github.com/element-hq/synapse/issues/15439 )
Also see discussion in https://github.com/element-hq/synapse/pull/17813
2024-10-30 21:21:22 -05:00
034d472688
Remove `Generator` in `_purge_unreferenced_state_groups` twice ( #17815 )
...
Context: https://github.com/matrix-org/synapse/issues/15439
(https://github.com/element-hq/synapse/issues/15439 )
Also see discussion in https://github.com/element-hq/synapse/pull/17813
2024-10-30 20:16:49 -05:00
0c429fae1d
Remove `Generator` in `update_cached_last_access_time` ( #17816 )
...
Context: https://github.com/matrix-org/synapse/issues/15439
(https://github.com/element-hq/synapse/issues/15439 )
Also see discussion in https://github.com/element-hq/synapse/pull/17813
2024-10-30 20:16:24 -05:00
2e5fe3f187
Remove `Generator` in `store_search_entries_txn` ( #17817 )
...
Context: https://github.com/matrix-org/synapse/issues/15439
(https://github.com/element-hq/synapse/issues/15439 )
Also see discussion in https://github.com/element-hq/synapse/pull/17813
2024-10-30 20:15:57 -05:00
af59a99933
Remove `Generator` from 4 places in `PersistEventStore` ( #17818 )
...
Context: https://github.com/matrix-org/synapse/issues/15439
(https://github.com/element-hq/synapse/issues/15439 )
Also see discussion in https://github.com/element-hq/synapse/pull/17813
2024-10-30 20:14:36 -05:00
7987d5e638
Remove `Generator` in `_quarantine_media_txn()` ( #17813 )
2024-10-30 19:34:11 -05:00
3ae80b0de4
Check if user is in room before being able to tag it ( #17839 )
...
Fix #17819
2024-10-30 11:55:23 -05:00
5c781b578d
Bump ruff from 0.6.9 to 0.7.1 ( #17868 )
2024-10-30 11:57:36 +00:00
418fbba8de
Bump phonenumbers from 8.13.47 to 8.13.48 ( #17880 )
2024-10-30 11:56:20 +00:00
6d65c3944b
Bump python-multipart from 0.0.12 to 0.0.16 ( #17879 )
2024-10-30 11:56:12 +00:00
330f170c0e
Bump bytes from 1.7.2 to 1.8.0 ( #17877 )
2024-10-30 11:55:17 +00:00
bf03361c86
Bump anyhow from 1.0.90 to 1.0.91 ( #17876 )
2024-10-30 11:54:59 +00:00
3e750ab0d8
Bump serde from 1.0.210 to 1.0.213 ( #17875 )
2024-10-30 11:54:48 +00:00
9cd3545bca
Bump regex from 1.11.0 to 1.11.1 ( #17874 )
2024-10-30 11:54:38 +00:00
83513b75f7
Speed up sliding sync by computing extensions in parallel ( #17884 )
...
The main change here is to add a helper function
`gather_optional_coroutines`, which works in a similar way as
`yieldable_gather_results` but takes a set of coroutines rather than a
function
2024-10-30 10:51:04 +00:00
58deef5eba
Add admin handler to list of handlers used for background tasks ( #17847 )
...
Fixes #17823
While we're at it, makes a change where the redactions are sent as the
admin if the user is not a member of the server (otherwise these fail
with a "User must be our own" message).
2024-10-29 13:50:13 -05:00
d427403c67
Fix check for outdated Rust library ( #17861 )
...
This failed when install with poetry, so let's properly try and detect
what's going on.
2024-10-29 17:06:15 +00:00
e9f9625d6b
Merge branch 'master' into develop
2024-10-29 17:47:05 +01:00
4be3bd41fd
Move announcements up
2024-10-29 17:05:22 +01:00
b3b1db4057
1.118.0
2024-10-29 15:30:10 +01:00
6c51f8649d
Include the destination in the error of 'Destination mismatch' ( #17830 )
...
To help debug problems such as
https://github.com/element-hq/synapse/issues/17822
2024-10-29 10:09:25 +00:00
69e9b75373
Bump types-setuptools from 75.1.0.20241014 to 75.2.0.20241019 ( #17856 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-25 10:44:12 +01:00
5d0514f29b
Bump serde_json from 1.0.128 to 1.0.132 ( #17857 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-25 10:43:40 +01:00
4e5410fdae
Bump types-psycopg2 from 2.9.21.20240819 to 2.9.21.20241019 ( #17855 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-25 10:42:38 +01:00
12d65a6778
Bump cryptography from 43.0.1 to 43.0.3 ( #17853 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-25 10:40:58 +01:00
1006c12eb2
Bump anyhow from 1.0.89 to 1.0.90 ( #17858 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-25 10:35:37 +01:00
reivilibre