1a5f9bb651
Enable refreshable tokens on the admin registration endpoint ( #16642 )
...
Signed-off-by: Charles Wright <cvwright@futo.org>
2023-11-22 15:01:09 +00:00
f2430b16d1
Bump pyo3 (0.20), pythonize (0.20), pyo3-log (0.9) ( #16673 )
...
Signed-off-by: Kai A. Hiller <V02460@gmail.com>
2023-11-22 14:55:43 +00:00
c432d8f18f
Admin API for server notice: consistently bypass rate limits ( #16670 )
...
* Admin API for server notice: disable rate limit for all calls
* Add changelog
* Update changelog.d/16670.bugfix
2023-11-22 13:47:29 +00:00
460743da16
Filter out auth chain queries that don't exist ( #16552 )
2023-11-22 10:59:16 +00:00
bb86eb9814
1.97.0rc1
2023-11-21 12:38:46 +00:00
6088303efb
Speed up how quickly we launch new tasks ( #16660 )
...
Now that we're reducing concurrency (#16656 ), this is more important.
2023-11-17 16:36:02 +00:00
d9dcfe2a35
Bump requests-toolbelt from 0.10.1 to 1.0.0. ( #16659 )
2023-11-17 10:23:07 -05:00
9c02ef21e0
Speed up purge room by adding index ( #16657 )
...
What it says on the tin
2023-11-17 14:15:44 +00:00
6fec2d035f
Also discard 'caches' and 'backfill' stream POSITIONS ( #16655 )
...
Follow on from #16640
2023-11-17 14:14:29 +00:00
518e4de758
Update admin user API return types in docs. ( #16654 )
2023-11-17 13:38:25 +00:00
700c8a0de5
Reduce task concurrency ( #16656 )
2023-11-17 13:14:26 +00:00
4d6b800385
Revert "Fix test not detecting tables with missing primary keys and missing replica identities, then add more replica identities. ( #16647 )" ( #16652 )
...
This reverts commit 830988ae72
2023-11-16 16:57:26 +00:00
ef5329a9f9
Revert "Add a Postgres `REPLICA IDENTITY` to tables that do not have an implicit one. This should allow use of Postgres logical replication. ( #16456 )" ( #16651 )
...
This reverts commit 69afe3f7a0
2023-11-16 16:48:48 +00:00
3e8531d3ba
Speed up deleting device messages ( #16643 )
...
Keeping track of a lower bound of stream ID where we've deleted everything below makes the queries much faster. Otherwise, every time we scan for rows to delete we'd re-scan across all the rows that have previously deleted (until the next table VACUUM).
2023-11-16 15:19:35 +00:00
1b238e8837
Speed up persisting large number of outliers ( #16649 )
...
Recalculating the roots tuple every iteration could be very expensive, so instead let's do a topological sort.
2023-11-16 14:25:35 +00:00
fef08cbee8
Fix sending out of order `POSITION` over replication ( #16639 )
...
If a worker reconnects to Redis we send out the current positions of all our streams. However, if we're also trying to send out a backlog of RDATA at the same time then we can end up sending a `POSITION` with the current token *before* we've sent all the RDATA before the current token.
This doesn't cause actual bugs as the receiving servers see the POSITION, fetch the relevant rows from the DB, and then ignore the old RDATA as they come in. However, this is inefficient so it'd be better if we didn't send out-of-order positions
2023-11-16 13:05:09 +00:00
898655fd12
More efficiently handle no-op POSITION ( #16640 )
...
We may receive `POSITION` commands where we already know that worker has
advanced past that position, so there is no point in handling it.
2023-11-16 12:32:17 +00:00
830988ae72
Fix test not detecting tables with missing primary keys and missing replica identities, then add more replica identities. ( #16647 )
...
* Fix the CI query that did not detect all cases of missing primary keys
* Add more missing REPLICA IDENTITY entries
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-11-16 12:26:27 +00:00
43d1aa75e8
Add an Admin API to temporarily grant the ability to update an existing cross-signing key without UIA ( #16634 )
2023-11-15 17:28:10 +00:00
999bd77d3a
Asynchronous Uploads ( #15503 )
...
Support asynchronous uploads as defined in MSC2246.
2023-11-15 09:19:24 -05:00
80922dc46e
Add links to pre-1.0 changelog issue/PR references. ( #16638 )
2023-11-15 13:31:24 +00:00
f2f2c7c1f0
Use full GitHub links instead of bare issue numbers. ( #16637 )
2023-11-15 08:02:11 -05:00
4dd18bdc2e
Improve documentation for `/_synapse/admin/v1/rooms/<room_id>/timestamp_to_event` ( #16631 )
2023-11-14 11:43:44 -05:00
0e36a57b60
Remove whole table locks on push rule add/delete ( #16051 )
...
The statements are already executed within a transaction thus a table
level lock is unnecessary.
2023-11-13 16:57:44 +00:00
69afe3f7a0
Add a Postgres `REPLICA IDENTITY` to tables that do not have an implicit one. This should allow use of Postgres logical replication. ( #16456 )
...
* Add Postgres replica identities to tables that don't have an implicit one
Fixes #16224
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Move the delta to version 83 as we missed the boat for 82
* Add a test that all tables have a REPLICA IDENTITY
* Extend the test to include when indices are deleted
* isort
* black
* Fully qualify `oid` as it is a 'hidden attribute' in Postgres 11
* Update tests/storage/test_database.py
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Add missed tables
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2023-11-13 16:03:22 +00:00
fb2554b11f
Fix outbound_federation_restricted_to docs & note when added ( #16628 )
2023-11-13 14:26:49 +00:00
2c6a7dfcbf
Use attempt_to_set_autocommit everywhere. ( #16615 )
...
To avoid asserting the type of the database connection.
2023-11-09 16:19:42 -05:00
dc7f068d9c
Fix a long-standing bug where Synapse would not unbind third-party identifiers for Application Service users when deactivated and would not emit a compliant response. ( #16617 )
...
* Don't skip unbinding 3PIDs and returning success status when deactivating AS user
Fixes #16608
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-11-09 20:18:25 +00:00
bc4372ad81
Use dbname instead of database for Postgres config. ( #16618 )
2023-11-09 14:40:45 -05:00
9f514dd0fb
Use _invalidate_cache_and_stream_bulk in more places. ( #16616 )
...
This takes advantage of the new bulk method in more places to
invalidate caches for many keys at once (and then to stream that
over replication).
2023-11-09 14:40:30 -05:00
ab3f1b3b53
Convert simple_select_one_txn and simple_select_one to return tuples. ( #16612 )
2023-11-09 11:13:31 -05:00
ff716b483b
Return attrs for more media repo APIs. ( #16611 )
2023-11-09 11:00:30 -05:00
91587d4cf9
Bulk-invalidate e2e cached queries after claiming keys ( #16613 )
...
Co-authored-by: Patrick Cloke <patrickc@matrix.org>
2023-11-09 15:57:09 +00:00
455ef04187
Avoid updating the same rows multiple times with simple_update_many_txn. ( #16609 )
...
simple_update_many_txn had a bug in it which would cause each
update to be applied twice.
2023-11-07 14:02:09 -05:00
9738b1c497
Avoid executing no-op queries. ( #16583 )
...
If simple_{insert,upsert,update}_many_txn is called without any data
to modify then return instead of executing the query.
This matches the behavior of simple_{select,delete}_many_txn.
2023-11-07 14:00:25 -05:00
ec9ff389f4
More tests for the simple_* methods. ( #16596 )
...
Expand tests for the simple_* database methods, additionally
test against both PostgreSQL and SQLite variants.
2023-11-07 09:34:23 -05:00
7e5d3b06fa
Collect information for PushRuleEvaluator in parallel. ( #16590 )
...
Fetch information needed for push rule evaluation in parallel.
Ideally this would use query pipelining, but this is not
available in psycopg2.
Due to the database thread pool this may result in little
to no parallelization.
2023-11-06 15:41:57 -05:00
1dd3074629
Bump setuptools_rust to match pinned version. ( #16605 )
2023-11-06 09:13:53 -05:00
cc4fe68adf
Support reactor timing metric on more reactors. ( #16532 )
...
Previously only Twisted's EPollReactor was compatible with the
reactor timing metric, notably not working when asyncio was used.
After this change, the following configurations support the reactor
timing metric:
* poll, epoll, or select reactors
* asyncio reactor with a poll, epoll, select, /dev/poll, or kqueue event loop.
2023-11-06 08:31:22 -05:00
92828a7f95
Simplify event persistence code ( #16584 )
...
The event persistence code used to handle multiple rooms
at a time, but was simplified to only ever be called with a
single room at a time (different rooms are now handled in
parallel). The code is still generic to multiple rooms causing
a lot of work that is unnecessary (e.g. unnecessary loops, and
partitioning data by room).
This strips out the ability to handle multiple rooms at once, greatly
simplifying the code.
2023-11-03 07:30:31 -04:00
0afbef30cf
Use simple_select_many_txn in event persistance code. ( #16585 )
...
Just to standardize on the normal helpers, it might also have
a slight perf improvement on PostgreSQL which will now use
`ANY (?)` instead of `IN (?, ?, ...)`.
2023-11-02 09:41:00 -04:00
c812f43bd7
Bump twisted from 23.8.0 to 23.10.0 ( #16588 )
2023-11-01 10:23:13 +00:00
ed1b879576
Do not call getfullargspec on every call. ( #16589 )
...
getfullargspec is relatively expensive and the results will
not change between calls, so precalculate it outside the
wrapper.
2023-10-31 20:16:17 +00:00
cfb6d38c47
Remove remaining usage of cursor_to_dict. ( #16564 )
2023-10-31 13:13:28 -04:00
4bb2b4aa9a
1.96.0rc1
2023-10-31 14:09:13 +00:00
60c5e8d79b
Revert "1.96.0rc1"
...
This reverts commit 4724a6ded1
2023-10-31 14:08:45 +00:00
4724a6ded1
1.96.0rc1
2023-10-31 13:47:08 +00:00
de981ae567
Claim local one-time-keys in bulk ( #16565 )
...
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2023-10-30 21:25:21 +00:00
91aa52c911
Clients link fixed in README ( #16569 )
2023-10-30 16:05:34 +00:00
408c13801a
Add fast path for replication events stream fetch ( #16580 )
...
We can bail early if the from token is greater than or equal to the
current token.
2023-10-30 14:47:57 +00:00
fdce83ee60
Claim fallback keys in bulk ( #16570 )
2023-10-30 14:34:37 +00:00
a3f6200d65
Bump setuptools-rust from 1.7.0 to 1.8.0 ( #16574 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Robertson <davidr@element.io>
2023-10-30 13:40:17 +00:00
4e1a19d375
Run actions/setup-go after checking out complement ( #16567 )
2023-10-30 13:07:08 +00:00
8c63e93286
Fix HTTP repl response to use minimum token ( #16578 )
2023-10-30 12:27:14 +00:00
747416e94c
Portdb: don't copy a table that gets rebuilt ( #16563 )
2023-10-27 20:14:02 +01:00
11a8ae0632
complement: enable dirty runs ( #16520 )
...
* complement: enable dirty runs
* Add changelog
* Set a low connpool limit when running in Complement
Dirty runs can cause many containers to be running concurrently,
which seems to easily exhaust resources on the host. The increased
speedup from dirty runs also seems to use more db connections on
workers, which are misconfigured currently to have
`SUM(workers * cp_max) > max_connections`, causing
```
FATAL: sorry, too many clients already
```
which results in tests failing.
* Try p=2 concurrency to restrict slowness of servers which causes partial state join tests to flake
* Debug logging
* Only run flakey tests
* Only adjust connection pool limits in worker mode
* Move cp vars to somewhere where they get executed in CI
* Move cp values back to where they actually work
* Debug logging
* Try p=1 to see if this makes worker mode happier
* Remove debug logging
2023-10-27 18:29:20 +01:00
2bf9341406
Ensure local invited & knocking users leave before purge. ( #16559 )
...
This is mostly useful for federated rooms where some users
would get stuck in the invite or knock state when the room
was purged from their homeserver.
2023-10-27 12:50:50 -04:00
5413cefe32
Reduce amount of caches POSITIONS we send ( #16561 )
...
Follow on from / actually correctly does #16557
2023-10-27 16:07:11 +01:00
89dbbd68e1
Reduce spurious replication catchup ( #16555 )
2023-10-27 13:27:20 +00:00
928e964857
Fix cross-worker ratelimiting ( #16558 )
...
c.f. #16481
2023-10-27 12:52:40 +01:00
0680d76659
Reduce replication traffic due to reflected cache stream POSITION ( #16557 )
2023-10-27 12:51:08 +01:00
c02406ac71
Add new module API for adding custom fields to events `unsigned` section ( #16549 )
2023-10-27 09:04:08 +00:00
679c691f6f
Remove more usages of cursor_to_dict. ( #16551 )
...
Mostly to improve type safety.
2023-10-26 15:12:28 -04:00
85e5f2dc25
Add a new module API to update user presence state. ( #16544 )
...
This adds a module API which allows a module to update a user's
presence state/status message. This is useful for controlling presence
from an external system.
To fully control presence from the module the presence.enabled config
parameter gains a new state of "untracked" which disables internal tracking
of presence changes via user actions, etc. Only updates from the module will
be persisted and sent down sync properly).
2023-10-26 15:11:24 -04:00
9407d5ba78
Convert simple_select_list and simple_select_list_txn to return lists of tuples ( #16505 )
...
This should use fewer allocations and improves type hints.
2023-10-26 13:01:36 -04:00
c14a7de6af
Pin the recommended poetry version in contributors' guide ( #16550 )
2023-10-25 16:31:15 +01:00
ba47fea528
Allow multiple workers to write to receipts stream. ( #16432 )
...
Fixes #16417
2023-10-25 16:16:19 +01:00
e182dbb5b9
Fix tests on Twisted trunk. ( #16528 )
...
Twisted trunk makes a change to the `TLSMemoryBIOFactory` where
the underlying protocol is changed from `TLSMemoryBIOProtocol` to
`BufferingTLSTransport` to improve performance of TLS code (see
https://github.com/twisted/twisted/issues/11989 ).
In order to properly hook this code up in tests we need to pass the test
reactor's clock into `TLSMemoryBIOFactory` to avoid the global (trial)
reactor being used by default.
Twisted does something similar internally for tests:
157cd8e659/src/twisted/web/test/test_agent.py (L871-L874)
2023-10-25 07:39:45 -04:00
95076f77c1
Fix http/s proxy authentication with long username/passwords ( #16504 )
2023-10-24 13:45:21 +00:00
6ec98810e3
Rework alias and public room list rules docs ( #16541 )
2023-10-24 13:26:41 +01:00
ffbe9b7666
Remove duplicate call to wake a remote destination when using federation sending worker ( #16515 )
2023-10-24 08:09:59 -04:00
3df70aa800
Replace all Prometheus datasource UIDs of the Grafana Dashboard with the variable `${DS_PROMETHEUS}` and remove `__inputs` ( #16471 )
2023-10-23 19:50:50 +01:00
3ab861ab9e
Fix type hint errors from Twisted trunk ( #16526 )
2023-10-23 14:28:05 -04:00
8f35f8148e
Fix bug where a new writer advances their token too quickly ( #16473 )
...
* Fix bug where a new writer advances their token too quickly
When starting a new writer (for e.g. persisting events), the
`MultiWriterIdGenerator` doesn't have a minimum token for it as there
are no rows matching that new writer in the DB.
This results in the the first stream ID it acquired being announced as
persisted *before* it actually finishes persisting, if another writer
gets and persists a subsequent stream ID. This is due to the logic of
setting the minimum persisted position to the minimum known position of
across all writers, and the new writer starts off not being considered.
* Fix sending out POSITIONs when our token advances without update
Broke in #14820
* For replication HTTP requests, only wait for minimal position
2023-10-23 16:57:30 +01:00
3bc23cc45c
Fix bug that could cause a `/sync` to tightloop with sqlite after restart ( #16540 )
...
This could happen if the last rows in the account data stream were inserted into `account_data`. After a restart the max account ID would be calculated without looking at the `account_data` table, and so have an old ID.
2023-10-23 13:39:25 +00:00
3bcb6a059f
Mention how to redirect the Jaeger traces to a specific Jaeger instance ( #16531 )
2023-10-23 11:55:36 +00:00
3a0aa6fe76
Force TLS certificate verification in registration script. ( #16530 )
...
If using the script remotely, there's no particularly convincing reason
to disable certificate verification, as this makes the connection
interceptible.
If on the other hand, the script is used locally (the most common use
case), you can simply target the HTTP listener and avoid TLS altogether.
This is what the script already attempts to do if passed a homeserver
configuration YAML file.
2023-10-23 07:38:51 -04:00
12ca87f5ea
Remove the last reference to event_txn_id. ( #16521 )
...
This table was no longer used, except for a background process
which purged old entries in it.
2023-10-23 07:37:45 -04:00
478a6c65eb
Bump matrix-synapse-ldap3 from 0.2.2 to 0.3.0 ( #16539 )
2023-10-23 12:28:29 +01:00
d2eab22de7
Clarify presence router docs. ( #16529 )
2023-10-20 11:40:26 -04:00
e9069c9f91
Mark sync as limited if there is a gap in the timeline ( #16485 )
...
This splits thinsg into two queries, but most of the time we won't have
new event backwards extremities so this shouldn't actually add an extra
RTT for the majority of cases.
Note this removes the check for events with no prev events, but that was
part of MSC2716 work that has since been removed.
2023-10-19 15:04:18 +01:00
49c9745b45
Avoid sending massive replication updates when purging a room. ( #16510 )
2023-10-18 12:26:01 -04:00
bcff01b406
Improve performance of delete device messages query ( #16492 )
2023-10-18 16:42:01 +01:00
8841db4d27
Run trial/integration tests if .ci is modified. ( #16512 )
2023-10-18 07:19:53 -04:00
68d9559fef
Test against Python 3.12 release ( #16511 )
2023-10-17 14:41:10 -04:00
6e6d611f55
1.95.0rc1
2023-10-17 11:54:45 -04:00
6ad1f9eac2
Convert DeviceLastConnectionInfo to attrs. ( #16507 )
...
To improve type safety & memory usage.
2023-10-17 12:47:42 +00:00
77dfc1f939
Fix a bug where servers could be marked as up when they were failing ( #16506 )
...
After this change a server will only be reported as back online
if they were previously having requests fail.
2023-10-17 07:32:40 -04:00
7291c68eea
Update the release script to remind releaser to check for special release notes. ( #16461 )
...
* Add reminder to check special release notes board in release script
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Update release.py
* Bah, black
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-10-16 15:22:50 +01:00
e3e0ae4ab1
Convert state delta processing from a dict to attrs. ( #16469 )
...
For improved type checking & memory usage.
2023-10-16 07:35:22 -04:00
eee6474bce
Remove useless async job to delete device messages on sync ( #16491 )
2023-10-16 11:06:27 +01:00
109882230c
Clean up logging on event persister endpoints ( #16488 )
2023-10-14 17:57:27 +01:00
166ffc0f23
Fix typo in useful_sql_for_admins.md ( #16477 )
2023-10-12 16:18:32 +01:00
4cc729d480
Revert "Drop unused tables & unneeded access token ID for events. ( #16268 )" ( #16465 )
...
This reverts commit cabd577460
2023-10-12 08:56:10 -04:00
f710d5480b
Update complement.sh to match new public API shape ( #16466 )
...
* Update complement.sh to match new public API shape
Sister PR to https://github.com/matrix-org/complement/pull/666
Context: https://github.com/matrix-org/complement/issues/654#issuecomment-1746613495
* Changelog
* Pedantry
* Run complement plz
2023-10-12 11:33:14 +01:00
cc865fffc0
Convert user_get_threepids response to attrs. ( #16468 )
...
This improves type annotations by not having a dictionary of Any values.
2023-10-11 20:08:11 -04:00
a4904dcb04
Convert simple_select_many_batch, simple_select_many_txn to tuples. ( #16444 )
2023-10-11 13:24:56 -04:00
d6b7d49a61
Handle content types with parameters. ( #16440 )
2023-10-11 07:50:34 -04:00
f1e43018b7
Inline simple_search_list/simple_search_list_txn. ( #16434 )
...
This only has a single use and is over abstracted. Inline it so that
we can improve type hints.
2023-10-10 12:16:36 -04:00
28fd28e92e
Add DB indices to speed up purging rooms ( #16457 )
2023-10-10 10:33:39 +01:00
8902b3031d
Disable statement timeout whilst purging rooms ( #16455 )
...
* Disable statement timeout whilst purging rooms
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Note the introduction version
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-10-09 15:41:17 +01:00
a6abee36bc
Don't block CI on sign-off ( #16454 )
...
As this doesn't work with the private sign off flow.
2023-10-09 12:22:54 +01:00
32fd9bc673
Fix possible AttributeError when account-api is called over unix socket ( #16404 )
...
Fixes #16396
2023-10-09 10:16:07 +01:00
1f10c20806
Apply join rate limiter outside the lineariser ( #16441 )
2023-10-06 17:31:52 +00:00
06bbf1029c
Convert simple_select_list_paginate_txn to return tuples. ( #16433 )
2023-10-06 11:41:57 -04:00
7615e2bf48
Return ThumbnailInfo in more places ( #16438 )
...
Improves type hints by using concrete types instead of
dictionaries.
2023-10-06 10:12:43 -04:00
cabd577460
Drop unused tables & unneeded access token ID for events. ( #16268 )
...
Drop the event_txn_id table and the tables related to MSC2716,
which is no longer supported in Synapse.
2023-10-06 08:29:33 -04:00
fc31b495b3
Stop sending incorrect knock_state_events. ( #16403 )
...
Synapse was incorrectly implemented with a knock_state_events
property on some APIs (instead of knock_room_state). This was
correct in Synapse 1.70.0, but *both* fields were sent to also be
compatible with Synapse versions expecting the wrong field.
Enough time has passed that only the correct field needs to be
included/handled.
2023-10-06 07:27:35 -04:00
ae5b997cfa
Fix comments related to replication. ( #16428 )
2023-10-06 07:25:44 -04:00
694802eecd
Add documentation on background updates. ( #16420 )
2023-10-06 07:23:20 -04:00
26b960b08b
Register media servlets via regex. ( #16419 )
...
This converts the media servlet URLs in the same way as
(most) of the rest of Synapse. This will give more flexibility
in the versions each endpoint exists under.
2023-10-06 07:22:55 -04:00
5946074d69
Bump pyo3 from 0.17.1 to 0.19.2 ( #16162 )
...
Signed-off-by: Kai A. Hiller <V02460@gmail.com>
2023-10-06 11:27:59 +01:00
3555790b27
Remove unused method. ( #16435 )
2023-10-05 17:42:44 -04:00
fa907025f4
Remove manys calls to cursor_to_dict ( #16431 )
...
This avoids calling cursor_to_dict and then immediately
unpacking the values in the dict for other users. By not
creating the intermediate dictionary we can avoid allocating
the dictionary and strings for the keys, which should generally
be more performant.
Additionally this improves type hints by avoid Dict[str, Any]
dictionaries coming out of the database layer.
2023-10-05 11:07:38 -04:00
4e302b30b6
Add __slots__ to replication commands. ( #16429 )
...
To slightly reduce the amount of memory each command takes.
2023-10-05 07:38:55 -04:00
009b47badf
Factor out `MultiWriter` token from `RoomStreamToken` ( #16427 )
2023-10-05 10:46:28 +01:00
ab9c1e8f39
Add type hints to synmark. ( #16421 )
2023-10-04 13:53:04 -04:00
80ec81dcc5
Some refactors around receipts stream ( #16426 )
2023-10-04 16:28:40 +01:00
8b50a9d01d
1.94.0rc1
2023-10-03 11:50:57 +01:00
1e67191a79
Add note to 'federation_domain_whitelist' option ( #16416 )
2023-10-03 09:55:29 +01:00
127b940dc0
Clean-up old release notes ( #16418 )
...
Fixes some broken formatting from the reStructuedText to Markdown
conversion and fixes some typos.
2023-10-02 11:05:29 -04:00
1026776380
mypy plugin to check `@cached` return types ( #14911 )
...
Co-authored-by: David Robertson <davidr@element.io>
Co-authored-by: Patrick Cloke <patrickc@matrix.org>
Co-authored-by: Erik Johnston <erik@matrix.org>
Assert that the return type of callables wrapped in @cached
and @cachedList are cachable (aka immutable).
2023-10-02 14:22:36 +00:00
5725712d47
Remove Python version from `/_synapse/admin/v1/server_version` ( #16380 )
...
There's no reason to expose the full Python version over what is
frequently a public API.
2023-10-02 09:07:53 -04:00
20fb08ec80
Downgrade repl stream time out error to warning ( #16401 )
...
This is because if a worker reaches ~100% CPU then everything starts
lagging and we hit the log line a lot. When at error we invoke sentry
and that has a lot of overhead, which then puts even more pressure on
the worker.
2023-09-29 11:52:48 +00:00
79eb6c0cdc
Support rendering some media downloads as inline ( #15988 )
...
Use an `inline` Content-Disposition header when the media is
"safe" to display inline (some known text, image, video, audio
formats).
2023-09-29 07:19:38 -04:00
fb664cf159
Remove warnings from the docs about using message retention. ( #16382 )
...
There are no known bugs in the message retention code, but
it is possible that there still exists race conditions. Additional
fixes will be made as reported.
2023-09-28 07:02:31 -04:00
cdb89dcefe
Improve state types. ( #16395 )
2023-09-28 07:01:46 -04:00
c690fd16c4
Use modern config for maturin. ( #16394 )
...
This allows maturin >= 0.15 to build the properly named
shared library object.
For now the old configuration is also kept to allow for
older maturin installs to be used.
2023-09-28 07:01:16 -04:00
f84da3c32e
Add a cache around server ACL checking ( #16360 )
...
* Pre-compiles the server ACLs onto an object per room and
invalidates them when new events come in.
* Converts the server ACL checking into Rust.
2023-09-26 11:57:50 -04:00
17800a0e97
Implement MSC4028: push all encrypted events. ( #16361 )
...
This unstable push rule is implemented behind an experimental
configuration flag.
2023-09-26 11:52:19 -04:00
06f650f5f4
Skip export-data on non-code (e.g. docs) PRs ( #16387 )
2023-09-26 15:21:07 +01:00
ec1c709440
Add documentation about the user directory search algorithm ( #16320 )
2023-09-26 13:44:38 +00:00
47ffc7e548
Reduce calls to `send_presence_to_destinations` ( #16385 )
2023-09-26 11:49:44 +01:00
2763c49eca
Improve comments in StateGroupBackgroundUpdateStore. ( #16383 )
2023-09-25 18:50:47 +00:00
9fd18e9b06
Add developer documentation concerning gradual schema migrations with column alterations. ( #15691 )
...
Co-authored-by: Eric Eastwood <erice@element.io>
2023-09-25 17:43:09 +00:00
525d9d6e11
Avoid running CI steps when the files they check have not been changed. ( #14745 )
2023-09-25 16:59:40 +00:00
b225acf3e6
Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14 ( #16381 )
...
* Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14
Bumps [types-psycopg2](https://github.com/python/typeshed ) from 2.9.21.11 to 2.9.21.14.
- [Commits](https://github.com/python/typeshed/commits )
---
updated-dependencies:
- dependency-name: types-psycopg2
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Relax the annotation of Cursor.description
See
https://github.com/matrix-org/synapse/pull/16343#issuecomment-1726083384
for rationale.
* Changelog
* Changelog
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Robertson <davidr@element.io>
2023-09-25 17:48:42 +01:00
12611bfcdd
Add support for pydantic v2 via pydantic.v1 compat module ( #16332 )
...
While maintaining support with pydantic v1.
2023-09-25 15:19:08 +00:00
fad4c63d25
Get CI to check PRs have been signed-off ( #16348 )
2023-09-25 14:45:17 +00:00
c9a0e1673a
Add missing license header. ( #16359 )
2023-09-21 09:47:29 -04:00
7ec0a141b4
Convert more cached return values to immutable types ( #16356 )
2023-09-20 07:48:55 -04:00
d7c89c5908
Return immutable objects for cachedList decorators ( #16350 )
2023-09-19 15:26:44 -04:00
5a66ff2f5c
Merge branch 'release-v1.93' into develop
2023-09-19 10:33:22 -04:00
9fabde6ead
Fix-up deactivated notes in docs. ( #16355 )
2023-09-19 08:05:33 -04:00
9caeb9be10
1.93.0rc1
2023-09-19 07:56:49 -04:00
3d60b07cde
Use string for federation_client_minimum_tls_version documentation examples ( #16353 )
2023-09-19 07:24:47 -04:00
118036eeab
Test against PostgreSQL 16. ( #16351 )
2023-09-18 13:21:00 -04:00
47d4bb6057
Stop patching EventBase.__eq__ in tests. ( #16349 )
...
It is clearer to directly test equality instead of doing indirect
assertions via patching __eq__.
2023-09-18 14:48:02 +00:00
eef2b9e344
Filter locked users in the admin API ( #16328 )
...
Co-authored-by: Hanadi Tamimi <hanadi.tamimi@sdui.de>
2023-09-18 15:37:51 +01:00
c1e244c8f7
Make cached account data/tags/admin types immutable ( #16325 )
2023-09-18 09:55:04 -04:00
85bfd4735e
Return an immutable value from get_latest_event_ids_in_room. ( #16326 )
2023-09-18 09:29:05 -04:00
63d28a88c1
Additional validation of receipts ( #16327 )
...
Reject invalid receipts with a reasonable error message &
expands tests for receipts.
2023-09-18 13:02:12 +00:00
4663d55502
Mandate Pillow>=10.0.1 because of libwebp CVE ( #16347 )
2023-09-18 15:01:23 +02:00
6946209e67
Set email charset as utf-8 rather than utf8 ( #16329 )
2023-09-18 07:32:01 -04:00
dd44ee00b6
Add automatic purge after all users forget a room ( #15488 )
...
Also add restore of purge/shutdown rooms after a synapse restart.
Co-authored-by: Eric Eastwood <erice@matrix.org>
Co-authored-by: Erik Johnston <erikj@matrix.org>
2023-09-15 15:37:44 +02:00
2a0f86f88f
Convert `_insert_graph_receipts_txn` to `simple_upsert` ( #16299 )
2023-09-15 09:16:45 +01:00
edec0b93ca
Only use literal strings for process names ( #16315 )
2023-09-15 09:10:24 +01:00
329597022e
Some minor performance fixes for task schedular ( #16313 )
2023-09-14 16:20:47 +01:00
e9e2904eb2
Speed up deleting to-device messages task ( #16318 )
2023-09-14 14:56:07 +01:00
39dc5de399
docs: Link to the Alpine Linux community package for Synapse ( #16304 )
2023-09-14 14:13:48 +01:00
954921736b
Refactor `get_user_by_id` ( #16316 )
2023-09-14 12:46:30 +01:00
032cf84f52
Remove a reference cycle in background process ( #16314 )
2023-09-13 16:17:06 +01:00
7afb5e0410
Fix using dehydrated devices (MSC2697) & refresh tokens ( #16288 )
...
Refresh tokens were not correctly moved to the rehydrated
device (similar to how the access token is currently handled).
This resulted in invalid refresh tokens after rehydration.
2023-09-13 08:33:39 -04:00
d38d0dffc9
Use StrCollection in additional places. ( #16301 )
2023-09-13 07:57:19 -04:00
e9addf6a01
Don't schedule an async task on every sync ( #16312 )
2023-09-13 11:59:44 +01:00
be3c7b08a3
Fix deleting device inbox when using background worker ( #16311 )
...
Introduced in #16240
The action for the task was only defined on the "master" handler, rather than the base worker one.
2023-09-13 11:54:16 +01:00
ab13fb08bf
Improve logging of replication ( #16309 )
2023-09-13 09:51:50 +00:00
12bee2dcc2
Merge branch 'master' into develop
2023-09-12 15:22:26 +02:00
ba48c563c9
Bump mypy from 1.4.1 to 1.5.1. ( #16300 )
2023-09-12 07:16:09 -04:00
16ef6f1e3c
Stop purging tables which are slated for removal. ( #16273 )
2023-09-12 07:12:31 -04:00
2b35626b6b
Refactor storing of server keys ( #16261 )
2023-09-12 11:08:04 +01:00
efe778a0b8
1.92.0
2023-09-12 11:59:35 +02:00
9400dc0535
Add the List-Unsubscribe header for notification emails. ( #16274 )
...
Adds both the List-Unsubscribe (RFC2369) and List-Unsubscribe-Post (RFC8058)
headers to push notification emails, which together should:
* Show an "Unsubscribe" link in the MUA UI when viewing Synapse notification emails.
* Enable "one-click" unsubscribe (the user never leaves their MUA, which automatically
makes a POST request to the specified endpoint).
2023-09-11 09:49:48 -04:00
151e4bbc45
Filter out down hosts when retrying fetching device lists ( #16298 )
2023-09-11 13:11:02 +01:00
edd83f23b7
Improve type hints for attrs classes ( #16276 )
2023-09-08 19:29:38 +01:00
a0ed55ef12
Upgrade CI run of Python 3.12 from rc1 to rc2 ( #16280 )
2023-09-08 12:55:43 -04:00
aa483cb4c9
Update ruff config ( #16283 )
...
Enable additional checks & clean-up unneeded configuration.
2023-09-08 11:24:36 -04:00
c1c6c95d72
Log values at DEBUG level with execute_values ( #16281 )
2023-09-08 14:50:13 +01:00
5c8870cb28
Fix-up incorrect spellings in docs. ( #16282 )
2023-09-08 09:47:36 -04:00
f43d994624
Fix bug with new task scheduler using lots of CPU. ( #16278 )
...
Using the new `TaskScheduler` meant that we'ed create lots of new
metrics (due to adding task ID to the desc of background process),
resulting in requests for metrics taking an increasing amount of CPU.
2023-09-08 14:43:01 +01:00
69b74d9330
Avoid temporary storage of sensitive information. ( #16272 )
...
During the UI auth process, avoid storing sensitive information
into the database.
2023-09-08 08:57:56 -04:00
583d5963e6
Raise setuptools_rust version cap to 1.7.0 ( #16277 )
2023-09-08 08:10:26 -04:00
d23c394669
Reduce CPU overhead of change password endpoint ( #16264 )
2023-09-08 13:06:00 +01:00
1cd410a783
Recheck if remote device is cached before requesting it ( #16252 )
...
This fixes a bug where we could get stuck re-requesting the device over
replication again and again.
2023-09-07 12:45:43 +00:00
7e98d382f9
Support releasing on macOS. ( #16266 )
2023-09-07 07:00:41 -04:00
8940d1b28e
Add `/notifications` endpoint to workers ( #16265 )
2023-09-07 09:26:07 +00:00
13e9cad537
Send the opentracing span information to appservices ( #16227 )
2023-09-06 15:19:17 -04:00
fe69e7f617
Handle "registration_enabled" parameter for CAS ( #16262 )
...
Similar to OIDC, CAS providers can now disable registration such
that only existing users are able to login via SSO.
2023-09-06 14:32:24 -04:00
32fb264120
Merge remote-tracking branch 'origin/release-v1.92' into develop
2023-09-06 13:08:22 -04:00
fd50a9b47c
Add back newsfile from #16258 .
2023-09-06 13:06:33 -04:00
51303035f2
Apply missed suggestions from the review of #16090 . ( #16263 )
...
* Suggestions from PR
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-09-06 16:15:56 +01:00
35934b02a9
Add GCC and GNU Make to the Nix flake development environment so that `ruff` can be compiled. ( #16090 )
...
* Add gcc and GNU make to the Nix flake
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* unset LD_LIBRARY_PATH
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-09-06 14:35:02 +01:00
ffe4ea1302
Update rust in flake.nix: 1.70.0 -> 1.71.1 to address CVE-2023-38497 ( #16260 )
2023-09-06 14:34:01 +01:00
e937e2111a
Add the ability to use `G` (GiB) and `T` (TiB) suffixes in configuration options that refer to numbers of bytes. ( #16219 )
...
* Add more suffixes to `parse_size`
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-09-06 14:01:10 +01:00
698f6fa250
Allow modules to delete rooms. ( #15997 )
...
* Allow user_id to be optional for room deletion
* Add module API method to delete a room
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Don't worry about the case block=True && requester_user_id is None
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-09-06 11:50:07 +01:00
4f1840a88a
Delete device messages asynchronously and in staged batches ( #16240 )
2023-09-06 09:30:53 +02:00
1e571cd664
Fix appservices being unable to handle to_device messages for multiple users ( #16251 )
2023-09-05 15:46:57 -04:00
b1d71c687a
Add MSC4040 `matrix-fed` service lookups ( #16137 )
2023-09-05 15:45:39 -04:00
c9cec2daed
Fix bug where we kept re-requesting a remote server's key repeatedly. ( #16257 )
...
* Correctly handle multiple rows per server/key
* Newsfile
2023-09-05 20:27:41 +01:00
a2b8814d64
Fix incorrect docstring for Ratelimiter. ( #16255 )
2023-09-05 12:11:05 -04:00
Charles Wright