8956e90c63
Merge pull request #5731
...
c393e82
2019-08-21 15:09:48 -05:00
65e937168e
Merge pull request #5722
...
8be5fea
2019-08-21 15:08:10 -05:00
e353e3d757
p2p: sanitize peer lists
...
Also remove the delta time fixup, since we now ignore those
as they're attacker controlled
2019-08-21 15:54:27 +00:00
2e2653602f
p2p: move log away from global
...
It was here while debugging, and I forgot to move it away
2019-08-21 14:00:43 +00:00
8703aa59db
MMS: Use chans instead of normal addresses for auto-config
2019-08-20 19:55:31 +02:00
26f7a26ee3
device: fix ledger requesting secret keys export twice
2019-08-20 16:08:09 +00:00
289d21500c
rpc: fix unitialized 'core_rpc_server::m_was_bootstrap_ever_used'
2019-08-20 15:08:48 +00:00
5a4c6cc3a8
daemon: fix merge error removing the "never seen before" timestamp check
2019-08-20 12:48:55 +00:00
c9df9d683a
Merge pull request #5696
...
fd60d05
2019-08-20 01:50:10 -05:00
30779de39d
fix feature not introduced until boost 1.66
2019-08-20 01:06:59 -04:00
fd60d05d5d
daemon: fix print_pl only printing public zone peers
2019-08-19 23:39:51 +00:00
4947f3bdba
Merge pull request #5636
...
b712ae0
2019-08-19 17:37:37 -05:00
56b98c7003
Merge pull request #5728
...
6560bfa
2019-08-19 17:33:08 -05:00
f205d28e96
Merge pull request #5727
...
7b9a420
2019-08-19 17:31:39 -05:00
4baec08d5c
Merge pull request #5725
...
dc8b7a8
2019-08-19 17:29:38 -05:00
1010a6503e
Merge pull request #5721
...
c164f90
2019-08-19 17:25:52 -05:00
1499caf596
Merge pull request #5720
...
bcd2da7
2019-08-19 17:18:04 -05:00
2da11baecc
Merge pull request #5718
...
c8709fe7b18e83
2019-08-19 17:17:11 -05:00
d22dfb7594
blockchain: reject rct signatures in coinbase txes from v12
2019-08-19 16:43:53 +00:00
555dc7c394
core: from v12, require consistent ring size for mixable txes
...
We're supposed to have a fixed ring size now
Already checked by MLSAG verification, but here seems more intuitive
2019-08-19 16:43:53 +00:00
26072f1393
blockchain: forbid v1 coinbase from v12
2019-08-19 16:43:52 +00:00
839fc6256b
reject setting lookahead major or minor to 0
2019-08-19 15:35:12 +00:00
07cb087e5d
blockchain: Fix alt chain generated coins overflow
...
Apply the overflow logic used for computing already_generated_coins in
the main chain to alternative chains.
2019-08-18 17:26:58 -07:00
50ec40ea16
Increase max_dbs from 20 to 32
...
We've added a lot of new indices recently, and 20 isn't enough for them plus
new DBs opened during format migrations.
2019-08-18 17:10:45 +01:00
459beb50d4
Merge pull request #5685
...
a604241
2019-08-17 15:27:21 -05:00
12d08dcbf5
Merge pull request #5518
...
def703a
2019-08-17 15:24:02 -05:00
adc16d2504
Fix check for disconnecting peers when syncing
...
The check added here (in #5732/#5733) is supposed to disconnect behind
peers when the current node is syncing, but actually disconnects behind
peers always.
We are syncing when `target > our_height`, but the check here triggers
when `target > remote_height`, which is basically always true when the
preceding `m_core.have_block(hshd.top_id)` check is true.
2019-08-16 21:16:33 -03:00
def703abec
wallet_api: add multi destination tx support
2019-08-16 16:23:12 +02:00
399a847cfc
Merge pull request #5689
...
1db5357
2019-08-15 17:29:34 -05:00
017162b5b2
Merge pull request #5682
...
3768db2
2019-08-15 17:27:30 -05:00
8a0711f2f2
Merge pull request #5674
...
fcbf7b3098aadf
2019-08-15 17:22:39 -05:00
6b6593dad9
Merge pull request #5673
...
097cca5
2019-08-15 17:21:26 -05:00
1a259a1c70
Merge pull request #5672
...
b2bfcab
2019-08-15 17:20:18 -05:00
739b02ef38
Merge pull request #5662
...
64fb0f8
2019-08-15 17:19:12 -05:00
48229234a9
Merge pull request #5659
...
6bb2797
2019-08-15 17:17:36 -05:00
c5e926676a
Merge pull request #5656
...
8ccc30b
2019-08-15 17:14:58 -05:00
df064eaa36
Merge pull request #5649
...
a182df2
2019-08-15 17:10:49 -05:00
1167370239
Merge pull request #5637
...
69f9420
2019-08-15 17:09:15 -05:00
7b9a420787
Replace std::random_shuffle with std::shuffle
...
According to [1], std::random_shuffle is deprecated in C++14 and removed
in C++17. Since std::shuffle is available since C++11 as a replacement
and monero already requires C++11, this is a good replacement.
A cryptographically secure random number generator is used in all cases
to prevent people from perhaps copying an insecure std::shuffle call
over to a place where a secure one would be warranted. A form of
defense-in-depth.
[1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
2019-08-15 16:33:15 +02:00
0ba675622f
Merge pull request #5634
...
1488109
2019-08-14 15:35:24 -05:00
0e986a86d5
Merge pull request #5607
...
52cd2fa
2019-08-14 15:34:14 -05:00
564bb1da3a
Merge pull request #5525
...
06054064228ee0880ebfd
2019-08-14 15:31:52 -05:00
2258551ef9
Merge pull request #5487
...
df83ed7
2019-08-14 15:26:55 -05:00
dd3b5ecb98
Merge pull request #5478
...
7d9b7fe
2019-08-14 15:23:31 -05:00
e37e263fcd
Merge pull request #4851
...
155475d
2019-08-14 15:21:47 -05:00
ae7bf37ed6
simplewallet: fix arg indexing bug in set_device_name
2019-08-13 18:10:32 +09:00
5a91b83cb4
simplewallet: add a few missing settings help text
2019-08-13 17:55:41 +09:00
4b1df4e50f
Fix for biased signature nonce
2019-08-12 15:58:15 -04:00
69465e3d83
cryptonote_protocol: fix '--no-sync', ignore new blocks and txes
2019-08-11 20:56:30 +00:00
6ca033d278
hid_error() could return a null, which causes the program to crash with
...
std::logic_error()
2019-08-09 21:24:48 +02:00
155475d971
Add IPv6 support
...
new cli options (RPC ones also apply to wallet):
--p2p-bind-ipv6-address (default = "::")
--p2p-bind-port-ipv6 (default same as ipv4 port for given nettype)
--rpc-bind-ipv6-address (default = "::1")
--p2p-use-ipv6 (default false)
--rpc-use-ipv6 (default false)
--p2p-require-ipv4 (default true, if ipv4 bind fails and this is
true, will not continue even if ipv6 bind
successful)
--rpc-require-ipv4 (default true, description as above)
ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except
in the cases of the cli args for bind address. For those the square
braces can be omitted.
2019-07-31 20:04:57 -04:00
6bb279710c
daemon: print 128bit diff properly
2019-07-30 05:37:38 -07:00
7d9b7fee43
functional_tests: add validate_address tests
2019-07-29 14:29:20 +00:00
52cd2fa0af
rpc: implement get_public_nodes command
2019-07-29 10:51:15 +00:00
6da3561e2a
Fixed error preventing build of monero-gui
...
get_attribute expects 2 values instead of 1
2019-07-28 16:03:45 +02:00
8adde33e01
Merge pull request #5635
...
03aa14e
2019-07-24 14:43:00 -05:00
bb37e434fc
Merge pull request #5624
...
6b41bd8
2019-07-24 14:39:40 -05:00
d4d5a4433d
Merge pull request #5623
...
b8cfa92
2019-07-24 14:38:15 -05:00
61512cf798
Merge pull request #5610
...
068fa1c
2019-07-24 14:35:11 -05:00
5030b8e8aa
Merge pull request #5608
...
c820e18
2019-07-24 14:33:36 -05:00
e05873d873
Merge pull request #5606
...
cf8cb68
2019-07-24 14:31:59 -05:00
c4071a00fb
Merge pull request #5600
...
dd58057
2019-07-24 14:29:10 -05:00
015c1792c0
Merge pull request #5597
...
343c0b4
2019-07-24 14:26:59 -05:00
8774555d29
Merge pull request #5595
...
2aa1134
2019-07-24 14:25:51 -05:00
8ae2681e08
Merge pull request #5594
...
f074b6b
2019-07-24 14:24:40 -05:00
c62ba1d08f
Merge pull request #5591
...
f17dcde
2019-07-24 14:23:11 -05:00
96cda93a93
Merge pull request #5588
...
cd720c7
2019-07-24 14:20:12 -05:00
9f746b72e2
Merge pull request #5585
...
270a3ae
2019-07-24 14:19:15 -05:00
e241a6280d
Merge pull request #5582
...
fcfcc3a
2019-07-24 14:18:09 -05:00
8600b3c69d
Merge pull request #5576
...
577324a
2019-07-24 14:16:00 -05:00
f1427568dc
Merge pull request #5574
...
162c3e1
2019-07-24 14:14:35 -05:00
5cecf4138b
Merge pull request #5573
...
c07bbd5
2019-07-24 14:13:33 -05:00
b333513db7
Merge pull request #5534
...
4c66614
2019-07-24 14:09:58 -05:00
e579fe4ae0
Merge pull request #5530
...
6abaaaa
2019-07-24 14:07:29 -05:00
4b76656f5c
Merge pull request #5524
...
06b8f29
2019-07-24 14:04:16 -05:00
7138f9d347
Merge pull request #5514
...
e4d100b
2019-07-24 14:00:54 -05:00
407683a38c
Merge pull request #5513
...
bc94ba4
2019-07-24 13:59:19 -05:00
e3de4aa68b
Merge pull request #5502
...
25a7cfd1a66a86
2019-07-24 13:57:06 -05:00
d433abfe01
Merge pull request #5460
...
a23dbe6
2019-07-24 13:52:29 -05:00
705fbcfda4
Merge pull request #5457
...
3b9ce45
2019-07-24 13:51:18 -05:00
e8da2f35ad
Merge pull request #5451
...
6aa3c2f
2019-07-24 13:49:57 -05:00
1880c1a582
Merge pull request #5363
...
515ac2965c4004
2019-07-24 13:47:41 -05:00
f91a06c6d7
Dropping cppzmq dependency; adding some zmq utils
2019-07-22 06:37:16 +00:00
de970334f5
bump version to 0.14.1.2
2019-07-18 16:57:30 +02:00
4850520b6a
update checkpoints.dat hash
2019-07-18 16:54:43 +02:00
a69dc81844
prep for 0.14.1.1
2019-07-17 22:25:53 +02:00
8eb075e789
Merge pull request #5732
...
a96c1a46ab361df2
2019-07-17 21:18:20 +02:00
3b24b1d082
Added support for "noise" over I1P/Tor to mask Tx transmission.
2019-07-17 14:22:37 +00:00
65c4004963
allow blocking whole subnets
2019-07-16 11:35:53 +00:00
515ac2951d
p2p: store network address directly in blocked host list
...
rather than their string representation
2019-07-16 11:35:52 +00:00
7a3e458881
improve tx_sanity_check clarification
2019-07-15 15:19:14 +02:00
f17dcde451
Remove unused txs member in NOTIFY_RESPONSE_GET_OBJECT
2019-07-15 13:27:06 +10:00
fd3ff74164
Merge pull request #5746
...
3140a37
2019-07-12 20:28:15 -05:00
309f2def9e
Merge pull request #5738
...
4ee095c
2019-07-12 20:26:43 -05:00
e4e8954c04
Merge pull request #5724
...
c223832
2019-07-12 20:23:08 -05:00
884df82db3
wallet: provide original address for outgoing transfers
2019-07-10 13:39:18 +00:00
3140a378da
wallet_rpc_server: fix get_bulk_payments with short payment ids
2019-07-09 14:39:44 +00:00
65f29a83c8
simplewallet: add restore_height command
2019-07-08 13:51:50 +00:00
0d916a667c
Fix incorrectly named binding for MMS send_signer_config command
...
send_message_config isn't used anywhere else in the code, and it is clear from the help command that it should be named send_signer_config.
2019-07-08 09:53:07 +00:00
256d286215
Minor formatting fix in help set command
2019-07-06 10:12:32 +00:00
4ee095c200
p2p: don't connect to more than one IP per class B if we can
2019-07-05 18:25:52 +00:00
c2238327d0
keccak: guard against misaligned memory accesses on ARM
...
The code generated is exactly the same as the direct access
one on x86_64
2019-07-04 22:13:16 +00:00
a96c1a46d4
cryptonote_protocol: drop peers we can't download from when syncing
...
Any peer that's behind us while syncing is useless to us (though
not to them). This ensures that we don't get our peer slots filled
with peers that we can't use. Once we've synced, we can connect
to them and they can then sync off us if they want.
2019-07-04 21:56:10 +00:00
ab361df2cd
p2p: add a few missing connection close calls
2019-07-04 21:56:10 +00:00
9d7107c870
Merge pull request #5663
...
5d6b43b
2019-07-04 14:46:37 -05:00
59ba0eee69
Merge pull request #5650
...
3c071d2
2019-07-04 14:44:05 -05:00
591c72613b
Merge pull request #5647
...
2ff99fb
2019-07-04 14:41:36 -05:00
c393e824d6
CryptonightR_JIT: fix return value on error
...
The value was positive rather than zero, but the caller only
checks for negative errors
2019-07-04 12:49:54 +01:00
c164f9037e
Remove unnecessary m_check_txin_table, fix const correctness
2019-07-03 14:39:52 +02:00
6560bfa64c
rpc: get_block_template add optional extra_nonce
...
Circumvents the need to create a new blockhashing blob when you already
know the data you want to set in the extra_nonce (so use this instead of
reserve_size).
2019-07-03 07:57:36 -04:00
8be5fea1de
simplewallet: optional all flag to export_outputs/export_key_images
2019-07-02 19:42:28 +00:00
bcd2da76cd
miner: fix --bg-mining-enable description
2019-07-02 17:43:36 +00:00
dc8b7a88bd
zmq: MacPorts latest fix
2019-07-01 23:13:55 -04:00
c8709fe52f
wallet: do not print log settings when unset
...
Coverity 199721
2019-07-01 15:17:30 +00:00
633f14b976
Merge pull request #5681
...
037f94c
2019-07-01 01:12:23 -05:00
2db997828a
Merge pull request #5678
...
15c699f
2019-07-01 00:22:07 -05:00
393c33f86c
Merge pull request #5675
...
da3e20e
2019-07-01 00:18:40 -05:00
4237707d3e
p2p: don't forget pruning seed or public RPC port when updating peers
...
Older nodes don't pass that information around
2019-06-26 10:20:19 +00:00
1db5357c7b
rpc headers fix
2019-06-25 01:49:04 +01:00
a604241ef6
simplewallet: don't ask about mining when running a command line
...
This is likely to be done via a script
2019-06-22 10:50:20 +00:00
3768db227c
p2p: add a reference to Cao, Tong et al. for the last_seen changes
...
"Exploring the Monero Peer-to-Peer Network". https://eprint.iacr.org/2019/411
2019-06-21 10:34:33 +00:00
037f94c54e
Remove Xiala.net from the list of dns resolvers
...
It is down permanently. See: https://xiala.net/
"Ende November 2018 werden alle Dienste von xiala.net abgeschaltet."
2019-06-21 09:40:10 +00:00
15c699f0a6
rpc: set sanity_check_failed to false when successful
2019-06-20 14:32:49 +09:00
da3e20ee01
tx_sanity_check: relax the median check a lot
...
we don't want to prevent bona fide txes, just obvious bad ones
2019-06-19 23:31:38 +00:00
098aadf084
p2p: close the right number of connections on setting max in/out peers
2019-06-19 11:49:36 +00:00
fcbf7b3f74
p2p: propagate out peers limit to payload handler
2019-06-19 11:49:36 +00:00
097cca59c1
wallet_api: catch getTxKey exception
...
- getTxKey method throws an exception, e.g., when user declines txKey export
2019-06-19 12:09:49 +02:00
b2bfcab618
wallet2: fix change subaddress mixup when sending pre rct outputs
2019-06-19 09:39:16 +00:00
5d6b43b672
core: fix --prune-blockchain not pruning if no blockchain exists
2019-06-17 16:26:43 +00:00
f074b6b571
device: show address on device display
...
- Trezor: support for device address display (subaddress, integrated address)
- Wallet::API support added
- Simplewallet:
- address device [<index>]
- address new <label> // shows address on device also
- integrated_address [device] <payment_id|address> // new optional "device" arg to display also on the device
2019-06-17 16:49:04 +02:00
64fb0f872a
device: tx_key caching fixed, store recovered txkey
2019-06-17 14:53:39 +02:00
8ccc30b163
Fix --restore-date usage
...
The wallet was ignoring --restore-height and --restore-date params and
prompting for them again.
2019-06-16 21:11:33 +01:00
3c071d203f
blockchain: silence an error getting blocks for pruned nodes
...
This happens often when a pre-pruning node asks a pruned node
for data it does not have
2019-06-16 11:03:41 +00:00
a182df21d0
Bans for RPC connections
...
Make bans control RPC sessions too. And auto-ban some bad requests.
Drops HTTP connections whenever response code is 500.
2019-06-16 11:38:08 +01:00
2ff99fb47f
db_lmdb: commit pruning txn at checkpoints
...
to avoid errors when the txn is too large
2019-06-15 09:50:54 +00:00
6335509727
Merge pull request #5641
...
633f1542
2019-06-14 16:20:02 +02:00
633f1542e2
prep for 0.14.1 release
2019-06-14 16:16:52 +02:00
2eef90d6ef
rpc: restrict the recent cutoff size in restricted RPC mode
2019-06-14 08:47:33 +00:00
0564da5fdc
ensure no NULL is passed to memcpy
...
NULL is valid when size is 0, but memcpy uses nonnull attributes,
so let's not poke the bear
2019-06-14 08:47:29 +00:00
1387549e90
serialization: check stream good flag at the end
...
just in case
2019-06-14 08:47:23 +00:00
a00cabd4f3
tree-hash: allocate variable memory on heap, not stack
...
Large amounts might run out of stack
Reported by guidov
2019-06-14 08:47:20 +00:00
f215219252
cryptonote: throw on tx hash calculation error
2019-06-14 08:47:17 +00:00
db2b9fba65
serialization: fail on read_varint error
2019-06-14 08:47:14 +00:00
68ad548193
cryptonote_protocol: fix another potential P2P DoS
...
When asking for txes in a fluffy transaction, one might ask
for the same (large) tx many times
2019-06-14 08:47:11 +00:00
1cc61018e5
cryptonote_protocol: expand basic DoS protection
...
Count transactions as well
2019-06-14 08:47:08 +00:00
8f66b7053a
cryptonote_protocol_handler: prevent potential DoS
...
Essentially, one can send such a large amount of IDs that core exhausts
all free memory. This issue can theoretically be exploited using very
large CN blockchains, such as Monero.
This is a partial fix. Thanks and credit given to CryptoNote author
'cryptozoidberg' for collaboration and the fix. Also thanks to
'moneromooo'. Referencing HackerOne report #506595 .
2019-06-14 08:47:05 +00:00
69f9420489
core: do not complain about low block rate if disconnected
...
In that case, we'll still keep the "Monero is now disconnected
from the network" near the end of the log
2019-06-13 10:25:30 +00:00
b712ae0af2
rpc: work around a GCC 7.4.0 (at least) bug
...
In static member function ‘static boost::optional<cryptonote::rpc::output_distribution_data> cryptonote::rpc::RpcHandler::get_output_distribution(const std::function<bool(long unsigned int, long unsigned int, long unsigned int, long unsigned int&, std::vector<long unsigned int>&, long unsigned int&)>&, uint64_t, uint64_t, uint64_t, const std::function<crypto::hash(long unsigned int)>&, bool, uint64_t)’:
cc1plus: warning: ‘void* __builtin_memset(void*, int, long unsigned int)’: specified size 18446744073709551536 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
2019-06-12 22:27:07 +00:00
03aa14ec87
tx_sanity_check: don't print an error when not enough outs to check
2019-06-12 12:06:14 +00:00
14881094af
rpc: fix get_transactions getting v1 txes from the txpool
...
It would try to get their prunable hash, but v1 txes don't have one
2019-06-12 11:59:13 +00:00
luigi1111