Commit Graph

6915 Commits

Author SHA1 Message Date
moneromooo-monero 8fdc0d4cb3
blockchain: fix wrong hf version when popping multiple blocks
Since we keep track of the hf version in the db, we pick it up
from there instead of doing the full reorg call, which is quite
expensive
2019-03-08 21:15:50 +03:00
moneromooo-monero 66d1424200
simplewallet: remove ability to transfer with detached short payment ids
It seemed like a good idea at the time
2019-03-08 21:15:50 +03:00
moneromooo-monero 3974e40efa
blockchain: fix block rate check for empty blockchains 2019-03-08 21:15:50 +03:00
Jethro Grassie ad6a732f24
ignore child process when exec 2019-03-08 21:15:49 +03:00
moneromooo-monero abb4728cf7
wallet2: fix ring reuse breaking when using histogram 2019-03-08 21:15:49 +03:00
moneromooo-monero 51a7dd045e
core: fix unmixable special case allowing ring size below 11 2019-03-08 21:15:49 +03:00
moneromooo-monero 7942e862b8
blockchain: include number of discarded blocks in --reorg-notify 2019-03-08 21:15:49 +03:00
moneromooo-monero eb982caad1
core: add a few more block rate window sizes
The 10 minute one will never trigger for 0 blocks, as it's still
fairly likely to happen even without the actual hash rate changing
much, so we add a 20 minute window, where it will (for 0 blocks)
and a one hour window.
2019-03-08 21:15:49 +03:00
moneromooo-monero eb5a2cbdd2
notify: fix tokenizing being too strict 2019-03-08 21:15:49 +03:00
moneromooo-monero cdf2e30825
core: add --block-rate-notify
This runs a command whenever the block rate deviates too much
from the expectation
2019-03-08 21:15:49 +03:00
moneromooo-monero 7eab7b6a72
blockchain: add --reorg-notify
This will trigger if a reorg is seen. This may be used to do things
like stop automated withdrawals on large reorgs.

%s is replaced by the height at the split point
%h is replaced by the height of the new chain
%n is replaced by the number of new blocks after the reorg
2019-03-08 21:15:48 +03:00
moneromooo-monero bc19bcb2f6
cryptonote_core: warn when the block rate deviates from expectations
The warning threshold is set to allow a false positive every
ten days on average.
2019-03-08 21:15:48 +03:00
moneromooo-monero 3353e6e784
notify: handle arbitrary tags 2019-03-08 21:15:48 +03:00
moneromooo-monero eaf602bceb
ArticMine's new block weight algorithm
This curbs runaway growth while still allowing substantial
spikes in block weight

Original specification from ArticMine:

here is the scaling proposal
Define: LongTermBlockWeight
Before fork:
LongTermBlockWeight = BlockWeight
At or after fork:
LongTermBlockWeight = min(BlockWeight, 1.4*LongTermEffectiveMedianBlockWeight)
Note: To avoid possible consensus issues over rounding the LongTermBlockWeight for a given block should be calculated to the nearest byte, and stored as a integer in the block itself. The stored LongTermBlockWeight is then used for future calculations of the LongTermEffectiveMedianBlockWeight and not recalculated each time.
Define:   LongTermEffectiveMedianBlockWeight
LongTermEffectiveMedianBlockWeight = max(300000, MedianOverPrevious100000Blocks(LongTermBlockWeight))
Change Definition of EffectiveMedianBlockWeight
From (current definition)
EffectiveMedianBlockWeight  = max(300000, MedianOverPrevious100Blocks(BlockWeight))
To (proposed definition)
EffectiveMedianBlockWeight  = min(max(300000, MedianOverPrevious100Blocks(BlockWeight)), 50*LongTermEffectiveMedianBlockWeight)
Notes:
1) There are no other changes to the existing penalty formula, median calculation, fees etc.
2) There is the requirement to store the LongTermBlockWeight of a block unencrypted in the block itself. This  is to avoid possible consensus issues over rounding and also to prevent the calculations from becoming unwieldy as we move away from the fork.
3) When the  EffectiveMedianBlockWeight cap is reached it is still possible to mine blocks up to 2x the EffectiveMedianBlockWeight by paying the corresponding penalty.
2019-03-08 21:15:48 +03:00
moneromooo-monero d48a44d161
Makefile: fix building without a git tree 2019-03-08 21:15:48 +03:00
moneromooo-monero d5c079ef1e
wallet2: extend fake out picks away from the gamma pick
in order to unbias selection from blocks with few txes
2019-03-08 21:15:48 +03:00
Riccardo Spagni ba1fd08e41
update version to 0.13.0.4 2019-03-08 21:15:47 +03:00
Lee Clagett 6246aada9d
Providing user supplied default constructor for expect<void> 2019-03-08 21:15:47 +03:00
moneromooo-monero 18683acc84
console_handler: add a global log when exiting via EOF
It's a common confusion point for users which run monerod
without stdin and with --detach
2019-03-08 21:15:47 +03:00
moneromooo-monero 89c74b5710
blockchain: move two new verification errors to the verify category
Lest we get people get scared again
2019-03-08 21:15:47 +03:00
moneromooo-monero 650594ab63
rpc: fix output distribution caching ignoring chain changes
0 is placeholder for whole chain, so we should compare chain
height changes rather than chain-height-or-zero. Even this isn't
totally foolproof if a blocks are popped and the same number
added again, but it is much better as it prevents the data from
slowly going out of sync.
2019-03-08 21:15:47 +03:00
xiphon 7e669f2d43
device: fixed Ledger Nano S device selection 2019-03-08 21:15:47 +03:00
moneromooo-monero 586e9189a6
Rename "blackball" for clarity
Apparently some people seem to think it's a censorship list...
2019-03-08 21:15:47 +03:00
moneromooo-monero e776762bf6
core: don't verify range proofs multiple times 2019-03-08 21:15:46 +03:00
stoffu 13edabb3e6
tx_pool: revert #4592 and move bin2hex conversion to on_get_transaction_pool 2019-03-08 21:15:46 +03:00
iDunk5400 d1d21b0378
ANSI colors in Windows 10 (v0.13) 2019-03-08 21:15:46 +03:00
moneromooo-monero 0bed77b72e
spawn: close all file descriptors before execve
No need to give whatever we're calling access to what we use
2019-03-08 21:15:46 +03:00
moneromooo-monero 627c303c2f
util: close keys file lock on exec 2019-03-08 21:15:46 +03:00
moneromooo-monero b26d373800
daemon: fix reading past stack on exit 2019-03-08 21:15:46 +03:00
moneromooo-monero 5ebebc1420
wallet_rpc_server: fix change_wallet_password RPC 2019-03-08 21:15:45 +03:00
moneromooo-monero 4fccdaea6a
wallet2_api: fix generating new wallet in the GUI
It was creating a new wallet without a password first (this should
be fixed), then not changing the password correctly
2019-03-08 21:15:45 +03:00
Riccardo Spagni 01a67e96b1
update the version in readme 2019-03-08 21:15:45 +03:00
Riccardo Spagni 72f5fb8019
bump version to 0.13.0.3 2019-03-08 21:15:45 +03:00
stoffu 2777f8c421
tx_pool: store hex string instead of raw binary to tx_blob of get_transaction_pool RPC
Inspired by https://github.com/masari-project/masari/issues/93
2019-03-08 21:15:45 +03:00
Tyler Baker 154c7abdb3
Dockerfile: init and update submodules
The Docker image is failing to build, as the submodules are not being
explicitly initialized and updated.

Fixes: https://github.com/monero-project/monero/issues/4582

Signed-off-by: Tyler Baker <tyler@foundries.io>
2019-03-08 21:15:45 +03:00
xiphon 83aa5c70d0
build: use ARCH 'native' by default, allow to configure and override it 2019-03-08 21:15:40 +03:00
Riccardo Spagni 6834ce6de2
Merge pull request #4574
a04d68f6 SOFTWARE is the default wallet device (m2049r)
2018-10-15 13:50:21 +02:00
Riccardo Spagni 8beb3cd2a1
Merge pull request #4569
e25d21a7 simplewallet: mark default-ring-size setting as obsolete (moneromooo-monero)
2018-10-15 13:49:58 +02:00
Riccardo Spagni dc24639e64
Merge pull request #4579
d7f3805d Revert "p2p: connect via the bound ip, if any" (moneromooo-monero)
2018-10-15 13:49:32 +02:00
Riccardo Spagni 92f42b1e81
Merge pull request #4570
3b04e2e3 daemon: do not run complex code in a signal handler (moneromooo-monero)
2018-10-15 13:49:05 +02:00
Riccardo Spagni 29d7ef0fe0
Merge pull request #4568
2509717b simplewallet: fix view key parsing in --generate-from-view-key (moneromooo-monero)
2018-10-15 13:48:21 +02:00
Riccardo Spagni a9504f7001
Merge pull request #4587
067e232b password: fix secure input with echo on windows (moneromooo-monero)
2018-10-15 13:47:54 +02:00
Riccardo Spagni 3c36a6a227
Merge pull request #4588
b215ea9f password: fix backspace outputting ^? on linux on echoing secure input (moneromooo-monero)
2018-10-15 13:47:27 +02:00
moneromooo-monero b215ea9f56
password: fix backspace outputting ^? on linux on echoing secure input 2018-10-14 10:39:40 +00:00
moneromooo-monero 067e232b19
password: fix secure input with echo on windows
Thanks to iDunk for the testing back and forth
2018-10-14 10:38:11 +00:00
moneromooo-monero d7f3805d2e
Revert "p2p: connect via the bound ip, if any"
This reverts commit 909398efc7.

It looks like it's causing trouble with tor on some setups
2018-10-13 10:20:15 +00:00
m2049r a04d68f698
SOFTWARE is the default wallet device 2018-10-12 23:15:02 +02:00
moneromooo-monero 3b04e2e3d4
daemon: do not run complex code in a signal handler
instead, delegate the work to a one off thread
and notify it from the signal handler
2018-10-12 19:17:55 +00:00
moneromooo-monero e25d21a788
simplewallet: mark default-ring-size setting as obsolete 2018-10-12 13:01:00 +00:00
moneromooo-monero 2509717b11
simplewallet: fix view key parsing in --generate-from-view-key 2018-10-12 12:55:57 +00:00