22a0367398
Merge pull request #6190
...
096a9db
2020-02-19 22:22:36 -05:00
fcb06f7a82
cryptonote_core: skip block notify on blockchain switching rollback
2020-02-19 16:19:29 +00:00
c61abf87c0
remove empty statements
...
Cleaning up a little around the code base.
2020-02-17 11:55:15 -05:00
82da832368
rpc: Add check for too old timestamps in payment signatures.
2020-02-17 15:10:19 +01:00
927fd47934
simplewallet: fix smart mining not starting after first setup
...
Also avoid rewriting the wallet if the setting is already was we need
2020-02-17 13:16:09 +00:00
e3779775d7
tx_pool: catch theoretical error in get_block_reward
...
Coverity 196626
2020-02-12 21:05:28 +00:00
09c8111c53
threadpool: lock mutex in create
...
In some contrived case, it might theoretically be the case that
destroy is called from another thread, which would modify the
threads array from two threads.
Coverity 208372
2020-02-12 21:05:28 +00:00
cc18926eba
wallet2_api: wallet recovery - seed offset passphrase support
2020-02-11 23:36:50 +00:00
9bde70e567
core: mention time being off in hash rate changes message
2020-02-10 16:56:10 +00:00
3627e53aab
rpc: fix print_pool_sh not finding local txes
2020-02-08 12:56:00 +00:00
29b7cd1351
device_ledger: include status code name in error message
2020-02-08 01:46:39 +00:00
1a6e7bd40f
wallet2: mention --daemon-ssl-allow-any-cert in --proxy error msg
2020-02-07 10:02:27 +00:00
c2095fc27b
miner: use verification mode for low diff one block nonce searches
...
This avoids lengthy init times when testing
2020-02-06 14:27:10 +00:00
bd4acbf44c
Merge pull request #6183
...
3813a992
2020-02-06 00:34:58 -08:00
af27276452
Merge pull request #6178
...
7ac7d5d3
2020-02-06 00:33:49 -08:00
e552ba14b2
Merge pull request #6127
...
67b4a19e
2020-02-06 00:33:31 -08:00
995f34b538
Merge pull request #6103
...
4b384003
2020-02-06 00:33:18 -08:00
756f06cd83
Merge pull request #6102
...
b328de6b
2020-02-06 00:32:47 -08:00
8136bf37e2
Merge pull request #6096
...
a633f85d
2020-02-06 00:31:50 -08:00
b8e5c769c7
Merge pull request #6095
...
7ba31191
2020-02-06 00:31:17 -08:00
78d4d5ab79
Merge pull request #6094
...
236d2a88
2020-02-06 00:30:48 -08:00
2532567091
Merge pull request #6078
...
b9fc2066
2020-02-06 00:30:15 -08:00
cd1610bc37
Merge pull request #6076
...
22d308669f57f0df
2020-02-06 00:29:52 -08:00
3b224bb99d
Merge pull request #6069
...
d64e5aa7
2020-02-06 00:29:32 -08:00
34d7ea62f6
Merge pull request #6053
...
deb350b7
2020-02-06 00:28:47 -08:00
9a08ac98c0
Merge pull request #6050
...
65301c40
2020-02-06 00:28:18 -08:00
9658f5d7fc
Merge pull request #6040
...
2f8f3a94
2020-02-06 00:26:34 -08:00
25c1bd4714
Merge pull request #6035
...
b90c4bc3fa16df99054b2621d0faae2ad56a483a3c849188
2020-02-06 00:26:13 -08:00
d7aeb5a9f8
Merge pull request #6233
...
8a27645
2020-02-04 14:38:35 -05:00
b818522d29
p2p: fix spurious warning when we're connected to at last one seed
2020-01-31 15:11:22 +00:00
4771a7aec1
p2p: remove obsolete local time in handshake
...
Also removes a potential fingerprinting vector
2020-01-29 14:39:58 +00:00
2fbbc4a2d3
p2p: avoid sending the same peer list over and over
...
Nodes remember which connections have been sent which peer addresses
and won't send it again. This causes more addresses to be sent as
the connection lifetime grows, since there is no duplication anymore,
which increases the diffusion speed of peer addresses. The whole
white list is now considered for sending, not just the most recent
seen peers. This further hardens against topology discovery, though
it will more readily send peers that have been last seen earlier
than it otherwise would. While this does save a fair amount of net
bandwidth, it makes heavy use of std::set lookups, which does bring
network_address::less up the profile, though not too aggressively.
2020-01-29 14:39:56 +00:00
39a343d76e
p2p: remove backward compatible peer list
2020-01-26 18:37:33 +00:00
606318026e
p2p: simplify last_seen serialization now we have optional stores
2020-01-26 18:37:32 +00:00
9467b2e44c
cryptonote_protocol: omit top 64 bits of difficulty when 0
2020-01-26 18:37:31 +00:00
5f98b46d58
p2p: remove obsolete local time from TIMED_SYNC
2020-01-26 18:37:26 +00:00
8eedc8a390
Merge pull request #6140
...
08635a08
2020-01-25 16:55:18 -08:00
40f82b35ae
Merge pull request #6170
...
56a4469e
2020-01-25 16:54:24 -08:00
56a4469ef3
network: log traffic and add a simple traffic analysis script
2020-01-26 00:33:41 +00:00
dd8c6b1703
wallet: do not split integrated addresses in address book api
2020-01-26 00:03:53 +00:00
dab604e010
wallet2_api: implement estimateTransactionFee
2020-01-25 05:34:51 +00:00
59e7d5686b
Merge pull request #6093
...
2e58eb5c
2020-01-24 20:24:44 -08:00
e8f94e7f1d
Merge pull request #6173
...
8231c7cd81c26589
2020-01-24 20:19:41 -08:00
93d49c1a54
Merge pull request #6172
...
d7cf8727
2020-01-24 20:17:39 -08:00
e51ce477db
Merge pull request #6157
...
402dd207
2020-01-24 20:07:37 -08:00
159c78758a
Merge pull request #6154
...
3b419333
2020-01-24 20:07:01 -08:00
f20a962774
Merge pull request #6153
...
24adee4a
2020-01-24 20:06:46 -08:00
d1b08c00cf
Merge pull request #6146
...
70c9cd3c
2020-01-24 20:06:34 -08:00
5558919e56
Merge pull request #6128
...
9fe8a76c
2020-01-24 20:06:12 -08:00
2e9d1e6e1f
wallet2: fix store-tx-info loading
...
The backward compatibility code was always setting it to 1
in modern wallets since store_tx_keys was not present and thus
assumed to be 1 by default.
Reported by SeventhAlpaca
2020-01-24 16:34:07 +00:00
d0641b42fe
net: fix incorrect less operator for top/i2p addresses
2020-01-18 19:18:56 -08:00
fe92fa1391
[randomx] Add missing randomx_vm_set_cache()
2020-01-17 19:25:26 +00:00
beb815a81d
Merge pull request #6144
...
0e0351c4
2020-01-16 17:51:25 -08:00
c39ea485a0
Merge pull request #6141
...
b9b5c473
2020-01-16 17:45:44 -08:00
2ce5529680
Merge pull request #6134
...
a7a40e28
2020-01-16 17:42:27 -08:00
f1ca98a7ef
Merge pull request #6133
...
b2ad757f
2020-01-16 17:41:35 -08:00
e4e70b57ca
Merge pull request #6130
...
6dec0013
2020-01-16 17:39:03 -08:00
c4abfbfbe7
Merge pull request #6124
...
21d4c216
2020-01-16 17:31:35 -08:00
c6f4113265
Merge pull request #6119
...
6f45cfa5
2020-01-16 17:29:27 -08:00
3acb22b889
Merge pull request #6115
...
27522aaa
2020-01-16 17:27:15 -08:00
50e59cfada
wallet2: reject zero keys in json input
...
Because the user might do this for reasons unknown.
Values beyond l-1 will be reduced, so are accepted.
Reported by who-biz.
2020-01-16 19:58:21 +00:00
ffe7165ebf
wallet: reroll fake outs selection on local tx_sanity_check failure
2020-01-14 22:56:23 +00:00
e49a055e89
Merge pull request #6112
...
7c1d31b0
2020-01-11 18:10:44 -08:00
d024695772
Merge pull request #6105
...
0de8a0d3
2020-01-11 18:04:49 -08:00
096a9dbdf9
Wallet: Distingush amounts for a single subaddress
...
Adding a new `amounts` field ot the output of `get_transfers` RPC
method. This field specifies individual payments made to a single
subaddress in a single transaction, e.g., made by this command:
transfer <addr1> <amount1> <addr1> <amount2>
2020-01-11 11:48:27 +01:00
664720747f
Daemon: Guard against reporting "synchronized" too early
...
The added condition "hshd.current_height >= target" guards against
reporting "synchronized" too early in the special situation that the
very first peer sending us data is synced to a lower height than
ourselves.
2020-01-10 15:49:49 +01:00
0349347e6d
ringdb: use a different iv for key and data in rings table
...
This is technically a record encrypted in two pieces,
so the iv needs to be different.
Some backward compatibility is added to read data written
by existing code, but new data is written with the new code.
2020-01-09 17:32:21 +00:00
7b88208722
simplewallet: reword mixin in user message in terms of ring size
2020-01-09 17:32:21 +00:00
f507a43a23
wallet2: do not remove known rings when a tx fails
...
Even if it fails, the ring composition is known to a potential
adversary, and so we should reuse the same ring next time
2020-01-09 17:32:21 +00:00
02224e714d
Fix check_fee() discrepancy.
...
M100 = max{300kb, min{100block_median, m_long_term_effective_median_block_weight}}
not
M100 = max{300kb, m_long_term_effective_median_block_weight}
Fix base reward in get_dynamic_base_fee_estimate().
get_dynamic_base_fee_estimate() should match check_fee()
Fee is calculated based on block reward, and the reward penalty takes into account 0.5*max_block_weight (both before and after HF_VERSION_EFFECTIVE_SHORT_TERM_MEDIAN_IN_PENALTY).
Moved median calculation according to best practice of 'keep definitions close to where they are used'.
2020-01-09 09:11:09 -06:00
a84131cea3
p2p: fix off by one adding fallback peers
...
The code would ignore the first one to be added
2020-01-07 14:40:26 +00:00
36bdf40288
p2p: fix adding wrong indices to the filtered peer list
2020-01-03 17:56:54 +00:00
d64e5aa719
wallet: allow message sign/verify for subaddresses
2019-12-31 08:44:36 +00:00
a6c24412e5
wallet: fix exceptions getting the hash of a pruned tx
2019-12-30 15:14:57 +00:00
6933693179
rpc: fill miner_tx_hash again
...
It was removed to save duplicated generation time, but it can
be copied from another instance instead
2019-12-20 14:16:31 +00:00
21c3d42eb9
p2p: drop the peerlist dump to TRACE
...
It's spammy
2019-12-17 20:27:04 +00:00
f717d5936c
wallet2: guard against race with multiple decrypt_keys users
...
If more than one thread wants to make sure of the spend secret key,
then we decrypt on the first caller and reencrypt on the last caller,
otherwise we could use an invalid secret key.
2019-12-17 01:38:29 +00:00
716012ca3a
rpc: drop the obsolete and wrong "unpruned size" log
...
Since we now get pruned data in the first place, the "unpruned" data
size will in fact be the pruned data size, leading to confusion
2019-12-16 14:50:07 +00:00
ae84ec90c8
wallet-cli/rpc: allow sweep_all to use outputs in all subaddresses within an account
2019-12-16 21:10:11 +09:00
bc6d8aa343
Corrected message typo
...
Message was "peer claims higher version that we think"
Requested change "peer claims higher version than we think"
2019-12-14 13:06:09 -05:00
5cbb17b946
wallet2: fix hang in wallet refresh
...
If the hashes received would move the current blockchain past the
stop point, the short history would not be updated, since we do
not expect another loop, but the daemon might return earlier hashes,
causing the end index to not be enough to reach the threshold and
this require another loop, which will download the same hashes and
cause an infinite loop.
2019-12-14 16:24:04 +00:00
8a276451b2
blockchain: fix flushing txes from the txpool
2019-12-14 02:13:39 +00:00
b4e1dc83d2
Merge pull request #6057
...
3b8dcc2
2019-12-12 13:49:58 -06:00
e5cc6d39a9
Merge pull request #6055
...
886ed25
2019-12-12 13:47:04 -06:00
ccde60838b
Merge pull request #6054
...
017f816
2019-12-12 13:45:50 -06:00
fb64463c4c
Merge pull request #6052
...
c96b7ee
2019-12-12 13:44:50 -06:00
e629db18f4
Merge pull request #6049
...
45fd72b277003f
2019-12-12 13:43:57 -06:00
a61db51aae
Merge pull request #6027
...
9768e96
2019-12-12 13:38:00 -06:00
dad4cf121e
Merge pull request #6018
...
dce6f053293780
2019-12-12 13:36:05 -06:00
987c3139dc
print_coinbase_tx_sum now supports 128 bits sums
...
The tail emission will bring the total above 64 bits
2019-12-12 01:56:59 +00:00
c361303184
Silence miner debugmsg spam
...
Don't try to allocate the dataset repeatedly if it has already failed.
2019-12-09 15:59:52 +00:00
d93e1dffa9
simplewallet: warn on refresh if refresh-from-block-height seems off
2019-12-09 14:09:39 +00:00
a6a2ad6cac
simplewallet: set manual refresh mode in rescan_bc
...
This ensures we get asked for the password if needed
2019-12-07 13:57:26 +00:00
72ca7e3b0f
Fix time comparison math
...
Dividing `dt` here by 1e6 converts it to seconds, but that is clearly
wrong since `REQUEST_NEXT_SCHEDULED_SPAN_THRESHOLD_STANDBY` is measured
in microseconds. As a result, this if statement was effectively never
used.
2019-12-05 21:02:18 -04:00
a2578892c0
--disable-ban-rpc option to prevent RPC users from banning
2019-12-04 17:45:27 +03:00
94266eeb89
simplewallet: fix output age display with duplicate heights
...
The highlight check was based on height, so would highlight
any output at that height, resulting in several matches if
a fake out was picked at the same height as the real spend
2019-12-03 18:50:28 +00:00
f1d379d27d
simplewallet: fix "outputs in same tx" detector
...
It was comparing source txids, but txids were empty,
so all checks triggered
2019-12-03 18:50:22 +00:00
5985c5afe8
rpc: add bad-blocks to flush_cache RPC
...
Flushes m_invalid_blocks in Blockchain.
2019-12-02 18:53:30 +00:00
ef95a76d0d
remove unused variable 'ptx' from on_describe_transfer()
2019-12-01 13:07:26 -05:00
5f2a32c15a
daemon: run with -rpc-payment-address and --rpc-restricted-bind-port
2019-11-29 20:07:01 +00:00
f8127831c7
simplewallet: fix encrypted payment id note triggering on dummy ones
2019-11-29 20:02:46 +00:00
316ab7b56e
wallet2: better error when restoring a wallet with the wrong keys
2019-11-28 18:22:29 +00:00
b90c4bc39e
rpc: error out from get_info if the proxied call errors out
...
Coverity 205410
2019-11-27 19:52:39 +00:00
054b2621b1
node_rpc_proxy: init some new rpc payment fields in invalidate
...
The cache time would take care of these, but it's cleaner that way
Coverity 205412
2019-11-27 19:52:37 +00:00
d0faae2a92
rpc: init a few missing client_info members
...
Coverity 205414
2019-11-27 19:52:37 +00:00
d56a483abe
rpc: do not propagate exceptions out of a dtor
...
Coverity 205415
2019-11-27 19:52:36 +00:00
3c849188ab
rpc: always set the update field in update on sucess
...
Coverity 205416
2019-11-27 19:52:33 +00:00
3813a992e4
download: catch exceptions checking for size
...
Happens on at least one windows box
2019-11-26 18:42:00 +00:00
8231c7cd04
rpc: fix bootstrap RPC payment RPC being made in raw JSON, not JSON RPC
2019-11-25 19:28:43 +00:00
88b82befc7
simplewallet: point to "set help" in the lock screen message
2019-11-25 13:17:21 +00:00
f19c9f2307
util: allow newlines in string to be split
2019-11-25 13:17:18 +00:00
7ac7d5d32f
updates: fix source code URL on _WIN32
2019-11-25 00:37:54 +01:00
81c2658989
rpc: don't auto fail RPC needing payment in bootstrap mode
2019-11-22 18:12:29 +00:00
d7cf872767
rpc: add received_timestamp for pool txes in gettransactions
2019-11-22 15:53:40 +00:00
0e0351c456
wallet_rpc_server: add count parameter to create_address
2019-11-22 12:00:01 +00:00
402dd2078c
db_lmdb: guard against non NUL terminated keys
2019-11-19 11:12:49 +00:00
d8fc8d8868
make d2h et al. constant-time
2019-11-19 04:21:02 -05:00
3b41933335
wallet: don't issue node rpc proxy requests in '--offline' mode
2019-11-19 03:26:42 +00:00
24adee4a08
p2p: don't request flags after closing connection
2019-11-19 02:03:39 +00:00
68a6507c3f
Fixed bug in ZMQ JSON-RPC method field
2019-11-18 12:59:41 +00:00
47d094c0c4
Fix #6147 DB corruption from child process overwrite
...
Don't leave stdout/stderr dangling on a fork.
2019-11-17 14:04:22 +00:00
df9843212a
Merge pull request #6135
...
09f59ec
2019-11-16 11:00:33 -06:00
b9b5c473d1
threadpool: use std::move when taking an element off the queue
...
It has a std::function, which can have a capture context, and
the function runtime might be small
2019-11-15 13:24:34 +00:00
08635a0875
blockchain: speedup fetching pruned contiguous tx blobs
...
About twice as fast, very roughly
2019-11-15 13:23:30 +00:00
09f59eccad
wallet: set non-empty error string on connection failure
2019-11-14 19:49:57 +00:00
a7a40e285c
Actually concatenate error strings.
2019-11-14 10:36:49 +01:00
6dec001359
simplewallet: fix restore height warning
2019-11-14 03:00:20 +01:00
b2ad757f48
Replace memset with memwipe.
2019-11-13 18:00:50 +01:00
9fe8a76c59
perf_timer: fix pause/resume macros dereferencing too much
2019-11-13 12:08:40 +00:00
67b4a19edf
simplewallet: noob-friendly help menu
2019-11-13 10:24:10 +03:00
dce6f055f9
rpc: Only show version string if it matches expected pattern
2019-11-12 18:19:24 -07:00
3293780992
daemon: Use rpc for "version" command
2019-11-12 17:57:36 -07:00
21d4c21619
blockchain: error out if the builtin hashes data size is wrong
2019-11-12 12:43:08 +00:00
6f45cfa5c5
p2p: zero last seen timestamp when inserting a new peer
2019-11-11 12:44:35 +00:00
27522aaa12
core_tests: reset thread pool between tests
...
Avoids a DB error (leading to an assert) where a thread uses
a read txn previously created with an environment that was
since closed and reopened. While this usually works since
BlockchainLMDB renews txns if it detects the environment has
changed, this will not work if objects end up being allocated
at the same address as the previous instance, leading to stale
data usage.
Thanks hyc for the LMDB debugging.
2019-11-10 12:58:49 +00:00
7c1d31b0a1
build: fix IOS, build blockchain_db and rpc, skip wallet_rpc_server
2019-11-09 14:21:22 +00:00
0de8a0d37d
wallet_rpc_server: new estimate_tx_size_and_weight RPC
2019-11-06 15:18:21 +00:00
4b38400336
wallet2: don't try to lock an empty filename
2019-11-05 15:33:01 +00:00
b328de6b7a
wallet_rpc_server: add tx weight in transfer commands responses
2019-11-05 14:25:06 +00:00
27457a2268
wallet2: fix pool txes not being flushed when mined
2019-11-04 19:32:48 +00:00
a633f85da9
daemon: allow printing N blocks from the end of the chain
...
It's a very common usage (for my anyway) and avoids the need to
get the current height, paste, subtract one, etc
2019-11-04 17:38:14 +00:00
7ba31191f3
daemon: add +meta print_tx parameter
...
prints size, weight and (if mined) height
2019-11-04 15:57:56 +00:00
236d2a88e2
blockchain_stats: make it work on pruned blockchains
...
It reports the actual size as pruned, however
2019-11-04 15:10:01 +00:00
2e58eb5cdb
lmdb: Remove meaningless const qualifier on function type
2019-11-04 02:28:45 -07:00
70c9cd3c9c
Change to Tx diffusion (Dandelion++ fluff) instead of flooding
2019-11-04 09:23:20 +00:00
06b0441762
Merge pull request #6074
...
38f691048dcff02e4ce108330245956beaa1fd35e2304d5472bd8797ae7bb5c
2019-11-03 14:52:16 -08:00
5d7ae2d279
Adding support for hidden (anonymity) txpool
2019-11-02 20:36:03 +00:00
eaadbbdab0
Merge pull request #6079
...
e4d1674e8
2019-11-02 17:31:22 +02:00
da31077bed
Merge pull request #6047
...
ebc6ce44f
2019-11-02 17:30:09 +02:00
e4d1674e8c
0.15.0.0 release engineering
2019-11-02 17:21:52 +02:00
38f6910481
simplewallet: plug a timing leak
...
As reported by Tramèr et al, timing of refresh requests can be used
to see whether a password was requested (and thus at least one output
received) since this will induce a delay in subsequent calls.
To avoid this, we schedule calls at a given time instead of sleeping
for a set time (which would make delays additive).
To further avoid a scheduled call being during the time in which a
password is prompted, the actual scheduled time is now randomized.
2019-11-02 11:41:41 +00:00
b9fc206660
Add a --keep-fakechain option to keep fakechain databases
...
This is handy when doing tests that generate a lot of transactions, since that
takes time it's preferable to re-use the database for future runs.
2019-11-01 23:56:08 +01:00
e108330248
wallet: reuse cached height when set after refresh
...
Refreshing sets cached height, which is otherwise got by calling
get_info. Since get_info is called upon needing to display a prompt
after a command has finished, it can be used to determine how much
time a given command took to run if the cache timeout lapses while
the command runs. Refreshing caches the height as a side effect, so
get_info will never be called as a result of displaying a prompt
after refreshing (and potentially leaking how much time it took to
process a set of transactions, therefore leaking whether we got
some monero in them).
2019-11-01 18:59:41 +00:00
5956beaa15
wallet2: fix is_synced checking target height, not height
...
Target height would be appropriate for the daemon, which syncs
off other daemons, but the wallet syncs off the daemon it's
connected to, and its target is the daemon's current height.
2019-11-01 18:59:39 +00:00
fd35e2304a
wallet: fix another facet of "did I get some monero" information leak
...
We get new pool txes before processing any tx, pool or not.
This ensures that if we're asked for a password, this does not
cause a measurable delay in the txpool query after the last
block query.
2019-11-01 18:59:38 +00:00
d5472bd87b
wallet2: do not send an unnecessary last getblocks.bin call on refresh
...
The "everything refreshed" state was detected when a refresh call did
not return any new blocks. This can be detected without that extra
"empty" call by comparing the claimed node height to the height of
the last block retrieved. Doing this avoids that last call, saves
some bandwidth, and makes the common refresh case use only one call
rather than two.
As a side effect, it prevents an information leak reported by
Tramèr et al: if the wallet retrieves a set of blocks which includes
an output sent to the refreshing wallet, the wallet will prompt the
user for the password to decode the amount and calculate the key
image for the new output, and this will delay subsequent calls to
getblocks.bin, allowing a passive adversary to note the delay and
deduce when the wallet receives at least one output.
This can still happen if the wallet downloads more than 1000 blocks,
since this will be split in several calls, but then the most the
adversary can tell is which 1000 block section the user received
some monero (the adversary can estimate the heights of the blocks
by calculating how many "large" transfers are done, which will be
sections of blocks, the last of which will usually be below 1000,
but the size of the data should allow the actual number of blocks
sent to be determined fairly accurately).
This timing trick still be used via the subsequent scan for incoming
txes in the txpool, which will be fixed later.
2019-11-01 18:59:37 +00:00
22d30866ca
simplewallet: add missing inactivity-lock-timeout to set help blurb
2019-11-01 15:37:55 +00:00
9f57f0df92
simplewallet: do not mention inactivity if a lock was manual
2019-11-01 14:36:57 +00:00
97ae7bb5cb
wallet2: do not repeatedly ask for pool txes sent to us
...
This lets a passive attacker with access to the network link
between node and wallet perform traffic analysis to deduce
when an idle wallet receives a transaction.
Reported by Tramèr et al.
2019-11-01 10:42:01 +00:00
ebc6ce44f4
cryptonote: untangle dependency from miner to blockchain
...
It causes link errors at least on mac
2019-10-31 01:06:42 +00:00
3b8dcc290d
wallet2: make keys unlocker reentrant
...
protects against having your keys mangled
2019-10-29 13:53:57 +00:00
886ed25055
blockchain: fix comment wrongly refering to SHA-3 rather than Keccak
2019-10-29 11:37:08 +00:00
017f816897
daemon: handle printing higher hash rates
2019-10-29 11:33:15 +00:00
deb350b783
always print peer IDs in the same format
2019-10-29 11:30:20 +00:00
c96b7ee619
tx_pool: fix error message assuming incorrectly
2019-10-29 10:43:59 +00:00
2e2bf8a207
daemon: always use bootstrap daemon (if set) in '--no-sync' mode
2019-10-28 21:52:19 +00:00
45fd72b0d7
Updated paper references
2019-10-28 12:34:44 -04:00
65301c406e
core: point out when we hit the block rate visibility limit
2019-10-28 16:06:15 +00:00
277003f145
Minor prover simplification
2019-10-28 09:34:49 -04:00
4c9fd8d86d
Merge pull request #6044
...
eb16755
2019-10-27 16:28:33 -05:00
eb16755083
blockchain: fix unwanted error when probing the pool for a tx
2019-10-27 19:23:25 +00:00
2f8f3a9432
rpc: base flush_cache request/response on the new base structs
2019-10-27 16:14:28 +00:00
e8964c26cc
wallet: do not warn if the rpc cost was free
2019-10-27 10:59:31 +00:00
ef8b3a15b4
Merge pull request #6017
...
5734686
2019-10-25 20:48:04 -05:00
f7f7513ec3
rpc: fix PRIx64 build error on some systems
2019-10-26 00:05:21 +00:00
7caa2b0d3e
Merge pull request #6024
...
296ec7c
2019-10-25 16:06:37 -05:00
07c6789148
Merge pull request #5958
...
d25acd734f28a7235b94e#5835 (export view key) (clashm)
32febd2
2019-10-25 16:03:24 -05:00
86d085e988
Merge pull request #6028
...
174a6ac
2019-10-25 14:29:15 -05:00
f253bf3846
Merge pull request #6007
...
a4dc575
2019-10-25 14:20:20 -05:00
9a995f338a
Merge pull request #6023
...
643dcb9
2019-10-25 13:56:06 -05:00
68b03abdc5
Merge pull request #6021
...
65e8a89
2019-10-25 13:52:19 -05:00
4a67bdbde4
Merge pull request #6019
...
d60c1b6
2019-10-25 13:45:59 -05:00
711625c467
Merge pull request #6014
...
93e7426
2019-10-25 13:44:31 -05:00
59439f8113
Merge pull request #6013
...
635401b
2019-10-25 13:43:00 -05:00
a4dc575ccb
rpc: add a flush_cache RPC
...
This allows flushing internal caches (for now, the bad tx cache,
which will allow debugging a stuck monerod after it has failed to
verify a transaction in a block, since it would otherwise not try
again, making subsequent log changes pointless)
2019-10-25 18:41:54 +00:00
960c215801
Merge pull request #5357
...
b3a9a4d2899379ffa4602
2019-10-25 13:38:21 -05:00
174a6ac9c5
tx_pool: fix divide by 0 in log
...
Coverity 205394
2019-10-25 16:56:55 +00:00
9768e96d74
simplewallet: remove remaining payment id dead code
...
pointed out by coverity
2019-10-25 16:53:15 +00:00
296ec7c9bb
device: bounds checking in Ledger send_secret/receive_secret
2019-10-25 13:13:23 +00:00
643dcb9700
net: link with libzmq
2019-10-25 12:06:16 +00:00
ffa46026b5
simplewallet: add public_nodes command
...
Lists nodes exposing their RPC port for public use
2019-10-25 09:34:41 +00:00
2899379791
daemon, wallet: new pay for RPC use system
...
Daemons intended for public use can be set up to require payment
in the form of hashes in exchange for RPC service. This enables
public daemons to receive payment for their work over a large
number of calls. This system behaves similarly to a pool, so
payment takes the form of valid blocks every so often, yielding
a large one off payment, rather than constant micropayments.
This system can also be used by third parties as a "paywall"
layer, where users of a service can pay for use by mining Monero
to the service provider's address. An example of this for web
site access is Primo, a Monero mining based website "paywall":
https://github.com/selene-kovri/primo
This has some advantages:
- incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own
- incentive to run your own node instead of using a third party's, thereby promoting decentralization
- decentralized: payment is done between a client and server, with no third party needed
- private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance
- no payment occurs on the blockchain, so there is no extra transactional load
- one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy)
- no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do
- Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue
- no large credit balance maintained on servers, so they have no incentive to exit scam
- you can use any/many node(s), since there's little cost in switching servers
- market based prices: competition between servers to lower costs
- incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others
- increases network security
- helps counteract mining pools' share of the network hash rate
- zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner
And some disadvantages:
- low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine)
- payment is "random", so a server might go a long time without a block before getting one
- a public node's overall expected payment may be small
Public nodes are expected to compete to find a suitable level for
cost of service.
The daemon can be set up this way to require payment for RPC services:
monerod --rpc-payment-address 4xxxxxx \
--rpc-payment-credits 250 --rpc-payment-difficulty 1000
These values are an example only.
The --rpc-payment-difficulty switch selects how hard each "share" should
be, similar to a mining pool. The higher the difficulty, the fewer
shares a client will find.
The --rpc-payment-credits switch selects how many credits are awarded
for each share a client finds.
Considering both options, clients will be awarded credits/difficulty
credits for every hash they calculate. For example, in the command line
above, 0.25 credits per hash. A client mining at 100 H/s will therefore
get an average of 25 credits per second.
For reference, in the current implementation, a credit is enough to
sync 20 blocks, so a 100 H/s client that's just starting to use Monero
and uses this daemon will be able to sync 500 blocks per second.
The wallet can be set to automatically mine if connected to a daemon
which requires payment for RPC usage. It will try to keep a balance
of 50000 credits, stopping mining when it's at this level, and starting
again as credits are spent. With the example above, a new client will
mine this much credits in about half an hour, and this target is enough
to sync 500000 blocks (currently about a third of the monero blockchain).
There are three new settings in the wallet:
- credits-target: this is the amount of credits a wallet will try to
reach before stopping mining. The default of 0 means 50000 credits.
- auto-mine-for-rpc-payment-threshold: this controls the minimum
credit rate which the wallet considers worth mining for. If the
daemon credits less than this ratio, the wallet will consider mining
to be not worth it. In the example above, the rate is 0.25
- persistent-rpc-client-id: if set, this allows the wallet to reuse
a client id across runs. This means a public node can tell a wallet
that's connecting is the same as one that connected previously, but
allows a wallet to keep their credit balance from one run to the
other. Since the wallet only mines to keep a small credit balance,
this is not normally worth doing. However, someone may want to mine
on a fast server, and use that credit balance on a low power device
such as a phone. If left unset, a new client ID is generated at
each wallet start, for privacy reasons.
To mine and use a credit balance on two different devices, you can
use the --rpc-client-secret-key switch. A wallet's client secret key
can be found using the new rpc_payments command in the wallet.
Note: anyone knowing your RPC client secret key is able to use your
credit balance.
The wallet has a few new commands too:
- start_mining_for_rpc: start mining to acquire more credits,
regardless of the auto mining settings
- stop_mining_for_rpc: stop mining to acquire more credits
- rpc_payments: display information about current credits with
the currently selected daemon
The node has an extra command:
- rpc_payments: display information about clients and their
balances
The node will forget about any balance for clients which have
been inactive for 6 months. Balances carry over on node restart.
2019-10-25 09:34:38 +00:00
65e8a89e1c
Change monerod --proxy to --tx-proxy
2019-10-24 21:06:31 -04:00
cc46f05f1f
Merge pull request #6002
...
0136bf7
2019-10-24 18:57:05 -05:00
d60c1b6312
changed 'batttery' to 'battery'
2019-10-24 19:55:28 -04:00
57346864a3
rpc: Include tag in get_info version string
2019-10-24 13:48:35 -06:00
81f6c3745e
Merge pull request #5495
...
28a627c
2019-10-24 13:02:39 -05:00
28a627c5ac
gen_ssl_cert: new tool to generate SSL certs for Monero
2019-10-24 17:47:52 +00:00
2200767963
Merge pull request #6004
...
951ceab
2019-10-24 12:43:38 -05:00
87171916ee
Merge pull request #5998
...
0da09ed
2019-10-24 12:38:35 -05:00
951ceab4f6
daemon: print difficulty in decimal, as it used to be
...
It got switched to hexadecimal when we went to 128 bit values
2019-10-24 17:37:05 +00:00
f9b5af85ea
Merge pull request #6001
...
705edd8
2019-10-24 10:57:30 -05:00
8926829569
Merge pull request #6000
...
641c9cf
2019-10-24 10:56:20 -05:00
bef8d3e381
Merge pull request #5999
...
fbf8168
2019-10-24 10:53:53 -05:00
5f6a06e74c
Merge pull request #5997
...
37cccb8
2019-10-24 10:52:04 -05:00
b3a9a4d99d
add a quick early out to get_blocks.bin when up to date
2019-10-24 11:30:54 +00:00
93e74269b3
wallet2: error out when we need a daemon password but have no prompt function
2019-10-23 18:36:53 +00:00
635401b077
wallet2: fix the logged number of detached transfers
2019-10-23 18:29:13 +00:00
4233d88341
Merge pull request #5973
...
abd3763
2019-10-22 10:54:46 -05:00
bb2bcf3521
Merge pull request #5972
...
9447e72
2019-10-22 10:52:14 -05:00
2c497bc411
Merge pull request #5989
...
4f583d5
2019-10-22 10:24:09 -05:00
1e9b577f2a
Merge pull request #5985
...
6fdaaba
2019-10-22 10:22:02 -05:00
35da1ce307
Merge pull request #5983
...
32d6376
2019-10-22 10:20:46 -05:00
8a88d9186a
Merge pull request #5982
...
bba5bae
2019-10-22 10:19:35 -05:00
426d2ac8ee
Merge pull request #5981
...
88c9d90fe443bb1ba9baf
2019-10-22 10:18:28 -05:00
3fb85857e0
Merge pull request #5980
...
ea813cf
2019-10-22 10:16:39 -05:00
99e4c403cb
Merge pull request #5977
...
e85c838
2019-10-22 10:14:33 -05:00
cf2d4d9a16
Merge pull request #5974
...
7fcd0b5
2019-10-22 10:13:34 -05:00
8bb3c6a8e6
Merge pull request #5970
...
ab96181
2019-10-22 10:09:56 -05:00
84ce43a239
Merge pull request #5966
...
be82c40
2019-10-22 10:08:32 -05:00
c81884f088
Merge pull request #5964
...
fd48461
2019-10-22 10:07:17 -05:00
6f202844b5
Merge pull request #5919
...
01f660f
2019-10-22 10:06:10 -05:00
be82c40703
Support median block size > 4 GB
...
add a 128/64 division routine so we can use a > 32 bit median block
size in calculations
2019-10-21 10:41:07 +00:00
0136bf7448
v12 fork heights
2019-10-18 20:32:25 +02:00
705edd81d9
daemon: fix coinbase txes always being seen as pruned
2019-10-18 12:25:08 +00:00
641c9cf19d
daemon: add miner tx hash in print_block output
2019-10-18 12:21:30 +00:00
fbf81689d4
utils: Increase max block size for import/export
2019-10-17 19:14:41 -06:00
0da09ede86
protocol: fix syncing from peers being too choosy about peers
2019-10-17 17:40:47 +00:00
37cccb8cfb
db_lmdb: an empty prunable data record means the tx is not pruned
...
as opposed to an absent record
2019-10-17 17:39:05 +00:00
6c05723981
Merge pull request #5984
...
7fdaa820f4fddc
2019-10-16 13:53:14 -05:00
461a25e1b5
Merge pull request #5962
...
ec14abd
2019-10-16 13:51:34 -05:00
824521b7bc
Merge pull request #5959
...
4d22317
2019-10-16 13:45:22 -05:00
017baeeab5
Merge pull request #5956
...
ec7f2ff
2019-10-16 13:44:25 -05:00
67043d642d
Merge pull request #5954
...
4ce40ed
2019-10-16 13:42:23 -05:00
40e71742a0
Merge pull request #5952
...
93d5cf2
2019-10-16 13:40:44 -05:00
75f7959fa9
Merge pull request #5946
...
16498dc
2019-10-16 13:38:18 -05:00
7fcd0b55ea
blockchain: initialize pow to ff..ff
...
as a safety to reject if it somehow does not get initialised
2019-10-16 09:00:30 +00:00
4f583d564c
daemon: fix print_pl synopsis missing recent options
2019-10-15 13:35:52 +00:00
fcb4c72bb5
Merge pull request #5943
...
d4d2b5c
2019-10-14 20:05:25 -05:00
37a72fd6ae
Merge pull request #5941
...
d37d30f
2019-10-14 18:11:13 -05:00
dd24d7f7fd
Merge pull request #5940
...
6b4bc0d
2019-10-14 18:09:44 -05:00
dc48cdc998
Merge pull request #5933
...
3455efa
2019-10-14 18:07:54 -05:00
4d0aadc081
wallet_rpc_server: don't report integrated addresses for 0 payment ID
...
These are dummy ones
2019-10-14 11:43:48 +00:00
19c0506e14
wallet: remove long payment ID sending support
2019-10-14 11:43:47 +00:00
455f9e3e9f
wallet2: ignore received unencrypted payment IDs (but warn hard)
2019-10-14 11:43:46 +00:00
b295e3cff6
simplewallet: reinstate short payment id nag, only if non default
2019-10-14 11:43:42 +00:00
6fdaaba935
node.inl, add xmrchain.net IP to hardcoded peers
...
added for mainnet, testnet, and stagenet.
server is owner by snipa, both snipa and I have access to it. No idea where its hosted.
xmrchain.net is a block explorer thats been around a while.
2019-10-13 17:13:57 -04:00
0f4fddc2f8
Add also ifdef __x86_64__
2019-10-13 19:08:23 +00:00
ea813cfb1b
RandomX: update to v1.1.4
...
* Faster cache initialization with SSSE3/AVX2
* Automatic detection of CPU capabilities in RandomX
* Fixed a possible out-of-bounds access in superscalar program generator
* Use MONERO_RANDOMX_UMASK to manually disable RandomX flags in monerod
2019-10-13 18:43:27 +02:00
7fdaa8285e
Fix build on FreeBSD/!x86
...
Checking battery status uses x86-only headers and functions. Remove this functionality to get it to build on other architectures.
2019-10-13 16:43:18 +00:00
d4d2b5c79a
p2p+rpc: don't skip p2p or rpc port bind failure by default
2019-10-13 13:27:46 +00:00
32d6376673
simplewallet: add --restore-from-seed alias
...
It may be more intuitive for some people
2019-10-11 14:39:38 +00:00
bba5baec37
simplewallet: don't trigger idle lock right after a foreground refresh
2019-10-11 14:30:20 +00:00
ab96181e91
blockchain: use effective median block weight for penalty from v12
...
It was using the raw block weight median, which was not what was
intended in ArticMine's design
2019-10-11 14:16:09 +00:00
1ba9bafd33
tx_pool: do not divide by 0
...
In case of a 0 tx weight, we use a placeholder value to insert in the
fee-per-byte set. This is used for pruning and mining, and those txes
are pruned, so will not be too large, nor added to the block template
if mining, so this is safe.
CID 204465
2019-10-11 14:09:31 +00:00
fe443bbdec
cryptonote: don't leave block_weight uninitialized
...
CID 204467
2019-10-11 14:09:31 +00:00
88c9d90ac4
protocol: initialize block_weight in block_complete_entry ctor
...
CID 204479
2019-10-11 14:09:31 +00:00
9447e7276d
cryptonote: add function to get weight from a pruned tx
...
The weight of the prunable data is deterministic from the
unpruned data, so it can be determined from a pruned tx
2019-10-11 12:08:36 +00:00
01f660f60f
blockchain: fill in cumulative block weight for alt blocks
2019-10-10 20:26:40 +00:00
e85c838154
simplewallet: do not print warning for locked coinbase txes
...
since they're all locked for a fixed amount
2019-10-10 18:29:30 +00:00
abd376313b
cryptonote: fill in tx weight when syncing from pruned blocks
2019-10-10 11:08:02 +00:00
bf525793c7
Merge pull request #5915
...
8330e77
2019-10-08 15:55:03 -05:00
5920913171
Merge pull request #5948
...
1c600a42675cf4f54301d
2019-10-08 14:48:36 -05:00
b0840a8e01
Merge pull request #5932
...
f3b65c6
2019-10-08 14:45:21 -05:00
a74a82c8b2
Merge pull request #5926
...
74a23e9
2019-10-08 14:42:41 -05:00
342e7f844f
Merge pull request #5921
...
2a7d915
2019-10-08 14:31:53 -05:00
f54301dd75
Fix for miners on reorg
...
Make sure dataset gets re-init'd if a reorg changes the epoch
2019-10-07 09:50:00 +01:00
fd4846134d
Print cdifficulty and don't serialize miner tx hash twice
2019-10-07 12:50:05 +11:00
ec14abdbe8
tx_pool: make spent return-by-reference as intended
2019-10-06 12:28:30 +09:00
2675cf4483
Update to RandomX v1.1.3, simplify
...
We don't need to detect if the cache has changed, just always
call to set it on the VM. The call will be a no-op if the cache
hasn't changed.
2019-10-05 18:51:20 +01:00
4d22317dee
wallet2: don't delete file that may not exist
2019-10-04 20:43:40 +02:00
1c600a492f
Fix randomx cache selection for RPCs
...
Was using the wrong cache slot, and returning invalid PoW hashes to RPC clients
2019-10-03 20:05:17 +01:00
32febd277d
Fix debug feature
2019-10-03 16:05:40 +02:00
235b94eb59
Revert PR #5835 (export view key)
2019-10-03 16:05:40 +02:00
34f28a79bc
Add display address
2019-10-03 16:05:32 +02:00
d25acd7a1d
Add hmac over encrypted value during transaction
2019-10-03 16:01:34 +02:00
4ce40edb27
p2p: reject invalid pruning seeds in peer lists
2019-10-02 19:29:05 +00:00
ec7f2ff9ed
p2p: reject invalid rpc_port in peer lists
2019-10-02 19:04:57 +00:00
93d5cf2441
wallet2: add ignore-outputs-{above/below} option
...
https://github.com/aeonix/aeon/pull/131
2019-10-02 13:04:24 +09:00
16498dc8ef
simplewallet.cpp - clean up welcome message
...
Fixed a typo ("and -are- not visible to the world by default"), removed a few redundant commas, and capitalized words inside the URL.
2019-10-01 02:32:32 +00:00
b60cf6a938
Merge pull request #5939
...
9baf2a7
2019-09-30 18:57:54 -05:00
3f732841f5
Merge pull request #5906
...
bd9c12e
2019-09-30 18:53:10 -05:00
17f063a50f
Merge pull request #5902
...
b9da023
2019-09-30 18:52:11 -05:00
d9cb50870d
Merge pull request #5900
...
6bbc646
2019-09-30 18:49:09 -05:00
e23b9847d0
Merge pull request #5894
...
c89f7ef
2019-09-30 18:45:41 -05:00
c6430f9dd0
Merge pull request #5893
...
Coverity fixes [3a816391bd962d2825f07d099658d46f701cd57a10
2019-09-30 18:43:48 -05:00
d37d30f79a
blockchain: tweak fee as a function of median values
...
Use the lesser of the short and long terms medians, rather then
the long term median alone
From ArticMine:
I found a bug in the new fee calculation formula with using only the long term median
It actually needs to be the lesser of the long term median and the old (modified short term median)
short term median with the last 10 blocks calculated as empty
Yes the issue occurs if there is a large long term median and, the short term median then falls and tries to then rise again
The fees are could be not high enough
for example LTM and STM rise to say 2000000 bytes
STM falls back to 300000 bytes
Fees are now based on 2000000 bytes until LTM also falls
So the STM is could prevented from rising back up
STM short term median LTM long term median
2019-09-28 22:53:41 +00:00
6b4bc0d389
RPC on_transfer_split error consistent with on_transfer if no tx sent
2019-09-28 19:22:15 +02:00
9baf2a7caa
build: link wallet_merged against blockchain_db and hardforks obj
2019-09-28 12:35:33 +00:00
8330e772f1
monerod can now sync from pruned blocks
...
If the peer (whether pruned or not itself) supports sending pruned blocks
to syncing nodes, the pruned version will be sent along with the hash
of the pruned data and the block weight. The original tx hashes can be
reconstructed from the pruned txes and theur prunable data hash. Those
hashes and the block weights are hashes and checked against the set of
precompiled hashes, ensuring the data we received is the original data.
It is currently not possible to use this system when not using the set
of precompiled hashes, since block weights can not otherwise be checked
for validity.
This is off by default for now, and is enabled by --sync-pruned-blocks
2019-09-27 00:10:37 +00:00
81c2ad6d5b
RandomX integration
...
Support RandomX PoW algorithm
2019-09-25 21:29:42 +01:00
3455efafa8
ban peers sending bad pow outright
...
PoW is expensive to verify, so be strict
2019-09-25 16:00:43 +00:00
f3b65c66f8
Request a thread stack size that is large enough for unbound
...
Unbound uses a 64 kb large character array on the stack, which
leads to a stack overflow for some libc implementations. musl
only gives 80 kb in total. This PR changes the stack size for
these threads to 1mb, which solves the segmentation fault.
2019-09-25 16:37:06 +02:00
3f6096867d
Merge pull request #5916
...
7b076d5
2019-09-24 10:42:29 -05:00
5fe38977b5
Merge pull request #5905
...
Revert a96c1a4adc16d2
2019-09-24 10:39:28 -05:00
74a23e9a59
protocol: only print sync complete message when out of precompiled hashes
...
This avoids most premature triggers
2019-09-24 15:29:59 +00:00
44aa7d5439
Merge pull request #5882
...
a444f06
2019-09-24 10:27:22 -05:00
06bee964a8
Merge pull request #5878
...
f9b3f6e
2019-09-24 10:10:28 -05:00
ee6e849627
Merge pull request #5877
...
2cd4fd84ad191f928f4be
2019-09-24 10:08:44 -05:00
8c41d36a08
Merge pull request #5864
...
32f725d
2019-09-24 10:05:21 -05:00
a1736a9429
Merge pull request #5848
...
functional_tests (moneromooo-monero)
2019-09-24 10:04:03 -05:00
d0663837d2
core: move hardforks into its own lib
...
So it can be used by others without encumbrance
2019-09-19 11:28:18 +00:00
a444f06e53
blockchain: enforce 10 block age for spending outputs
...
Some custom wallet code apparently ignores this, which causes users
of that code to be fingerprinted
2019-09-17 11:39:25 +00:00
d53a55204f
functional_tests: add get_transaction_pool_stats
...
Also fix part of the RPC results being returned as binary.
This makes the RPC backward incompatible.
2019-09-17 11:38:29 +00:00
cc4be4fa15
wallet: add edit_address_book RPC
2019-09-17 11:38:23 +00:00
7b076d5170
p2p: fix bans taking port into account
2019-09-16 22:45:45 +00:00
32f725d32f
Properly format multiline logs
...
As a side effect, colouring on Windows should now work
regardless of version
2019-09-16 16:58:01 +00:00
f9b3f6ef3b
Removed Berkeley DB and db switching logic
2019-09-16 16:18:05 +02:00
2c171a9b02
Merge pull request #5861
...
f0356f7
2019-09-14 13:27:18 -05:00
d663e1e3db
Merge pull request #5818
...
f91a06c
2019-09-14 13:25:14 -05:00
dbe31f63e1
Merge pull request #5899
...
7d3bba5
2019-09-14 13:23:28 -05:00
76805b62ce
Merge pull request #5874
...
f380f69
2019-09-14 13:19:01 -05:00
85962ee8e2
Merge pull request #5872
...
495a7e5
2019-09-14 13:16:45 -05:00
d00e511cc6
Merge pull request #5871
...
3407743
2019-09-14 13:14:22 -05:00
e753663d31
Merge pull request #5870
...
83ca764
2019-09-14 13:12:44 -05:00
b526208001
Merge pull request #5868
...
1f1fff2
2019-09-14 13:10:51 -05:00
6e1257cfbd
Merge pull request #5866
...
21f6c80
2019-09-14 13:09:32 -05:00
4a39e1a4a5
Merge pull request #5865
...
11f13da19bfe7e
2019-09-14 13:07:35 -05:00
3e75df42a7
Merge pull request #5854
...
2cb22d4
2019-09-14 13:06:05 -05:00
29e0f11305
Merge pull request #5823
...
26072f1555dc7cd22dfb7
2019-09-14 13:04:41 -05:00
b9da0234e9
blockchain: keep block template timestamp not below recent median
...
Such a template would yield an invalid block, though would require
an attacker to have mined a long blockchain with drifting times
(assuming the miner's clock is roughly correct)
Fixed by crCr62U0
2019-09-11 15:21:52 +00:00
bd9c12e18a
simplewallet: remove erroneously added line under subaddress-lookahead
2019-09-11 10:50:20 +09:00
62fc4bec4c
Revert "cryptonote_protocol: drop peers we can't download from when syncing"
...
This reverts commit a96c1a46d4
2019-09-11 01:04:44 +00:00
ea92a32f72
Revert "Fix check for disconnecting peers when syncing"
...
This reverts commit adc16d2504
2019-09-11 01:04:01 +00:00
f0356f74d3
wallet2: enable ignoring fractional outputs also when sweeping
2019-09-10 12:24:08 +09:00
7d3bba5ca0
wallet2_api: add missing parameter
2019-09-09 16:03:47 +02:00
9325501762
Merge pull request #5855
...
2ec455d
2019-09-08 20:04:00 -05:00
19ef2e99ad
Merge pull request #5850
...
c4da1a2
2019-09-08 20:00:55 -05:00
d30b234f08
Merge pull request #5849
...
b51f4cd
2019-09-08 19:59:05 -05:00
1fd43d3f9f
Merge pull request #5847
...
894cc81
2019-09-08 19:57:49 -05:00
871661f3dc
Merge pull request #5843
...
9f6866950813c1
2019-09-08 19:56:33 -05:00
db87e92b34
Merge pull request #5842
...
87d2f06
2019-09-08 19:53:27 -05:00
86938725ae
Merge pull request #5841
...
cae488d
2019-09-08 19:48:09 -05:00
21290005d7
Merge pull request #5840
...
063eebb
2019-09-08 19:46:03 -05:00
15dabf7d18
Merge pull request #5839
...
e353e3d
2019-09-08 19:45:09 -05:00
3b28ff2d6d
Merge pull request #5838
...
2e26536
2019-09-08 19:43:46 -05:00
4ef3848423
Merge pull request #5835
...
26f7a26
2019-09-08 19:42:49 -05:00
253786c8ea
Merge pull request #5833
...
289d215
2019-09-08 19:41:27 -05:00
da4512639e
Merge pull request #5830
...
5a4c6cc
2019-09-08 19:40:29 -05:00
c89f7effd1
wallet2_api: fix load unsigned tx from file error propagation
2019-09-09 00:03:55 +00:00
d099658522
bootstrap_daemon: resolve CID 203915 (UNCAUGHT_EXCEPT)
...
The issue is triggered by the captured `this` in RPC server, which
passes reference to throwable `core_rpc_server`:
`core_rpc_server.cpp:164: m_bootstrap_daemon.reset(new bootstrap_daemon([this]{ return get_random_public_node(); }));`
The solution is to simply remove noexcept from the remaining `bootstrap_daemon`
constructors because noexcept is false in this context.
>"An exception of type "boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::asio::invalid_service_owner>>" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate()."
2019-09-07 00:29:09 +00:00
1bd962d9f9
wallet2: resolve CID 203918 null pointer deference (NULL_RETURNS)
2019-09-06 23:11:37 +00:00
928f4be953
Make null hash constants constexpr
...
Simplify m_template initialization in miner
2019-09-05 17:37:19 +02:00
2ec455df1f
wallet: fix mismatch between two concepts of "balance"
...
One considers the blockchain, while the other considers the
blockchain and some recent actions, such as a recently created
transaction which spend some outputs, but isn't yet mined.
Typically, the "balance" command wants the latter, to reflect
the recent action, but things like proving ownership wants
the former.
This fixes a crash in get_reserve_proof, where a preliminary
check and the main code used two concepts of "balance".
2019-09-05 11:19:34 +00:00
340774341f
wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_payments
...
Much easier to work with than the raw unlock_time field
2019-09-05 10:54:57 +00:00
bc1144e98e
Fix IP address serialization on big endian
...
IP addresses are stored in network byte order even on little
endian hosts
2019-09-04 14:54:01 +00:00
54fd97ae3f
slow-hash: fix CNv2+ on big endian
2019-09-04 14:53:59 +00:00
4672b5cea9
db_lmdb: print percentages as percentages, not ratios
2019-09-04 14:53:59 +00:00
d046ca1db0
difficulty: fix check_hash on big endian
2019-09-04 14:53:53 +00:00
a567e884b2
Merge pull request #5822
...
839fc62
2019-09-04 09:39:07 -05:00
e4f11a68fe
Merge pull request #5819
...
07cb087
2019-09-04 09:37:32 -05:00
902e4b6ebf
Merge pull request #5806
...
69465e3
2019-09-04 09:28:22 -05:00
0198b76217
Merge pull request #5799
...
082730b
2019-09-04 09:27:02 -05:00
23547e6ed6
Merge pull request #5536
...
1a367d6
2019-09-04 09:18:38 -05:00
4ad191ffa9
Removed unused boost/value_init header
2019-09-02 14:38:29 +02:00
2cd4fd8972
Changed the use of boost:value_initialized for C++ list initializer
2019-09-02 14:16:29 +02:00
98af2e954b
Merge pull request #5793
...
bdfc63a3b24b1d
2019-08-29 14:36:41 -05:00
f380f69c69
simplewallet: warn if invalid default ring size is set and actually ignore the setting
2019-08-29 15:55:53 +09:00
1a367d6a22
simplewallet: lock console on inactivity
2019-08-28 19:01:48 +00:00
495a7e5b97
rpc: don't include an address in mining_status when not mining
...
Best case is an address mined previously and it'll get returned,
worst case it was never initialized in the first place
2019-08-28 16:02:37 +00:00
83ca76435b
wallet_rpc_server: call deinit on exit
2019-08-28 15:59:33 +00:00
1f1fff2679
daemon: print mining algorithm in mining_status even when not mining
2019-08-28 15:55:31 +00:00
21f6c80fcd
rpc: move a leftover light wallet RPC out of daemon RPC
2019-08-28 15:51:28 +00:00
19bfe7e5ab
simplewallet: fix warnings about useless std::move
2019-08-28 15:13:50 +00:00
11f13da8b4
blockchain: fix logging bad number of blocks if first one fails
2019-08-28 14:53:29 +00:00
6bbc646e6f
Fix bug in mempool get_transaction_stats histogram calculation
...
The 98th percentile position in the agebytes map was incorrectly
calculated: it assumed the transactions in the mempool all have unique
timestamps at second-granularity. This commit fixes this by correctly
finding the right cumulative number of transactions in the map suffix.
This bug could lead to an out-of-bounds write in the rare case that
all transactions in the mempool were received (and added to the mempool)
at a rate of at least 50 transactions per second. (More specifically,
the number of *unique* receive_time values, which have second-
granularity, must be at most 2% of the number of transactions in the
mempool for this crash to trigger.) If this condition is satisfied, 'it'
points to *before* the agebytes map, 'delta' gets a nonsense value, and
the value of 'i' in the first stats.histo-filling loop will be out of
bounds of stats.histo.
2019-08-28 16:46:31 +02:00
85014813cf
Merge pull request #5707
...
3a0451a
2019-08-28 02:22:00 -05:00
3a0451a8be
MLSAG speedup and additional checks
2019-08-27 16:22:44 -04:00
f68512e9e4
Merge pull request #5729
...
7c894fcf07524b
2019-08-27 15:19:47 -05:00
8f6f674753
Merge pull request #5609
...
1dc3b1a
2019-08-27 15:14:15 -05:00
3e80f44503
Merge pull request #5559
...
33e91e1
2019-08-27 15:09:37 -05:00
082730b6e5
daemon: automatic public nodes discovering and bootstrap daemon switching
2019-08-27 12:01:49 +00:00
33e91e1a1e
wallet, rpc: add a release field to get_version
...
It does not leak much since you can make a fair guess by RPC
version already, and some people want to avoid non release
clients when using third parties' nodes (because they'd never
lie about it)
2019-08-26 19:28:25 +00:00
f07524b56b
device_ledger: fix uninitialized additional_key
...
Coverity 200185
2019-08-26 12:50:29 +00:00
7c894fc7fd
device_ledger: add paranoid buffer overflow check
...
Coverity 200183
2019-08-26 12:50:26 +00:00
2cb22d4071
core: make the "update probably needed soon" message less scary
2019-08-26 07:56:55 +00:00
c4da1a25c3
wallet2: fix unset_ring tx retrieval checks
2019-08-24 14:46:31 +00:00
87d2f063af
simplewallet: moan harder about untrusted nodes
2019-08-24 12:36:10 +00:00
b51f4cdcaf
daemon: add pruned and publicrpc flags to print_pl
2019-08-23 19:15:45 +00:00
894cc81e83
wallet2: fix cold signing losing tx keys
2019-08-23 16:38:20 +00:00
063eebbd43
daemon: implement 'set_bootstrap_daemon' command
2019-08-23 12:09:02 +00:00
cae488dc9b
p2p: reject incoming connections to self
2019-08-22 17:08:29 +00:00
63186a01ce
Wallet: Option to export data to ASCII
...
New CLI wallet variable: export-format with options "binary" (the default),
or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert
data to ASCII using base64.
Reading files from the disk tries to auto detect what format has been
used (using a magic string added when exporting the data).
Implements https://github.com/monero-project/monero/issues/2859
2019-08-22 16:03:22 +02:00
50813c103e
ringdb: fix bug in blackballing
2019-08-22 21:34:48 +09:00
2425f27acd
blockchain_blackball: use is_output_spent instead of ringdb.blackballed for spentness test
2019-08-22 21:34:47 +09:00
9f68669503
blockchain_blackball: add --historical-stat which prints historical stats of spent ratio
2019-08-22 21:34:40 +09:00
1dc3b1a516
wallet: add --extra-entropy command line flag
...
It lets the user add custom entropy to the PRNG.
It does this by hashing the new data and xoring the resulting
hash with the PRNG state.
2019-08-22 11:12:57 +00:00
cdfa2e58df
Merge pull request #5827
...
30779de
2019-08-21 15:54:10 -05:00
2be47ae02a
Merge pull request #5817
...
50ec40e
2019-08-21 15:49:51 -05:00
7bdff6005f
Merge pull request #5815
...
adc16d2
2019-08-21 15:48:09 -05:00
d8244eb39c
Merge pull request #5808
...
5a91b83ae7bf37
2019-08-21 15:41:42 -05:00
0a42fddde4
Merge pull request #5807
...
4b1df4e
2019-08-21 15:38:35 -05:00
28e0a28b96
Merge pull request #5800
...
6ca033d
2019-08-21 15:36:05 -05:00
11ab328ce3
Merge pull request #5778
...
8703aa5
2019-08-21 15:31:11 -05:00
eea0123de4
Merge pull request #5755
...
7a3e458
2019-08-21 15:23:58 -05:00
1bd3f1a1fb
Merge pull request #5750
...
884df82
2019-08-21 15:20:51 -05:00
de30131abd
Merge pull request #5743
...
65f29a8
2019-08-21 15:17:26 -05:00
b488ee8188
Merge pull request #5742
...
0d916a6
2019-08-21 15:13:16 -05:00
9e8179ca84
Merge pull request #5740
...
256d286
2019-08-21 15:11:32 -05:00
8956e90c63
Merge pull request #5731
...
c393e82
2019-08-21 15:09:48 -05:00
65e937168e
Merge pull request #5722
...
8be5fea
2019-08-21 15:08:10 -05:00
e353e3d757
p2p: sanitize peer lists
...
Also remove the delta time fixup, since we now ignore those
as they're attacker controlled
2019-08-21 15:54:27 +00:00
2e2653602f
p2p: move log away from global
...
It was here while debugging, and I forgot to move it away
2019-08-21 14:00:43 +00:00
8703aa59db
MMS: Use chans instead of normal addresses for auto-config
2019-08-20 19:55:31 +02:00
26f7a26ee3
device: fix ledger requesting secret keys export twice
2019-08-20 16:08:09 +00:00
289d21500c
rpc: fix unitialized 'core_rpc_server::m_was_bootstrap_ever_used'
2019-08-20 15:08:48 +00:00
5a4c6cc3a8
daemon: fix merge error removing the "never seen before" timestamp check
2019-08-20 12:48:55 +00:00
c9df9d683a
Merge pull request #5696
...
fd60d05
2019-08-20 01:50:10 -05:00
30779de39d
fix feature not introduced until boost 1.66
2019-08-20 01:06:59 -04:00
fd60d05d5d
daemon: fix print_pl only printing public zone peers
2019-08-19 23:39:51 +00:00
4947f3bdba
Merge pull request #5636
...
b712ae0
2019-08-19 17:37:37 -05:00
56b98c7003
Merge pull request #5728
...
6560bfa
2019-08-19 17:33:08 -05:00
f205d28e96
Merge pull request #5727
...
7b9a420
2019-08-19 17:31:39 -05:00
4baec08d5c
Merge pull request #5725
...
dc8b7a8
2019-08-19 17:29:38 -05:00
1010a6503e
Merge pull request #5721
...
c164f90
2019-08-19 17:25:52 -05:00
1499caf596
Merge pull request #5720
...
bcd2da7
2019-08-19 17:18:04 -05:00
2da11baecc
Merge pull request #5718
...
c8709fe7b18e83
2019-08-19 17:17:11 -05:00
d22dfb7594
blockchain: reject rct signatures in coinbase txes from v12
2019-08-19 16:43:53 +00:00
555dc7c394
core: from v12, require consistent ring size for mixable txes
...
We're supposed to have a fixed ring size now
Already checked by MLSAG verification, but here seems more intuitive
2019-08-19 16:43:53 +00:00
26072f1393
blockchain: forbid v1 coinbase from v12
2019-08-19 16:43:52 +00:00
839fc6256b
reject setting lookahead major or minor to 0
2019-08-19 15:35:12 +00:00
07cb087e5d
blockchain: Fix alt chain generated coins overflow
...
Apply the overflow logic used for computing already_generated_coins in
the main chain to alternative chains.
2019-08-18 17:26:58 -07:00
50ec40ea16
Increase max_dbs from 20 to 32
...
We've added a lot of new indices recently, and 20 isn't enough for them plus
new DBs opened during format migrations.
2019-08-18 17:10:45 +01:00
459beb50d4
Merge pull request #5685
...
a604241
2019-08-17 15:27:21 -05:00
12d08dcbf5
Merge pull request #5518
...
def703a
2019-08-17 15:24:02 -05:00
adc16d2504
Fix check for disconnecting peers when syncing
...
The check added here (in #5732/#5733) is supposed to disconnect behind
peers when the current node is syncing, but actually disconnects behind
peers always.
We are syncing when `target > our_height`, but the check here triggers
when `target > remote_height`, which is basically always true when the
preceding `m_core.have_block(hshd.top_id)` check is true.
2019-08-16 21:16:33 -03:00
def703abec
wallet_api: add multi destination tx support
2019-08-16 16:23:12 +02:00
399a847cfc
Merge pull request #5689
...
1db5357
2019-08-15 17:29:34 -05:00
017162b5b2
Merge pull request #5682
...
3768db2
2019-08-15 17:27:30 -05:00
8a0711f2f2
Merge pull request #5674
...
fcbf7b3098aadf
2019-08-15 17:22:39 -05:00
6b6593dad9
Merge pull request #5673
...
097cca5
2019-08-15 17:21:26 -05:00
1a259a1c70
Merge pull request #5672
...
b2bfcab
2019-08-15 17:20:18 -05:00
739b02ef38
Merge pull request #5662
...
64fb0f8
2019-08-15 17:19:12 -05:00
48229234a9
Merge pull request #5659
...
6bb2797
2019-08-15 17:17:36 -05:00
c5e926676a
Merge pull request #5656
...
8ccc30b
2019-08-15 17:14:58 -05:00
df064eaa36
Merge pull request #5649
...
a182df2
2019-08-15 17:10:49 -05:00
1167370239
Merge pull request #5637
...
69f9420
2019-08-15 17:09:15 -05:00
7b9a420787
Replace std::random_shuffle with std::shuffle
...
According to [1], std::random_shuffle is deprecated in C++14 and removed
in C++17. Since std::shuffle is available since C++11 as a replacement
and monero already requires C++11, this is a good replacement.
A cryptographically secure random number generator is used in all cases
to prevent people from perhaps copying an insecure std::shuffle call
over to a place where a secure one would be warranted. A form of
defense-in-depth.
[1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
2019-08-15 16:33:15 +02:00
0ba675622f
Merge pull request #5634
...
1488109
2019-08-14 15:35:24 -05:00
0e986a86d5
Merge pull request #5607
...
52cd2fa
2019-08-14 15:34:14 -05:00
564bb1da3a
Merge pull request #5525
...
06054064228ee0880ebfd
2019-08-14 15:31:52 -05:00
2258551ef9
Merge pull request #5487
...
df83ed7
2019-08-14 15:26:55 -05:00
dd3b5ecb98
Merge pull request #5478
...
7d9b7fe
2019-08-14 15:23:31 -05:00
e37e263fcd
Merge pull request #4851
...
155475d
2019-08-14 15:21:47 -05:00
ae7bf37ed6
simplewallet: fix arg indexing bug in set_device_name
2019-08-13 18:10:32 +09:00
5a91b83cb4
simplewallet: add a few missing settings help text
2019-08-13 17:55:41 +09:00
4b1df4e50f
Fix for biased signature nonce
2019-08-12 15:58:15 -04:00
69465e3d83
cryptonote_protocol: fix '--no-sync', ignore new blocks and txes
2019-08-11 20:56:30 +00:00
6ca033d278
hid_error() could return a null, which causes the program to crash with
...
std::logic_error()
2019-08-09 21:24:48 +02:00
155475d971
Add IPv6 support
...
new cli options (RPC ones also apply to wallet):
--p2p-bind-ipv6-address (default = "::")
--p2p-bind-port-ipv6 (default same as ipv4 port for given nettype)
--rpc-bind-ipv6-address (default = "::1")
--p2p-use-ipv6 (default false)
--rpc-use-ipv6 (default false)
--p2p-require-ipv4 (default true, if ipv4 bind fails and this is
true, will not continue even if ipv6 bind
successful)
--rpc-require-ipv4 (default true, description as above)
ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except
in the cases of the cli args for bind address. For those the square
braces can be omitted.
2019-07-31 20:04:57 -04:00
6bb279710c
daemon: print 128bit diff properly
2019-07-30 05:37:38 -07:00
7d9b7fee43
functional_tests: add validate_address tests
2019-07-29 14:29:20 +00:00
2a7d91523b
Fixed i2p/tor tx flooding bug (white noise disabled)
2019-07-29 12:27:00 +00:00
52cd2fa0af
rpc: implement get_public_nodes command
2019-07-29 10:51:15 +00:00
6da3561e2a
Fixed error preventing build of monero-gui
...
get_attribute expects 2 values instead of 1
2019-07-28 16:03:45 +02:00
8adde33e01
Merge pull request #5635
...
03aa14e
2019-07-24 14:43:00 -05:00
bb37e434fc
Merge pull request #5624
...
6b41bd8
2019-07-24 14:39:40 -05:00
d4d5a4433d
Merge pull request #5623
...
b8cfa92
2019-07-24 14:38:15 -05:00
61512cf798
Merge pull request #5610
...
068fa1c
2019-07-24 14:35:11 -05:00
5030b8e8aa
Merge pull request #5608
...
c820e18
2019-07-24 14:33:36 -05:00
e05873d873
Merge pull request #5606
...
cf8cb68
2019-07-24 14:31:59 -05:00
c4071a00fb
Merge pull request #5600
...
dd58057
2019-07-24 14:29:10 -05:00
015c1792c0
Merge pull request #5597
...
343c0b4
2019-07-24 14:26:59 -05:00
8774555d29
Merge pull request #5595
...
2aa1134
2019-07-24 14:25:51 -05:00
8ae2681e08
Merge pull request #5594
...
f074b6b
2019-07-24 14:24:40 -05:00
c62ba1d08f
Merge pull request #5591
...
f17dcde
2019-07-24 14:23:11 -05:00
96cda93a93
Merge pull request #5588
...
cd720c7
2019-07-24 14:20:12 -05:00
9f746b72e2
Merge pull request #5585
...
270a3ae
2019-07-24 14:19:15 -05:00
e241a6280d
Merge pull request #5582
...
fcfcc3a
2019-07-24 14:18:09 -05:00
8600b3c69d
Merge pull request #5576
...
577324a
2019-07-24 14:16:00 -05:00
f1427568dc
Merge pull request #5574
...
162c3e1
2019-07-24 14:14:35 -05:00
5cecf4138b
Merge pull request #5573
...
c07bbd5
2019-07-24 14:13:33 -05:00
b333513db7
Merge pull request #5534
...
4c66614
2019-07-24 14:09:58 -05:00
e579fe4ae0
Merge pull request #5530
...
6abaaaa
2019-07-24 14:07:29 -05:00
4b76656f5c
Merge pull request #5524
...
06b8f29
2019-07-24 14:04:16 -05:00
7138f9d347
Merge pull request #5514
...
e4d100b
2019-07-24 14:00:54 -05:00
407683a38c
Merge pull request #5513
...
bc94ba4
2019-07-24 13:59:19 -05:00
e3de4aa68b
Merge pull request #5502
...
25a7cfd1a66a86
2019-07-24 13:57:06 -05:00
d433abfe01
Merge pull request #5460
...
a23dbe6
2019-07-24 13:52:29 -05:00
705fbcfda4
Merge pull request #5457
...
3b9ce45
2019-07-24 13:51:18 -05:00
e8da2f35ad
Merge pull request #5451
...
6aa3c2f
2019-07-24 13:49:57 -05:00
1880c1a582
Merge pull request #5363
...
515ac2965c4004
2019-07-24 13:47:41 -05:00
f91a06c6d7
Dropping cppzmq dependency; adding some zmq utils
2019-07-22 06:37:16 +00:00
de970334f5
bump version to 0.14.1.2
2019-07-18 16:57:30 +02:00
4850520b6a
update checkpoints.dat hash
2019-07-18 16:54:43 +02:00
a69dc81844
prep for 0.14.1.1
2019-07-17 22:25:53 +02:00
8eb075e789
Merge pull request #5732
...
a96c1a46ab361df2
2019-07-17 21:18:20 +02:00
3b24b1d082
Added support for "noise" over I1P/Tor to mask Tx transmission.
2019-07-17 14:22:37 +00:00
65c4004963
allow blocking whole subnets
2019-07-16 11:35:53 +00:00
515ac2951d
p2p: store network address directly in blocked host list
...
rather than their string representation
2019-07-16 11:35:52 +00:00
7a3e458881
improve tx_sanity_check clarification
2019-07-15 15:19:14 +02:00
f17dcde451
Remove unused txs member in NOTIFY_RESPONSE_GET_OBJECT
2019-07-15 13:27:06 +10:00
fd3ff74164
Merge pull request #5746
...
3140a37
2019-07-12 20:28:15 -05:00
309f2def9e
Merge pull request #5738
...
4ee095c
2019-07-12 20:26:43 -05:00
e4e8954c04
Merge pull request #5724
...
c223832
2019-07-12 20:23:08 -05:00
884df82db3
wallet: provide original address for outgoing transfers
2019-07-10 13:39:18 +00:00
3140a378da
wallet_rpc_server: fix get_bulk_payments with short payment ids
2019-07-09 14:39:44 +00:00
65f29a83c8
simplewallet: add restore_height command
2019-07-08 13:51:50 +00:00
0d916a667c
Fix incorrectly named binding for MMS send_signer_config command
...
send_message_config isn't used anywhere else in the code, and it is clear from the help command that it should be named send_signer_config.
2019-07-08 09:53:07 +00:00
256d286215
Minor formatting fix in help set command
2019-07-06 10:12:32 +00:00
4ee095c200
p2p: don't connect to more than one IP per class B if we can
2019-07-05 18:25:52 +00:00
c2238327d0
keccak: guard against misaligned memory accesses on ARM
...
The code generated is exactly the same as the direct access
one on x86_64
2019-07-04 22:13:16 +00:00
a96c1a46d4
cryptonote_protocol: drop peers we can't download from when syncing
...
Any peer that's behind us while syncing is useless to us (though
not to them). This ensures that we don't get our peer slots filled
with peers that we can't use. Once we've synced, we can connect
to them and they can then sync off us if they want.
2019-07-04 21:56:10 +00:00
ab361df2cd
p2p: add a few missing connection close calls
2019-07-04 21:56:10 +00:00
9d7107c870
Merge pull request #5663
...
5d6b43b
2019-07-04 14:46:37 -05:00
59ba0eee69
Merge pull request #5650
...
3c071d2
2019-07-04 14:44:05 -05:00
591c72613b
Merge pull request #5647
...
2ff99fb
2019-07-04 14:41:36 -05:00
c393e824d6
CryptonightR_JIT: fix return value on error
...
The value was positive rather than zero, but the caller only
checks for negative errors
2019-07-04 12:49:54 +01:00
c164f9037e
Remove unnecessary m_check_txin_table, fix const correctness
2019-07-03 14:39:52 +02:00
6560bfa64c
rpc: get_block_template add optional extra_nonce
...
Circumvents the need to create a new blockhashing blob when you already
know the data you want to set in the extra_nonce (so use this instead of
reserve_size).
2019-07-03 07:57:36 -04:00
8be5fea1de
simplewallet: optional all flag to export_outputs/export_key_images
2019-07-02 19:42:28 +00:00
bcd2da76cd
miner: fix --bg-mining-enable description
2019-07-02 17:43:36 +00:00
dc8b7a88bd
zmq: MacPorts latest fix
2019-07-01 23:13:55 -04:00
c8709fe52f
wallet: do not print log settings when unset
...
Coverity 199721
2019-07-01 15:17:30 +00:00
633f14b976
Merge pull request #5681
...
037f94c
2019-07-01 01:12:23 -05:00
2db997828a
Merge pull request #5678
...
15c699f
2019-07-01 00:22:07 -05:00
393c33f86c
Merge pull request #5675
...
da3e20e
2019-07-01 00:18:40 -05:00
4237707d3e
p2p: don't forget pruning seed or public RPC port when updating peers
...
Older nodes don't pass that information around
2019-06-26 10:20:19 +00:00
1db5357c7b
rpc headers fix
2019-06-25 01:49:04 +01:00
a604241ef6
simplewallet: don't ask about mining when running a command line
...
This is likely to be done via a script
2019-06-22 10:50:20 +00:00
3768db227c
p2p: add a reference to Cao, Tong et al. for the last_seen changes
...
"Exploring the Monero Peer-to-Peer Network". https://eprint.iacr.org/2019/411
2019-06-21 10:34:33 +00:00
037f94c54e
Remove Xiala.net from the list of dns resolvers
...
It is down permanently. See: https://xiala.net/
"Ende November 2018 werden alle Dienste von xiala.net abgeschaltet."
2019-06-21 09:40:10 +00:00
15c699f0a6
rpc: set sanity_check_failed to false when successful
2019-06-20 14:32:49 +09:00
da3e20ee01
tx_sanity_check: relax the median check a lot
...
we don't want to prevent bona fide txes, just obvious bad ones
2019-06-19 23:31:38 +00:00
098aadf084
p2p: close the right number of connections on setting max in/out peers
2019-06-19 11:49:36 +00:00
fcbf7b3f74
p2p: propagate out peers limit to payload handler
2019-06-19 11:49:36 +00:00
097cca59c1
wallet_api: catch getTxKey exception
...
- getTxKey method throws an exception, e.g., when user declines txKey export
2019-06-19 12:09:49 +02:00
b2bfcab618
wallet2: fix change subaddress mixup when sending pre rct outputs
2019-06-19 09:39:16 +00:00
5d6b43b672
core: fix --prune-blockchain not pruning if no blockchain exists
2019-06-17 16:26:43 +00:00
f074b6b571
device: show address on device display
...
- Trezor: support for device address display (subaddress, integrated address)
- Wallet::API support added
- Simplewallet:
- address device [<index>]
- address new <label> // shows address on device also
- integrated_address [device] <payment_id|address> // new optional "device" arg to display also on the device
2019-06-17 16:49:04 +02:00
64fb0f872a
device: tx_key caching fixed, store recovered txkey
2019-06-17 14:53:39 +02:00
8ccc30b163
Fix --restore-date usage
...
The wallet was ignoring --restore-height and --restore-date params and
prompting for them again.
2019-06-16 21:11:33 +01:00
3c071d203f
blockchain: silence an error getting blocks for pruned nodes
...
This happens often when a pre-pruning node asks a pruned node
for data it does not have
2019-06-16 11:03:41 +00:00
a182df21d0
Bans for RPC connections
...
Make bans control RPC sessions too. And auto-ban some bad requests.
Drops HTTP connections whenever response code is 500.
2019-06-16 11:38:08 +01:00
2ff99fb47f
db_lmdb: commit pruning txn at checkpoints
...
to avoid errors when the txn is too large
2019-06-15 09:50:54 +00:00
6335509727
Merge pull request #5641
...
633f1542
2019-06-14 16:20:02 +02:00
633f1542e2
prep for 0.14.1 release
2019-06-14 16:16:52 +02:00
2eef90d6ef
rpc: restrict the recent cutoff size in restricted RPC mode
2019-06-14 08:47:33 +00:00
0564da5fdc
ensure no NULL is passed to memcpy
...
NULL is valid when size is 0, but memcpy uses nonnull attributes,
so let's not poke the bear
2019-06-14 08:47:29 +00:00
1387549e90
serialization: check stream good flag at the end
...
just in case
2019-06-14 08:47:23 +00:00
a00cabd4f3
tree-hash: allocate variable memory on heap, not stack
...
Large amounts might run out of stack
Reported by guidov
2019-06-14 08:47:20 +00:00
f215219252
cryptonote: throw on tx hash calculation error
2019-06-14 08:47:17 +00:00
db2b9fba65
serialization: fail on read_varint error
2019-06-14 08:47:14 +00:00
68ad548193
cryptonote_protocol: fix another potential P2P DoS
...
When asking for txes in a fluffy transaction, one might ask
for the same (large) tx many times
2019-06-14 08:47:11 +00:00
1cc61018e5
cryptonote_protocol: expand basic DoS protection
...
Count transactions as well
2019-06-14 08:47:08 +00:00
8f66b7053a
cryptonote_protocol_handler: prevent potential DoS
...
Essentially, one can send such a large amount of IDs that core exhausts
all free memory. This issue can theoretically be exploited using very
large CN blockchains, such as Monero.
This is a partial fix. Thanks and credit given to CryptoNote author
'cryptozoidberg' for collaboration and the fix. Also thanks to
'moneromooo'. Referencing HackerOne report #506595 .
2019-06-14 08:47:05 +00:00
69f9420489
core: do not complain about low block rate if disconnected
...
In that case, we'll still keep the "Monero is now disconnected
from the network" near the end of the log
2019-06-13 10:25:30 +00:00
b712ae0af2
rpc: work around a GCC 7.4.0 (at least) bug
...
In static member function ‘static boost::optional<cryptonote::rpc::output_distribution_data> cryptonote::rpc::RpcHandler::get_output_distribution(const std::function<bool(long unsigned int, long unsigned int, long unsigned int, long unsigned int&, std::vector<long unsigned int>&, long unsigned int&)>&, uint64_t, uint64_t, uint64_t, const std::function<crypto::hash(long unsigned int)>&, bool, uint64_t)’:
cc1plus: warning: ‘void* __builtin_memset(void*, int, long unsigned int)’: specified size 18446744073709551536 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
2019-06-12 22:27:07 +00:00
03aa14ec87
tx_sanity_check: don't print an error when not enough outs to check
2019-06-12 12:06:14 +00:00
14881094af
rpc: fix get_transactions getting v1 txes from the txpool
...
It would try to get their prunable hash, but v1 txes don't have one
2019-06-12 11:59:13 +00:00
fd0cf689dd
Merge pull request #5619
...
f2f207d
2019-06-11 18:17:11 -05:00
6b41bd8eb5
Delete more include string.h
2019-06-11 16:08:42 +08:00
b8cfa92b7e
rpc: implement set_bootstrap_daemon method
2019-06-10 21:10:08 +00:00
35c20c4332
Fix GCC 9.1 build warnings
...
GCC wants operator= aand copy ctor to be both defined, or neither
2019-06-09 09:39:18 +00:00
f2f207d635
miner: fix double free of thread attributes
...
issue: #5568
2019-06-09 10:51:18 +02:00
2cbe75661c
p2p: fix GCC 9.1 crash
2019-06-08 17:52:53 +00:00
068fa1ca5c
p2p: delay IGP probing on startup
...
We might have external access without having to do this
2019-06-06 10:33:02 +00:00
c820e1839f
simplewallet: print errors on exceptions creating wallets
...
Exceptions would otherwise terminate the process silently
2019-06-06 09:49:47 +00:00
cf8cb6873a
rpc: use ip address string representation for peer::host field
2019-06-04 19:33:35 +00:00
dd58057126
Remember RPC version on initial connect
...
Don't keep asking for it on an intact connection
Wallet is too chatty over the wire
2019-06-02 09:31:50 +01:00
62d32e955a
Merge pull request #5577
...
f950517a
2019-06-01 20:25:19 +02:00
7e417dd408
Merge pull request #5571
...
35da33be4b51f9a3
2019-06-01 20:22:19 +02:00
14d3295649
Merge pull request #5561
...
9bfa4c203544596fc9aaccf3
2019-06-01 20:21:45 +02:00
fccfc1aa25
Merge pull request #5555
...
b6830db2Fix #5553 (Howard Chu)
2019-06-01 20:20:39 +02:00
343c0b4255
add a command line option to disable ZMQ server
2019-06-01 13:03:37 -04:00
880ebfdeea
daemon: add more chain specific info in alt_chain_info
2019-06-01 15:43:52 +00:00
2aa11341fc
daemon: display peer address type in print_cn
2019-05-31 09:10:05 +00:00
fcfcc3ac86
rpc: in/out peers can now return the setting's value
2019-05-30 12:13:31 +00:00
cd720c7e0b
add cumulative difficulty to diff command
2019-05-30 11:57:21 +03:00
270a3ae58b
Unused private member m_miner_address
2019-05-29 10:12:47 -04:00
f950517a08
core: update pruning if using --prune-blockchain on a pruned blockchain
...
Avoids a massive amount of spurious warnings if the last update before
the daemon exited was a while ago and the daemon was syncing
2019-05-28 09:12:11 +00:00
577324a954
wallet_manager: omit redundant disconnect, drop unused variable
2019-05-27 14:40:29 +00:00
35da33bea9
blockchain: do not try to pop blocks down to the genesis block
2019-05-26 17:11:32 +00:00
4b51f9a34f
core: do not commit half constructed batch db txn
2019-05-25 16:24:56 +00:00
162c3e18ec
blockchain_export: allow exporting blocks.dat format from pruned
...
We don't need any of the pruned data for this
2019-05-24 14:12:45 +00:00
c07bbd5c04
daemon: fix "never seen before" time span display for peers
2019-05-24 10:47:36 +00:00
9bfa4c20ca
Fix allow any cert mode in wallet rpc when configured over rpc
2019-05-22 00:15:14 -04:00
3544596f9f
Add ssl_options support to monerod's rpc mode.
2019-05-22 00:09:11 -04:00
c9aaccf346
Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works.
2019-05-21 15:43:27 -04:00
b6830db2d4
Fix #5553
...
Make sure the tip hash still matches the cached block
2019-05-19 03:02:33 +01:00
915f59e3c0
wallet: add unlock_time details to show_transfers
...
also add a note when receiving the tx, because the user
might not notice the "XXX blocks to unlock" in the balance.
2019-05-16 21:37:05 +00:00
e8487fa46b
Merge pull request #5539
...
3f612cdaaf9bc4ec1873af356810307539bd157f
2019-05-15 16:10:41 +02:00
5e80b3c3ef
Merge pull request #5535
...
e1016bce
2019-05-15 16:06:58 +02:00
1607419e38
Merge pull request #5538
...
615f287
2019-05-14 16:02:59 -05:00
eedf5106f5
Merge pull request #5532
...
46244dd
2019-05-14 15:59:34 -05:00
5a67ff2b32
Merge pull request #5526
...
1e8f3f6
2019-05-14 15:54:10 -05:00
266f68be32
Merge pull request #5512
...
d47292e
2019-05-14 15:51:14 -05:00
1873af35bf
Made code block usage consistent across all .md files
2019-05-12 05:16:26 +01:00
615f287aec
wallet: fix certificate fingerprint length check
...
Fixed by crCr62U0
2019-05-11 13:05:06 +00:00
e1016bce14
password: do not use line input on windows
...
This keeps its builtin command editing away
Thanks iDunk for testing on Windows
2019-05-10 18:56:50 +00:00
4c666141e3
expose set/get walletcache attribute functionality in wallet api
2019-05-10 19:24:45 +02:00
46244dd08c
wallet_rpc_server: use original addresses in destinations in get_transfers
...
And add them for pending transfers, where they were missing
2019-05-10 14:44:13 +00:00
6abaaaa994
remove obsolete save_graph skeleton code
2019-05-10 14:17:18 +00:00
1e8f3f66bf
rpc: fail update RPC when running offline
2019-05-09 19:14:49 +00:00
4228ee0b9e
daemon: add optional arguments to alt_chain_info
...
>N limits display to alt chains with more than N blocks
-N limits display to alt chains younger than N blocks
2019-05-09 09:13:11 +00:00
0605406714
daemon: sort alt chains by height
2019-05-09 09:12:49 +00:00
06b8f29992
blockchain: keep alternative blocks in LMDB
...
Alternative blocks are cleared on startup unless --keep-alt-blocks
is passed on the command line
2019-05-08 17:36:52 +00:00
f64f59627d
Merge pull request #5510
...
e9809382
2019-05-07 17:36:27 +02:00
97cb1c9436
Merge pull request #5508
...
1c44e658
2019-05-07 17:35:28 +02:00
a22a8b0f2b
Merge pull request #5505
...
7e5158aa
2019-05-07 17:34:53 +02:00
luigi1111