d4d2b5c79a
p2p+rpc: don't skip p2p or rpc port bind failure by default
2019-10-13 13:27:46 +00:00
32d6376673
simplewallet: add --restore-from-seed alias
...
It may be more intuitive for some people
2019-10-11 14:39:38 +00:00
bba5baec37
simplewallet: don't trigger idle lock right after a foreground refresh
2019-10-11 14:30:20 +00:00
ab96181e91
blockchain: use effective median block weight for penalty from v12
...
It was using the raw block weight median, which was not what was
intended in ArticMine's design
2019-10-11 14:16:09 +00:00
1ba9bafd33
tx_pool: do not divide by 0
...
In case of a 0 tx weight, we use a placeholder value to insert in the
fee-per-byte set. This is used for pruning and mining, and those txes
are pruned, so will not be too large, nor added to the block template
if mining, so this is safe.
CID 204465
2019-10-11 14:09:31 +00:00
fe443bbdec
cryptonote: don't leave block_weight uninitialized
...
CID 204467
2019-10-11 14:09:31 +00:00
88c9d90ac4
protocol: initialize block_weight in block_complete_entry ctor
...
CID 204479
2019-10-11 14:09:31 +00:00
9447e7276d
cryptonote: add function to get weight from a pruned tx
...
The weight of the prunable data is deterministic from the
unpruned data, so it can be determined from a pruned tx
2019-10-11 12:08:36 +00:00
01f660f60f
blockchain: fill in cumulative block weight for alt blocks
2019-10-10 20:26:40 +00:00
e85c838154
simplewallet: do not print warning for locked coinbase txes
...
since they're all locked for a fixed amount
2019-10-10 18:29:30 +00:00
abd376313b
cryptonote: fill in tx weight when syncing from pruned blocks
2019-10-10 11:08:02 +00:00
bf525793c7
Merge pull request #5915
...
8330e77
2019-10-08 15:55:03 -05:00
5920913171
Merge pull request #5948
...
1c600a42675cf4f54301d
2019-10-08 14:48:36 -05:00
b0840a8e01
Merge pull request #5932
...
f3b65c6
2019-10-08 14:45:21 -05:00
a74a82c8b2
Merge pull request #5926
...
74a23e9
2019-10-08 14:42:41 -05:00
342e7f844f
Merge pull request #5921
...
2a7d915
2019-10-08 14:31:53 -05:00
f54301dd75
Fix for miners on reorg
...
Make sure dataset gets re-init'd if a reorg changes the epoch
2019-10-07 09:50:00 +01:00
fd4846134d
Print cdifficulty and don't serialize miner tx hash twice
2019-10-07 12:50:05 +11:00
ec14abdbe8
tx_pool: make spent return-by-reference as intended
2019-10-06 12:28:30 +09:00
2675cf4483
Update to RandomX v1.1.3, simplify
...
We don't need to detect if the cache has changed, just always
call to set it on the VM. The call will be a no-op if the cache
hasn't changed.
2019-10-05 18:51:20 +01:00
4d22317dee
wallet2: don't delete file that may not exist
2019-10-04 20:43:40 +02:00
1c600a492f
Fix randomx cache selection for RPCs
...
Was using the wrong cache slot, and returning invalid PoW hashes to RPC clients
2019-10-03 20:05:17 +01:00
32febd277d
Fix debug feature
2019-10-03 16:05:40 +02:00
235b94eb59
Revert PR #5835 (export view key)
2019-10-03 16:05:40 +02:00
34f28a79bc
Add display address
2019-10-03 16:05:32 +02:00
d25acd7a1d
Add hmac over encrypted value during transaction
2019-10-03 16:01:34 +02:00
4ce40edb27
p2p: reject invalid pruning seeds in peer lists
2019-10-02 19:29:05 +00:00
ec7f2ff9ed
p2p: reject invalid rpc_port in peer lists
2019-10-02 19:04:57 +00:00
93d5cf2441
wallet2: add ignore-outputs-{above/below} option
...
https://github.com/aeonix/aeon/pull/131
2019-10-02 13:04:24 +09:00
16498dc8ef
simplewallet.cpp - clean up welcome message
...
Fixed a typo ("and -are- not visible to the world by default"), removed a few redundant commas, and capitalized words inside the URL.
2019-10-01 02:32:32 +00:00
b60cf6a938
Merge pull request #5939
...
9baf2a7
2019-09-30 18:57:54 -05:00
3f732841f5
Merge pull request #5906
...
bd9c12e
2019-09-30 18:53:10 -05:00
17f063a50f
Merge pull request #5902
...
b9da023
2019-09-30 18:52:11 -05:00
d9cb50870d
Merge pull request #5900
...
6bbc646
2019-09-30 18:49:09 -05:00
e23b9847d0
Merge pull request #5894
...
c89f7ef
2019-09-30 18:45:41 -05:00
c6430f9dd0
Merge pull request #5893
...
Coverity fixes [3a816391bd962d2825f07d099658d46f701cd57a10
2019-09-30 18:43:48 -05:00
d37d30f79a
blockchain: tweak fee as a function of median values
...
Use the lesser of the short and long terms medians, rather then
the long term median alone
From ArticMine:
I found a bug in the new fee calculation formula with using only the long term median
It actually needs to be the lesser of the long term median and the old (modified short term median)
short term median with the last 10 blocks calculated as empty
Yes the issue occurs if there is a large long term median and, the short term median then falls and tries to then rise again
The fees are could be not high enough
for example LTM and STM rise to say 2000000 bytes
STM falls back to 300000 bytes
Fees are now based on 2000000 bytes until LTM also falls
So the STM is could prevented from rising back up
STM short term median LTM long term median
2019-09-28 22:53:41 +00:00
6b4bc0d389
RPC on_transfer_split error consistent with on_transfer if no tx sent
2019-09-28 19:22:15 +02:00
9baf2a7caa
build: link wallet_merged against blockchain_db and hardforks obj
2019-09-28 12:35:33 +00:00
8330e772f1
monerod can now sync from pruned blocks
...
If the peer (whether pruned or not itself) supports sending pruned blocks
to syncing nodes, the pruned version will be sent along with the hash
of the pruned data and the block weight. The original tx hashes can be
reconstructed from the pruned txes and theur prunable data hash. Those
hashes and the block weights are hashes and checked against the set of
precompiled hashes, ensuring the data we received is the original data.
It is currently not possible to use this system when not using the set
of precompiled hashes, since block weights can not otherwise be checked
for validity.
This is off by default for now, and is enabled by --sync-pruned-blocks
2019-09-27 00:10:37 +00:00
81c2ad6d5b
RandomX integration
...
Support RandomX PoW algorithm
2019-09-25 21:29:42 +01:00
3455efafa8
ban peers sending bad pow outright
...
PoW is expensive to verify, so be strict
2019-09-25 16:00:43 +00:00
f3b65c66f8
Request a thread stack size that is large enough for unbound
...
Unbound uses a 64 kb large character array on the stack, which
leads to a stack overflow for some libc implementations. musl
only gives 80 kb in total. This PR changes the stack size for
these threads to 1mb, which solves the segmentation fault.
2019-09-25 16:37:06 +02:00
3f6096867d
Merge pull request #5916
...
7b076d5
2019-09-24 10:42:29 -05:00
5fe38977b5
Merge pull request #5905
...
Revert a96c1a4adc16d2
2019-09-24 10:39:28 -05:00
74a23e9a59
protocol: only print sync complete message when out of precompiled hashes
...
This avoids most premature triggers
2019-09-24 15:29:59 +00:00
44aa7d5439
Merge pull request #5882
...
a444f06
2019-09-24 10:27:22 -05:00
06bee964a8
Merge pull request #5878
...
f9b3f6e
2019-09-24 10:10:28 -05:00
ee6e849627
Merge pull request #5877
...
2cd4fd84ad191f928f4be
2019-09-24 10:08:44 -05:00
8c41d36a08
Merge pull request #5864
...
32f725d
2019-09-24 10:05:21 -05:00
a1736a9429
Merge pull request #5848
...
functional_tests (moneromooo-monero)
2019-09-24 10:04:03 -05:00
d0663837d2
core: move hardforks into its own lib
...
So it can be used by others without encumbrance
2019-09-19 11:28:18 +00:00
a444f06e53
blockchain: enforce 10 block age for spending outputs
...
Some custom wallet code apparently ignores this, which causes users
of that code to be fingerprinted
2019-09-17 11:39:25 +00:00
d53a55204f
functional_tests: add get_transaction_pool_stats
...
Also fix part of the RPC results being returned as binary.
This makes the RPC backward incompatible.
2019-09-17 11:38:29 +00:00
cc4be4fa15
wallet: add edit_address_book RPC
2019-09-17 11:38:23 +00:00
7b076d5170
p2p: fix bans taking port into account
2019-09-16 22:45:45 +00:00
32f725d32f
Properly format multiline logs
...
As a side effect, colouring on Windows should now work
regardless of version
2019-09-16 16:58:01 +00:00
f9b3f6ef3b
Removed Berkeley DB and db switching logic
2019-09-16 16:18:05 +02:00
2c171a9b02
Merge pull request #5861
...
f0356f7
2019-09-14 13:27:18 -05:00
d663e1e3db
Merge pull request #5818
...
f91a06c
2019-09-14 13:25:14 -05:00
dbe31f63e1
Merge pull request #5899
...
7d3bba5
2019-09-14 13:23:28 -05:00
76805b62ce
Merge pull request #5874
...
f380f69
2019-09-14 13:19:01 -05:00
85962ee8e2
Merge pull request #5872
...
495a7e5
2019-09-14 13:16:45 -05:00
d00e511cc6
Merge pull request #5871
...
3407743
2019-09-14 13:14:22 -05:00
e753663d31
Merge pull request #5870
...
83ca764
2019-09-14 13:12:44 -05:00
b526208001
Merge pull request #5868
...
1f1fff2
2019-09-14 13:10:51 -05:00
6e1257cfbd
Merge pull request #5866
...
21f6c80
2019-09-14 13:09:32 -05:00
4a39e1a4a5
Merge pull request #5865
...
11f13da19bfe7e
2019-09-14 13:07:35 -05:00
3e75df42a7
Merge pull request #5854
...
2cb22d4
2019-09-14 13:06:05 -05:00
29e0f11305
Merge pull request #5823
...
26072f1555dc7cd22dfb7
2019-09-14 13:04:41 -05:00
b9da0234e9
blockchain: keep block template timestamp not below recent median
...
Such a template would yield an invalid block, though would require
an attacker to have mined a long blockchain with drifting times
(assuming the miner's clock is roughly correct)
Fixed by crCr62U0
2019-09-11 15:21:52 +00:00
bd9c12e18a
simplewallet: remove erroneously added line under subaddress-lookahead
2019-09-11 10:50:20 +09:00
62fc4bec4c
Revert "cryptonote_protocol: drop peers we can't download from when syncing"
...
This reverts commit a96c1a46d4
2019-09-11 01:04:44 +00:00
ea92a32f72
Revert "Fix check for disconnecting peers when syncing"
...
This reverts commit adc16d2504
2019-09-11 01:04:01 +00:00
f0356f74d3
wallet2: enable ignoring fractional outputs also when sweeping
2019-09-10 12:24:08 +09:00
7d3bba5ca0
wallet2_api: add missing parameter
2019-09-09 16:03:47 +02:00
9325501762
Merge pull request #5855
...
2ec455d
2019-09-08 20:04:00 -05:00
19ef2e99ad
Merge pull request #5850
...
c4da1a2
2019-09-08 20:00:55 -05:00
d30b234f08
Merge pull request #5849
...
b51f4cd
2019-09-08 19:59:05 -05:00
1fd43d3f9f
Merge pull request #5847
...
894cc81
2019-09-08 19:57:49 -05:00
871661f3dc
Merge pull request #5843
...
9f6866950813c1
2019-09-08 19:56:33 -05:00
db87e92b34
Merge pull request #5842
...
87d2f06
2019-09-08 19:53:27 -05:00
86938725ae
Merge pull request #5841
...
cae488d
2019-09-08 19:48:09 -05:00
21290005d7
Merge pull request #5840
...
063eebb
2019-09-08 19:46:03 -05:00
15dabf7d18
Merge pull request #5839
...
e353e3d
2019-09-08 19:45:09 -05:00
3b28ff2d6d
Merge pull request #5838
...
2e26536
2019-09-08 19:43:46 -05:00
4ef3848423
Merge pull request #5835
...
26f7a26
2019-09-08 19:42:49 -05:00
253786c8ea
Merge pull request #5833
...
289d215
2019-09-08 19:41:27 -05:00
da4512639e
Merge pull request #5830
...
5a4c6cc
2019-09-08 19:40:29 -05:00
c89f7effd1
wallet2_api: fix load unsigned tx from file error propagation
2019-09-09 00:03:55 +00:00
d099658522
bootstrap_daemon: resolve CID 203915 (UNCAUGHT_EXCEPT)
...
The issue is triggered by the captured `this` in RPC server, which
passes reference to throwable `core_rpc_server`:
`core_rpc_server.cpp:164: m_bootstrap_daemon.reset(new bootstrap_daemon([this]{ return get_random_public_node(); }));`
The solution is to simply remove noexcept from the remaining `bootstrap_daemon`
constructors because noexcept is false in this context.
>"An exception of type "boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::asio::invalid_service_owner>>" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate()."
2019-09-07 00:29:09 +00:00
1bd962d9f9
wallet2: resolve CID 203918 null pointer deference (NULL_RETURNS)
2019-09-06 23:11:37 +00:00
928f4be953
Make null hash constants constexpr
...
Simplify m_template initialization in miner
2019-09-05 17:37:19 +02:00
2ec455df1f
wallet: fix mismatch between two concepts of "balance"
...
One considers the blockchain, while the other considers the
blockchain and some recent actions, such as a recently created
transaction which spend some outputs, but isn't yet mined.
Typically, the "balance" command wants the latter, to reflect
the recent action, but things like proving ownership wants
the former.
This fixes a crash in get_reserve_proof, where a preliminary
check and the main code used two concepts of "balance".
2019-09-05 11:19:34 +00:00
340774341f
wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_payments
...
Much easier to work with than the raw unlock_time field
2019-09-05 10:54:57 +00:00
bc1144e98e
Fix IP address serialization on big endian
...
IP addresses are stored in network byte order even on little
endian hosts
2019-09-04 14:54:01 +00:00
54fd97ae3f
slow-hash: fix CNv2+ on big endian
2019-09-04 14:53:59 +00:00
4672b5cea9
db_lmdb: print percentages as percentages, not ratios
2019-09-04 14:53:59 +00:00
d046ca1db0
difficulty: fix check_hash on big endian
2019-09-04 14:53:53 +00:00
a567e884b2
Merge pull request #5822
...
839fc62
2019-09-04 09:39:07 -05:00
e4f11a68fe
Merge pull request #5819
...
07cb087
2019-09-04 09:37:32 -05:00
902e4b6ebf
Merge pull request #5806
...
69465e3
2019-09-04 09:28:22 -05:00
0198b76217
Merge pull request #5799
...
082730b
2019-09-04 09:27:02 -05:00
23547e6ed6
Merge pull request #5536
...
1a367d6
2019-09-04 09:18:38 -05:00
4ad191ffa9
Removed unused boost/value_init header
2019-09-02 14:38:29 +02:00
2cd4fd8972
Changed the use of boost:value_initialized for C++ list initializer
2019-09-02 14:16:29 +02:00
98af2e954b
Merge pull request #5793
...
bdfc63a3b24b1d
2019-08-29 14:36:41 -05:00
f380f69c69
simplewallet: warn if invalid default ring size is set and actually ignore the setting
2019-08-29 15:55:53 +09:00
1a367d6a22
simplewallet: lock console on inactivity
2019-08-28 19:01:48 +00:00
495a7e5b97
rpc: don't include an address in mining_status when not mining
...
Best case is an address mined previously and it'll get returned,
worst case it was never initialized in the first place
2019-08-28 16:02:37 +00:00
83ca76435b
wallet_rpc_server: call deinit on exit
2019-08-28 15:59:33 +00:00
1f1fff2679
daemon: print mining algorithm in mining_status even when not mining
2019-08-28 15:55:31 +00:00
21f6c80fcd
rpc: move a leftover light wallet RPC out of daemon RPC
2019-08-28 15:51:28 +00:00
19bfe7e5ab
simplewallet: fix warnings about useless std::move
2019-08-28 15:13:50 +00:00
11f13da8b4
blockchain: fix logging bad number of blocks if first one fails
2019-08-28 14:53:29 +00:00
6bbc646e6f
Fix bug in mempool get_transaction_stats histogram calculation
...
The 98th percentile position in the agebytes map was incorrectly
calculated: it assumed the transactions in the mempool all have unique
timestamps at second-granularity. This commit fixes this by correctly
finding the right cumulative number of transactions in the map suffix.
This bug could lead to an out-of-bounds write in the rare case that
all transactions in the mempool were received (and added to the mempool)
at a rate of at least 50 transactions per second. (More specifically,
the number of *unique* receive_time values, which have second-
granularity, must be at most 2% of the number of transactions in the
mempool for this crash to trigger.) If this condition is satisfied, 'it'
points to *before* the agebytes map, 'delta' gets a nonsense value, and
the value of 'i' in the first stats.histo-filling loop will be out of
bounds of stats.histo.
2019-08-28 16:46:31 +02:00
85014813cf
Merge pull request #5707
...
3a0451a
2019-08-28 02:22:00 -05:00
3a0451a8be
MLSAG speedup and additional checks
2019-08-27 16:22:44 -04:00
f68512e9e4
Merge pull request #5729
...
7c894fcf07524b
2019-08-27 15:19:47 -05:00
8f6f674753
Merge pull request #5609
...
1dc3b1a
2019-08-27 15:14:15 -05:00
3e80f44503
Merge pull request #5559
...
33e91e1
2019-08-27 15:09:37 -05:00
082730b6e5
daemon: automatic public nodes discovering and bootstrap daemon switching
2019-08-27 12:01:49 +00:00
33e91e1a1e
wallet, rpc: add a release field to get_version
...
It does not leak much since you can make a fair guess by RPC
version already, and some people want to avoid non release
clients when using third parties' nodes (because they'd never
lie about it)
2019-08-26 19:28:25 +00:00
f07524b56b
device_ledger: fix uninitialized additional_key
...
Coverity 200185
2019-08-26 12:50:29 +00:00
7c894fc7fd
device_ledger: add paranoid buffer overflow check
...
Coverity 200183
2019-08-26 12:50:26 +00:00
2cb22d4071
core: make the "update probably needed soon" message less scary
2019-08-26 07:56:55 +00:00
c4da1a25c3
wallet2: fix unset_ring tx retrieval checks
2019-08-24 14:46:31 +00:00
87d2f063af
simplewallet: moan harder about untrusted nodes
2019-08-24 12:36:10 +00:00
b51f4cdcaf
daemon: add pruned and publicrpc flags to print_pl
2019-08-23 19:15:45 +00:00
894cc81e83
wallet2: fix cold signing losing tx keys
2019-08-23 16:38:20 +00:00
063eebbd43
daemon: implement 'set_bootstrap_daemon' command
2019-08-23 12:09:02 +00:00
cae488dc9b
p2p: reject incoming connections to self
2019-08-22 17:08:29 +00:00
63186a01ce
Wallet: Option to export data to ASCII
...
New CLI wallet variable: export-format with options "binary" (the default),
or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert
data to ASCII using base64.
Reading files from the disk tries to auto detect what format has been
used (using a magic string added when exporting the data).
Implements https://github.com/monero-project/monero/issues/2859
2019-08-22 16:03:22 +02:00
50813c103e
ringdb: fix bug in blackballing
2019-08-22 21:34:48 +09:00
2425f27acd
blockchain_blackball: use is_output_spent instead of ringdb.blackballed for spentness test
2019-08-22 21:34:47 +09:00
9f68669503
blockchain_blackball: add --historical-stat which prints historical stats of spent ratio
2019-08-22 21:34:40 +09:00
1dc3b1a516
wallet: add --extra-entropy command line flag
...
It lets the user add custom entropy to the PRNG.
It does this by hashing the new data and xoring the resulting
hash with the PRNG state.
2019-08-22 11:12:57 +00:00
cdfa2e58df
Merge pull request #5827
...
30779de
2019-08-21 15:54:10 -05:00
2be47ae02a
Merge pull request #5817
...
50ec40e
2019-08-21 15:49:51 -05:00
7bdff6005f
Merge pull request #5815
...
adc16d2
2019-08-21 15:48:09 -05:00
d8244eb39c
Merge pull request #5808
...
5a91b83ae7bf37
2019-08-21 15:41:42 -05:00
0a42fddde4
Merge pull request #5807
...
4b1df4e
2019-08-21 15:38:35 -05:00
28e0a28b96
Merge pull request #5800
...
6ca033d
2019-08-21 15:36:05 -05:00
11ab328ce3
Merge pull request #5778
...
8703aa5
2019-08-21 15:31:11 -05:00
eea0123de4
Merge pull request #5755
...
7a3e458
2019-08-21 15:23:58 -05:00
1bd3f1a1fb
Merge pull request #5750
...
884df82
2019-08-21 15:20:51 -05:00
de30131abd
Merge pull request #5743
...
65f29a8
2019-08-21 15:17:26 -05:00
b488ee8188
Merge pull request #5742
...
0d916a6
2019-08-21 15:13:16 -05:00
9e8179ca84
Merge pull request #5740
...
256d286
2019-08-21 15:11:32 -05:00
8956e90c63
Merge pull request #5731
...
c393e82
2019-08-21 15:09:48 -05:00
65e937168e
Merge pull request #5722
...
8be5fea
2019-08-21 15:08:10 -05:00
e353e3d757
p2p: sanitize peer lists
...
Also remove the delta time fixup, since we now ignore those
as they're attacker controlled
2019-08-21 15:54:27 +00:00
2e2653602f
p2p: move log away from global
...
It was here while debugging, and I forgot to move it away
2019-08-21 14:00:43 +00:00
8703aa59db
MMS: Use chans instead of normal addresses for auto-config
2019-08-20 19:55:31 +02:00
26f7a26ee3
device: fix ledger requesting secret keys export twice
2019-08-20 16:08:09 +00:00
289d21500c
rpc: fix unitialized 'core_rpc_server::m_was_bootstrap_ever_used'
2019-08-20 15:08:48 +00:00
5a4c6cc3a8
daemon: fix merge error removing the "never seen before" timestamp check
2019-08-20 12:48:55 +00:00
c9df9d683a
Merge pull request #5696
...
fd60d05
2019-08-20 01:50:10 -05:00
30779de39d
fix feature not introduced until boost 1.66
2019-08-20 01:06:59 -04:00
fd60d05d5d
daemon: fix print_pl only printing public zone peers
2019-08-19 23:39:51 +00:00
4947f3bdba
Merge pull request #5636
...
b712ae0
2019-08-19 17:37:37 -05:00
56b98c7003
Merge pull request #5728
...
6560bfa
2019-08-19 17:33:08 -05:00
f205d28e96
Merge pull request #5727
...
7b9a420
2019-08-19 17:31:39 -05:00
4baec08d5c
Merge pull request #5725
...
dc8b7a8
2019-08-19 17:29:38 -05:00
1010a6503e
Merge pull request #5721
...
c164f90
2019-08-19 17:25:52 -05:00
1499caf596
Merge pull request #5720
...
bcd2da7
2019-08-19 17:18:04 -05:00
2da11baecc
Merge pull request #5718
...
c8709fe7b18e83
2019-08-19 17:17:11 -05:00
d22dfb7594
blockchain: reject rct signatures in coinbase txes from v12
2019-08-19 16:43:53 +00:00
555dc7c394
core: from v12, require consistent ring size for mixable txes
...
We're supposed to have a fixed ring size now
Already checked by MLSAG verification, but here seems more intuitive
2019-08-19 16:43:53 +00:00
26072f1393
blockchain: forbid v1 coinbase from v12
2019-08-19 16:43:52 +00:00
839fc6256b
reject setting lookahead major or minor to 0
2019-08-19 15:35:12 +00:00
07cb087e5d
blockchain: Fix alt chain generated coins overflow
...
Apply the overflow logic used for computing already_generated_coins in
the main chain to alternative chains.
2019-08-18 17:26:58 -07:00
50ec40ea16
Increase max_dbs from 20 to 32
...
We've added a lot of new indices recently, and 20 isn't enough for them plus
new DBs opened during format migrations.
2019-08-18 17:10:45 +01:00
459beb50d4
Merge pull request #5685
...
a604241
2019-08-17 15:27:21 -05:00
12d08dcbf5
Merge pull request #5518
...
def703a
2019-08-17 15:24:02 -05:00
adc16d2504
Fix check for disconnecting peers when syncing
...
The check added here (in #5732/#5733) is supposed to disconnect behind
peers when the current node is syncing, but actually disconnects behind
peers always.
We are syncing when `target > our_height`, but the check here triggers
when `target > remote_height`, which is basically always true when the
preceding `m_core.have_block(hshd.top_id)` check is true.
2019-08-16 21:16:33 -03:00
def703abec
wallet_api: add multi destination tx support
2019-08-16 16:23:12 +02:00
399a847cfc
Merge pull request #5689
...
1db5357
2019-08-15 17:29:34 -05:00
017162b5b2
Merge pull request #5682
...
3768db2
2019-08-15 17:27:30 -05:00
8a0711f2f2
Merge pull request #5674
...
fcbf7b3098aadf
2019-08-15 17:22:39 -05:00
6b6593dad9
Merge pull request #5673
...
097cca5
2019-08-15 17:21:26 -05:00
1a259a1c70
Merge pull request #5672
...
b2bfcab
2019-08-15 17:20:18 -05:00
739b02ef38
Merge pull request #5662
...
64fb0f8
2019-08-15 17:19:12 -05:00
48229234a9
Merge pull request #5659
...
6bb2797
2019-08-15 17:17:36 -05:00
c5e926676a
Merge pull request #5656
...
8ccc30b
2019-08-15 17:14:58 -05:00
df064eaa36
Merge pull request #5649
...
a182df2
2019-08-15 17:10:49 -05:00
1167370239
Merge pull request #5637
...
69f9420
2019-08-15 17:09:15 -05:00
7b9a420787
Replace std::random_shuffle with std::shuffle
...
According to [1], std::random_shuffle is deprecated in C++14 and removed
in C++17. Since std::shuffle is available since C++11 as a replacement
and monero already requires C++11, this is a good replacement.
A cryptographically secure random number generator is used in all cases
to prevent people from perhaps copying an insecure std::shuffle call
over to a place where a secure one would be warranted. A form of
defense-in-depth.
[1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
2019-08-15 16:33:15 +02:00
0ba675622f
Merge pull request #5634
...
1488109
2019-08-14 15:35:24 -05:00
0e986a86d5
Merge pull request #5607
...
52cd2fa
2019-08-14 15:34:14 -05:00
564bb1da3a
Merge pull request #5525
...
06054064228ee0880ebfd
2019-08-14 15:31:52 -05:00
2258551ef9
Merge pull request #5487
...
df83ed7
2019-08-14 15:26:55 -05:00
dd3b5ecb98
Merge pull request #5478
...
7d9b7fe
2019-08-14 15:23:31 -05:00
e37e263fcd
Merge pull request #4851
...
155475d
2019-08-14 15:21:47 -05:00
ae7bf37ed6
simplewallet: fix arg indexing bug in set_device_name
2019-08-13 18:10:32 +09:00
5a91b83cb4
simplewallet: add a few missing settings help text
2019-08-13 17:55:41 +09:00
4b1df4e50f
Fix for biased signature nonce
2019-08-12 15:58:15 -04:00
69465e3d83
cryptonote_protocol: fix '--no-sync', ignore new blocks and txes
2019-08-11 20:56:30 +00:00
6ca033d278
hid_error() could return a null, which causes the program to crash with
...
std::logic_error()
2019-08-09 21:24:48 +02:00
155475d971
Add IPv6 support
...
new cli options (RPC ones also apply to wallet):
--p2p-bind-ipv6-address (default = "::")
--p2p-bind-port-ipv6 (default same as ipv4 port for given nettype)
--rpc-bind-ipv6-address (default = "::1")
--p2p-use-ipv6 (default false)
--rpc-use-ipv6 (default false)
--p2p-require-ipv4 (default true, if ipv4 bind fails and this is
true, will not continue even if ipv6 bind
successful)
--rpc-require-ipv4 (default true, description as above)
ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except
in the cases of the cli args for bind address. For those the square
braces can be omitted.
2019-07-31 20:04:57 -04:00
6bb279710c
daemon: print 128bit diff properly
2019-07-30 05:37:38 -07:00
7d9b7fee43
functional_tests: add validate_address tests
2019-07-29 14:29:20 +00:00
2a7d91523b
Fixed i2p/tor tx flooding bug (white noise disabled)
2019-07-29 12:27:00 +00:00
52cd2fa0af
rpc: implement get_public_nodes command
2019-07-29 10:51:15 +00:00
6da3561e2a
Fixed error preventing build of monero-gui
...
get_attribute expects 2 values instead of 1
2019-07-28 16:03:45 +02:00
8adde33e01
Merge pull request #5635
...
03aa14e
2019-07-24 14:43:00 -05:00
bb37e434fc
Merge pull request #5624
...
6b41bd8
2019-07-24 14:39:40 -05:00
d4d5a4433d
Merge pull request #5623
...
b8cfa92
2019-07-24 14:38:15 -05:00
61512cf798
Merge pull request #5610
...
068fa1c
2019-07-24 14:35:11 -05:00
5030b8e8aa
Merge pull request #5608
...
c820e18
2019-07-24 14:33:36 -05:00
e05873d873
Merge pull request #5606
...
cf8cb68
2019-07-24 14:31:59 -05:00
c4071a00fb
Merge pull request #5600
...
dd58057
2019-07-24 14:29:10 -05:00
015c1792c0
Merge pull request #5597
...
343c0b4
2019-07-24 14:26:59 -05:00
8774555d29
Merge pull request #5595
...
2aa1134
2019-07-24 14:25:51 -05:00
8ae2681e08
Merge pull request #5594
...
f074b6b
2019-07-24 14:24:40 -05:00
c62ba1d08f
Merge pull request #5591
...
f17dcde
2019-07-24 14:23:11 -05:00
96cda93a93
Merge pull request #5588
...
cd720c7
2019-07-24 14:20:12 -05:00
9f746b72e2
Merge pull request #5585
...
270a3ae
2019-07-24 14:19:15 -05:00
e241a6280d
Merge pull request #5582
...
fcfcc3a
2019-07-24 14:18:09 -05:00
8600b3c69d
Merge pull request #5576
...
577324a
2019-07-24 14:16:00 -05:00
f1427568dc
Merge pull request #5574
...
162c3e1
2019-07-24 14:14:35 -05:00
5cecf4138b
Merge pull request #5573
...
c07bbd5
2019-07-24 14:13:33 -05:00
b333513db7
Merge pull request #5534
...
4c66614
2019-07-24 14:09:58 -05:00
e579fe4ae0
Merge pull request #5530
...
6abaaaa
2019-07-24 14:07:29 -05:00
4b76656f5c
Merge pull request #5524
...
06b8f29
2019-07-24 14:04:16 -05:00
7138f9d347
Merge pull request #5514
...
e4d100b
2019-07-24 14:00:54 -05:00
407683a38c
Merge pull request #5513
...
bc94ba4
2019-07-24 13:59:19 -05:00
e3de4aa68b
Merge pull request #5502
...
25a7cfd1a66a86
2019-07-24 13:57:06 -05:00
d433abfe01
Merge pull request #5460
...
a23dbe6
2019-07-24 13:52:29 -05:00
705fbcfda4
Merge pull request #5457
...
3b9ce45
2019-07-24 13:51:18 -05:00
e8da2f35ad
Merge pull request #5451
...
6aa3c2f
2019-07-24 13:49:57 -05:00
1880c1a582
Merge pull request #5363
...
515ac2965c4004
2019-07-24 13:47:41 -05:00
f91a06c6d7
Dropping cppzmq dependency; adding some zmq utils
2019-07-22 06:37:16 +00:00
de970334f5
bump version to 0.14.1.2
2019-07-18 16:57:30 +02:00
4850520b6a
update checkpoints.dat hash
2019-07-18 16:54:43 +02:00
a69dc81844
prep for 0.14.1.1
2019-07-17 22:25:53 +02:00
8eb075e789
Merge pull request #5732
...
a96c1a46ab361df2
2019-07-17 21:18:20 +02:00
3b24b1d082
Added support for "noise" over I1P/Tor to mask Tx transmission.
2019-07-17 14:22:37 +00:00
65c4004963
allow blocking whole subnets
2019-07-16 11:35:53 +00:00
515ac2951d
p2p: store network address directly in blocked host list
...
rather than their string representation
2019-07-16 11:35:52 +00:00
7a3e458881
improve tx_sanity_check clarification
2019-07-15 15:19:14 +02:00
f17dcde451
Remove unused txs member in NOTIFY_RESPONSE_GET_OBJECT
2019-07-15 13:27:06 +10:00
fd3ff74164
Merge pull request #5746
...
3140a37
2019-07-12 20:28:15 -05:00
309f2def9e
Merge pull request #5738
...
4ee095c
2019-07-12 20:26:43 -05:00
e4e8954c04
Merge pull request #5724
...
c223832
2019-07-12 20:23:08 -05:00
884df82db3
wallet: provide original address for outgoing transfers
2019-07-10 13:39:18 +00:00
3140a378da
wallet_rpc_server: fix get_bulk_payments with short payment ids
2019-07-09 14:39:44 +00:00
65f29a83c8
simplewallet: add restore_height command
2019-07-08 13:51:50 +00:00
0d916a667c
Fix incorrectly named binding for MMS send_signer_config command
...
send_message_config isn't used anywhere else in the code, and it is clear from the help command that it should be named send_signer_config.
2019-07-08 09:53:07 +00:00
256d286215
Minor formatting fix in help set command
2019-07-06 10:12:32 +00:00
4ee095c200
p2p: don't connect to more than one IP per class B if we can
2019-07-05 18:25:52 +00:00
c2238327d0
keccak: guard against misaligned memory accesses on ARM
...
The code generated is exactly the same as the direct access
one on x86_64
2019-07-04 22:13:16 +00:00
a96c1a46d4
cryptonote_protocol: drop peers we can't download from when syncing
...
Any peer that's behind us while syncing is useless to us (though
not to them). This ensures that we don't get our peer slots filled
with peers that we can't use. Once we've synced, we can connect
to them and they can then sync off us if they want.
2019-07-04 21:56:10 +00:00
ab361df2cd
p2p: add a few missing connection close calls
2019-07-04 21:56:10 +00:00
9d7107c870
Merge pull request #5663
...
5d6b43b
2019-07-04 14:46:37 -05:00
59ba0eee69
Merge pull request #5650
...
3c071d2
2019-07-04 14:44:05 -05:00
591c72613b
Merge pull request #5647
...
2ff99fb
2019-07-04 14:41:36 -05:00
c393e824d6
CryptonightR_JIT: fix return value on error
...
The value was positive rather than zero, but the caller only
checks for negative errors
2019-07-04 12:49:54 +01:00
c164f9037e
Remove unnecessary m_check_txin_table, fix const correctness
2019-07-03 14:39:52 +02:00
6560bfa64c
rpc: get_block_template add optional extra_nonce
...
Circumvents the need to create a new blockhashing blob when you already
know the data you want to set in the extra_nonce (so use this instead of
reserve_size).
2019-07-03 07:57:36 -04:00
8be5fea1de
simplewallet: optional all flag to export_outputs/export_key_images
2019-07-02 19:42:28 +00:00
bcd2da76cd
miner: fix --bg-mining-enable description
2019-07-02 17:43:36 +00:00
dc8b7a88bd
zmq: MacPorts latest fix
2019-07-01 23:13:55 -04:00
c8709fe52f
wallet: do not print log settings when unset
...
Coverity 199721
2019-07-01 15:17:30 +00:00
633f14b976
Merge pull request #5681
...
037f94c
2019-07-01 01:12:23 -05:00
2db997828a
Merge pull request #5678
...
15c699f
2019-07-01 00:22:07 -05:00
393c33f86c
Merge pull request #5675
...
da3e20e
2019-07-01 00:18:40 -05:00
4237707d3e
p2p: don't forget pruning seed or public RPC port when updating peers
...
Older nodes don't pass that information around
2019-06-26 10:20:19 +00:00
1db5357c7b
rpc headers fix
2019-06-25 01:49:04 +01:00
a604241ef6
simplewallet: don't ask about mining when running a command line
...
This is likely to be done via a script
2019-06-22 10:50:20 +00:00
3768db227c
p2p: add a reference to Cao, Tong et al. for the last_seen changes
...
"Exploring the Monero Peer-to-Peer Network". https://eprint.iacr.org/2019/411
2019-06-21 10:34:33 +00:00
037f94c54e
Remove Xiala.net from the list of dns resolvers
...
It is down permanently. See: https://xiala.net/
"Ende November 2018 werden alle Dienste von xiala.net abgeschaltet."
2019-06-21 09:40:10 +00:00
15c699f0a6
rpc: set sanity_check_failed to false when successful
2019-06-20 14:32:49 +09:00
da3e20ee01
tx_sanity_check: relax the median check a lot
...
we don't want to prevent bona fide txes, just obvious bad ones
2019-06-19 23:31:38 +00:00
098aadf084
p2p: close the right number of connections on setting max in/out peers
2019-06-19 11:49:36 +00:00
fcbf7b3f74
p2p: propagate out peers limit to payload handler
2019-06-19 11:49:36 +00:00
097cca59c1
wallet_api: catch getTxKey exception
...
- getTxKey method throws an exception, e.g., when user declines txKey export
2019-06-19 12:09:49 +02:00
b2bfcab618
wallet2: fix change subaddress mixup when sending pre rct outputs
2019-06-19 09:39:16 +00:00
5d6b43b672
core: fix --prune-blockchain not pruning if no blockchain exists
2019-06-17 16:26:43 +00:00
f074b6b571
device: show address on device display
...
- Trezor: support for device address display (subaddress, integrated address)
- Wallet::API support added
- Simplewallet:
- address device [<index>]
- address new <label> // shows address on device also
- integrated_address [device] <payment_id|address> // new optional "device" arg to display also on the device
2019-06-17 16:49:04 +02:00
64fb0f872a
device: tx_key caching fixed, store recovered txkey
2019-06-17 14:53:39 +02:00
8ccc30b163
Fix --restore-date usage
...
The wallet was ignoring --restore-height and --restore-date params and
prompting for them again.
2019-06-16 21:11:33 +01:00
3c071d203f
blockchain: silence an error getting blocks for pruned nodes
...
This happens often when a pre-pruning node asks a pruned node
for data it does not have
2019-06-16 11:03:41 +00:00
a182df21d0
Bans for RPC connections
...
Make bans control RPC sessions too. And auto-ban some bad requests.
Drops HTTP connections whenever response code is 500.
2019-06-16 11:38:08 +01:00
2ff99fb47f
db_lmdb: commit pruning txn at checkpoints
...
to avoid errors when the txn is too large
2019-06-15 09:50:54 +00:00
6335509727
Merge pull request #5641
...
633f1542
2019-06-14 16:20:02 +02:00
633f1542e2
prep for 0.14.1 release
2019-06-14 16:16:52 +02:00
2eef90d6ef
rpc: restrict the recent cutoff size in restricted RPC mode
2019-06-14 08:47:33 +00:00
0564da5fdc
ensure no NULL is passed to memcpy
...
NULL is valid when size is 0, but memcpy uses nonnull attributes,
so let's not poke the bear
2019-06-14 08:47:29 +00:00
1387549e90
serialization: check stream good flag at the end
...
just in case
2019-06-14 08:47:23 +00:00
a00cabd4f3
tree-hash: allocate variable memory on heap, not stack
...
Large amounts might run out of stack
Reported by guidov
2019-06-14 08:47:20 +00:00
f215219252
cryptonote: throw on tx hash calculation error
2019-06-14 08:47:17 +00:00
db2b9fba65
serialization: fail on read_varint error
2019-06-14 08:47:14 +00:00
68ad548193
cryptonote_protocol: fix another potential P2P DoS
...
When asking for txes in a fluffy transaction, one might ask
for the same (large) tx many times
2019-06-14 08:47:11 +00:00
1cc61018e5
cryptonote_protocol: expand basic DoS protection
...
Count transactions as well
2019-06-14 08:47:08 +00:00
8f66b7053a
cryptonote_protocol_handler: prevent potential DoS
...
Essentially, one can send such a large amount of IDs that core exhausts
all free memory. This issue can theoretically be exploited using very
large CN blockchains, such as Monero.
This is a partial fix. Thanks and credit given to CryptoNote author
'cryptozoidberg' for collaboration and the fix. Also thanks to
'moneromooo'. Referencing HackerOne report #506595 .
2019-06-14 08:47:05 +00:00
69f9420489
core: do not complain about low block rate if disconnected
...
In that case, we'll still keep the "Monero is now disconnected
from the network" near the end of the log
2019-06-13 10:25:30 +00:00
b712ae0af2
rpc: work around a GCC 7.4.0 (at least) bug
...
In static member function ‘static boost::optional<cryptonote::rpc::output_distribution_data> cryptonote::rpc::RpcHandler::get_output_distribution(const std::function<bool(long unsigned int, long unsigned int, long unsigned int, long unsigned int&, std::vector<long unsigned int>&, long unsigned int&)>&, uint64_t, uint64_t, uint64_t, const std::function<crypto::hash(long unsigned int)>&, bool, uint64_t)’:
cc1plus: warning: ‘void* __builtin_memset(void*, int, long unsigned int)’: specified size 18446744073709551536 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
2019-06-12 22:27:07 +00:00
03aa14ec87
tx_sanity_check: don't print an error when not enough outs to check
2019-06-12 12:06:14 +00:00
14881094af
rpc: fix get_transactions getting v1 txes from the txpool
...
It would try to get their prunable hash, but v1 txes don't have one
2019-06-12 11:59:13 +00:00
fd0cf689dd
Merge pull request #5619
...
f2f207d
2019-06-11 18:17:11 -05:00
6b41bd8eb5
Delete more include string.h
2019-06-11 16:08:42 +08:00
b8cfa92b7e
rpc: implement set_bootstrap_daemon method
2019-06-10 21:10:08 +00:00
35c20c4332
Fix GCC 9.1 build warnings
...
GCC wants operator= aand copy ctor to be both defined, or neither
2019-06-09 09:39:18 +00:00
f2f207d635
miner: fix double free of thread attributes
...
issue: #5568
2019-06-09 10:51:18 +02:00
2cbe75661c
p2p: fix GCC 9.1 crash
2019-06-08 17:52:53 +00:00
068fa1ca5c
p2p: delay IGP probing on startup
...
We might have external access without having to do this
2019-06-06 10:33:02 +00:00
c820e1839f
simplewallet: print errors on exceptions creating wallets
...
Exceptions would otherwise terminate the process silently
2019-06-06 09:49:47 +00:00
cf8cb6873a
rpc: use ip address string representation for peer::host field
2019-06-04 19:33:35 +00:00
dd58057126
Remember RPC version on initial connect
...
Don't keep asking for it on an intact connection
Wallet is too chatty over the wire
2019-06-02 09:31:50 +01:00
62d32e955a
Merge pull request #5577
...
f950517a
2019-06-01 20:25:19 +02:00
7e417dd408
Merge pull request #5571
...
35da33be4b51f9a3
2019-06-01 20:22:19 +02:00
14d3295649
Merge pull request #5561
...
9bfa4c203544596fc9aaccf3
2019-06-01 20:21:45 +02:00
fccfc1aa25
Merge pull request #5555
...
b6830db2Fix #5553 (Howard Chu)
2019-06-01 20:20:39 +02:00
343c0b4255
add a command line option to disable ZMQ server
2019-06-01 13:03:37 -04:00
880ebfdeea
daemon: add more chain specific info in alt_chain_info
2019-06-01 15:43:52 +00:00
2aa11341fc
daemon: display peer address type in print_cn
2019-05-31 09:10:05 +00:00
fcfcc3ac86
rpc: in/out peers can now return the setting's value
2019-05-30 12:13:31 +00:00
cd720c7e0b
add cumulative difficulty to diff command
2019-05-30 11:57:21 +03:00
270a3ae58b
Unused private member m_miner_address
2019-05-29 10:12:47 -04:00
f950517a08
core: update pruning if using --prune-blockchain on a pruned blockchain
...
Avoids a massive amount of spurious warnings if the last update before
the daemon exited was a while ago and the daemon was syncing
2019-05-28 09:12:11 +00:00
577324a954
wallet_manager: omit redundant disconnect, drop unused variable
2019-05-27 14:40:29 +00:00
35da33bea9
blockchain: do not try to pop blocks down to the genesis block
2019-05-26 17:11:32 +00:00
4b51f9a34f
core: do not commit half constructed batch db txn
2019-05-25 16:24:56 +00:00
162c3e18ec
blockchain_export: allow exporting blocks.dat format from pruned
...
We don't need any of the pruned data for this
2019-05-24 14:12:45 +00:00
c07bbd5c04
daemon: fix "never seen before" time span display for peers
2019-05-24 10:47:36 +00:00
9bfa4c20ca
Fix allow any cert mode in wallet rpc when configured over rpc
2019-05-22 00:15:14 -04:00
3544596f9f
Add ssl_options support to monerod's rpc mode.
2019-05-22 00:09:11 -04:00
c9aaccf346
Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works.
2019-05-21 15:43:27 -04:00
b6830db2d4
Fix #5553
...
Make sure the tip hash still matches the cached block
2019-05-19 03:02:33 +01:00
915f59e3c0
wallet: add unlock_time details to show_transfers
...
also add a note when receiving the tx, because the user
might not notice the "XXX blocks to unlock" in the balance.
2019-05-16 21:37:05 +00:00
e8487fa46b
Merge pull request #5539
...
3f612cdaaf9bc4ec1873af356810307539bd157f
2019-05-15 16:10:41 +02:00
5e80b3c3ef
Merge pull request #5535
...
e1016bce
2019-05-15 16:06:58 +02:00
1607419e38
Merge pull request #5538
...
615f287
2019-05-14 16:02:59 -05:00
eedf5106f5
Merge pull request #5532
...
46244dd
2019-05-14 15:59:34 -05:00
5a67ff2b32
Merge pull request #5526
...
1e8f3f6
2019-05-14 15:54:10 -05:00
266f68be32
Merge pull request #5512
...
d47292e
2019-05-14 15:51:14 -05:00
1873af35bf
Made code block usage consistent across all .md files
2019-05-12 05:16:26 +01:00
615f287aec
wallet: fix certificate fingerprint length check
...
Fixed by crCr62U0
2019-05-11 13:05:06 +00:00
e1016bce14
password: do not use line input on windows
...
This keeps its builtin command editing away
Thanks iDunk for testing on Windows
2019-05-10 18:56:50 +00:00
4c666141e3
expose set/get walletcache attribute functionality in wallet api
2019-05-10 19:24:45 +02:00
46244dd08c
wallet_rpc_server: use original addresses in destinations in get_transfers
...
And add them for pending transfers, where they were missing
2019-05-10 14:44:13 +00:00
6abaaaa994
remove obsolete save_graph skeleton code
2019-05-10 14:17:18 +00:00
1e8f3f66bf
rpc: fail update RPC when running offline
2019-05-09 19:14:49 +00:00
4228ee0b9e
daemon: add optional arguments to alt_chain_info
...
>N limits display to alt chains with more than N blocks
-N limits display to alt chains younger than N blocks
2019-05-09 09:13:11 +00:00
0605406714
daemon: sort alt chains by height
2019-05-09 09:12:49 +00:00
06b8f29992
blockchain: keep alternative blocks in LMDB
...
Alternative blocks are cleared on startup unless --keep-alt-blocks
is passed on the command line
2019-05-08 17:36:52 +00:00
f64f59627d
Merge pull request #5510
...
e9809382
2019-05-07 17:36:27 +02:00
97cb1c9436
Merge pull request #5508
...
1c44e658
2019-05-07 17:35:28 +02:00
a22a8b0f2b
Merge pull request #5505
...
7e5158aa
2019-05-07 17:34:53 +02:00
c20221f290
Merge pull request #5503
...
ccc1e311
2019-05-07 17:34:16 +02:00
ebb1c03e8c
Merge pull request #5501
...
b4ca72dd
2019-05-07 17:32:33 +02:00
2d04b0e500
Merge pull request #5499
...
a4c4a2d8
2019-05-07 17:31:45 +02:00
9d91301faa
Merge pull request #5496
...
0eb0d6b8
2019-05-07 17:30:27 +02:00
cf8319602d
Merge pull request #5481
...
28a7d315
2019-05-07 17:29:42 +02:00
e4d100b062
wallet2: don't wait a day before using new version fees
...
30 blocks should be more than enough to drain the txpool of
transactions made with the old fee scheme
2019-05-02 18:00:25 +00:00
bc94ba4d14
wallet: distinguish between empty and absent attributes
2019-05-02 13:00:08 +00:00
d47292eb3d
error: fix compile error on windows with depends
...
state_not_recoverable is not defined there
2019-05-02 10:14:09 +00:00
a4c4a2d8aa
blockchain: keep a rolling long term block weight median
2019-05-02 09:47:01 +00:00
77f9bfa4d5
Merge pull request #5493
...
5e0da6fb
2019-05-02 11:30:28 +02:00
52eb454d7b
Merge pull request #5491
...
98fb98f99074c0d8968848a7
2019-05-02 11:30:11 +02:00
efd2412e77
Merge pull request #5489
...
64983fce
2019-05-02 11:29:25 +02:00
08ab0cbdda
Merge pull request #5476
...
0aaf5e2a
2019-05-02 11:28:51 +02:00
e980938210
fix wide difficulty conversion with some versions of boost
2019-05-01 19:58:09 +00:00
1c44e65863
wallet2: reject standalone short payment IDs in monero: URI API
2019-05-01 18:41:39 +00:00
7e5158aa97
mnemonics: fix 4 byte UTF-8 rewriting
2019-04-30 21:10:54 +00:00
ccc1e311dc
wallet_rpc_server: reject standalone short payment id in address book
2019-04-30 21:07:37 +00:00
1a66a86f94
remove unused code
2019-04-29 20:52:40 +00:00
25a7cfdb4a
add a few checks where it seems appropriate
2019-04-29 20:52:40 +00:00
b4ca72dde9
wallet2: fix infinite loop picking outputs in corner case
...
If we have fewer outputs available on the chain than what we
require, but the output we're spending already has a ring,
it would loop picking outputs randomly, but never find enough.
Also tune logs for better debugging this kind of thing.
2019-04-29 10:02:20 +00:00
5e0da6fb68
change SSL certificate fingerprint whitelisting from SHA1 to SHA-256
...
SHA1 is too close to bruteforceable
2019-04-26 11:37:15 +00:00
98fb98f93f
wallet_rpc_server: adding missing return on error in set_daemon
2019-04-25 23:35:37 +00:00
9074c0d8cf
wallet_rpc_server: return false on error in set_log_categories
...
Reported by SmajeNz0
2019-04-25 23:35:37 +00:00
968848a77b
wallet_rpc_server: fix crash in validate_address if no wallet is loaded
...
Reported by SmajeNz0
2019-04-25 23:35:37 +00:00
0eb0d6b802
rpc: improve get_output_distribution
...
It can now handle small reorgs without having to rescan the
whole blockchain.
Also add a test for it.
2019-04-25 16:49:29 +00:00
0aaf5e2ac8
device/trezor: device sorting and filtering improved
...
- Trezor type detection refactored, T1 disabled (was enabled before which was a bug)
- Sort connected devices by env TREZOR_PATH
- Compatibility with Trezor ecosystem using TREZOR_PATH env var
- Enables to pick particular Trezor to use in GUI as we don't have the multi-device selection yet
- Dump all detected devices to log for better debugging / troubleshooting
2019-04-25 00:31:10 +02:00
581994b61c
Merge pull request #5486
...
4be18df3b386ae57
2019-04-24 22:41:40 +02:00
2e2ee3d823
Merge pull request #5485
...
c519d1df
2019-04-24 22:41:18 +02:00
2aa7fbd1d6
Merge pull request #5480
...
7af49ef0
2019-04-24 22:39:50 +02:00
edcb0cfff2
Merge pull request #5477
...
97e1c927
2019-04-24 22:38:36 +02:00
fd7ed93526
Merge pull request #5470
...
31a9aa83
2019-04-24 22:37:43 +02:00
28a7d31565
p2p: do not send last_seen timestamp to peers
...
This can be used for fingerprinting and working out the
network topology.
Instead of sending the first N (which are sorted by last
seen time), we sent a random subset of the first N+N/5,
which ensures reasonably recent peers are used, while
preventing repeated calls from deducing new entries are
peers the target node just connected to.
The list is also randomly shuffled so the original set of
timestamps cannot be approximated.
2019-04-24 17:56:12 +00:00
64983fcee4
wallet2: default to trying to keep 5 outputs of 2+ monero
...
In the case where previously a second unneeded output would be
added to a transaction. This should help *some* of the cases
where outputs are slowly being consolidated, leading to the
whole balance being locked when sending monero.
2019-04-24 12:25:43 +00:00
df83ed74e4
consensus: from v12, enforce >= 2 outputs
2019-04-23 22:09:35 +00:00
4be18df32a
tx_sanity_check: relax uniqueness check a bit
...
It triggers easily on testnet
2019-04-23 21:59:57 +00:00
b386ae5725
wallet2: add missing "sanity check failed" reason message
2019-04-23 21:59:57 +00:00
c519d1df34
wallet2: fix wrong change being recorded in sweep_all
...
leading to the sanity check triggering
2019-04-23 21:58:55 +00:00
6aa3c2f303
dns_checks: new helper program to check on DNSSEC lookups
2019-04-23 15:20:45 +00:00
7af49ef0c2
daemonizer: add --non-interactive for windows
...
The RPC functional tests need it
Thanks to iDunk for debugging/testing
2019-04-23 00:26:51 +00:00
97e1c9278c
wallet: fix key image computation signaling to the device
2019-04-22 16:14:50 +02:00
31a9aa83af
wallet_rpc_server: add block_height and frozen to incoming_transfers
2019-04-20 08:44:09 +00:00
375fde9454
hardfork: fix off by one updating fork index after popping
2019-04-20 00:05:35 +00:00
71c6b24893
Merge pull request #5464
...
0f52fe4cb414b69f
2019-04-18 22:04:11 +02:00
2267f110b2
Merge pull request #5463
...
fbbe75d7
2019-04-18 22:03:30 +02:00
950f79dc03
Merge pull request #5389
...
588e670035e0a968
2019-04-18 22:01:51 +02:00
2e342d8df6
Merge pull request #5458
...
84047cb7
2019-04-18 22:01:22 +02:00
b8f1709684
Merge pull request #5456
...
58eade68
2019-04-18 22:01:03 +02:00
55807141f2
Merge pull request #5453
...
71102267
2019-04-18 21:59:01 +02:00
fbbe75d75f
device/trezor: button request callback fix
2019-04-18 18:04:54 +02:00
588e670089
simplewallet: fix output representation offset
2019-04-18 15:14:41 +00:00
35e0a968bd
wallet2: "output lineup" fake out selection
...
Based on python code by sarang:
https://github.com/SarangNoether/skunkworks/blob/outputs/outputs/simulate.py
2019-04-18 15:14:38 +00:00
b414b69f5c
Windows: fix a build error in MSYS2 with boost 1.70.0
2019-04-18 17:00:13 +02:00
a23dbe69f6
simplewallet: prompt when spending more than one old out in one tx
2019-04-18 12:46:03 +00:00
84047cb729
wallet_rpc_server: add unlocked field to incoming_transfers output
2019-04-17 15:30:49 +00:00
3b9ce453a9
wallet_rpc_server: remove unused variable
2019-04-17 11:25:33 +00:00
58eade689c
simplewallet: add the change amount to the prompt when locking
2019-04-17 11:05:18 +00:00
e9464eb5e3
Merge pull request #5413
...
5fafb90e
2019-04-17 08:27:36 +02:00
5fafb90e91
testdb: add override keyword where missing
...
and delete obsolete BlockchainBDB::get_tx_output_indices along the way
2019-04-17 10:26:25 +09:00
b0a346689b
daemon: fix absolute/relative log file test for windows
2019-04-16 22:15:36 +00:00
7110226794
wallet_rpc_server: set suggested_confirmations_threshold for pool txes
2019-04-16 20:59:57 +00:00
294e858d57
wallet_rpc_server: add set_log_level/set_log_categories
2019-04-16 20:50:15 +00:00
1b092f3a44
Merge pull request #5452
...
c30d93fc
2019-04-16 22:48:50 +02:00
810dd0a5f6
Merge pull request #5450
...
926e0472
2019-04-16 22:48:18 +02:00
68d131615e
Merge pull request #5448
...
d009f6ddbb0ef5b1
2019-04-16 22:47:36 +02:00
c8ce4217cf
Merge pull request #5445
...
b18f0b10
2019-04-16 22:46:53 +02:00
f376cd5605
Merge pull request #5446
...
7d79222f8fec0f989880d61b8a61b33d5650852482e510f1
2019-04-16 22:46:29 +02:00
e98cbfbdfe
Merge pull request #5444
...
6643b047
2019-04-16 22:45:42 +02:00
c5f64bf170
Merge pull request #5443
...
07dd5536
2019-04-16 22:45:23 +02:00
8af1a89e4c
Merge pull request #5441
...
b3648232e1b097b9
2019-04-16 22:44:41 +02:00
1fc20ba48a
Merge pull request #5439
...
f26e0b5d
2019-04-16 22:44:19 +02:00
ac8e2a7819
Merge pull request #5437
...
acb68dba
2019-04-16 22:44:00 +02:00
b0472c43a1
Merge pull request #5435
...
5140c15e
2019-04-16 22:42:26 +02:00
1f01070a0c
Merge pull request #5434
...
ccb996af
2019-04-16 22:41:40 +02:00
8deee24cbb
Merge pull request #5431
...
34f8c237
2019-04-16 22:40:34 +02:00
35b3d754e8
Merge pull request #5429
...
bcb86ae6
2019-04-16 22:39:37 +02:00
45e1f7c292
Merge pull request #5428
...
f3425f8d
2019-04-16 22:39:18 +02:00
8d16e92dcb
Merge pull request #5425
...
58585986
2019-04-16 22:38:56 +02:00
a1ea611e24
Merge pull request #5424
...
93bb2f48
2019-04-16 22:38:32 +02:00
8966ac314c
Merge pull request #5422
...
2c221d1b
2019-04-16 22:38:11 +02:00
96696d1e75
Merge pull request #5418
...
374f388d
2019-04-16 22:37:52 +02:00
0d2aaac15b
Merge pull request #5414
...
e9fac29a467f4c7e815d08dc661f1fb8
2019-04-16 22:37:02 +02:00
313a56a2da
Merge pull request #5406
...
bea1918a
2019-04-16 22:32:27 +02:00
ce2f46f76b
Merge pull request #5405
...
ffdbcfb6
2019-04-16 22:32:06 +02:00
46c477ab30
Merge pull request #5400
...
5e673c03
2019-04-16 22:30:40 +02:00
c30d93fcd9
rpc: add a pruned bool to the prune_blockchain call
2019-04-16 15:15:14 +00:00
926e047288
simplewallet: add another warning about long payment ids
2019-04-16 10:11:02 +00:00
7d79222f5c
daemon: remove debug info
2019-04-15 22:32:09 +00:00
d009f6dd61
rpc: fix get_block_hashes.bin from wallet on pruned blockchain
...
We want to get all blocks here, even pruned ones
2019-04-15 22:27:15 +00:00
bb0ef5b1f2
blockchain: lock the blockchain while pruning
2019-04-15 22:27:12 +00:00
b18f0b1051
wallet: new --offline option
...
It will avoid connecting to a daemon (so useful for cold signing
using a RPC wallet), and not perform DNS queries.
2019-04-15 09:14:12 +00:00
9880d61b98
wallet_rpc_server: remove unused code
2019-04-15 09:13:12 +00:00
8a61b33d8e
rpc: omit irrelevant fields for pool txes in gettransactions
2019-04-15 09:11:54 +00:00
565085245a
rpc: add relayed in get_transaction output
2019-04-15 09:11:50 +00:00
82e510f15e
rpc: set default log category in core_rpc_server.h
2019-04-15 09:10:29 +00:00
e89aa2ec56
Merge pull request #5421
...
e78cea74
2019-04-15 09:22:50 +02:00
64a4aa4f60
Merge pull request #5408
...
c4f8a8a6
2019-04-15 09:21:00 +02:00
9bd0983d5e
Merge pull request #5402
...
cbf32241
2019-04-15 09:18:10 +02:00
e31559d319
Merge pull request #5398
...
41901b8dc97a1f79
2019-04-15 09:17:47 +02:00
8bf0a3f123
Merge pull request #5396
...
b40392fb
2019-04-15 09:17:26 +02:00
98f4c8af98
Merge pull request #5395
...
15f27c80
2019-04-15 09:17:07 +02:00
89b8ecfc7c
Merge pull request #5392
...
a2195b9b
2019-04-15 09:14:28 +02:00
3f46c5b4e1
Merge pull request #5365
...
383c38fd
2019-04-15 09:12:50 +02:00
37aea526a9
Merge pull request #5355
...
c68fe787827f52ad
2019-04-15 09:12:20 +02:00
6643b04737
Increment m_threads_active when mining thread starts
2019-04-15 13:08:33 +10:00
07dd55363c
hardfork: remove "no hf version db" recreation check
...
This is now obsolete, and this removes the warning on startup
on a new db that confuses some people
2019-04-14 10:34:29 +00:00
f26e0b5d11
cryptonote_protocol: warn when the last connection goes
2019-04-14 10:30:01 +00:00
b364823286
daemon: fix ratio not being floating point
...
Coverity 197648
2019-04-14 09:26:12 +00:00
e1b097b99b
core_rpc_server: remove dummy assigning int to bool
...
Coverity 197653
2019-04-14 09:26:12 +00:00
5e673c03fe
blockchain_db: fix db txn ending too early
...
The db txn in add_block ending caused the entire overarching
batch txn to stop.
Also add a new guard class so a db txn can be stopped in the
face of exceptions.
Also use a read only db txn in init when the db itself is
read only, and do not save the max tx size in that case.
2019-04-14 08:35:38 +00:00
acb68dbaa9
bulletproofs: cut down on keyV allocations
2019-04-13 22:37:08 +00:00
5140c15e56
daemon: if a log file has a /, interpret it from the cwd
...
rather than from data dir where it normally is.
It makes things like --log-file ./foo.log behave as you'd expect.
2019-04-13 11:21:08 +00:00
ccb996afc6
rpc: new sanity check on relayed transactions
...
This will weed out some transactions with silly rings
2019-04-12 20:22:09 +00:00
34f8c237c2
simplewallet: fix warning about long payment id using the old option
2019-04-12 14:09:26 +00:00
bcb86ae651
wallet_rpc_server: fix inconsistent wallet caches on reload
...
Loading the same wallet as the currently loaded one would autosave
the current state after loading it, leading to some kind of rollback
effect. We now save before loading to avoid this. If loading fails,
it means the current wallet will be saved (or maybe not, depending
on where the failure occurs: most of the sanity checks occur before
saving). There is a new autosave_current flag to open/restore calls
so the (enabled by default) autosave can be skipped.
2019-04-12 13:40:42 +00:00
f3425f8d32
rpc.getblocktemplate: set reserved_offset to zero when reserve_size==0
2019-04-12 18:55:38 +09:00
5858598604
p2p: fix integer overflow in host bans
2019-04-11 21:59:27 +00:00
93bb2f48f7
ringct: prevent use of full ringct signatures for more than one input
2019-04-11 19:44:06 +00:00
8f1fe45fe1
simplewallet: fix merge error with new welcome command
2019-04-11 18:46:23 +00:00
2c221d1b6c
wallet2: update estimate_rct_tx_size for smaller rct proofs
2019-04-11 17:31:18 +00:00
e78cea74bd
rpc: fix off by one in get_height
2019-04-11 17:24:02 +00:00
9c77dbf376
Merge pull request #5386
...
d843f200
2019-04-11 13:16:28 +02:00
083271375a
Merge pull request #5383
...
0575794f047af5c39f9571aa8646bd006fd8834d04a20cb2798e3cad7c657bb2f8be31d22d68b31f23f86dadb3a32d55108f4375064ab12321b1ac1d
2019-04-11 13:14:44 +02:00
d843f20044
simplewallet: add a welcome/disclaimer message command
...
I saw one when landing on www.tribler.org, and it seemed
like a good idea to have something similar, alongside some
more general "what is monero" text.
2019-04-11 11:11:45 +00:00
064ab12340
functional_tests: add more blockchain related tests
...
Related to emission, reorgs, getting tx data back, output
distribution and histogram
2019-04-11 11:07:58 +00:00
5db72d12b4
Merge pull request #5388
...
0be5b2ee
2019-04-11 13:05:43 +02:00
5c02316598
Merge pull request #5382
...
c12b43cb3f1e9e8436c037eccd1eaff2
2019-04-11 13:03:55 +02:00
38717dafc0
Merge pull request #5381
...
def40161
2019-04-11 13:03:32 +02:00
915d9e5a1f
Merge pull request #5380
...
113e4877adaea3ea631ef00e
2019-04-11 13:02:59 +02:00
fa789109f6
Merge pull request #5379
...
83fc45a4
2019-04-11 13:02:47 +02:00
bd429033df
Merge pull request #5378
...
eda2661a
2019-04-11 13:02:35 +02:00
4a2cc76c84
Merge pull request #5376
...
c746f45d
2019-04-11 13:01:54 +02:00
3a4008f0fc
Merge pull request #5374
...
a2561653
2019-04-11 13:01:30 +02:00
036daa3af9
Merge pull request #5373
...
aff80e70
2019-04-11 13:00:55 +02:00
9f8dc4ce51
simplewallet: new net_stats command
...
displays total sent and received bytes
2019-04-11 10:46:41 +00:00
19e37c05d6
Merge pull request #5367
...
07b716bf
2019-04-11 12:41:55 +02:00
793651e731
Merge pull request #5366
...
c2f271d1
2019-04-11 12:41:34 +02:00
76fbcfe2dd
Merge pull request #5123
...
089c7637
2019-04-11 12:41:07 +02:00
41901b8deb
device/trezor: env-configurable ports
2019-04-10 18:29:24 +02:00
374f388de2
wallet_rpc_server: add a all flag to export_outputs
...
if we don't want to export new outputs only
2019-04-10 10:37:34 +00:00
661f1fb8b2
blockchain: remove unused calc of short_term_constraint
2019-04-09 19:39:24 +09:00
2e578b8214
Enabling daemon-rpc SSL now requires non-system CA verification
...
If `--daemon-ssl enabled` is set in the wallet, then a user certificate,
fingerprint, or onion/i2p address must be provided.
2019-04-07 13:02:43 -04:00
c4f8a8a6a9
build fix: combinator.h stdexcept missing include
2019-04-07 17:41:13 +02:00
bea1918a05
blockchain_import: error out if preparing to handle blocks fails
...
Coverity 197562
2019-04-07 13:48:19 +00:00
ffdbcfb6b3
core: don't check block rate nor fork time in regtest mode
2019-04-07 13:30:02 +00:00
c68fe7873b
device/trezor: add button pressed request
2019-04-07 13:35:49 +02:00
d58f368289
Require manual override for user chain certificates.
...
An override for the wallet to daemon connection is provided, but not for
other SSL contexts. The intent is to prevent users from supplying a
system CA as the "user" whitelisted certificate, which is less secure
since the key is controlled by a third party.
2019-04-07 00:44:37 -04:00
21eb1b0725
Pass SSL arguments via one class and use shared_ptr instead of reference
2019-04-07 00:44:37 -04:00
1f5ed328aa
Change default SSL to "enabled" if user specifies fingerprint/certificate
...
Currently if a user specifies a ca file or fingerprint to verify peer,
the default behavior is SSL autodetect which allows for mitm downgrade
attacks. It should be investigated whether a manual override should be
allowed - the configuration is likely always invalid.
2019-04-06 23:47:07 -04:00
a3b0284837
Change SSL certificate file list to OpenSSL builtin load_verify_location
...
Specifying SSL certificates for peer verification does an exact match,
making it a not-so-obvious alias for the fingerprints option. This
changes the checks to OpenSSL which loads concatenated certificate(s)
from a single file and does a certificate-authority (chain of trust)
check instead. There is no drop in security - a compromised exact match
fingerprint has the same worse case failure. There is increased security
in allowing separate long-term CA key and short-term SSL server keys.
This also removes loading of the system-default CA files if a custom
CA file or certificate fingerprint is specified.
2019-04-06 23:47:06 -04:00
e8cf7dcc2b
rpc: merge the two get_info implementations
2019-04-06 14:04:24 +00:00
3759e2359f
Merge pull request #5360
...
b0c552f5
2019-04-06 16:03:13 +02:00
18ceac9ca5
Merge pull request #5351
...
a299dc96
2019-04-06 16:01:44 +02:00
c7e536db23
Merge pull request #5350
...
050bb337
2019-04-06 16:00:40 +02:00
cd8fe937ad
Merge pull request #5347
...
d45b85e1
2019-04-06 15:59:56 +02:00
4ac78e1612
Merge pull request #5346
...
c84ea299e40eb2ad547a970811604b6d8461df043bbc3661
2019-04-06 15:59:43 +02:00
7e5651c346
Merge pull request #5345
...
678262ab
2019-04-06 15:59:10 +02:00
c61b3f0ead
Merge pull request #5344
...
5e1a3e48
2019-04-06 15:58:50 +02:00
9e72f785d6
Merge pull request #5343
...
cafa15b9
2019-04-06 15:58:25 +02:00
6f8e0a28b2
Merge pull request #5342
...
849a768f
2019-04-06 15:57:50 +02:00
e1f0e6da5c
Merge pull request #5340
...
16eda54b
2019-04-06 15:56:52 +02:00
827f52add0
wallet: API changes to enable passphrase entry
2019-04-05 22:17:50 +02:00
cbf3224180
rpc: make wide_difficulty hexadecimal
...
This should be friendlier for clients which don't have bignum support
2019-04-05 16:30:16 +00:00
089c7637a6
cryptonote: rework block blob size sanity check
...
Use the actual block weight limit, assuming that weight is always
greater or equal to size
2019-04-05 09:35:19 +00:00
a2561653cb
wallet: new option to start background mining
...
The setup-background-mining option can be used to select
background mining when a wallet loads. The user will be asked
the first time the wallet is created.
2019-04-04 18:10:45 +00:00
b40392fb02
wallet2: add --no-dns flag
2019-04-04 14:32:40 +00:00
a2195b9b7f
crypto: replace rand<T>()%N idiom with unbiased rand_idx(N)
2019-04-04 22:38:19 +09:00
a299dc96f7
rpc.gettransactions: fill as_json with partial tx in pruned mode
2019-04-04 18:08:01 +09:00
15f27c80b9
wallet2: support multi out txes without change in sanity check
2019-04-03 20:58:21 +00:00
8bb253b0db
libwallet_merged: add missing net target
2019-04-02 21:22:51 +02:00
0be5b2ee78
simplewallet: new unset_ring command
...
Useful when debugging, though not much for users
2019-04-02 14:18:07 +00:00
d3018d0f0b
api/wallet: fix some wrong namespace
2019-04-02 10:11:49 +09:00
c12b43cb5a
wallet: add number of blocks required for the balance to fully unlock
2019-04-01 19:31:19 +00:00
3f1e9e84c0
wallet2: set confirmations to 0 for pool txes in proofs
...
It makes more sense than (uint64_t)-1, which is going to look
like very much confirmed when not checking in_pool
2019-04-01 19:31:10 +00:00
36c037ec47
wallet_rpc_server: error out on getting the spend key from a hot wallet
2019-04-01 19:31:01 +00:00
cd1eaff29e
wallet_rpc_server: always fill out subaddr_indices in get_transfers
...
It was not filled out for in and pool types
2019-04-01 19:30:27 +00:00
def4016171
miner: fix race when stopping mining with start mining enabled
2019-04-01 19:28:50 +00:00
113e487739
blockchain_stats: fix sign in formatting function
2019-04-01 19:24:47 +00:00
adaea3ea3c
various: remove unused variables
2019-04-01 19:24:41 +00:00
631ef00e76
blockchain: some debug info when adding txes-from-block fails
2019-04-01 19:24:35 +00:00
b6726aaa6c
Merge pull request #5319
...
f825055d67aa4adc705acbacf82bc29e01efdc6a
2019-04-01 20:56:52 +02:00
f825055d22
wallet_rpc_server: error out on getting the spend key from a hot wallet
2019-04-01 16:03:29 +00:00
67aa4adcfc
wallet_rpc_server: add a set_daemon RPC
2019-04-01 16:03:25 +00:00
705acbac4d
wallet2: init some variables to default values if loading old wallets
2019-04-01 16:03:23 +00:00
f82bc29ec2
wallet_rpc_server: always fill out subaddr_indices in get_transfers
...
It was not filled out for in and pool types
2019-04-01 16:03:20 +00:00
01efdc6a7e
wallet_rpc_server: set confirmations to 0 for pending/pool txes
2019-04-01 16:03:17 +00:00
83fc45a413
Add NanoX support
2019-04-01 17:40:24 +02:00
0eb2c7b272
Merge pull request #5339
...
9f49722c
2019-04-01 17:37:14 +02:00
6e0242f861
Merge pull request #5334
...
19f8089f
2019-04-01 17:37:01 +02:00
286dec012d
Merge pull request #5333
...
18faa6da
2019-04-01 17:36:16 +02:00
b8ab510f23
Merge pull request #5332
...
7c44091598fdcb2a3a981a33
2019-04-01 17:35:12 +02:00
3b52940471
Merge pull request #5349
...
f1a3796a
2019-04-01 17:34:43 +02:00
29e4e70f30
Merge pull request #5352
...
ae6885f69b687c78
2019-04-01 17:34:02 +02:00
3b1fa543ca
Merge pull request #5329
...
023f2c77
2019-04-01 17:32:20 +02:00
1ed6441925
Merge pull request #5327
...
c23ea796
2019-04-01 17:32:01 +02:00
a69b71dc41
Merge pull request #5326
...
dc20d774
2019-04-01 17:31:36 +02:00
4f3f15edba
Merge pull request #5325
...
760d3a2a
2019-04-01 17:31:17 +02:00
13f414cb9f
Merge pull request #5322
...
85f2f8c9
2019-04-01 17:31:01 +02:00
55d7eb06a8
Merge pull request #5317
...
1730a44f
2019-04-01 17:28:55 +02:00
97831e5f8b
Merge pull request #5308
...
a7211793
2019-04-01 17:27:56 +02:00
5a71fb74f0
Merge pull request #5307
...
e99b2b12
2019-04-01 17:27:25 +02:00
c994dc7ec0
Merge pull request #5306
...
8a97563a
2019-04-01 17:27:09 +02:00
8b57e33789
Merge pull request #5305
...
4500236f
2019-04-01 17:26:23 +02:00
30a3a73609
Merge pull request #5303
...
0a6cb30d
2019-04-01 17:26:10 +02:00
94880540e7
Merge pull request #5302
...
23fb056a
2019-04-01 17:25:53 +02:00
b09f1bdb8f
Merge pull request #5299
...
4ee15655
2019-04-01 17:24:33 +02:00
4a06b3ee62
Merge pull request #5298
...
8fd7452b
2019-04-01 17:24:13 +02:00
f13d38350a
Merge pull request #5297
...
a8b98a0b
2019-04-01 17:23:37 +02:00
89fb0e3cd6
Merge pull request #5295
...
2b10f22a
2019-04-01 17:23:25 +02:00
cabd848efa
Merge pull request #5294
...
77e9815d
2019-04-01 17:22:51 +02:00
6cb0a26d9d
Merge pull request #5292
...
328d291f
2019-04-01 17:22:22 +02:00
a6b798e72f
Merge pull request #5291
...
a52366c1
2019-04-01 17:21:14 +02:00
574c399386
Merge pull request #5288
...
39f000b3
2019-04-01 17:20:25 +02:00
7ec799c542
Merge pull request #5287
...
1d14b3f0
2019-04-01 17:19:32 +02:00
e55b3f9dda
Merge pull request #5239
...
91f4c7f4
2019-04-01 17:19:10 +02:00
eda2661aa2
Allow pruning before v10
...
This check is now not needed anymore, and would prevent people
from using --prune-blockchain when starting a new sync
2019-04-01 14:06:49 +00:00
c746f45d3e
Add hash of top block to /getheight RPC
2019-04-01 01:02:58 +01:00
5e1a3e48ba
lmdb: fix size_t size issues on 32 bit
2019-03-31 11:12:21 +00:00
aff80e7043
blockchain: fix returned height in create_block_template
...
It's now needed for CNv4, and was not retained when cached
2019-03-30 20:27:25 +00:00
07b716bfea
util: name replace_file arguments better
...
It was confusing unless you read code and the rename(2) man page.
2019-03-29 16:32:00 +00:00
c2f271d13a
device/trezor: increase live-refresh timeout
2019-03-29 17:23:14 +01:00
383c38fdb1
fix init warning on whatever compiler version
2019-03-29 11:25:36 -04:00
ae6885f6b4
blockchain: incremental long term block weight cache
2019-03-28 18:07:57 +00:00
9b687c7873
blockchain: simple cache for the long term block weights
2019-03-28 18:07:57 +00:00
7c44091541
Add get_tx_proof support, needed for new sanity check
...
Enhance debug info
2019-03-28 18:26:15 +01:00
98fdcb2aa5
Add support for V11 protocol with BulletProofV2 and short amount.
...
New scheme key destination contrfol
Fix dummy decryption in debug mode
2019-03-28 18:26:15 +01:00
3a981a3313
Add application version compatibility check.
2019-03-28 18:26:15 +01:00
b0c552f50f
cryptonote_protocol_handler: add block/tx hashes in notify logs
2019-03-28 00:43:55 +00:00
ef92620c1d
socks: fix build with boost 1.70
2019-03-27 13:22:41 +00:00
050bb337d7
wallet2: factor the watchonly/multisig/etc fields on creation
...
There's half a dozen calls, and it's easy to miss some when
adding a new field.
2019-03-27 08:51:16 +00:00
f1a3796a43
wallet2: fix tx sanity check change test for the sweep_all case
2019-03-25 22:41:22 +00:00
d45b85e170
wallet2: skip derivation precalc for blocks we know we'll skip
2019-03-25 14:28:05 +00:00
c84ea2993f
cryptonote_basic: some more minor speedups
2019-03-25 13:43:38 +00:00
e40eb2ad9d
cryptonote_basic: speedup calculate_block_hash
...
The block 202612 fix can be left tested at the end, if we
already know we're not in the general case
2019-03-25 13:43:29 +00:00
547a9708de
cryptonote: block parsing + hash calculation speedup
...
This saves a duplicate serialization step
2019-03-25 13:43:17 +00:00
11604b6da6
blockchain: avoid unneeded block copy
2019-03-25 13:42:32 +00:00
8461df0405
save some database calls when getting top block hash and height
2019-03-25 13:42:25 +00:00
3bbc366147
Avoid repeated (de)serialization when syncing
2019-03-25 13:42:18 +00:00
678262ab65
wallet_rpc_server: allow english/local language names in create_wallet
...
and return both in get_languages
2019-03-25 12:52:43 +00:00
a8b98a0bd7
wallet: fix memory only wallets
...
at least when using restore_deterministic_wallet
2019-03-25 12:49:25 +00:00
1d14b3f072
ringct: fix capitalization for scaler mult
2019-03-25 13:00:14 +08:00
7acfa9f3cc
Added socks proxy (tor/i2pd/kovri) support to wallet
2019-03-25 01:35:13 +00:00
1730a44f90
core: improve block rate monitor trigger probabilities
...
The original intent of one false positive a week on average
was not met, since what we really want is not the probability
of having N blocks in T seconds, but either N blocks of fewer
in T seconds, or N blocks or more in T seconds.
Some of this could be cached since it calculates the same fairly
complex floating point values, but it seems pretty fast already.
2019-03-25 00:55:09 +00:00
cafa15b904
wallet2: set confirmations to 0 for pool txes in proofs
...
It makes more sense than (uint64_t)-1, which is going to look
like very much confirmed when not checking in_pool
2019-03-24 21:59:06 +00:00
91f4c7f45f
Make difficulty 128 bit instead of 64 bit
...
Based on Boolberry work by:
jahrsg <jahr@jahr.me>
cr.zoidberg <crypto.zoidberg@gmail.com>
2019-03-24 21:03:19 +00:00
849a768f36
perf_timer: move some debug levels to info for consistency
2019-03-24 20:15:33 +00:00
e4b049da05
Merge pull request #5286
...
cce948a5
2019-03-24 19:38:50 +02:00
4176a399de
Merge pull request #5282
...
f962449d
2019-03-24 19:37:07 +02:00
8cb4293e82
Merge pull request #5277
...
adf6d773
2019-03-24 19:35:39 +02:00
0920ac7642
Merge pull request #5207
...
be6f426a
2019-03-24 19:33:36 +02:00
de4ca3f14e
Merge pull request #5324
...
223c6b07
2019-03-24 19:05:28 +02:00
0965b101f2
Merge pull request #5321
...
e9519e98
2019-03-24 19:04:27 +02:00
c23ea7962d
New interactive daemon command 'print_net_stats': Global traffic stats
2019-03-24 16:58:57 +01:00
16eda54b38
wallet: use original user address if we have a short payment id
2019-03-24 08:58:59 +00:00
9f49722c4d
Fix build on FreeBSD
2019-03-24 01:12:06 -06:00
19f8089fca
p2p: don't lookup seed nodes when offline
...
This will cause DNS requests, which will block and timeout
if there is really no network connectivity
2019-03-22 15:47:48 +00:00
18faa6da0c
wallet: add freeze/thaw/frozen commands
...
These commands let one freeze outputs by key image, so they
do not appear in balance, nor are considered when creating
a transaction, etc
This is helpful when receiving an output from a suspected spy,
who might try to track your other outputs by seeing with what
other outputs it gets spent.
The frozen command may be used without parameters to list all
currently frozen outputs.
2019-03-22 09:19:24 +00:00
e9519e9876
cryptonote: fix calculating coinbase tx hash
...
Also set error flag on exception when handling new txes
to keep tests working
2019-03-21 17:13:01 +00:00
023f2c7747
wallet_rpc_server: remove mixin from transfer RPCs
...
it's been a while, only use ring_size now
2019-03-21 14:47:39 +00:00
adf6d7730f
wallet: fix offline signing calling a daemon RPC
2019-03-21 14:46:29 +00:00
b05f10f82e
wallet2: sanity check new tx before sending
...
We generate and check tx proofs and verify the amounts in those
match what the original amounts were.
2019-03-21 13:03:45 +00:00
cac4c3103a
Merge pull request #5271
...
2790d4d3
2019-03-21 14:52:02 +02:00
e0a05837ba
Merge pull request #5270
...
5ade7281
2019-03-21 14:51:41 +02:00
dcfd5a8892
Merge pull request #5266
...
576116d4
2019-03-21 14:51:30 +02:00
5ac46c5310
Merge pull request #5256
...
4b21d38d
2019-03-21 14:48:40 +02:00
6c0c7d796d
Merge pull request #5252
...
7ac33342
2019-03-21 14:48:24 +02:00
39107e18d5
Merge pull request #5251
...
7632dede89b1630efa43b547
2019-03-21 14:47:43 +02:00
56feda84d3
Merge pull request #5250
...
a48e49aa
2019-03-21 14:47:11 +02:00
30e823e7cd
Merge pull request #5248
...
3f6f90bb
2019-03-21 14:46:58 +02:00
df50181ab2
Merge pull request #5237
...
3907588b
2019-03-21 14:46:20 +02:00
5e03bd06c1
Merge pull request #5235
...
c6a70af8
2019-03-21 14:45:58 +02:00
f9b1c4f962
Merge pull request #5213
...
efb2bdd3
2019-03-21 14:44:26 +02:00
48e3a341f8
Merge pull request #5211
...
c9b13fbba1fd1d49d74d26f2
2019-03-21 14:44:04 +02:00
efb2bdd309
slow-hash: default to JIT on x86_64
2019-03-21 11:29:08 +00:00
dc20d77459
rpc: add miner tx hash to block header response
2019-03-21 00:24:12 +00:00
223c6b0796
dns_utils: really add default DNSSEC servers on failure
...
Coverity 196597
2019-03-20 23:46:22 +00:00
760d3a2a0c
daemon: init public_port in all ctors
...
Coverity 196596
2019-03-20 23:45:00 +00:00
a1fd1d499c
device/trezor: HF10 support added, wallet::API
...
- import only key images generated by cold signing process
- wallet_api: trezor methods added
- wallet: button request code added
- const added to methods
- wallet2::get_tx_key_device() tries to decrypt stored tx private keys using the device.
- simplewallet supports get_tx_key and get_tx_proof on hw device using the get_tx_key feature
- live refresh enables refresh with trezor i.e. computing key images on the fly. More convenient and efficient for users.
- device: has_ki_live_refresh added
- a thread is watching whether live refresh is being computed, if not for 30 seconds, it terminates the live refresh process - switches Trezor state
2019-03-20 21:11:02 +01:00
d74d26f2c9
crypto: hmac_keccak added
2019-03-20 21:11:01 +01:00
85f2f8c933
Fix daemon startup parameter '--limit-rate' processing after parameter defaults
2019-03-20 16:40:59 +01:00
0c7e7bce18
Adding classes, functions, and utilities for common LMDB operations.
2019-03-19 17:52:26 +00:00
f2f725d8db
Merge pull request #5201
...
4921c794
2019-03-19 10:59:55 +02:00
695d51a481
Merge pull request #5203
...
8b514645
2019-03-19 10:59:42 +02:00
acc7211b5b
Merge pull request #5199
...
eef164f7
2019-03-19 10:58:38 +02:00
2900f6a3ca
Merge pull request #5198
...
9c4d403a
2019-03-19 10:58:25 +02:00
bf0f85221b
Merge pull request #5195
...
a54e81e5
2019-03-19 10:57:28 +02:00
38dcd975f2
Merge pull request #4889
...
f42263eb
2019-03-19 10:55:45 +02:00
a7211793ba
rpc: quantize db size up to 5 GB in restricted mode
2019-03-17 21:27:52 +00:00
e99b2b12fd
simplewallet: make the long payment ids warnigns more warney
...
We want people to really realize it's bad for *their* privacy.
2019-03-17 18:42:52 +00:00
c3de019f56
Merge pull request #5192
...
d0e07b3d7d88d8f2
2019-03-17 17:56:52 +02:00
848591c4d8
Merge pull request #5190
...
551104fb
2019-03-17 17:56:04 +02:00
429930534d
Merge pull request #5185
...
59478c80
2019-03-17 17:55:32 +02:00
e1be617ea2
Merge pull request #5182
...
b674728d
2019-03-17 17:55:13 +02:00
6031a1f5b4
Merge pull request #5179
...
7c09882a
2019-03-17 17:53:53 +02:00
fd231226b9
Merge pull request #5177
...
bb2aed8e
2019-03-17 17:52:56 +02:00
761ef99e77
Merge pull request #5168
...
8630a028
2019-03-17 17:52:41 +02:00
47c278c90f
Merge pull request #5166
...
75e5aafd
2019-03-17 17:51:52 +02:00
6d5849d9bb
Merge pull request #5165
...
36451697c17c8188acb14c107dd7a3b7
2019-03-17 17:51:24 +02:00
50d48d6118
Merge pull request #5135
...
de32dcea
2019-03-17 17:50:41 +02:00
4c91eb23a0
Merge pull request #5061
...
1f2930ce
2019-03-17 17:49:30 +02:00
8a97563a93
Use threadpool instead of new threads for DNS queries
2019-03-17 15:39:15 +00:00
4500236f25
wallet2: make use_fork_rules handle chain heights lower than leeway
2019-03-17 14:22:50 +00:00
0a6cb30d62
wallet: flush output cache upon reorg
...
Fixes output usage tracking
2019-03-17 10:34:07 +00:00
23fb056a72
wallet_rpc_server: new auto_refresh RPC
...
It can enable/disable auto refresh, and set auto refresh period
2019-03-17 10:33:51 +00:00
e063615a0e
Merge pull request #5249
...
3ac40938
2019-03-16 14:06:07 +02:00
03d1dbc2ad
Merge pull request #5280
...
aac4e2f5
2019-03-16 14:05:30 +02:00
4ee156556d
wallet_rpc_server: fix buffer read overflow in string assignment
2019-03-15 19:36:13 +00:00
8fd7452b6e
wallet: move light wallet RPC out of core RPC
...
It's not nothing to do with it
2019-03-15 13:34:08 +00:00
f42263ebb6
wallet: adds rescan_bc option with preserving key images
...
- enables to perform rescan_spent / ki sync with untrusted daemon. Spent check status involves RPC calls which require trusted daemon status as it leaks information. The new call performs soft reset while preserving key images thus a sequence: refresh, ki sync / import, rescan_bc keep_ki will correctly perform spent checking without need for trusted daemon.
- useful to detect spent outputs with untrusted daemon on watch_only / multisig / hw-cold wallets after expensive key image sync.
- cli: rescan_bc keep_ki
2019-03-15 12:55:29 +01:00
2b10f22ae6
mnemonics: fix half length seed to bytes conversion
2019-03-15 11:05:42 +00:00
77e9815db7
blockchain: do not try to pop the genesis block
2019-03-15 10:51:48 +00:00
328d291fe4
wallet2: set seed language when creating from json
2019-03-15 00:16:50 +00:00
a52366c1bf
wallet2: fix generation from json when restore height is not set
...
It was not recovering then, but creating a new random address
2019-03-14 23:41:41 +00:00
39f000b394
miner: fix possible exit crash due to race in stop
...
If a thread asks to stop the miner, m_stop will be set, and
that thread will wait to join. If the main thread is exiting
at that time, it will ask the miner to stop, but the miner
will claim it's not mining and early out since m_stop is
set. This will cause the database and other things to get
shutdown. If the miner happens to find a block at that time,
it will try to call core, and crash.
Instead, lock and check whether any threads are currently
in m_threads, since they'll only be cleared once the threads
are joined. Moreover, since we lock, the second thread will
have to wait for the first one to have finished. Calling
join twice on a thread seems fine as per pthread_join(3).
2019-03-14 16:59:08 +00:00
cce948a5ae
simplewallet: add some missing spacing before uses data
2019-03-14 10:07:49 +00:00
c88e992104
Merge pull request #4977
...
5ea17909
2019-03-14 09:43:02 +02:00
f962449d46
wallet_rpc_server: include out subaddress indices in get_transfers
2019-03-13 14:14:15 +00:00
aac4e2f585
wallet_rpc_server: add missing --rpc-ssl-allowed-fingerprints
2019-03-13 12:59:44 +00:00
bc61b5ca95
wallet2: don't store 0 amount outputs, they'll fail to be spent
...
It's better to just ignore them, the user does not really need
to know they're here. If the mask is wrong, they'll fail to be
used, and sweeping will fail as it tries to use it.
Reported by Josh Davis.
2019-03-12 18:42:30 +00:00
2790d4d30a
hardfork: update last_versions on popped block
2019-03-12 13:43:12 +00:00
5ade72818b
Wallet API: multisig_tx_set passing bug fixed
2019-03-12 14:02:01 +03:00
576116d415
wallet: fix load failure if the mms isn't usable
2019-03-11 16:11:48 +00:00
4ef3c895a4
blockchain: fix ahead of time PoW batch calc
2019-03-10 10:16:13 +00:00
59478c80dd
daemon: new mining_status command
2019-03-09 20:51:53 +00:00
4b21d38dfd
blockchain: speed up getting N blocks weights/long term weights
2019-03-08 12:04:14 +00:00
7ac3334217
slow-hash: cache TLS references locally once at function start
2019-03-07 18:11:19 +00:00
7632dede7b
crypto: fix PaX issue on NetBSD with CNv4 JIT
2019-03-07 16:46:02 +00:00
a48e49aa36
aesb: avoid stomping on an existing define on NetBSD
2019-03-07 16:08:00 +00:00
3ac40938c3
timings: fix errno.h mispelt as error.h
2019-03-07 16:03:55 +00:00
3f6f90bb31
wallet2: do not use invalid keys as fake outs in rings
2019-03-07 15:49:13 +00:00
49afbd0c53
Merge pull request #5232
...
082149c5f3b368c6e518f2b18780d6b4
2019-03-07 15:17:31 +02:00
3907588bf6
rpc: make fill_pow restricted
...
It's slow work, so let's not expose it
2019-03-06 00:05:41 +00:00
c6a70af86a
wallet2: key image import fixes
...
- return the right output data when offset is not zero
- do not consider import failed if result height is zero
(it can be 0 if unknown)
- select the right tx pubkey when using subaddresses (it's faster,
and we might select the wrong one if we got an output using one
of the additional tx keys)
- account for skipped outputs for spent/unspent balance info
"spent" is arguably wrong, since it will count spent change
multiple times as it goes through receive/spend cycles.
2019-03-05 22:41:44 +00:00
1f2930ce0b
Update 2019 copyright
2019-03-05 22:05:34 +01:00
5bbbe3902b
Merge pull request #4852
...
057c279c
2019-03-05 16:21:30 +02:00
8b51464516
add multisig tx sets to describe_transfer rpc endpoint
2019-03-05 14:42:43 +01:00
057c279cb4
epee: add SSL support
...
RPC connections now have optional tranparent SSL.
An optional private key and certificate file can be passed,
using the --{rpc,daemon}-ssl-private-key and
--{rpc,daemon}-ssl-certificate options. Those have as
argument a path to a PEM format private private key and
certificate, respectively.
If not given, a temporary self signed certificate will be used.
SSL can be enabled or disabled using --{rpc}-ssl, which
accepts autodetect (default), disabled or enabled.
Access can be restricted to particular certificates using the
--rpc-ssl-allowed-certificates, which takes a list of
paths to PEM encoded certificates. This can allow a wallet to
connect to only the daemon they think they're connected to,
by forcing SSL and listing the paths to the known good
certificates.
To generate long term certificates:
openssl genrsa -out /tmp/KEY 4096
openssl req -new -key /tmp/KEY -out /tmp/REQ
openssl x509 -req -days 999999 -sha256 -in /tmp/REQ -signkey /tmp/KEY -out /tmp/CERT
/tmp/KEY is the private key, and /tmp/CERT is the certificate,
both in PEM format. /tmp/REQ can be removed. Adjust the last
command to set expiration date, etc, as needed. It doesn't
make a whole lot of sense for monero anyway, since most servers
will run with one time temporary self signed certificates anyway.
SSL support is transparent, so all communication is done on the
existing ports, with SSL autodetection. This means you can start
using an SSL daemon now, but you should not enforce SSL yet or
nothing will talk to you.
2019-03-05 14:16:08 +01:00
5ea17909ca
device/trezor: debugging features, trezor tests
2019-03-05 14:02:45 +01:00
e65221d690
Merge pull request #5119
...
f024a10b
2019-03-05 14:12:24 +02:00
5b9c3df5c1
Merge pull request #5103
...
ceb72be3
2019-03-05 14:09:42 +02:00
ed6aa76cca
Merge pull request #5100
...
c485102488c85c189feda0ee238401d4dc5a760979b4e9f39827880807d655e4f75d51abb044d03ab747e836e69477bf
2019-03-05 14:09:19 +02:00
f024a10b68
db_lmdb: make mdb_block_info format conversion more future proof
...
If mdb_block_info changes again, the v2 to v3 conversion would
convert to an incorrect format.
2019-03-05 12:06:23 +00:00
ceb72be329
p2p: avoid busy loop when we have nothing to connect to
2019-03-05 12:00:45 +00:00
c4851024ce
wallet_rpc_server: avoid repeated string allocations when parsing
2019-03-05 11:58:22 +00:00
88c85c18e0
cryptonote: avoid double parsing blocks when syncing
2019-03-05 11:58:18 +00:00
9feda0eeba
cryptonote: speed up calculating coinbase tx prunable hash
...
It's a hash of an empty buffer, so we can avoid keccak
2019-03-05 11:58:16 +00:00
238401d4e9
core: avoid double parsing blocks after hoh
2019-03-05 11:58:13 +00:00
dc5a76095c
blockchain: avoid unneeded block copy
2019-03-05 11:58:10 +00:00
79b4e9f377
save some database calls when getting top block hash and height
2019-03-05 11:58:05 +00:00
9827880877
blockchain: avoid pointless transaction copy and temporary
2019-03-05 11:58:02 +00:00
07d655e438
blockchain: avoid duplicate block hash computation
2019-03-05 11:58:00 +00:00
f75d51abda
core: avoid calculating tx prefix hash when we don't need it
2019-03-05 11:57:57 +00:00
b044d03a51
Avoid repeated (de)serialization when syncing
2019-03-05 11:57:55 +00:00
082149c580
fix merge errors, update recommended version to 0.14.0.2
2019-03-05 13:46:35 +02:00
f3b368c659
update checkpoints hash
2019-03-05 13:06:36 +02:00
e518f2b1c0
update checkpoints, update README for 0.14.1 release
2019-03-05 13:05:41 +02:00
b747e836c8
wallet2: don't calculate prefix hash when we don't need it
2019-03-05 10:28:55 +00:00
e69477bf25
db: speedup block addition
...
by avoiding repeated (de)serialization
2019-03-05 10:28:52 +00:00
108c625b3f
CryptonightR: define out i386/x86_64 specific code on other archs
2019-03-05 10:24:24 +00:00
1b8757dddc
slow-hash: fix build on arm
2019-03-05 10:24:24 +00:00
23abe60705
check load_t_from_json return values
2019-03-04 22:38:06 +00:00
e396146aee
default initialize rpc structures
2019-03-04 22:38:03 +00:00
ef93b0995c
various: remove unused variables
2019-03-04 22:24:49 +00:00
2f7108f9d7
Merge pull request #5156
...
3d2772a0
2019-03-04 21:33:07 +02:00
6984a4d69c
Merge pull request #5154
...
8a1ff079
2019-03-04 21:32:42 +02:00
5260111631
Merge pull request #5146
...
4a9257b4
2019-03-04 21:32:30 +02:00
8e3bd389ea
Merge pull request #5143
...
1f5680c8c7c74caf
2019-03-04 21:31:33 +02:00
27db0e3bb9
Merge pull request #5141
...
5c81a9f1
2019-03-04 21:30:45 +02:00
5ab6d68a40
Merge pull request #5140
...
a3973fc9
2019-03-04 21:30:14 +02:00
66014706bb
Merge pull request #5131
...
d2c95ab9
2019-03-04 21:28:09 +02:00
42adc50766
Merge pull request #5125
...
8298f42e
2019-03-04 21:27:16 +02:00
372c0da086
Merge pull request #5111
...
6a3608d3
2019-03-04 21:24:32 +02:00
196022530b
Merge pull request #5108
...
1c9d5285
2019-03-04 21:24:09 +02:00
a28237c9ca
Merge pull request #5102
...
1eef0565
2019-03-04 21:22:51 +02:00
e1a177f0da
Merge pull request #5092
...
eec79276
2019-03-04 21:21:08 +02:00
4466f4504e
Merge pull request #5091
...
123fc2a2
2019-03-04 21:20:34 +02:00
b0d326bf2a
Merge pull request #5084
...
9d58749b
2019-03-04 21:19:12 +02:00
9d415495bf
Merge pull request #5082
...
1bc5f9fa
2019-03-04 21:18:53 +02:00
11daa98c0a
Merge pull request #5081
...
d78addcb
2019-03-04 21:18:24 +02:00
46fd181cca
Merge pull request #4054
...
24569454
2019-03-04 21:17:21 +02:00
9547e3f451
Merge pull request #5224
...
807903bb
2019-03-04 17:17:34 +02:00
de6d6c0e29
Merge pull request #5217
...
fa2fbc39
2019-03-04 17:15:06 +02:00
5f67e7f547
blockchain: forbid older BP rct versions from v11
2019-03-04 15:08:12 +00:00
09020235bf
Merge pull request #5175
...
85088d9f
2019-03-04 17:06:58 +02:00
815c8a48ab
Merge pull request #5174
...
0de1439624d281c378ab59eab9a61884fff23bf73dde67d8
2019-03-04 17:06:37 +02:00
8c53ac2dd1
Merge pull request #5132
...
2dbc487e63cc02c0f0e55ceb460da140
2019-03-04 14:58:45 +02:00
0de14396b9
tests: add a CNv4 JIT test
2019-03-04 11:56:55 +00:00
24d281c324
crypto: plug CNv4 JIT into cn_slow_hash
...
Enabled by setting the MONERO_USE_CNV4_JIT env var to 1
2019-03-04 11:56:55 +00:00
78ab59ea44
crypto: clear cache after generating random program
2019-03-04 11:56:46 +00:00
fff23bf7c6
CNv4 JIT compiler for x86-64 and tests
...
Minimalistic JIT code generator for random math sequence in CryptonightR.
Usage:
- Allocate writable and executable memory
- Call v4_generate_JIT_code with "buf" pointed to memory allocated on the previous step
- Call the generated code instead of "v4_random_math(code, r)", omit the "code" parameter
2019-03-04 11:56:29 +00:00
3dde67d82d
blockchain: add v10 fork heights
2019-03-04 11:56:22 +00:00
a17da7202b
Print the reason why a notification spec failed to parse
2019-03-04 11:48:46 +00:00
356d813799
blockchain: include number of discarded blocks in --reorg-notify
2019-03-04 11:48:44 +00:00
4d598e3d4d
core: add a few more block rate window sizes
...
The 10 minute one will never trigger for 0 blocks, as it's still
fairly likely to happen even without the actual hash rate changing
much, so we add a 20 minute window, where it will (for 0 blocks)
and a one hour window.
2019-03-04 11:48:42 +00:00
d4fb9641e0
core: add --block-rate-notify
...
This runs a command whenever the block rate deviates too much
from the expectation
2019-03-04 11:48:39 +00:00
28b6dbf263
notify: fix tokenizing being too strict
2019-03-04 11:48:36 +00:00
807903bbbf
hardfork: fix fork determination for historical heights
2019-03-04 11:19:59 +00:00
1b4fa00d7c
Merge pull request #5126
...
f1fb06b19da0892bf51397b3
2019-03-04 12:10:16 +02:00
55305559c1
Merge pull request #5124
...
b8787f43
2019-03-04 12:09:13 +02:00
35e0bf2e06
Merge pull request #5122
...
52964501
2019-03-04 12:08:26 +02:00
4f06639d63
Merge pull request #5120
...
45b7df70
2019-03-04 12:07:40 +02:00
e62ae67d16
Merge pull request #5118
...
49b2a48a
2019-03-04 12:07:02 +02:00
b8787f4302
ArticMine's new block weight algorithm
...
This curbs runaway growth while still allowing substantial
spikes in block weight
Original specification from ArticMine:
here is the scaling proposal
Define: LongTermBlockWeight
Before fork:
LongTermBlockWeight = BlockWeight
At or after fork:
LongTermBlockWeight = min(BlockWeight, 1.4*LongTermEffectiveMedianBlockWeight)
Note: To avoid possible consensus issues over rounding the LongTermBlockWeight for a given block should be calculated to the nearest byte, and stored as a integer in the block itself. The stored LongTermBlockWeight is then used for future calculations of the LongTermEffectiveMedianBlockWeight and not recalculated each time.
Define: LongTermEffectiveMedianBlockWeight
LongTermEffectiveMedianBlockWeight = max(300000, MedianOverPrevious100000Blocks(LongTermBlockWeight))
Change Definition of EffectiveMedianBlockWeight
From (current definition)
EffectiveMedianBlockWeight = max(300000, MedianOverPrevious100Blocks(BlockWeight))
To (proposed definition)
EffectiveMedianBlockWeight = min(max(300000, MedianOverPrevious100Blocks(BlockWeight)), 50*LongTermEffectiveMedianBlockWeight)
Notes:
1) There are no other changes to the existing penalty formula, median calculation, fees etc.
2) There is the requirement to store the LongTermBlockWeight of a block unencrypted in the block itself. This is to avoid possible consensus issues over rounding and also to prevent the calculations from becoming unwieldy as we move away from the fork.
3) When the EffectiveMedianBlockWeight cap is reached it is still possible to mine blocks up to 2x the EffectiveMedianBlockWeight by paying the corresponding penalty.
Note: the long term block weight is stored in the database, but not in the actual block itself,
since it requires recalculating anyway for verification.
2019-03-04 09:33:58 +00:00
fa2fbc3917
wallet2: fix mishandling rct outputs in coinbase tx
...
Reported by cutcoin
2019-03-03 18:55:12 +00:00
364516975a
Simplify RPC endpoint, emoving second RPC endpoint generate_from_view_key
2019-03-02 23:14:35 +01:00
be6f426a3f
rpc: Allow submitting tx as hex blob over ZMQ
2019-02-27 16:55:04 -07:00
9c4d403ae0
dns_utils: use fallback if the default resolver does not support DNSSEC
2019-02-27 11:08:56 +00:00
4921c79494
cn_deserialize: remove some unused code
2019-02-26 17:57:03 +00:00
eef164f7cc
cryptonote_protocol_handler: search for syncing peers in "cruise mode"
...
When all our outgoing peer slots are filled, we cycle one peer at
a time looking for syncing peers until we have at least two such
peers. This brings two advantages:
- Peers without incoming connections will find more syncing peers
that before, thereby strengthening network decentralization
- Peers will have more resistance to isolation attacks, as they
are more likely to find a "good" peer than they were before
2019-02-26 12:45:28 +00:00
7d88d8f27c
discontinue use of alloca
...
NetBSD emits:
warning: Warning: reference to the libc supplied alloca(3); this most likely will not work. Please use the compiler provided version of alloca(3), by supplying the appropriate compiler flags (e.g. not -std=c89).
and man 3 alloca says:
Normally, gcc(1) translates calls to alloca() with inlined code. This is not done when either the -ansi, -std=c89, -std=c99, or the
-std=c11 option is given and the header <alloca.h> is not included. Otherwise, (without an -ansi or -std=c* option) the glibc version of
<stdlib.h> includes <alloca.h> and that contains the lines:
#ifdef __GNUC__
#define alloca(size) __builtin_alloca (size)
#endif
It looks like alloca is a bad idea in modern C/C++, so we use
VLAs for C and std::vector for C++.
2019-02-25 11:11:07 +00:00
a54e81e572
daemon: add '--no-sync' arg to optionally disable blockchain sync
2019-02-25 03:22:14 +00:00
551104fbf1
daemon: add --public-node mode, RPC port propagation over P2P
2019-02-25 02:40:23 +03:00
8298f42e9d
miner: it can now autodetect the optimal number of threads
2019-02-23 12:22:32 +00:00
b674728dfa
Better error when sending a tx with a too large extra field
2019-02-22 11:45:32 +00:00
bb2aed8e4d
rpc: quantize db size up to 5 GB in restricted mode
2019-02-21 23:49:53 +00:00
7c09882a27
dns_utils: remove MoneroPulse/checkpoints mention in TXT record code
...
This code is used for more than just these
2019-02-21 17:38:43 +00:00
c17c81881b
Remove code duplication
2019-02-21 15:49:32 +01:00
85088d9f85
db_lmdb: fix missing mdb_dbi_close in migration
...
Fixed by hyc
2019-02-21 09:52:30 +00:00
3d2772a0d6
wallet-rpc: get balance for all accounts and subaddresses
2019-02-20 14:23:36 +09:00
8630a028f2
wallet: fix payment ID decryption for construction data
2019-02-20 03:55:35 +01:00
75e5aafdcb
device/trezor: dummy payment ID fix
2019-02-20 02:00:14 +01:00
acb14c1079
Add generate_from_view_key RPC method
2019-02-19 14:30:35 +01:00
7dd7a3b791
Add generate_from_keys RPC method
2019-02-19 14:13:01 +01:00
8a1ff079ea
wallet-rpc: get transfers for all accounts and subaddresses
2019-02-17 22:21:45 -05:00
4a9257b464
Support docker for gitian builds
...
Building with docker is arguably easier and more familiar to most people
than either kvm, or lxc.
This commit also relaxes the back compat requirement a bit. 32 bit linux
now uses glibc version 2.0. Also, the docker shell could not handle gcc arguments
containing spaces, so the explicit '-DFELT_TYPE' declaration was dropped.
Lastly, this removes some packages from the osx descriptor.
2019-02-14 23:14:34 +01:00
5c81a9f1a1
wallet_rpc_server: add a validate_address RPC
2019-02-14 21:01:11 +00:00
f1fb06b137
Fixed path to int-util.h
2019-02-14 20:46:56 +01:00
9da0892b10
Adding cnv4-2 tweaks
...
Co-Authored-By: Lee Clagett <vtnerd@users.noreply.github.com>
2019-02-14 20:42:50 +01:00
f51397b306
Cryptonight variant 4 aka CryptonightR
...
It introduces random integer math into the main loop.
2019-02-14 11:29:54 +01:00
1f5680c8db
simplewallet: add help for ask-password options
2019-02-14 09:21:22 +00:00
c7c74cafec
simplewallet: mark confirm-missing-payment-id as obsolete
2019-02-14 09:21:22 +00:00
a3973fc95f
debug compilation fix: net lib missing common deps
...
```
Undefined symbols for architecture x86_64:
"common_category()", referenced from:
make_error_code(common_error) in parse.cpp.o
make_error_code(common_error) in tor_address.cpp.o
"boost::system::detail::system_category_ncx()", referenced from:
boost::system::system_category() in parse.cpp.o
boost::system::system_category() in socks.cpp.o
boost::system::system_category() in libepee.a(net_utils_base.cpp.o)
"boost::system::detail::generic_category_ncx()", referenced from:
boost::system::generic_category() in parse.cpp.o
boost::system::generic_category() in socks.cpp.o
boost::system::generic_category() in tor_address.cpp.o
boost::system::generic_category() in libepee.a(string_tools.cpp.o)
boost::system::generic_category() in libepee.a(net_utils_base.cpp.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [src/net/libnet.dylib] Error 1
make[2]: *** [src/net/CMakeFiles/net.dir/all] Error 2
```
2019-02-13 23:37:46 +01:00
d2c95ab941
Don't decrypt keys in view only wallets in wallet_keys_unlocker
2019-02-13 15:36:49 +11:00
de32dcea1d
Human readable message if maximum outputs reached
2019-02-10 09:51:20 -05:00
2dbc487ec0
Add support for V10 protocol with BulletProofV2 and short amount.
2019-02-08 17:02:55 +01:00
63cc02c08d
Fix dummy decryption in debug mode
2019-02-08 17:02:55 +01:00
f0e55cebf7
fix log namespace
2019-02-08 17:02:55 +01:00
460da140ec
New scheme key destination contrfol
...
Implies protocol version management.
2019-02-08 17:02:44 +01:00
49b2a48a46
simplewallet: tell the user to complain to the recipient
...
for long payment ids
2019-02-03 10:34:07 +00:00
529645014c
ringct: fix v1 ecdhInfo serialization
...
The change made for v2 broke v1, and we have no way to know which
version we're serializing here. However, since we don't actually
care about space savings in this case, we continue serialiazing
both mask and amount.
2019-02-03 10:33:10 +00:00
2456945408
epee: add SSL support
...
RPC connections now have optional tranparent SSL.
An optional private key and certificate file can be passed,
using the --{rpc,daemon}-ssl-private-key and
--{rpc,daemon}-ssl-certificate options. Those have as
argument a path to a PEM format private private key and
certificate, respectively.
If not given, a temporary self signed certificate will be used.
SSL can be enabled or disabled using --{rpc}-ssl, which
accepts autodetect (default), disabled or enabled.
Access can be restricted to particular certificates using the
--rpc-ssl-allowed-certificates, which takes a list of
paths to PEM encoded certificates. This can allow a wallet to
connect to only the daemon they think they're connected to,
by forcing SSL and listing the paths to the known good
certificates.
To generate long term certificates:
openssl genrsa -out /tmp/KEY 4096
openssl req -new -key /tmp/KEY -out /tmp/REQ
openssl x509 -req -days 999999 -sha256 -in /tmp/REQ -signkey /tmp/KEY -out /tmp/CERT
/tmp/KEY is the private key, and /tmp/CERT is the certificate,
both in PEM format. /tmp/REQ can be removed. Adjust the last
command to set expiration date, etc, as needed. It doesn't
make a whole lot of sense for monero anyway, since most servers
will run with one time temporary self signed certificates anyway.
SSL support is transparent, so all communication is done on the
existing ports, with SSL autodetection. This means you can start
using an SSL daemon now, but you should not enforce SSL yet or
nothing will talk to you.
2019-02-02 20:05:33 +00:00
45b7df703b
wallet_rpc_server: remove detached short payment ids support
2019-02-02 18:53:14 +00:00
fec359a641
cryptonote: Fix enum check in expand_transaction_2
...
This was noticed because GCC warned about using an enum value in a
boolean context.
2019-02-01 16:44:58 +01:00
9bf0e53751
cryptonote: Add const-qualifier on comparison functor
...
The original code did not compile with GCC 8.2.1 in C++17 mode, since
comparison functions for std::set's must be invocable as const.
2019-02-01 16:44:56 +01:00
5d2fdc2e8c
serialization: Use pos_type instead of streampos
...
According to [1], the ios_base::streampos member type is deprecated, and
removed in C++17. This type was an alias for pos_type, which this commit
uses instead.
[1]: https://en.cppreference.com/w/cpp/io/ios_base
2019-02-01 16:44:55 +01:00
6a3608d3d2
cryptonote_protocol_handler: pad tx messages when using tor/i2p
2019-01-30 23:17:45 +00:00
123fc2a25a
i2p: initial support
2019-01-30 13:37:45 -05:00
1c9d5285d1
blockchain_prune: don't prune before v10
...
This uses system time since it doesn't see the p2p network,
so is not 100% accurate
2019-01-30 16:32:14 +00:00
31bdf7bd11
Merge pull request #4988
...
973403bc
2019-01-29 16:47:17 +02:00
227bf1407e
Merge pull request #5104
...
dc0b86ab
2019-01-29 16:45:47 +02:00
973403bc9f
Adding initial support for broadcasting transactions over Tor
...
- Support for ".onion" in --add-exclusive-node and --add-peer
- Add --anonymizing-proxy for outbound Tor connections
- Add --anonymous-inbounds for inbound Tor connections
- Support for sharing ".onion" addresses over Tor connections
- Support for broadcasting transactions received over RPC exclusively
over Tor (else broadcast over public IP when Tor not enabled).
2019-01-28 23:56:33 +00:00
dc0b86ab4b
block_queue: fix late sanity check off by one
2019-01-28 22:17:43 +00:00
1e5cd3b35a
Merge pull request #5062
...
acfff8d0
2019-01-28 21:40:11 +02:00
40bb66cc1e
Merge pull request #5053
...
23813c71f6db59b0ff95921613852678
2019-01-28 21:35:46 +02:00
acfff8d0ce
rpc: fix internal daemon calls in restricted rpc getting partial data
2019-01-28 19:35:20 +00:00
23c7663167
Merge pull request #5080
...
d294a577
2019-01-28 21:34:17 +02:00
c07c907114
Merge pull request #5074
...
b8c5f550
2019-01-28 21:33:33 +02:00
23813c7160
blockchain: add --reorg-notify
...
This will trigger if a reorg is seen. This may be used to do things
like stop automated withdrawals on large reorgs.
%s is replaced by the height at the split point
%h is replaced by the height of the new chain
%n is replaced by the number of new blocks after the reorg
2019-01-28 19:32:31 +00:00
f6db59b011
notify: handle arbitrary tags
2019-01-28 19:32:28 +00:00
ff95921668
notify: warn if the spec contains one of '"\
...
These aren't processed as a shell does, so this may surprise users
2019-01-28 19:32:25 +00:00
13852678e1
common: set MONERO_DEFAULT_LOG_CATEGORY for notify and spawn
2019-01-28 19:32:22 +00:00
4f104a0dc3
Merge pull request #5069
...
2112060d
2019-01-28 21:32:14 +02:00
b7719022fd
Merge pull request #5068
...
96e35506
2019-01-28 21:31:47 +02:00
f2ca4e3205
Merge pull request #5063
...
11227e0b
2019-01-28 21:30:26 +02:00
756ed760f7
Merge pull request #5056
...
8258a9e7
2019-01-28 21:27:34 +02:00
77e96d0948
Merge pull request #5055
...
6c060e6a
2019-01-28 21:27:10 +02:00
0c970fde1c
Merge pull request #5054
...
93c21644
2019-01-28 21:26:44 +02:00
0daa00e035
Merge pull request #5052
...
b6534c407d37598199d946e6cdc3ccecf931e16c
2019-01-28 21:24:55 +02:00
1eef056588
performance_tests: better stats, and keep track of timing history
2019-01-28 15:45:37 +00:00
eec792764d
blockchain: fix default genesis block timestamp
2019-01-26 21:39:00 +00:00
b6534c40e6
ringct: remove unused senderPk from ecdhTuple
...
This was an early ringct field, which was never used in production
2019-01-22 23:17:42 +00:00
7d37598158
ringct: the commitment mask is now deterministic
...
saves space in the tx and is safe
Found by knaccc
2019-01-22 23:17:39 +00:00
99d946e619
ringct: encode 8 byte amount, saving 24 bytes per output
...
Found by knaccc
2019-01-22 23:17:31 +00:00
cdc3ccec5f
ringct: save 3 bytes on bulletproof size
...
Found by luigi1111
2019-01-22 23:17:27 +00:00
f931e16c6e
add a bulletproof version, new bulletproof type, and rct config
...
This makes it easier to modify the bulletproof format
2019-01-22 23:17:24 +00:00
b750fb27b0
Pruning
...
The blockchain prunes seven eighths of prunable tx data.
This saves about two thirds of the blockchain size, while
keeping the node useful as a sync source for an eighth
of the blockchain.
No other data is currently pruned.
There are three ways to prune a blockchain:
- run monerod with --prune-blockchain
- run "prune_blockchain" in the monerod console
- run the monero-blockchain-prune utility
The first two will prune in place. Due to how LMDB works, this
will not reduce the blockchain size on disk. Instead, it will
mark parts of the file as free, so that future data will use
that free space, causing the file to not grow until free space
grows scarce.
The third way will create a second database, a pruned copy of
the original one. Since this is a new file, this one will be
smaller than the original one.
Once the database is pruned, it will stay pruned as it syncs.
That is, there is no need to use --prune-blockchain again, etc.
2019-01-22 20:30:51 +00:00
9d58749b85
wallet2: fix hashchain going out of sync on refresh error
2019-01-19 16:47:13 +00:00
1bc5f9fa4b
bulletproofs: speed up vector_power_sum
...
found by sarang
2019-01-19 00:18:34 +00:00
d78addcbc0
db_lmdb: don't unnecessarily cast to double on the way to uint64_t
2019-01-19 00:03:04 +00:00
4e72384318
Merge pull request #5008
...
c6d38718b7441c4aa9b1c04a
2019-01-18 19:12:58 +02:00
5753d71922
Merge pull request #5050
...
07cb574c
2019-01-18 19:02:01 +02:00
8ba36cf6d4
Merge pull request #5049
...
0a29660f
2019-01-18 19:01:23 +02:00
416b6719bd
Merge pull request #5047
...
584126d1
2019-01-18 19:01:02 +02:00
54eb3318e2
Merge pull request #5048
...
a67b77a9
2019-01-18 19:00:47 +02:00
c6d387184e
core: include a dummy encrypted payment id when no payment is used
...
For better transaction uniformity, even though this wastes space.
2019-01-18 16:58:50 +00:00
b7441c4a32
core, wallet: remember original text version of destination address
2019-01-18 16:58:47 +00:00
a9b1c04acf
crptonote_core: do not error out sending unparsable extra field
...
extra is arbitrary, and the user may well want to send custom data
2019-01-18 16:58:45 +00:00
13b12973d1
Merge pull request #5037
...
51b0625e
2019-01-18 09:25:59 +02:00
aa5b0c7f71
Merge pull request #5028
...
464097e5a6216d1a
2019-01-18 09:25:34 +02:00
f3368acef5
Merge pull request #5020
...
1ef79b43
2019-01-18 09:25:18 +02:00
3c80562861
Merge pull request #5014
...
0debe7d7
2019-01-18 09:24:19 +02:00
4fb9cfa017
Merge pull request #4971
...
15904610247dab73bf9ef7ad
2019-01-18 09:23:03 +02:00
d294a577fa
daemon: extend 'print_pl' command, optional filter by type and limit
2019-01-18 01:32:18 +00:00
1717e63551
simplewallet: fix help text of rescan_bc to mention the "hard" option
2019-01-18 09:51:44 +09:00
1590461005
simplewallet: remove extra colon in a few calls to input_secure_line
2019-01-18 09:48:54 +09:00
247dab7304
simplewallet: avoid conversion to string in input_secure_line
2019-01-18 09:48:52 +09:00
bf9ef7adb6
simplewallet: factor yesno hint into input_line
2019-01-18 09:48:48 +09:00
464097e592
blockchain_ancestry: allow getting ancestry of a single output
...
This involved a reorg of the code, to factor and speedup some bits,
as well as using the cache for all modes, and making both modes
usable in the same run.
2019-01-16 20:13:12 +00:00
a6216d1ac2
blockchain_db: allow getting output keys without commitment
...
Since the commitment has to be calculated for non rct outputs,
it slows down a lot unnecessarily if we don't need it
2019-01-16 20:13:08 +00:00
1ef79b430f
simplewallet: disable long payment ids by default
...
unless --long-payment-id-support is used
2019-01-16 20:06:04 +00:00
0debe7d7d3
wallet2: remember which output keys map to which key images
...
This allows filling in transfer_details when a cold signed tx
gets seen in a block next
2019-01-16 19:58:13 +00:00
xiphon